ahmido
a449ecec5b
Beschreibung Implementiert das Drift MVP Feature (Spec: 044-drift-mvp) mit Fokus auf automatische Drift-Erkennung zwischen Inventory Sync Runs und Bulk-Triage für Findings. Was wurde implementiert? Drift-Erkennung: Vergleicht Policy-Snapshots, Assignments und Scope Tags zwischen Baseline- und Current-Runs. Deterministische Fingerprints verhindern Duplikate. Findings UI: Neue Filament Resource für Findings mit Listen- und Detail-Ansicht. DB-only Diffs (keine Graph-Calls zur Laufzeit). Bulk Acknowledge: "Acknowledge selected" (Bulk-Action auf der Liste) "Acknowledge all matching" (Header-Action, respektiert aktuelle Filter; Type-to-Confirm bei >100 Findings) Scope Tag Fix: Behebt False Positives bei Legacy-Daten ohne scope_tags.ids (inferiert Default-Werte). Authorization: Tenant-isoliert, Rollen-basiert (Owner/Manager/Operator können acknowledge). Tests: Vollständige Pest-Coverage (28 Tests, 347 Assertions) für Drift-Logik, UI und Bulk-Actions. Warum diese Änderungen? Problem: Keine automatisierte Drift-Erkennung; manuelle Triage bei vielen Findings ist mühsam. Lösung: Async Drift-Generierung mit persistenter Findings-Tabelle. Safe Bulk-Tools für Massen-Triage ohne Deletes. Konformität: Folgt AGENTS.md Workflow, Spec-Kit (Tasks + Checklists abgehakt), Laravel/Filament Best Practices. Technische Details Neue Dateien: ~40 (Models, Services, Tests, Views, Migrations) Änderungen: Filament Resources, Jobs, Policies DB: Neue findings Tabelle (JSONB für Evidence, Indexes für Performance) Tests: ./vendor/bin/sail artisan test tests/Feature/Drift --parallel → 28 passed Migration: ./vendor/bin/sail artisan migrate (neue Tabelle + Indexes) Screenshots / Links Spec: spec.md Tasks: tasks.md (alle abgehakt) UI: Findings-Liste mit Bulk-Actions; Detail-View mit Diffs Checklist Tests passieren (parallel + serial) Code formatiert (./vendor/bin/pint --dirty) Migration reversibel Tenant-Isolation enforced No Graph-Calls in Views Authorization checks Spec + Tasks aligned Deployment Notes Neue Migration: create_findings_table Neue Permissions: drift.view, drift.acknowledge Queue-Job: GenerateDriftFindingsJob (async, deduped)
36 lines
2.0 KiB
Markdown
36 lines
2.0 KiB
Markdown
# Specification Quality Checklist: Drift MVP (044)
|
|
|
|
**Purpose**: Validate specification completeness and quality before proceeding to implementation
|
|
**Created**: 2026-01-12
|
|
**Feature**: [specs/044-drift-mvp/spec.md](../spec.md)
|
|
|
|
## Content Quality
|
|
|
|
- [x] No implementation details (languages, frameworks, APIs) (spec.md contains scenarios/rules/states/acceptance only)
|
|
- [x] Focused on user value and business needs (spec.md: Purpose, User Scenarios, Acceptance Criteria)
|
|
- [x] Written for non-technical stakeholders (spec.md uses plain language; avoids code/framework terms)
|
|
- [x] All mandatory sections completed (spec.md includes Purpose, User Scenarios, Rules, Acceptance Criteria)
|
|
|
|
## Requirement Completeness
|
|
|
|
- [x] No [NEEDS CLARIFICATION] markers remain (spec.md: no "[NEEDS CLARIFICATION]" markers)
|
|
- [x] Requirements are testable and unambiguous (spec.md: Rules + Acceptance Criteria)
|
|
- [x] Success criteria are measurable (spec.md: Acceptance Criteria)
|
|
- [x] Success criteria are technology-agnostic (no implementation details) (spec.md: Acceptance Criteria)
|
|
- [x] All acceptance scenarios are defined (spec.md: Scenario 1/2/3)
|
|
- [x] Edge cases are identified (spec.md: blocked state; error state; acknowledgement per comparison)
|
|
- [x] Scope is clearly bounded (spec.md: Rules → Coverage (MVP))
|
|
- [x] Dependencies and assumptions identified (spec.md: Rules → UI states; Run tracking)
|
|
|
|
## Feature Readiness
|
|
|
|
- [x] All functional requirements have clear acceptance criteria (spec.md: Rules + Acceptance Criteria)
|
|
- [x] User scenarios cover primary flows (spec.md: Scenario 1/2/3)
|
|
- [x] Feature meets measurable outcomes defined in Success Criteria (spec.md: Acceptance Criteria are measurable and testable)
|
|
- [x] No implementation details leak into specification (spec.md avoids implementation and names a generic “persisted run record” only)
|
|
|
|
## Notes
|
|
|
|
- Items marked incomplete require spec updates before `/speckit.clarify` or `/speckit.plan`.
|
|
- Constitution gate: this checklist must exist for features that change runtime behavior.
|