ahmido
f6dbc89edb
Adds browser fixture coverage for evidence system surfaces as described in Spec 376. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #447
64 lines
3.2 KiB
Markdown
64 lines
3.2 KiB
Markdown
# Validation Report
|
|
|
|
## Starting State
|
|
|
|
- Branch before session: `376-browser-audit-fixture-coverage-evidence-system-surfaces`
|
|
- Session branch: `376-browser-audit-fixture-coverage-evidence-system-surfaces-session-1781347251`
|
|
- Baseline HEAD: `8efc8981 feat(guard): implement ui bloat regression guard (#446)`
|
|
- Initial dirty state: untracked active spec directory `specs/376-browser-audit-fixture-coverage-evidence-system-surfaces/`
|
|
- Scope decision: no product UI refactor; no production auth change; no new route.
|
|
|
|
## Commands Run
|
|
|
|
| Command | Result |
|
|
|---|---|
|
|
| `php -l apps/platform/tests/Browser/Spec376BrowserAuditFixtureCoverageSmokeTest.php` | pass |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/AdminLocalSmokeLoginTest.php tests/Feature/Auth/SystemPanelAuthTest.php tests/Feature/Evidence/EvidenceSnapshotResourceTest.php tests/Feature/RequiredPermissions/RequiredPermissionsAccessTest.php tests/Feature/ProviderConnections/Spec353ProviderConnectionGuidanceTest.php` | pass, 32 tests, 178 assertions |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec376BrowserAuditFixtureCoverageSmokeTest.php` | first run failed on over-specific Provider Connection copy assertion |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec376BrowserAuditFixtureCoverageSmokeTest.php` | pass, 2 tests, 21 assertions |
|
|
| `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` | pass |
|
|
| `git diff --check` | pass |
|
|
| `git add -N ... && git diff --check` against new/untracked files, then clear intent-to-add markers | pass after markdown EOF/trailing-space cleanup |
|
|
| `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec376BrowserAuditFixtureCoverageSmokeTest.php` | final rerun pass, 2 tests, 21 assertions |
|
|
|
|
## Browser Result
|
|
|
|
PASS. All five in-scope surfaces were reached in a real Pest Browser run:
|
|
|
|
- Evidence Snapshot View
|
|
- Required Permissions
|
|
- System Dashboard
|
|
- System Operations
|
|
- Provider Connection Detail
|
|
|
|
All reachable pages asserted:
|
|
|
|
- target surface text visible
|
|
- no JavaScript errors
|
|
- no console logs
|
|
- screenshot captured
|
|
|
|
## Screenshot Result
|
|
|
|
Pest Browser saved screenshots under `apps/platform/tests/Browser/Screenshots/`. The generated files were copied into:
|
|
|
|
`specs/376-browser-audit-fixture-coverage-evidence-system-surfaces/artifacts/screenshots/`
|
|
|
|
## Lane / Runtime Impact
|
|
|
|
- Browser lane: one new bounded Spec 376 browser family.
|
|
- Feature lane: existing fixture/auth/surface Feature tests passed and remain the proof for route safety.
|
|
- Product runtime: no runtime behavior changed.
|
|
- Browser cost: material but explicit and bounded to five surfaces.
|
|
- Escalation outcome: `document-in-feature`.
|
|
|
|
## Limitations
|
|
|
|
- System surfaces are browser-auditable through Pest Browser platform-guard `actingAs`, not through a manual browser smoke-login URL.
|
|
- Screenshot helper copy into host-level `specs/` requires either host-side copy after Sail runs or a future explicit `TENANTATLAS_REPO_ROOT` environment path when running inside Sail.
|
|
- This is reachability and fixture proof, not a full UI redesign audit.
|
|
|
|
## Closeout Audit Readiness
|
|
|
|
Spec 376 closes the fixture/evidence gap needed before a later post-productization browser re-audit can proceed.
|