Compare commits
4 Commits
173-tenant
...
dev
| Author | SHA1 | Date | |
|---|---|---|---|
| dc46c4fa58 | |||
| 98be510362 | |||
| 44898a98ac | |||
| 3a2a06e8d7 |
12
.github/agents/copilot-instructions.md
vendored
12
.github/agents/copilot-instructions.md
vendored
@ -125,6 +125,12 @@ ## Active Technologies
|
||||
- PostgreSQL with existing `operation_runs`, `managed_tenant_onboarding_sessions`, tenant records, and workspace records; no schema changes (172-deferred-operator-surfaces-retrofit)
|
||||
- PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantDashboard`, `DashboardKpis`, `NeedsAttention`, `BaselineCompareNow`, `RecentDriftFindings`, `RecentOperations`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `FindingResource`, `OperationRunLinks`, and canonical admin Operations page (173-tenant-dashboard-truth-alignment)
|
||||
- PostgreSQL unchanged; no new persistence, cache store, or durable dashboard summary artifac (173-tenant-dashboard-truth-alignment)
|
||||
- PHP 8.4, Laravel 12, Filament v5, Livewire v4, Blade + Filament v5, Livewire v4, Pest v4, Laravel Sail, existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, `TenantReviewReadinessGate`, `EvidenceSnapshotService`, `TenantReviewRegisterService`, and current evidence/review/review-pack resources and pages (174-evidence-freshness-publication-trust)
|
||||
- PostgreSQL with existing `evidence_snapshots`, `evidence_snapshot_items`, `tenant_reviews`, and `review_packs` tables using current summary JSON and timestamps; no schema change planned (174-evidence-freshness-publication-trust)
|
||||
- PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `WorkspaceOverviewBuilder`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `WorkspaceSummaryStats`, `WorkspaceNeedsAttention`, `WorkspaceRecentOperations`, `FindingResource`, `BaselineCompareLanding`, `EvidenceSnapshotResource`, `TenantReviewResource`, and canonical admin Operations routes (175-workspace-governance-attention)
|
||||
- PostgreSQL unchanged; no new persistence, cache table, or materialized aggregate is introduced (175-workspace-governance-attention)
|
||||
- PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantResource`, `ProviderConnectionResource`, `TenantVerificationReport`, `BadgeCatalog`, `BadgeRenderer`, `TenantOperabilityService`, `ProviderConsentStatus`, `ProviderVerificationStatus`, and shared provider-state Blade partials (179-provider-truth-cleanup)
|
||||
- PostgreSQL unchanged; no new table, column, or persisted artifact is introduced (179-provider-truth-cleanup)
|
||||
|
||||
- PHP 8.4.15 (feat/005-bulk-operations)
|
||||
|
||||
@ -144,8 +150,8 @@ ## Code Style
|
||||
PHP 8.4.15: Follow standard conventions
|
||||
|
||||
## Recent Changes
|
||||
- 173-tenant-dashboard-truth-alignment: Added PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantDashboard`, `DashboardKpis`, `NeedsAttention`, `BaselineCompareNow`, `RecentDriftFindings`, `RecentOperations`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `FindingResource`, `OperationRunLinks`, and canonical admin Operations page
|
||||
- 172-deferred-operator-surfaces-retrofit: Added PHP 8.4, Laravel 12, Livewire v4, Filament v5, Tailwind CSS v4 + `laravel/framework`, `filament/filament`, `livewire/livewire`, `pestphp/pest`
|
||||
- 171-operations-naming-consolidation: Added PHP 8.4, Laravel 12, Livewire v4, Filament v5, Tailwind CSS v4 + `laravel/framework`, `filament/filament`, `livewire/livewire`, `pestphp/pest`
|
||||
- 179-provider-truth-cleanup: Added PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantResource`, `ProviderConnectionResource`, `TenantVerificationReport`, `BadgeCatalog`, `BadgeRenderer`, `TenantOperabilityService`, `ProviderConsentStatus`, `ProviderVerificationStatus`, and shared provider-state Blade partials
|
||||
- 175-workspace-governance-attention: Added PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `WorkspaceOverviewBuilder`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `WorkspaceSummaryStats`, `WorkspaceNeedsAttention`, `WorkspaceRecentOperations`, `FindingResource`, `BaselineCompareLanding`, `EvidenceSnapshotResource`, `TenantReviewResource`, and canonical admin Operations routes
|
||||
- 174-evidence-freshness-publication-trust: Added PHP 8.4, Laravel 12, Filament v5, Livewire v4, Blade + Filament v5, Livewire v4, Pest v4, Laravel Sail, existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, `TenantReviewReadinessGate`, `EvidenceSnapshotService`, `TenantReviewRegisterService`, and current evidence/review/review-pack resources and pages
|
||||
<!-- MANUAL ADDITIONS START -->
|
||||
<!-- MANUAL ADDITIONS END -->
|
||||
|
||||
@ -10,6 +10,7 @@
|
||||
use App\Models\Workspace;
|
||||
use App\Services\Auth\WorkspaceCapabilityResolver;
|
||||
use App\Support\Auth\Capabilities;
|
||||
use App\Support\Navigation\CanonicalNavigationContext;
|
||||
use App\Support\OperateHub\OperateHubShell;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use BackedEnum;
|
||||
@ -79,9 +80,23 @@ protected function getHeaderWidgets(): array
|
||||
*/
|
||||
protected function getHeaderActions(): array
|
||||
{
|
||||
return app(OperateHubShell::class)->headerActions(
|
||||
$actions = app(OperateHubShell::class)->headerActions(
|
||||
scopeActionName: 'operate_hub_scope_alerts',
|
||||
returnActionName: 'operate_hub_return_alerts',
|
||||
);
|
||||
|
||||
$navigationContext = CanonicalNavigationContext::fromRequest(request());
|
||||
|
||||
if ($navigationContext?->backLinkLabel !== null && $navigationContext->backLinkUrl !== null) {
|
||||
array_splice($actions, 1, 0, [
|
||||
Action::make('operate_hub_back_to_origin_alerts')
|
||||
->label($navigationContext->backLinkLabel)
|
||||
->icon('heroicon-o-arrow-left')
|
||||
->color('gray')
|
||||
->url($navigationContext->backLinkUrl),
|
||||
]);
|
||||
}
|
||||
|
||||
return $actions;
|
||||
}
|
||||
}
|
||||
|
||||
@ -7,9 +7,11 @@
|
||||
use App\Filament\Resources\EvidenceSnapshotResource;
|
||||
use App\Models\EvidenceSnapshot;
|
||||
use App\Models\Tenant;
|
||||
use App\Models\TenantReview;
|
||||
use App\Models\User;
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeDomain;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Ui\ActionSurface\ActionSurfaceDeclaration;
|
||||
use App\Support\Ui\ActionSurface\Enums\ActionSurfaceInspectAffordance;
|
||||
use App\Support\Ui\ActionSurface\Enums\ActionSurfaceProfile;
|
||||
@ -90,14 +92,30 @@ public function mount(): void
|
||||
}
|
||||
|
||||
$snapshots = $query->get()->unique('tenant_id')->values();
|
||||
$currentReviewTenantIds = TenantReview::query()
|
||||
->where('workspace_id', $workspaceId)
|
||||
->whereIn('tenant_id', $snapshots->pluck('tenant_id')->map(static fn (mixed $tenantId): int => (int) $tenantId)->all())
|
||||
->whereIn('status', [
|
||||
TenantReviewStatus::Draft->value,
|
||||
TenantReviewStatus::Ready->value,
|
||||
TenantReviewStatus::Published->value,
|
||||
])
|
||||
->pluck('tenant_id')
|
||||
->mapWithKeys(static fn (mixed $tenantId): array => [(int) $tenantId => true])
|
||||
->all();
|
||||
|
||||
$this->rows = $snapshots->map(function (EvidenceSnapshot $snapshot): array {
|
||||
$this->rows = $snapshots->map(function (EvidenceSnapshot $snapshot) use ($currentReviewTenantIds): array {
|
||||
$truth = $this->snapshotTruth($snapshot);
|
||||
$freshnessSpec = BadgeCatalog::spec(BadgeDomain::GovernanceArtifactFreshness, $truth->freshnessState);
|
||||
$tenantId = (int) $snapshot->tenant_id;
|
||||
$hasCurrentReview = $currentReviewTenantIds[$tenantId] ?? false;
|
||||
$nextStep = ! $hasCurrentReview && $truth->contentState === 'trusted' && $truth->freshnessState === 'current'
|
||||
? 'Create a current review from this evidence snapshot'
|
||||
: $truth->nextStepText();
|
||||
|
||||
return [
|
||||
'tenant_name' => $snapshot->tenant?->name ?? 'Unknown tenant',
|
||||
'tenant_id' => (int) $snapshot->tenant_id,
|
||||
'tenant_id' => $tenantId,
|
||||
'snapshot_id' => (int) $snapshot->getKey(),
|
||||
'completeness_state' => (string) $snapshot->completeness_state,
|
||||
'generated_at' => $snapshot->generated_at?->toDateTimeString(),
|
||||
@ -114,7 +132,7 @@ public function mount(): void
|
||||
'color' => $freshnessSpec->color,
|
||||
'icon' => $freshnessSpec->icon,
|
||||
],
|
||||
'next_step' => $truth->nextStepText(),
|
||||
'next_step' => $nextStep,
|
||||
'view_url' => $snapshot->tenant
|
||||
? EvidenceSnapshotResource::getUrl('view', ['record' => $snapshot], tenant: $snapshot->tenant)
|
||||
: null,
|
||||
|
||||
@ -74,6 +74,8 @@ public function mount(): void
|
||||
{
|
||||
$this->navigationContextPayload = is_array(request()->query('nav')) ? request()->query('nav') : null;
|
||||
|
||||
$this->applyRequestedTenantScope();
|
||||
|
||||
app(CanonicalAdminTenantFilterState::class)->sync(
|
||||
$this->getTableFiltersSessionKey(),
|
||||
['type', 'initiator_name'],
|
||||
@ -187,6 +189,17 @@ public function table(Table $table): Table
|
||||
});
|
||||
}
|
||||
|
||||
private function applyRequestedTenantScope(): void
|
||||
{
|
||||
if (! $this->shouldForceWorkspaceWideTenantScope()) {
|
||||
return;
|
||||
}
|
||||
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
app(WorkspaceContext::class)->clearLastTenantId(request());
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array{likely_stale:int,reconciled:int}
|
||||
*/
|
||||
@ -258,12 +271,14 @@ private function scopedSummaryQuery(): ?Builder
|
||||
|
||||
private function applyRequestedDashboardPrefilter(): void
|
||||
{
|
||||
$requestedTenantId = request()->query('tenant_id');
|
||||
if (! $this->shouldForceWorkspaceWideTenantScope()) {
|
||||
$requestedTenantId = request()->query('tenant_id');
|
||||
|
||||
if (is_numeric($requestedTenantId)) {
|
||||
$tenantId = (string) $requestedTenantId;
|
||||
$this->tableFilters['tenant_id']['value'] = $tenantId;
|
||||
$this->tableDeferredFilters['tenant_id']['value'] = $tenantId;
|
||||
if (is_numeric($requestedTenantId)) {
|
||||
$tenantId = (string) $requestedTenantId;
|
||||
$this->tableFilters['tenant_id']['value'] = $tenantId;
|
||||
$this->tableDeferredFilters['tenant_id']['value'] = $tenantId;
|
||||
}
|
||||
}
|
||||
|
||||
$requestedTab = request()->query('activeTab');
|
||||
@ -272,4 +287,9 @@ private function applyRequestedDashboardPrefilter(): void
|
||||
$this->activeTab = (string) $requestedTab;
|
||||
}
|
||||
}
|
||||
|
||||
private function shouldForceWorkspaceWideTenantScope(): bool
|
||||
{
|
||||
return request()->query('tenant_scope') === 'all';
|
||||
}
|
||||
}
|
||||
|
||||
@ -87,7 +87,6 @@
|
||||
use Illuminate\Database\QueryException;
|
||||
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
|
||||
use Illuminate\Support\Facades\DB;
|
||||
use Illuminate\Support\Facades\Gate;
|
||||
use Illuminate\Validation\ValidationException;
|
||||
use InvalidArgumentException;
|
||||
use Livewire\Attributes\Locked;
|
||||
@ -3334,7 +3333,7 @@ private function canInspectOperationRun(OperationRun $run): bool
|
||||
return false;
|
||||
}
|
||||
|
||||
return Gate::forUser($user)->allows('view', $run);
|
||||
return $user->can('view', $run);
|
||||
}
|
||||
|
||||
public function verificationSucceeded(): bool
|
||||
|
||||
@ -469,29 +469,12 @@ private static function migrationReviewDescription(?ProviderConnection $record):
|
||||
|
||||
private static function consentStatusLabelFromState(mixed $state): string
|
||||
{
|
||||
$value = $state instanceof BackedEnum ? $state->value : (is_string($state) ? $state : 'unknown');
|
||||
|
||||
return match ($value) {
|
||||
'required' => 'Required',
|
||||
'granted' => 'Granted',
|
||||
'failed' => 'Failed',
|
||||
'revoked' => 'Revoked',
|
||||
default => 'Unknown',
|
||||
};
|
||||
return BadgeRenderer::spec(BadgeDomain::ProviderConsentStatus, $state)->label;
|
||||
}
|
||||
|
||||
private static function verificationStatusLabelFromState(mixed $state): string
|
||||
{
|
||||
$value = $state instanceof BackedEnum ? $state->value : (is_string($state) ? $state : 'unknown');
|
||||
|
||||
return match ($value) {
|
||||
'pending' => 'Pending',
|
||||
'healthy' => 'Healthy',
|
||||
'degraded' => 'Degraded',
|
||||
'blocked' => 'Blocked',
|
||||
'error' => 'Error',
|
||||
default => 'Unknown',
|
||||
};
|
||||
return BadgeRenderer::spec(BadgeDomain::ProviderVerificationStatus, $state)->label;
|
||||
}
|
||||
|
||||
public static function form(Schema $schema): Schema
|
||||
@ -527,7 +510,7 @@ public static function form(Schema $schema): Schema
|
||||
])
|
||||
->columns(2)
|
||||
->columnSpanFull(),
|
||||
Section::make('Status')
|
||||
Section::make('Current state')
|
||||
->schema([
|
||||
Placeholder::make('consent_status_display')
|
||||
->label('Consent')
|
||||
@ -535,18 +518,31 @@ public static function form(Schema $schema): Schema
|
||||
Placeholder::make('verification_status_display')
|
||||
->label('Verification')
|
||||
->content(fn (?ProviderConnection $record): string => static::verificationStatusLabelFromState($record?->verification_status)),
|
||||
TextInput::make('status')
|
||||
->label('Status')
|
||||
->disabled()
|
||||
->dehydrated(false),
|
||||
TextInput::make('health_status')
|
||||
->label('Health')
|
||||
->disabled()
|
||||
->dehydrated(false),
|
||||
Placeholder::make('last_health_check_at_display')
|
||||
->label('Last check')
|
||||
->content(fn (?ProviderConnection $record): string => $record?->last_health_check_at?->diffForHumans() ?? 'Never'),
|
||||
])
|
||||
->columns(2)
|
||||
->columnSpanFull(),
|
||||
Section::make('Diagnostics')
|
||||
->schema([
|
||||
Placeholder::make('status_display')
|
||||
->label('Legacy status')
|
||||
->content(fn (?ProviderConnection $record): string => BadgeRenderer::spec(BadgeDomain::ProviderConnectionStatus, $record?->status)->label),
|
||||
Placeholder::make('health_status_display')
|
||||
->label('Legacy health')
|
||||
->content(fn (?ProviderConnection $record): string => BadgeRenderer::spec(BadgeDomain::ProviderConnectionHealth, $record?->health_status)->label),
|
||||
Placeholder::make('migration_review_status_display')
|
||||
->label('Migration review')
|
||||
->content(fn (?ProviderConnection $record): string => static::migrationReviewLabel($record))
|
||||
->hint(fn (?ProviderConnection $record): ?string => static::migrationReviewDescription($record)),
|
||||
Placeholder::make('last_error_reason_code_display')
|
||||
->label('Last error reason')
|
||||
->content(fn (?ProviderConnection $record): string => filled($record?->last_error_reason_code) ? (string) $record->last_error_reason_code : 'n/a'),
|
||||
Placeholder::make('last_error_message_display')
|
||||
->label('Last error message')
|
||||
->content(fn (?ProviderConnection $record): string => static::sanitizeErrorMessage($record?->last_error_message) ?? 'n/a')
|
||||
->columnSpanFull(),
|
||||
])
|
||||
->columns(2)
|
||||
->columnSpanFull(),
|
||||
@ -580,22 +576,55 @@ public static function infolist(Schema $schema): Schema
|
||||
->state(fn (ProviderConnection $record): string => static::credentialSourceLabel($record)),
|
||||
])
|
||||
->columns(2),
|
||||
Section::make('Status')
|
||||
Section::make('Current state')
|
||||
->schema([
|
||||
Infolists\Components\TextEntry::make('consent_status')
|
||||
->label('Consent')
|
||||
->formatStateUsing(fn ($state): string => static::consentStatusLabelFromState($state)),
|
||||
->badge()
|
||||
->formatStateUsing(fn ($state): string => static::consentStatusLabelFromState($state))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderConsentStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderConsentStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConsentStatus)),
|
||||
Infolists\Components\TextEntry::make('verification_status')
|
||||
->label('Verification')
|
||||
->formatStateUsing(fn ($state): string => static::verificationStatusLabelFromState($state)),
|
||||
->badge()
|
||||
->formatStateUsing(fn ($state): string => static::verificationStatusLabelFromState($state))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderVerificationStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderVerificationStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderVerificationStatus)),
|
||||
Infolists\Components\TextEntry::make('last_health_check_at')
|
||||
->label('Last check')
|
||||
->since(),
|
||||
])
|
||||
->columns(2),
|
||||
Section::make('Diagnostics')
|
||||
->schema([
|
||||
Infolists\Components\TextEntry::make('status')
|
||||
->label('Status'),
|
||||
->label('Legacy status')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::ProviderConnectionStatus))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderConnectionStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderConnectionStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConnectionStatus)),
|
||||
Infolists\Components\TextEntry::make('health_status')
|
||||
->label('Health'),
|
||||
->label('Legacy health')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::ProviderConnectionHealth))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderConnectionHealth))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderConnectionHealth))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConnectionHealth)),
|
||||
Infolists\Components\TextEntry::make('migration_review_required')
|
||||
->label('Migration review')
|
||||
->formatStateUsing(fn (ProviderConnection $record): string => static::migrationReviewLabel($record))
|
||||
->tooltip(fn (ProviderConnection $record): ?string => static::migrationReviewDescription($record)),
|
||||
Infolists\Components\TextEntry::make('last_error_reason_code')
|
||||
->label('Last error reason')
|
||||
->placeholder('n/a'),
|
||||
Infolists\Components\TextEntry::make('last_error_message')
|
||||
->label('Last error message')
|
||||
->formatStateUsing(fn (?string $state): ?string => static::sanitizeErrorMessage($state))
|
||||
->placeholder('n/a')
|
||||
->columnSpanFull(),
|
||||
])
|
||||
->columns(2),
|
||||
]);
|
||||
@ -655,20 +684,36 @@ public static function table(Table $table): Table
|
||||
? 'Dedicated'
|
||||
: 'Platform')
|
||||
->color(fn (?ProviderConnectionType $state): string => $state === ProviderConnectionType::Dedicated ? 'info' : 'gray'),
|
||||
Tables\Columns\TextColumn::make('consent_status')
|
||||
->label('Consent')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::ProviderConsentStatus))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderConsentStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderConsentStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConsentStatus)),
|
||||
Tables\Columns\TextColumn::make('verification_status')
|
||||
->label('Verification')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::ProviderVerificationStatus))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderVerificationStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderVerificationStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderVerificationStatus)),
|
||||
Tables\Columns\TextColumn::make('status')
|
||||
->label('Status')
|
||||
->label('Legacy status')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::ProviderConnectionStatus))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderConnectionStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderConnectionStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConnectionStatus)),
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConnectionStatus))
|
||||
->toggleable(isToggledHiddenByDefault: true),
|
||||
Tables\Columns\TextColumn::make('health_status')
|
||||
->label('Health')
|
||||
->label('Legacy health')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::ProviderConnectionHealth))
|
||||
->color(BadgeRenderer::color(BadgeDomain::ProviderConnectionHealth))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::ProviderConnectionHealth))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConnectionHealth)),
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::ProviderConnectionHealth))
|
||||
->toggleable(isToggledHiddenByDefault: true),
|
||||
Tables\Columns\TextColumn::make('migration_review_required')
|
||||
->label('Migration review')
|
||||
->badge()
|
||||
@ -714,8 +759,45 @@ public static function table(Table $table): Table
|
||||
|
||||
return $query->where('provider_connections.provider', $value);
|
||||
}),
|
||||
SelectFilter::make('consent_status')
|
||||
->label('Consent')
|
||||
->options([
|
||||
'unknown' => 'Unknown',
|
||||
'required' => 'Required',
|
||||
'granted' => 'Granted',
|
||||
'failed' => 'Failed',
|
||||
'revoked' => 'Revoked',
|
||||
])
|
||||
->query(function (Builder $query, array $data): Builder {
|
||||
$value = $data['value'] ?? null;
|
||||
|
||||
if (! is_string($value) || $value === '') {
|
||||
return $query;
|
||||
}
|
||||
|
||||
return $query->where('provider_connections.consent_status', $value);
|
||||
}),
|
||||
SelectFilter::make('verification_status')
|
||||
->label('Verification')
|
||||
->options([
|
||||
'unknown' => 'Unknown',
|
||||
'pending' => 'Pending',
|
||||
'healthy' => 'Healthy',
|
||||
'degraded' => 'Degraded',
|
||||
'blocked' => 'Blocked',
|
||||
'error' => 'Error',
|
||||
])
|
||||
->query(function (Builder $query, array $data): Builder {
|
||||
$value = $data['value'] ?? null;
|
||||
|
||||
if (! is_string($value) || $value === '') {
|
||||
return $query;
|
||||
}
|
||||
|
||||
return $query->where('provider_connections.verification_status', $value);
|
||||
}),
|
||||
SelectFilter::make('status')
|
||||
->label('Status')
|
||||
->label('Diagnostic status')
|
||||
->options([
|
||||
'connected' => 'Connected',
|
||||
'needs_consent' => 'Needs consent',
|
||||
@ -732,7 +814,7 @@ public static function table(Table $table): Table
|
||||
return $query->where('provider_connections.status', $value);
|
||||
}),
|
||||
SelectFilter::make('health_status')
|
||||
->label('Health')
|
||||
->label('Diagnostic health')
|
||||
->options([
|
||||
'ok' => 'OK',
|
||||
'degraded' => 'Degraded',
|
||||
|
||||
@ -284,13 +284,6 @@ public static function table(Table $table): Table
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::TenantStatus))
|
||||
->description(fn (Tenant $record): string => static::tenantLifecyclePresentation($record)->shortDescription)
|
||||
->sortable(),
|
||||
Tables\Columns\TextColumn::make('app_status')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::TenantAppStatus))
|
||||
->color(BadgeRenderer::color(BadgeDomain::TenantAppStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::TenantAppStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::TenantAppStatus))
|
||||
->toggleable(isToggledHiddenByDefault: true),
|
||||
Tables\Columns\TextColumn::make('created_at')
|
||||
->dateTime()
|
||||
->since()
|
||||
@ -310,13 +303,6 @@ public static function table(Table $table): Table
|
||||
'staging' => 'STAGING',
|
||||
'other' => 'Other',
|
||||
]),
|
||||
Tables\Filters\SelectFilter::make('app_status')
|
||||
->options([
|
||||
'ok' => 'OK',
|
||||
'consent_required' => 'Consent required',
|
||||
'error' => 'Error',
|
||||
'unknown' => 'Unknown',
|
||||
]),
|
||||
])
|
||||
->actions([
|
||||
Actions\Action::make('related_onboarding')
|
||||
@ -842,12 +828,6 @@ public static function infolist(Schema $schema): Schema
|
||||
->label('Lifecycle summary')
|
||||
->state(fn (Tenant $record): string => static::tenantLifecyclePresentation($record)->longDescription)
|
||||
->columnSpanFull(),
|
||||
Infolists\Components\TextEntry::make('app_status')
|
||||
->badge()
|
||||
->formatStateUsing(BadgeRenderer::label(BadgeDomain::TenantAppStatus))
|
||||
->color(BadgeRenderer::color(BadgeDomain::TenantAppStatus))
|
||||
->icon(BadgeRenderer::icon(BadgeDomain::TenantAppStatus))
|
||||
->iconColor(BadgeRenderer::iconColor(BadgeDomain::TenantAppStatus)),
|
||||
])
|
||||
->columns(2)
|
||||
->columnSpanFull(),
|
||||
@ -1492,19 +1472,30 @@ private static function providerConnectionState(Tenant $tenant): array
|
||||
{
|
||||
$ctaUrl = ProviderConnectionResource::getUrl('index', ['tenant_id' => (string) $tenant->external_id], panel: 'admin');
|
||||
|
||||
$connection = ProviderConnection::query()
|
||||
$defaultConnection = ProviderConnection::query()
|
||||
->where('tenant_id', (int) $tenant->getKey())
|
||||
->where('provider', 'microsoft')
|
||||
->orderByDesc('is_default')
|
||||
->where('is_default', true)
|
||||
->orderBy('id')
|
||||
->first();
|
||||
|
||||
$connection = $defaultConnection instanceof ProviderConnection
|
||||
? $defaultConnection
|
||||
: ProviderConnection::query()
|
||||
->where('tenant_id', (int) $tenant->getKey())
|
||||
->where('provider', 'microsoft')
|
||||
->orderBy('id')
|
||||
->first();
|
||||
|
||||
if (! $connection instanceof ProviderConnection) {
|
||||
return [
|
||||
'state' => 'needs_action',
|
||||
'state' => 'missing',
|
||||
'cta_url' => $ctaUrl,
|
||||
'needs_default_connection' => false,
|
||||
'display_name' => null,
|
||||
'provider' => null,
|
||||
'consent_status' => null,
|
||||
'verification_status' => null,
|
||||
'status' => null,
|
||||
'health_status' => null,
|
||||
'last_health_check_at' => null,
|
||||
@ -1515,8 +1506,15 @@ private static function providerConnectionState(Tenant $tenant): array
|
||||
return [
|
||||
'state' => $connection->is_default ? 'default_configured' : 'configured',
|
||||
'cta_url' => $ctaUrl,
|
||||
'needs_default_connection' => ! $connection->is_default,
|
||||
'display_name' => (string) $connection->display_name,
|
||||
'provider' => (string) $connection->provider,
|
||||
'consent_status' => $connection->consent_status instanceof BackedEnum
|
||||
? (string) $connection->consent_status->value
|
||||
: (is_string($connection->consent_status) ? $connection->consent_status : null),
|
||||
'verification_status' => $connection->verification_status instanceof BackedEnum
|
||||
? (string) $connection->verification_status->value
|
||||
: (is_string($connection->verification_status) ? $connection->verification_status : null),
|
||||
'status' => is_string($connection->status) ? $connection->status : null,
|
||||
'health_status' => is_string($connection->health_status) ? $connection->health_status : null,
|
||||
'last_health_check_at' => optional($connection->last_health_check_at)->toDateTimeString(),
|
||||
|
||||
@ -201,7 +201,7 @@ protected function getViewData(): array
|
||||
&& $user->can(Capabilities::PROVIDER_RUN, $tenant);
|
||||
|
||||
$lifecycleNotice = $isTenantMember && ! $canOperate
|
||||
? 'Verification can be started from tenant management only while the tenant is active.'
|
||||
? 'Verification can be started from tenant management only while the tenant is active. Consent and connection configuration remain separate from this stored verification report.'
|
||||
: null;
|
||||
|
||||
$runData = null;
|
||||
|
||||
@ -16,11 +16,21 @@ class WorkspaceNeedsAttention extends Widget
|
||||
|
||||
/**
|
||||
* @var array<int, array{
|
||||
* key: string,
|
||||
* tenant_id: int,
|
||||
* tenant_label: string,
|
||||
* tenant_route_key: string,
|
||||
* family: string,
|
||||
* urgency: string,
|
||||
* title: string,
|
||||
* body: string,
|
||||
* url: string,
|
||||
* supporting_message: ?string,
|
||||
* badge: string,
|
||||
* badge_color: string
|
||||
* badge_color: string,
|
||||
* destination: array<string, mixed>,
|
||||
* action_disabled: bool,
|
||||
* helper_text: ?string,
|
||||
* url: ?string
|
||||
* }>
|
||||
*/
|
||||
public array $items = [];
|
||||
@ -37,11 +47,21 @@ class WorkspaceNeedsAttention extends Widget
|
||||
|
||||
/**
|
||||
* @param array<int, array{
|
||||
* key: string,
|
||||
* tenant_id: int,
|
||||
* tenant_label: string,
|
||||
* tenant_route_key: string,
|
||||
* family: string,
|
||||
* urgency: string,
|
||||
* title: string,
|
||||
* body: string,
|
||||
* url: string,
|
||||
* supporting_message: ?string,
|
||||
* badge: string,
|
||||
* badge_color: string
|
||||
* badge_color: string,
|
||||
* destination: array<string, mixed>,
|
||||
* action_disabled: bool,
|
||||
* helper_text: ?string,
|
||||
* url: ?string
|
||||
* }> $items
|
||||
* @param array{
|
||||
* title: string,
|
||||
|
||||
@ -25,6 +25,7 @@ class WorkspaceRecentOperations extends Widget
|
||||
* outcome_color: string,
|
||||
* guidance: ?string,
|
||||
* started_at: string,
|
||||
* destination: array<string, mixed>,
|
||||
* url: string
|
||||
* }>
|
||||
*/
|
||||
@ -51,6 +52,7 @@ class WorkspaceRecentOperations extends Widget
|
||||
* outcome_color: string,
|
||||
* guidance: ?string,
|
||||
* started_at: string,
|
||||
* destination: array<string, mixed>,
|
||||
* url: string
|
||||
* }> $operations
|
||||
* @param array{
|
||||
|
||||
@ -20,9 +20,11 @@ class WorkspaceSummaryStats extends StatsOverviewWidget
|
||||
* key: string,
|
||||
* label: string,
|
||||
* value: int,
|
||||
* category: string,
|
||||
* description: string,
|
||||
* destination: ?array<string, mixed>,
|
||||
* destination_url: ?string,
|
||||
* color: string
|
||||
* color: string,
|
||||
* }>
|
||||
*/
|
||||
public array $metrics = [];
|
||||
@ -32,9 +34,11 @@ class WorkspaceSummaryStats extends StatsOverviewWidget
|
||||
* key: string,
|
||||
* label: string,
|
||||
* value: int,
|
||||
* category: string,
|
||||
* description: string,
|
||||
* destination: ?array<string, mixed>,
|
||||
* destination_url: ?string,
|
||||
* color: string
|
||||
* color: string,
|
||||
* }> $metrics
|
||||
*/
|
||||
public function mount(array $metrics = []): void
|
||||
@ -53,8 +57,13 @@ protected function getStats(): array
|
||||
->description($metric['description'])
|
||||
->color($metric['color']);
|
||||
|
||||
if ($metric['destination_url'] !== null) {
|
||||
$stat->url($metric['destination_url']);
|
||||
$destination = $metric['destination'] ?? null;
|
||||
$destinationUrl = is_array($destination) && ($destination['disabled'] ?? false) === false
|
||||
? ($destination['url'] ?? null)
|
||||
: ($metric['destination_url'] ?? null);
|
||||
|
||||
if (is_string($destinationUrl) && $destinationUrl !== '') {
|
||||
$stat->url($destinationUrl);
|
||||
}
|
||||
|
||||
return $stat;
|
||||
|
||||
@ -46,6 +46,8 @@ final class BadgeCatalog
|
||||
BadgeDomain::IgnoredAt->value => Domains\IgnoredAtBadge::class,
|
||||
BadgeDomain::RestorePreviewDecision->value => Domains\RestorePreviewDecisionBadge::class,
|
||||
BadgeDomain::RestoreResultStatus->value => Domains\RestoreResultStatusBadge::class,
|
||||
BadgeDomain::ProviderConsentStatus->value => Domains\ProviderConsentStatusBadge::class,
|
||||
BadgeDomain::ProviderVerificationStatus->value => Domains\ProviderVerificationStatusBadge::class,
|
||||
BadgeDomain::ProviderConnectionStatus->value => Domains\ProviderConnectionStatusBadge::class,
|
||||
BadgeDomain::ProviderConnectionHealth->value => Domains\ProviderConnectionHealthBadge::class,
|
||||
BadgeDomain::ManagedTenantOnboardingVerificationStatus->value => Domains\ManagedTenantOnboardingVerificationStatusBadge::class,
|
||||
@ -166,6 +168,32 @@ public static function normalizeProviderConnectionStatus(mixed $value): ?string
|
||||
};
|
||||
}
|
||||
|
||||
public static function normalizeProviderConsentStatus(mixed $value): ?string
|
||||
{
|
||||
$state = self::normalizeState($value);
|
||||
|
||||
return match ($state) {
|
||||
'needs_admin_consent', 'needs_consent', 'consent_required' => 'required',
|
||||
'connected' => 'granted',
|
||||
'error' => 'failed',
|
||||
default => $state,
|
||||
};
|
||||
}
|
||||
|
||||
public static function normalizeProviderVerificationStatus(mixed $value): ?string
|
||||
{
|
||||
$state = self::normalizeState($value);
|
||||
|
||||
return match ($state) {
|
||||
'not_started', 'never_checked' => 'unknown',
|
||||
'in_progress' => 'pending',
|
||||
'ok' => 'healthy',
|
||||
'warning', 'needs_attention' => 'degraded',
|
||||
'failed' => 'error',
|
||||
default => $state,
|
||||
};
|
||||
}
|
||||
|
||||
public static function normalizeProviderConnectionHealth(mixed $value): ?string
|
||||
{
|
||||
$state = self::normalizeState($value);
|
||||
|
||||
@ -37,6 +37,8 @@ enum BadgeDomain: string
|
||||
case IgnoredAt = 'ignored_at';
|
||||
case RestorePreviewDecision = 'restore_preview_decision';
|
||||
case RestoreResultStatus = 'restore_result_status';
|
||||
case ProviderConsentStatus = 'provider_connection.consent_status';
|
||||
case ProviderVerificationStatus = 'provider_connection.verification_status';
|
||||
case ProviderConnectionStatus = 'provider_connection.status';
|
||||
case ProviderConnectionHealth = 'provider_connection.health';
|
||||
case ManagedTenantOnboardingVerificationStatus = 'managed_tenant_onboarding.verification_status';
|
||||
|
||||
24
app/Support/Badges/Domains/ProviderConsentStatusBadge.php
Normal file
24
app/Support/Badges/Domains/ProviderConsentStatusBadge.php
Normal file
@ -0,0 +1,24 @@
|
||||
<?php
|
||||
|
||||
namespace App\Support\Badges\Domains;
|
||||
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeMapper;
|
||||
use App\Support\Badges\BadgeSpec;
|
||||
|
||||
final class ProviderConsentStatusBadge implements BadgeMapper
|
||||
{
|
||||
public function spec(mixed $value): BadgeSpec
|
||||
{
|
||||
$state = BadgeCatalog::normalizeProviderConsentStatus($value);
|
||||
|
||||
return match ($state) {
|
||||
'required' => new BadgeSpec('Required', 'warning', 'heroicon-m-exclamation-triangle'),
|
||||
'granted' => new BadgeSpec('Granted', 'success', 'heroicon-m-check-circle'),
|
||||
'failed' => new BadgeSpec('Failed', 'danger', 'heroicon-m-x-circle'),
|
||||
'revoked' => new BadgeSpec('Revoked', 'danger', 'heroicon-m-no-symbol'),
|
||||
'unknown' => new BadgeSpec('Unknown', 'gray', 'heroicon-m-question-mark-circle'),
|
||||
default => BadgeSpec::unknown(),
|
||||
};
|
||||
}
|
||||
}
|
||||
@ -0,0 +1,25 @@
|
||||
<?php
|
||||
|
||||
namespace App\Support\Badges\Domains;
|
||||
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeMapper;
|
||||
use App\Support\Badges\BadgeSpec;
|
||||
|
||||
final class ProviderVerificationStatusBadge implements BadgeMapper
|
||||
{
|
||||
public function spec(mixed $value): BadgeSpec
|
||||
{
|
||||
$state = BadgeCatalog::normalizeProviderVerificationStatus($value);
|
||||
|
||||
return match ($state) {
|
||||
'pending' => new BadgeSpec('Pending', 'info', 'heroicon-m-clock'),
|
||||
'healthy' => new BadgeSpec('Healthy', 'success', 'heroicon-m-check-circle'),
|
||||
'degraded' => new BadgeSpec('Degraded', 'warning', 'heroicon-m-exclamation-triangle'),
|
||||
'blocked' => new BadgeSpec('Blocked', 'danger', 'heroicon-m-no-symbol'),
|
||||
'error' => new BadgeSpec('Error', 'danger', 'heroicon-m-x-circle'),
|
||||
'unknown' => new BadgeSpec('Unknown', 'gray', 'heroicon-m-question-mark-circle'),
|
||||
default => BadgeSpec::unknown(),
|
||||
};
|
||||
}
|
||||
}
|
||||
@ -188,13 +188,15 @@ private function resolveTenantRouteParameter(mixed $routeTenant): ?Tenant
|
||||
return null;
|
||||
}
|
||||
|
||||
$tenantKeyColumn = (new Tenant)->getQualifiedKeyName();
|
||||
|
||||
return Tenant::query()
|
||||
->withTrashed()
|
||||
->where(static function ($query) use ($routeTenant): void {
|
||||
->where(static function ($query) use ($routeTenant, $tenantKeyColumn): void {
|
||||
$query->where('external_id', $routeTenant);
|
||||
|
||||
if (ctype_digit($routeTenant)) {
|
||||
$query->orWhereKey((int) $routeTenant);
|
||||
$query->orWhere($tenantKeyColumn, (int) $routeTenant);
|
||||
}
|
||||
})
|
||||
->first();
|
||||
|
||||
@ -79,11 +79,14 @@ public static function index(
|
||||
?Tenant $tenant = null,
|
||||
?CanonicalNavigationContext $context = null,
|
||||
?string $activeTab = null,
|
||||
bool $allTenants = false,
|
||||
): string {
|
||||
$parameters = $context?->toQuery() ?? [];
|
||||
|
||||
if ($tenant instanceof Tenant) {
|
||||
$parameters['tenant_id'] = (int) $tenant->getKey();
|
||||
} elseif ($allTenants) {
|
||||
$parameters['tenant_scope'] = 'all';
|
||||
}
|
||||
|
||||
if (is_string($activeTab) && $activeTab !== '') {
|
||||
|
||||
@ -17,6 +17,7 @@
|
||||
use App\Services\Baselines\SnapshotRendering\FidelityState;
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeDomain;
|
||||
use App\Support\Evidence\EvidenceCompletenessState;
|
||||
use App\Support\OperationCatalog;
|
||||
use App\Support\OperationRunLinks;
|
||||
use App\Support\OperationRunOutcome;
|
||||
@ -349,7 +350,9 @@ private function buildEvidenceSnapshotEnvelope(EvidenceSnapshot $snapshot): Arti
|
||||
'required' => 'Refresh evidence before using this snapshot',
|
||||
'optional' => in_array($status, ['queued', 'generating'], true)
|
||||
? 'Wait for evidence generation to finish'
|
||||
: 'Review the evidence freshness before relying on this snapshot',
|
||||
: ($freshnessState === 'stale'
|
||||
? 'Refresh the stale evidence before relying on this snapshot'
|
||||
: 'Review the evidence freshness before relying on this snapshot'),
|
||||
default => null,
|
||||
},
|
||||
),
|
||||
@ -402,7 +405,7 @@ public function forTenantReviewFresh(TenantReview $review): ArtifactTruthEnvelop
|
||||
|
||||
private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthEnvelope
|
||||
{
|
||||
$review->loadMissing(['tenant', 'currentExportReviewPack']);
|
||||
$review->loadMissing(['tenant', 'currentExportReviewPack', 'evidenceSnapshot']);
|
||||
|
||||
$summary = is_array($review->summary) ? $review->summary : [];
|
||||
$publishBlockers = $review->publishBlockers();
|
||||
@ -410,6 +413,7 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
$completeness = $review->completenessEnum()->value;
|
||||
$sectionCounts = is_array($summary['section_state_counts'] ?? null) ? $summary['section_state_counts'] : [];
|
||||
$staleSections = (int) ($sectionCounts['stale'] ?? 0);
|
||||
$sourceEvidence = $this->evidenceTrustBurden($review->evidenceSnapshot);
|
||||
|
||||
$artifactExistence = match ($status) {
|
||||
TenantReviewStatus::Archived, TenantReviewStatus::Superseded => 'historical_only',
|
||||
@ -417,24 +421,27 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
default => 'created',
|
||||
};
|
||||
|
||||
$contentState = match ($completeness) {
|
||||
TenantReviewCompletenessState::Complete->value => 'trusted',
|
||||
TenantReviewCompletenessState::Partial->value => 'partial',
|
||||
TenantReviewCompletenessState::Missing->value => 'missing_input',
|
||||
TenantReviewCompletenessState::Stale->value => 'trusted',
|
||||
$contentState = match (true) {
|
||||
$completeness === TenantReviewCompletenessState::Missing->value => 'missing_input',
|
||||
$completeness === TenantReviewCompletenessState::Partial->value || $sourceEvidence['isPartial'] => 'partial',
|
||||
$sourceEvidence['isMissing'] => 'missing_input',
|
||||
$completeness === TenantReviewCompletenessState::Complete->value => 'trusted',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value => 'trusted',
|
||||
default => 'partial',
|
||||
};
|
||||
|
||||
$freshnessState = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'stale',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value || $staleSections > 0 => 'stale',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value || $staleSections > 0 || $sourceEvidence['isStale'] => 'stale',
|
||||
default => 'current',
|
||||
};
|
||||
|
||||
$publicationReadiness = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'internal_only',
|
||||
$status === TenantReviewStatus::Published => 'publishable',
|
||||
$publishBlockers !== [] => 'blocked',
|
||||
$contentState === 'missing_input' => 'blocked',
|
||||
$freshnessState === 'stale' || $contentState === 'partial' => 'internal_only',
|
||||
$status === TenantReviewStatus::Published => 'publishable',
|
||||
$status === TenantReviewStatus::Ready => 'publishable',
|
||||
default => 'internal_only',
|
||||
};
|
||||
@ -442,16 +449,16 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
$actionability = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'none',
|
||||
$publicationReadiness === 'publishable' && $freshnessState === 'current' => 'none',
|
||||
$publicationReadiness === 'internal_only' && $contentState === 'trusted' => 'optional',
|
||||
$freshnessState === 'stale' && $publishBlockers === [] => 'optional',
|
||||
$publicationReadiness === 'blocked' => 'required',
|
||||
$publicationReadiness === 'internal_only' => 'optional',
|
||||
default => 'required',
|
||||
};
|
||||
|
||||
$reasonCode = match (true) {
|
||||
$publishBlockers !== [] => 'review_publish_blocked',
|
||||
$status === TenantReviewStatus::Failed => 'review_generation_failed',
|
||||
$completeness === TenantReviewCompletenessState::Missing->value => 'review_missing_sections',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value => 'review_stale_sections',
|
||||
$contentState === 'missing_input' => 'review_missing_sections',
|
||||
$freshnessState === 'stale' => 'review_stale_sections',
|
||||
default => null,
|
||||
};
|
||||
$reason = $this->reasonPresenter->forArtifactTruth($reasonCode, 'artifact_truth');
|
||||
@ -470,7 +477,11 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
$publicationReadiness === 'internal_only' => [
|
||||
BadgeDomain::GovernanceArtifactPublicationReadiness,
|
||||
'internal_only',
|
||||
'This review exists and is useful internally, but it is not yet ready for stakeholder publication.',
|
||||
match (true) {
|
||||
$freshnessState === 'stale' => 'This review is useful internally, but stale evidence should be refreshed before stakeholder publication.',
|
||||
$contentState === 'partial' => 'This review is useful internally, but the evidence basis is partial and should be completed before stakeholder publication.',
|
||||
default => 'This review exists and is useful internally, but it is not yet ready for stakeholder publication.',
|
||||
},
|
||||
],
|
||||
$freshnessState === 'stale' => [
|
||||
BadgeDomain::GovernanceArtifactFreshness,
|
||||
@ -490,6 +501,8 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
|
||||
if ($publishBlockers !== [] && $review->tenant !== null) {
|
||||
$nextActionUrl = TenantReviewResource::tenantScopedUrl('view', ['record' => $review], $review->tenant);
|
||||
} elseif (($freshnessState === 'stale' || $contentState === 'partial') && $review->tenant !== null && $review->evidenceSnapshot !== null) {
|
||||
$nextActionUrl = EvidenceSnapshotResource::getUrl('view', ['record' => $review->evidenceSnapshot], tenant: $review->tenant);
|
||||
}
|
||||
|
||||
return $this->makeEnvelope(
|
||||
@ -514,9 +527,11 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
nextActionLabel: $this->nextActionLabel(
|
||||
$actionability,
|
||||
$reason,
|
||||
match ($actionability) {
|
||||
'required' => 'Resolve the review blockers before publication',
|
||||
'optional' => 'Complete the remaining review work before publication',
|
||||
match (true) {
|
||||
$publicationReadiness === 'blocked' => 'Resolve the review blockers before publication',
|
||||
$freshnessState === 'stale' => 'Refresh the evidence basis before publishing this review',
|
||||
$contentState === 'partial' => 'Complete the evidence basis before publishing this review',
|
||||
$actionability === 'optional' => 'Complete the remaining review work before publication',
|
||||
default => null,
|
||||
},
|
||||
),
|
||||
@ -568,14 +583,18 @@ public function forReviewPackFresh(ReviewPack $pack): ArtifactTruthEnvelope
|
||||
|
||||
private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelope
|
||||
{
|
||||
$pack->loadMissing(['tenant', 'tenantReview']);
|
||||
$pack->loadMissing(['tenant', 'tenantReview', 'evidenceSnapshot']);
|
||||
|
||||
$summary = is_array($pack->summary) ? $pack->summary : [];
|
||||
$status = (string) $pack->status;
|
||||
$evidenceResolution = is_array($summary['evidence_resolution'] ?? null) ? $summary['evidence_resolution'] : [];
|
||||
$sourceReview = $pack->tenantReview;
|
||||
$sourceReviewTruth = $sourceReview instanceof TenantReview
|
||||
? $this->forTenantReviewFresh($sourceReview)
|
||||
: null;
|
||||
$sourceBlockers = $sourceReview instanceof TenantReview ? $sourceReview->publishBlockers() : [];
|
||||
$sourceReviewStatus = $sourceReview instanceof TenantReview ? $sourceReview->statusEnum() : null;
|
||||
$sourceEvidence = $this->evidenceTrustBurden($pack->evidenceSnapshot);
|
||||
|
||||
$artifactExistence = match ($status) {
|
||||
ReviewPackStatus::Queued->value, ReviewPackStatus::Generating->value => 'not_created',
|
||||
@ -588,23 +607,31 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
$artifactExistence === 'not_created' => 'missing_input',
|
||||
$status === ReviewPackStatus::Failed->value => 'missing_input',
|
||||
($evidenceResolution['outcome'] ?? null) !== 'resolved' => 'missing_input',
|
||||
$sourceReview instanceof TenantReview && $sourceBlockers !== [] => 'partial',
|
||||
$sourceReviewTruth?->contentState === 'missing_input' => 'missing_input',
|
||||
$sourceReviewTruth?->contentState === 'partial' || $sourceEvidence['isPartial'] => 'partial',
|
||||
default => 'trusted',
|
||||
};
|
||||
|
||||
$freshnessState = $artifactExistence === 'historical_only' ? 'stale' : 'current';
|
||||
$freshnessState = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'stale',
|
||||
$sourceReviewTruth?->freshnessState === 'stale' || $sourceEvidence['isStale'] => 'stale',
|
||||
default => 'current',
|
||||
};
|
||||
|
||||
$publicationReadiness = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'internal_only',
|
||||
$artifactExistence === 'not_created' => 'blocked',
|
||||
$status === ReviewPackStatus::Failed->value => 'blocked',
|
||||
$sourceReview instanceof TenantReview && $sourceBlockers !== [] => 'blocked',
|
||||
$sourceReviewTruth?->publicationReadiness === 'blocked' => 'blocked',
|
||||
$sourceReviewTruth?->publicationReadiness === 'internal_only' => 'internal_only',
|
||||
$freshnessState === 'stale' || $contentState === 'partial' => 'internal_only',
|
||||
$sourceReviewStatus === TenantReviewStatus::Draft || $sourceReviewStatus === TenantReviewStatus::Failed => 'internal_only',
|
||||
default => $status === ReviewPackStatus::Ready->value ? 'publishable' : 'blocked',
|
||||
};
|
||||
|
||||
$actionability = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'none',
|
||||
$publicationReadiness === 'publishable' => 'none',
|
||||
$publicationReadiness === 'publishable' && $freshnessState === 'current' => 'none',
|
||||
$publicationReadiness === 'internal_only' => 'optional',
|
||||
default => 'required',
|
||||
};
|
||||
@ -612,7 +639,7 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
$reasonCode = match (true) {
|
||||
$status === ReviewPackStatus::Failed->value => 'review_pack_generation_failed',
|
||||
($evidenceResolution['outcome'] ?? null) !== 'resolved' => 'review_pack_missing_snapshot',
|
||||
$sourceReview instanceof TenantReview && $sourceBlockers !== [] => 'review_pack_source_not_publishable',
|
||||
$sourceReviewTruth?->publicationReadiness === 'blocked' || $sourceReviewTruth?->publicationReadiness === 'internal_only' => 'review_pack_source_not_publishable',
|
||||
$artifactExistence === 'historical_only' => 'review_pack_expired',
|
||||
default => null,
|
||||
};
|
||||
@ -632,7 +659,11 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
$publicationReadiness === 'internal_only' => [
|
||||
BadgeDomain::GovernanceArtifactPublicationReadiness,
|
||||
'internal_only',
|
||||
'This pack can be reviewed internally, but the source review is not currently publishable.',
|
||||
match (true) {
|
||||
$freshnessState === 'stale' => 'This pack is downloadable, but the source review relies on stale evidence and should stay internal until refreshed.',
|
||||
$contentState === 'partial' => 'This pack is downloadable, but the source review relies on partial evidence and should stay internal until the evidence basis is completed.',
|
||||
default => 'This pack can be reviewed internally, but the source review is not currently publishable.',
|
||||
},
|
||||
],
|
||||
default => [
|
||||
BadgeDomain::GovernanceArtifactPublicationReadiness,
|
||||
@ -645,6 +676,8 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
|
||||
if ($sourceReview instanceof TenantReview && $pack->tenant !== null) {
|
||||
$nextActionUrl = TenantReviewResource::tenantScopedUrl('view', ['record' => $sourceReview], $pack->tenant);
|
||||
} elseif (($freshnessState === 'stale' || $contentState === 'partial') && $pack->tenant !== null && $pack->evidenceSnapshot !== null) {
|
||||
$nextActionUrl = EvidenceSnapshotResource::getUrl('view', ['record' => $pack->evidenceSnapshot], tenant: $pack->tenant);
|
||||
} elseif ($pack->operation_run_id !== null) {
|
||||
$nextActionUrl = OperationRunLinks::tenantlessView((int) $pack->operation_run_id);
|
||||
}
|
||||
@ -671,9 +704,11 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
nextActionLabel: $this->nextActionLabel(
|
||||
$actionability,
|
||||
$reason,
|
||||
match ($actionability) {
|
||||
'required' => 'Open the source review before sharing this pack',
|
||||
'optional' => 'Review the source review before sharing this pack',
|
||||
match (true) {
|
||||
$publicationReadiness === 'blocked' => 'Open the source review before sharing this pack',
|
||||
$freshnessState === 'stale' => 'Refresh the source review before sharing this pack',
|
||||
$contentState === 'partial' => 'Complete the source review before sharing this pack',
|
||||
$actionability === 'optional' => 'Review the source review before sharing this pack',
|
||||
default => null,
|
||||
},
|
||||
),
|
||||
@ -704,6 +739,30 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array{isMissing: bool, isPartial: bool, isStale: bool}
|
||||
*/
|
||||
private function evidenceTrustBurden(?EvidenceSnapshot $snapshot): array
|
||||
{
|
||||
if (! $snapshot instanceof EvidenceSnapshot) {
|
||||
return [
|
||||
'isMissing' => false,
|
||||
'isPartial' => false,
|
||||
'isStale' => false,
|
||||
];
|
||||
}
|
||||
|
||||
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
||||
$completeness = $snapshot->completenessState();
|
||||
$staleDimensions = (int) ($summary['stale_dimensions'] ?? 0);
|
||||
|
||||
return [
|
||||
'isMissing' => $completeness === EvidenceCompletenessState::Missing,
|
||||
'isPartial' => $completeness === EvidenceCompletenessState::Partial,
|
||||
'isStale' => $completeness === EvidenceCompletenessState::Stale || $staleDimensions > 0,
|
||||
];
|
||||
}
|
||||
|
||||
public function forOperationRun(OperationRun $run): ArtifactTruthEnvelope
|
||||
{
|
||||
return $this->resolveEnvelope(
|
||||
@ -808,7 +867,7 @@ private function buildOperationRunEnvelope(OperationRun $run): ArtifactTruthEnve
|
||||
reason: ArtifactTruthCause::fromReasonResolutionEnvelope($reason, ReasonPresenter::GOVERNANCE_ARTIFACT_TRUTH_ARTIFACT),
|
||||
nextActionLabel: $reason?->firstNextStep()?->label
|
||||
?? ($actionability === 'required'
|
||||
? 'Inspect the blocked operation details before retrying'
|
||||
? 'Inspect the blocked run details before retrying'
|
||||
: 'Wait for the artifact-producing operation to finish'),
|
||||
nextActionUrl: null,
|
||||
relatedRunId: (int) $run->getKey(),
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
@ -2,17 +2,24 @@
|
||||
$state = $getState();
|
||||
$state = is_array($state) ? $state : [];
|
||||
|
||||
$connectionState = is_string($state['state'] ?? null) ? (string) $state['state'] : 'needs_action';
|
||||
$connectionState = is_string($state['state'] ?? null) ? (string) $state['state'] : 'missing';
|
||||
$ctaUrl = is_string($state['cta_url'] ?? null) ? (string) $state['cta_url'] : '#';
|
||||
$needsDefaultConnection = (bool) ($state['needs_default_connection'] ?? false);
|
||||
|
||||
$displayName = is_string($state['display_name'] ?? null) ? (string) $state['display_name'] : null;
|
||||
$provider = is_string($state['provider'] ?? null) ? (string) $state['provider'] : null;
|
||||
$consentStatus = is_string($state['consent_status'] ?? null) ? (string) $state['consent_status'] : null;
|
||||
$verificationStatus = is_string($state['verification_status'] ?? null) ? (string) $state['verification_status'] : null;
|
||||
$status = is_string($state['status'] ?? null) ? (string) $state['status'] : null;
|
||||
$healthStatus = is_string($state['health_status'] ?? null) ? (string) $state['health_status'] : null;
|
||||
$lastCheck = is_string($state['last_health_check_at'] ?? null) ? (string) $state['last_health_check_at'] : null;
|
||||
$lastErrorReason = is_string($state['last_error_reason_code'] ?? null) ? (string) $state['last_error_reason_code'] : null;
|
||||
|
||||
$isMissing = $connectionState === 'needs_action';
|
||||
$isMissing = $connectionState === 'missing';
|
||||
$consentSpec = \App\Support\Badges\BadgeRenderer::spec(\App\Support\Badges\BadgeDomain::ProviderConsentStatus, $consentStatus);
|
||||
$verificationSpec = \App\Support\Badges\BadgeRenderer::spec(\App\Support\Badges\BadgeDomain::ProviderVerificationStatus, $verificationStatus);
|
||||
$legacyStatusSpec = \App\Support\Badges\BadgeRenderer::spec(\App\Support\Badges\BadgeDomain::ProviderConnectionStatus, $status);
|
||||
$legacyHealthSpec = \App\Support\Badges\BadgeRenderer::spec(\App\Support\Badges\BadgeDomain::ProviderConnectionHealth, $healthStatus);
|
||||
@endphp
|
||||
|
||||
<div class="space-y-3 rounded-md border border-gray-200 bg-white p-4 shadow-sm">
|
||||
@ -20,7 +27,9 @@
|
||||
<div>
|
||||
<div class="text-sm font-semibold text-gray-800">Provider connection</div>
|
||||
@if ($isMissing)
|
||||
<div class="mt-1 text-sm text-amber-700">Needs action: no default Microsoft provider connection is configured.</div>
|
||||
<div class="mt-1 text-sm text-amber-700">Needs action: no Microsoft provider connection is configured.</div>
|
||||
@elseif ($needsDefaultConnection)
|
||||
<div class="mt-1 text-sm text-amber-700">Needs action: set a default Microsoft provider connection.</div>
|
||||
@else
|
||||
<div class="mt-1 text-sm text-gray-700">{{ $displayName ?? 'Unnamed connection' }}</div>
|
||||
@endif
|
||||
@ -32,18 +41,32 @@
|
||||
</div>
|
||||
|
||||
@unless ($isMissing)
|
||||
@if ($needsDefaultConnection && $displayName)
|
||||
<div class="text-sm text-gray-700">
|
||||
Current connection: <span class="font-medium">{{ $displayName }}</span>
|
||||
</div>
|
||||
@endif
|
||||
|
||||
<dl class="grid grid-cols-1 gap-2 text-sm text-gray-700 sm:grid-cols-2">
|
||||
<div>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Provider</dt>
|
||||
<dd>{{ $provider ?? 'n/a' }}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Status</dt>
|
||||
<dd>{{ $status ?? 'n/a' }}</dd>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Consent</dt>
|
||||
<dd>
|
||||
<x-filament::badge :color="$consentSpec->color" :icon="$consentSpec->icon" size="sm">
|
||||
{{ $consentSpec->label }}
|
||||
</x-filament::badge>
|
||||
</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Health</dt>
|
||||
<dd>{{ $healthStatus ?? 'n/a' }}</dd>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Verification</dt>
|
||||
<dd>
|
||||
<x-filament::badge :color="$verificationSpec->color" :icon="$verificationSpec->icon" size="sm">
|
||||
{{ $verificationSpec->label }}
|
||||
</x-filament::badge>
|
||||
</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Last check</dt>
|
||||
@ -51,10 +74,32 @@
|
||||
</div>
|
||||
</dl>
|
||||
|
||||
@if ($lastErrorReason)
|
||||
<div class="rounded-md border border-amber-300 bg-amber-50 p-2 text-xs text-amber-800">
|
||||
Last error reason: {{ $lastErrorReason }}
|
||||
</div>
|
||||
@endif
|
||||
<div class="space-y-2 rounded-md border border-gray-200 bg-gray-50 p-3 text-sm text-gray-700">
|
||||
<div class="text-xs font-semibold uppercase tracking-wide text-gray-500">Diagnostics</div>
|
||||
<dl class="grid grid-cols-1 gap-2 sm:grid-cols-2">
|
||||
<div>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Legacy status</dt>
|
||||
<dd>
|
||||
<x-filament::badge :color="$legacyStatusSpec->color" :icon="$legacyStatusSpec->icon" size="sm">
|
||||
{{ $legacyStatusSpec->label }}
|
||||
</x-filament::badge>
|
||||
</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt class="text-xs uppercase tracking-wide text-gray-500">Legacy health</dt>
|
||||
<dd>
|
||||
<x-filament::badge :color="$legacyHealthSpec->color" :icon="$legacyHealthSpec->icon" size="sm">
|
||||
{{ $legacyHealthSpec->label }}
|
||||
</x-filament::badge>
|
||||
</dd>
|
||||
</div>
|
||||
</dl>
|
||||
|
||||
@if ($lastErrorReason)
|
||||
<div class="rounded-md border border-amber-300 bg-amber-50 p-2 text-xs text-amber-800">
|
||||
Last error reason: {{ $lastErrorReason }}
|
||||
</div>
|
||||
@endif
|
||||
</div>
|
||||
@endunless
|
||||
</div>
|
||||
|
||||
@ -26,7 +26,7 @@
|
||||
</h1>
|
||||
|
||||
<p class="max-w-2xl text-sm leading-6 text-gray-600 dark:text-gray-300">
|
||||
This home stays workspace-scoped even when you were previously working in a tenant. Tenant drill-down remains explicit so the overview never silently narrows itself.
|
||||
This home stays workspace-scoped even when you were previously working in a tenant. Governance risk is ranked ahead of execution noise, and calm wording only appears when the checked workspace domains are genuinely quiet.
|
||||
</p>
|
||||
</div>
|
||||
</x-filament::section>
|
||||
@ -82,6 +82,18 @@ class="rounded-xl border border-gray-200 bg-white px-4 py-3 text-left transition
|
||||
@endif
|
||||
|
||||
<div class="space-y-6">
|
||||
<div class="flex flex-wrap gap-2 text-xs text-gray-600 dark:text-gray-300">
|
||||
<span class="inline-flex items-center rounded-full border border-danger-200 bg-danger-50 px-3 py-1 font-medium text-danger-700 dark:border-danger-700/50 dark:bg-danger-950/30 dark:text-danger-200">
|
||||
Governance risk counts affected tenants
|
||||
</span>
|
||||
<span class="inline-flex items-center rounded-full border border-warning-200 bg-warning-50 px-3 py-1 font-medium text-warning-700 dark:border-warning-700/50 dark:bg-warning-950/30 dark:text-warning-200">
|
||||
Activity counts execution load only
|
||||
</span>
|
||||
<span class="inline-flex items-center rounded-full border border-gray-200 bg-white px-3 py-1 font-medium text-gray-600 dark:border-white/10 dark:bg-white/5 dark:text-gray-300">
|
||||
Recent operations stay diagnostic
|
||||
</span>
|
||||
</div>
|
||||
|
||||
@livewire(\App\Filament\Widgets\Workspace\WorkspaceSummaryStats::class, [
|
||||
'metrics' => $overview['summary_metrics'] ?? [],
|
||||
], key('workspace-overview-summary-' . ($workspace['id'] ?? 'none')))
|
||||
|
||||
@ -27,12 +27,12 @@
|
||||
|
||||
<x-filament::section
|
||||
heading="Verification report"
|
||||
description="Latest verification state for this tenant (DB-only rendering)."
|
||||
description="Latest stored verification result for this tenant. Consent and connection configuration are summarized separately above."
|
||||
>
|
||||
<div class="space-y-4">
|
||||
@if ($run === null)
|
||||
<div class="rounded-lg border border-gray-200 bg-white p-4 text-sm text-gray-600 shadow-sm dark:border-gray-800 dark:bg-gray-900 dark:text-gray-300">
|
||||
No verification operation has been started yet.
|
||||
No provider verification check has been recorded yet.
|
||||
</div>
|
||||
|
||||
<div class="flex items-center gap-2">
|
||||
|
||||
@ -22,25 +22,66 @@
|
||||
@else
|
||||
<div class="space-y-3">
|
||||
@foreach ($items as $item)
|
||||
<a
|
||||
href="{{ $item['url'] }}"
|
||||
class="block rounded-xl border border-gray-200 bg-gray-50 p-4 transition hover:border-gray-300 hover:bg-white dark:border-white/10 dark:bg-white/5 dark:hover:border-white/20 dark:hover:bg-white/10"
|
||||
>
|
||||
<div class="flex items-start justify-between gap-3">
|
||||
<div class="space-y-1">
|
||||
<div class="text-sm font-semibold text-gray-950 dark:text-white">
|
||||
{{ $item['title'] }}
|
||||
</div>
|
||||
<div class="text-sm leading-6 text-gray-600 dark:text-gray-300">
|
||||
{{ $item['body'] }}
|
||||
@php
|
||||
$destination = $item['destination'] ?? null;
|
||||
$actionUrl = is_array($destination) && ($destination['disabled'] ?? false) === false
|
||||
? ($destination['url'] ?? null)
|
||||
: null;
|
||||
@endphp
|
||||
|
||||
<div class="rounded-xl border border-gray-200 bg-gray-50 p-4 dark:border-white/10 dark:bg-white/5">
|
||||
<div class="space-y-3">
|
||||
<div class="flex flex-wrap items-start justify-between gap-3">
|
||||
<div class="space-y-2">
|
||||
<div class="flex flex-wrap items-center gap-2">
|
||||
<span class="inline-flex items-center rounded-full border border-gray-200 bg-white px-2.5 py-0.5 text-xs font-medium text-gray-700 dark:border-white/10 dark:bg-white/10 dark:text-gray-200">
|
||||
{{ $item['tenant_label'] }}
|
||||
</span>
|
||||
|
||||
<span class="inline-flex items-center rounded-full border border-gray-200 bg-white px-2.5 py-0.5 text-xs font-medium uppercase tracking-wide text-gray-500 dark:border-white/10 dark:bg-white/10 dark:text-gray-300">
|
||||
{{ str_replace('_', ' ', $item['urgency']) }}
|
||||
</span>
|
||||
|
||||
<x-filament::badge :color="$item['badge_color']" size="sm">
|
||||
{{ $item['badge'] }}
|
||||
</x-filament::badge>
|
||||
</div>
|
||||
|
||||
<div class="text-sm font-semibold text-gray-950 dark:text-white">
|
||||
{{ $item['title'] }}
|
||||
</div>
|
||||
|
||||
<div class="text-sm leading-6 text-gray-600 dark:text-gray-300">
|
||||
{{ $item['body'] }}
|
||||
</div>
|
||||
|
||||
@if (filled($item['supporting_message'] ?? null))
|
||||
<p class="text-xs leading-5 text-gray-500 dark:text-gray-400">
|
||||
{{ $item['supporting_message'] }}
|
||||
</p>
|
||||
@endif
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<x-filament::badge :color="$item['badge_color']" size="sm">
|
||||
{{ $item['badge'] }}
|
||||
</x-filament::badge>
|
||||
<div class="flex flex-wrap items-center gap-3 text-sm">
|
||||
@if (is_string($actionUrl) && $actionUrl !== '')
|
||||
<x-filament::link :href="$actionUrl" size="sm">
|
||||
{{ $destination['label'] ?? 'Open' }}
|
||||
</x-filament::link>
|
||||
@else
|
||||
<span class="text-gray-500 dark:text-gray-400">
|
||||
{{ $destination['label'] ?? 'Unavailable' }}
|
||||
</span>
|
||||
@endif
|
||||
|
||||
@if (filled($item['helper_text'] ?? null))
|
||||
<span class="text-xs text-gray-500 dark:text-gray-400">
|
||||
{{ $item['helper_text'] }}
|
||||
</span>
|
||||
@endif
|
||||
</div>
|
||||
</div>
|
||||
</a>
|
||||
</div>
|
||||
@endforeach
|
||||
</div>
|
||||
@endif
|
||||
|
||||
@ -1,4 +1,8 @@
|
||||
<x-filament::section heading="Recent operations">
|
||||
<p class="mb-4 text-xs leading-5 text-gray-500 dark:text-gray-400">
|
||||
Diagnostic recency across your visible workspace slice. This does not define governance health on its own.
|
||||
</p>
|
||||
|
||||
@if ($operations === [])
|
||||
<div class="flex h-full flex-col justify-between gap-4">
|
||||
<div class="space-y-2">
|
||||
@ -22,45 +26,57 @@
|
||||
@else
|
||||
<div class="space-y-3">
|
||||
@foreach ($operations as $operation)
|
||||
<a
|
||||
href="{{ $operation['url'] }}"
|
||||
class="block rounded-xl border border-gray-200 bg-gray-50 p-4 transition hover:border-gray-300 hover:bg-white dark:border-white/10 dark:bg-white/5 dark:hover:border-white/20 dark:hover:bg-white/10"
|
||||
>
|
||||
<div class="flex items-start justify-between gap-3">
|
||||
<div class="min-w-0 space-y-2">
|
||||
<div class="flex flex-wrap items-center gap-2">
|
||||
<div class="text-sm font-semibold text-gray-950 dark:text-white">
|
||||
{{ $operation['title'] }}
|
||||
@php
|
||||
$destination = $operation['destination'] ?? null;
|
||||
$actionUrl = is_array($destination) ? ($destination['url'] ?? null) : ($operation['url'] ?? null);
|
||||
@endphp
|
||||
|
||||
<div class="rounded-xl border border-gray-200 bg-gray-50 p-4 dark:border-white/10 dark:bg-white/5">
|
||||
<div class="space-y-3">
|
||||
<div class="flex items-start justify-between gap-3">
|
||||
<div class="min-w-0 space-y-2">
|
||||
<div class="flex flex-wrap items-center gap-2">
|
||||
<div class="text-sm font-semibold text-gray-950 dark:text-white">
|
||||
{{ $operation['title'] }}
|
||||
</div>
|
||||
|
||||
@if (filled($operation['tenant_label'] ?? null))
|
||||
<span class="inline-flex items-center rounded-full border border-gray-200 bg-white px-2 py-0.5 text-xs font-medium text-gray-600 dark:border-white/10 dark:bg-white/10 dark:text-gray-300">
|
||||
{{ $operation['tenant_label'] }}
|
||||
</span>
|
||||
@endif
|
||||
</div>
|
||||
|
||||
@if (filled($operation['tenant_label'] ?? null))
|
||||
<span class="inline-flex items-center rounded-full border border-gray-200 bg-white px-2 py-0.5 text-xs font-medium text-gray-600 dark:border-white/10 dark:bg-white/10 dark:text-gray-300">
|
||||
{{ $operation['tenant_label'] }}
|
||||
</span>
|
||||
<div class="flex flex-wrap items-center gap-2">
|
||||
<x-filament::badge :color="$operation['status_color']" size="sm">
|
||||
{{ $operation['status_label'] }}
|
||||
</x-filament::badge>
|
||||
<x-filament::badge :color="$operation['outcome_color']" size="sm">
|
||||
{{ $operation['outcome_label'] }}
|
||||
</x-filament::badge>
|
||||
</div>
|
||||
|
||||
@if (filled($operation['guidance'] ?? null))
|
||||
<p class="text-xs leading-5 text-gray-600 dark:text-gray-300">
|
||||
{{ $operation['guidance'] }}
|
||||
</p>
|
||||
@endif
|
||||
</div>
|
||||
|
||||
<div class="flex flex-wrap items-center gap-2">
|
||||
<x-filament::badge :color="$operation['status_color']" size="sm">
|
||||
{{ $operation['status_label'] }}
|
||||
</x-filament::badge>
|
||||
<x-filament::badge :color="$operation['outcome_color']" size="sm">
|
||||
{{ $operation['outcome_label'] }}
|
||||
</x-filament::badge>
|
||||
<div class="shrink-0 text-xs text-gray-500 dark:text-gray-400">
|
||||
{{ $operation['started_at'] }}
|
||||
</div>
|
||||
|
||||
@if (filled($operation['guidance'] ?? null))
|
||||
<p class="text-xs leading-5 text-gray-600 dark:text-gray-300">
|
||||
{{ $operation['guidance'] }}
|
||||
</p>
|
||||
@endif
|
||||
</div>
|
||||
|
||||
<div class="shrink-0 text-xs text-gray-500 dark:text-gray-400">
|
||||
{{ $operation['started_at'] }}
|
||||
</div>
|
||||
@if (is_string($actionUrl) && $actionUrl !== '')
|
||||
<div>
|
||||
<x-filament::link :href="$actionUrl" size="sm">
|
||||
{{ $destination['label'] ?? 'Open operation' }}
|
||||
</x-filament::link>
|
||||
</div>
|
||||
@endif
|
||||
</div>
|
||||
</a>
|
||||
</div>
|
||||
@endforeach
|
||||
</div>
|
||||
@endif
|
||||
|
||||
@ -0,0 +1,35 @@
|
||||
# Specification Quality Checklist: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Purpose**: Validate specification completeness and quality before proceeding to planning
|
||||
**Created**: 2026-04-04
|
||||
**Feature**: [spec.md](../spec.md)
|
||||
|
||||
## Content Quality
|
||||
|
||||
- [x] No implementation details (languages, frameworks, APIs)
|
||||
- [x] Focused on user value and business needs
|
||||
- [x] Written for non-technical stakeholders
|
||||
- [x] All mandatory sections completed
|
||||
|
||||
## Requirement Completeness
|
||||
|
||||
- [x] No [NEEDS CLARIFICATION] markers remain
|
||||
- [x] Requirements are testable and unambiguous
|
||||
- [x] Success criteria are measurable
|
||||
- [x] Success criteria are technology-agnostic (no implementation details)
|
||||
- [x] All acceptance scenarios are defined
|
||||
- [x] Edge cases are identified
|
||||
- [x] Scope is clearly bounded
|
||||
- [x] Dependencies and assumptions identified
|
||||
|
||||
## Feature Readiness
|
||||
|
||||
- [x] All functional requirements have clear acceptance criteria
|
||||
- [x] User scenarios cover primary flows
|
||||
- [x] Feature meets measurable outcomes defined in Success Criteria
|
||||
- [x] No implementation details leak into specification
|
||||
|
||||
## Notes
|
||||
|
||||
- Required repo contract references such as routes, capabilities, and affected operator surfaces are included because this repository's spec format requires them; the requirements and outcomes themselves remain user-facing and do not prescribe code structure.
|
||||
- No clarification markers remain. The feature is ready for `/speckit.plan`.
|
||||
@ -0,0 +1,396 @@
|
||||
openapi: 3.1.0
|
||||
info:
|
||||
title: Evidence Review Trust Surfaces Contract
|
||||
version: 1.0.0
|
||||
description: >-
|
||||
Internal reference contract for the rendered HTML surfaces affected by Spec 174.
|
||||
These routes continue to return HTML through Filament and Livewire. The vendor
|
||||
media types below document the structured truth payloads that must be derivable
|
||||
before rendering. This is not a public API commitment.
|
||||
paths:
|
||||
/admin/evidence/overview:
|
||||
get:
|
||||
summary: Canonical evidence overview
|
||||
description: >-
|
||||
Returns the rendered evidence overview for entitled tenants in the current workspace.
|
||||
The vendor media type documents the derived row contract used to communicate
|
||||
artifact truth, freshness, and next steps.
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered evidence overview page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.evidence-overview+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/EvidenceOverviewPage'
|
||||
'404':
|
||||
description: Workspace context is missing or the viewer is not entitled to the relevant scope
|
||||
/admin/reviews:
|
||||
get:
|
||||
summary: Canonical review register
|
||||
description: >-
|
||||
Returns the rendered review register for entitled tenants in the current workspace.
|
||||
The vendor media type documents the row-level trust and publication contract.
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered review register page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.review-register+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ReviewRegisterPage'
|
||||
'404':
|
||||
description: Workspace context is missing or the viewer is not entitled to the relevant scope
|
||||
/admin/t/{tenant}/evidence/{snapshot}:
|
||||
get:
|
||||
summary: Tenant-scoped evidence snapshot detail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: snapshot
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: integer
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered evidence snapshot detail page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.evidence-snapshot-detail+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/EvidenceSnapshotDetailPage'
|
||||
'403':
|
||||
description: Viewer is in tenant scope but lacks the required manage capability for actions
|
||||
'404':
|
||||
description: Snapshot is not visible because it does not exist or tenant entitlement is missing
|
||||
/admin/t/{tenant}/reviews/{review}:
|
||||
get:
|
||||
summary: Tenant-scoped review detail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: review
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: integer
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered tenant review detail page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.tenant-review-detail+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/TenantReviewDetailPage'
|
||||
'403':
|
||||
description: Viewer is in tenant scope but lacks the required manage capability for actions
|
||||
'404':
|
||||
description: Review is not visible because it does not exist or tenant entitlement is missing
|
||||
/admin/t/{tenant}/review-packs/{pack}:
|
||||
get:
|
||||
summary: Tenant-scoped review pack detail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: pack
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: integer
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered review pack detail page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.review-pack-detail+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ReviewPackDetailPage'
|
||||
'403':
|
||||
description: Viewer is in tenant scope but lacks the required manage capability for actions
|
||||
'404':
|
||||
description: Review pack is not visible because it does not exist or tenant entitlement is missing
|
||||
components:
|
||||
schemas:
|
||||
ArtifactTruthSummary:
|
||||
type: object
|
||||
required:
|
||||
- primaryLabel
|
||||
- contentState
|
||||
- freshnessState
|
||||
- actionability
|
||||
properties:
|
||||
primaryLabel:
|
||||
type: string
|
||||
primaryExplanation:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
contentState:
|
||||
type: string
|
||||
freshnessState:
|
||||
type: string
|
||||
enum:
|
||||
- current
|
||||
- stale
|
||||
- unknown
|
||||
publicationReadiness:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
enum:
|
||||
- publishable
|
||||
- internal_only
|
||||
- blocked
|
||||
actionability:
|
||||
type: string
|
||||
enum:
|
||||
- none
|
||||
- optional
|
||||
- required
|
||||
nextActionLabel:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
nextActionUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
diagnosticLabel:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
Badge:
|
||||
type: object
|
||||
required:
|
||||
- label
|
||||
properties:
|
||||
label:
|
||||
type: string
|
||||
color:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
icon:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
EvidenceOverviewRow:
|
||||
type: object
|
||||
required:
|
||||
- tenantName
|
||||
- tenantId
|
||||
- snapshotId
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
- freshness
|
||||
- nextStep
|
||||
properties:
|
||||
tenantName:
|
||||
type: string
|
||||
tenantId:
|
||||
type: integer
|
||||
snapshotId:
|
||||
type: integer
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
missingDimensions:
|
||||
type: integer
|
||||
staleDimensions:
|
||||
type: integer
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
freshness:
|
||||
$ref: '#/components/schemas/Badge'
|
||||
nextStep:
|
||||
type: string
|
||||
viewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
ReviewRegisterRow:
|
||||
type: object
|
||||
required:
|
||||
- tenantName
|
||||
- tenantId
|
||||
- reviewId
|
||||
- status
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
- publication
|
||||
- nextStep
|
||||
properties:
|
||||
tenantName:
|
||||
type: string
|
||||
tenantId:
|
||||
type: integer
|
||||
reviewId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
publishedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
publication:
|
||||
$ref: '#/components/schemas/Badge'
|
||||
nextStep:
|
||||
type: string
|
||||
viewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
EvidenceOverviewPage:
|
||||
type: object
|
||||
required:
|
||||
- rows
|
||||
properties:
|
||||
rows:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/EvidenceOverviewRow'
|
||||
ReviewRegisterPage:
|
||||
type: object
|
||||
required:
|
||||
- rows
|
||||
properties:
|
||||
rows:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/ReviewRegisterRow'
|
||||
EvidenceSnapshotDetailPage:
|
||||
type: object
|
||||
required:
|
||||
- recordId
|
||||
- tenantId
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
properties:
|
||||
recordId:
|
||||
type: integer
|
||||
tenantId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
linkedReviewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
linkedRunUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
TenantReviewDetailPage:
|
||||
type: object
|
||||
required:
|
||||
- recordId
|
||||
- tenantId
|
||||
- status
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
properties:
|
||||
recordId:
|
||||
type: integer
|
||||
tenantId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
publishedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
linkedEvidenceUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
linkedPackUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
ReviewPackDetailPage:
|
||||
type: object
|
||||
required:
|
||||
- recordId
|
||||
- tenantId
|
||||
- status
|
||||
- artifactTruth
|
||||
properties:
|
||||
recordId:
|
||||
type: integer
|
||||
tenantId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
expiresAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
linkedReviewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
linkedEvidenceUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
268
specs/174-evidence-freshness-publication-trust/data-model.md
Normal file
268
specs/174-evidence-freshness-publication-trust/data-model.md
Normal file
@ -0,0 +1,268 @@
|
||||
# Data Model: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
## Overview
|
||||
|
||||
This feature does not add or modify persisted domain entities. It strengthens the derived trust-propagation model that transforms existing evidence, review, and pack records into operator-facing truth across tenant-scoped detail pages and canonical summary pages.
|
||||
|
||||
The key design constraint is that freshness and publication trust remain derived from existing fields and relationships:
|
||||
|
||||
- evidence-source freshness signals
|
||||
- evidence snapshot completeness and summary state
|
||||
- tenant review completeness and publish blockers
|
||||
- review pack linkage back to a source review and source evidence snapshot
|
||||
- the existing `ArtifactTruthEnvelope` dimensions
|
||||
|
||||
## Existing Persistent Entities
|
||||
|
||||
### 1. EvidenceSnapshot
|
||||
|
||||
- Purpose: Immutable tenant-scoped evidence basis assembled from multiple evidence dimensions.
|
||||
- Key persisted fields used by this feature:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `status`
|
||||
- `completeness_state`
|
||||
- `summary`
|
||||
- `generated_at`
|
||||
- `expires_at`
|
||||
- `operation_run_id`
|
||||
- `fingerprint`
|
||||
- Key summary fields used by this feature:
|
||||
- `dimension_count`
|
||||
- `missing_dimensions`
|
||||
- `stale_dimensions`
|
||||
- `dimensions[]`
|
||||
- `finding_count`
|
||||
- `report_count`
|
||||
- `operation_count`
|
||||
- Relationships used by this feature:
|
||||
- `items`
|
||||
- `tenantReviews`
|
||||
- `reviewPacks`
|
||||
- `operationRun`
|
||||
- `tenant`
|
||||
|
||||
### 2. EvidenceSnapshotItem
|
||||
|
||||
- Purpose: Dimension-level evidence record inside one snapshot.
|
||||
- Key persisted fields used by this feature:
|
||||
- `evidence_snapshot_id`
|
||||
- `tenant_id`
|
||||
- `dimension_key`
|
||||
- `state`
|
||||
- `required`
|
||||
- `measured_at`
|
||||
- `freshness_at`
|
||||
- `source_kind`
|
||||
- `source_record_type`
|
||||
- `source_record_id`
|
||||
- `summary_payload`
|
||||
- `sort_order`
|
||||
- Relationships used by this feature:
|
||||
- `snapshot`
|
||||
- `tenant`
|
||||
|
||||
### 3. TenantReview
|
||||
|
||||
- Purpose: Tenant-scoped review artifact anchored to one evidence snapshot.
|
||||
- Key persisted fields used by this feature:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `evidence_snapshot_id`
|
||||
- `status`
|
||||
- `completeness_state`
|
||||
- `summary`
|
||||
- `generated_at`
|
||||
- `published_at`
|
||||
- `archived_at`
|
||||
- `current_export_review_pack_id`
|
||||
- `operation_run_id`
|
||||
- `fingerprint`
|
||||
- Key summary fields used by this feature:
|
||||
- `publish_blockers[]`
|
||||
- `section_state_counts.complete`
|
||||
- `section_state_counts.partial`
|
||||
- `section_state_counts.missing`
|
||||
- `section_state_counts.stale`
|
||||
- `section_count`
|
||||
- `finding_count`
|
||||
- `report_count`
|
||||
- `operation_count`
|
||||
- Relationships used by this feature:
|
||||
- `evidenceSnapshot`
|
||||
- `sections`
|
||||
- `currentExportReviewPack`
|
||||
- `reviewPacks`
|
||||
- `operationRun`
|
||||
- `tenant`
|
||||
|
||||
### 4. ReviewPack
|
||||
|
||||
- Purpose: Tenant-scoped export artifact derived from a review and evidence basis.
|
||||
- Key persisted fields used by this feature:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `tenant_review_id`
|
||||
- `evidence_snapshot_id`
|
||||
- `status`
|
||||
- `summary`
|
||||
- `generated_at`
|
||||
- `expires_at`
|
||||
- `file_disk`
|
||||
- `file_path`
|
||||
- `file_size`
|
||||
- `operation_run_id`
|
||||
- `fingerprint`
|
||||
- Key summary fields used by this feature:
|
||||
- `review_status`
|
||||
- `review_completeness_state`
|
||||
- `evidence_resolution.outcome`
|
||||
- `evidence_resolution.snapshot_id`
|
||||
- `evidence_resolution.snapshot_fingerprint`
|
||||
- `evidence_resolution.completeness_state`
|
||||
- `finding_count`
|
||||
- `report_count`
|
||||
- `operation_count`
|
||||
- Relationships used by this feature:
|
||||
- `tenantReview`
|
||||
- `evidenceSnapshot`
|
||||
- `operationRun`
|
||||
- `tenant`
|
||||
|
||||
## Existing Derived State Chain
|
||||
|
||||
### A. Evidence Freshness Derivation
|
||||
|
||||
Evidence freshness is already determined in the evidence domain before any UI surface is rendered.
|
||||
|
||||
1. Each evidence source provider returns a dimension payload with:
|
||||
- `state`
|
||||
- `required`
|
||||
- `measured_at`
|
||||
- `freshness_at`
|
||||
2. `EvidenceCompletenessEvaluator` rolls required dimension states into snapshot completeness:
|
||||
- `missing` wins first
|
||||
- then `stale`
|
||||
- then `partial`
|
||||
- otherwise `complete`
|
||||
3. `EvidenceSnapshotService` persists:
|
||||
- `completeness_state`
|
||||
- `summary.missing_dimensions`
|
||||
- `summary.stale_dimensions`
|
||||
- per-dimension summary state
|
||||
|
||||
This feature must reuse that chain instead of replacing it.
|
||||
|
||||
### B. Review Readiness Derivation
|
||||
|
||||
Tenant review readiness is already derived from section completeness and blockers.
|
||||
|
||||
1. `TenantReviewSectionFactory` and related composition logic produce section completeness states.
|
||||
2. `TenantReviewReadinessGate` derives:
|
||||
- `blockersForSections()`
|
||||
- `completenessForSections()`
|
||||
- `statusForSections()`
|
||||
3. `TenantReview.summary` persists:
|
||||
- `publish_blockers[]`
|
||||
- `section_state_counts.*`
|
||||
|
||||
This feature must reuse those publish blockers and section-state counts rather than adding a parallel publish-readiness source.
|
||||
|
||||
## Derived View Models
|
||||
|
||||
### 1. ArtifactTruthPropagationModel
|
||||
|
||||
This is the conceptual chain, not a new class.
|
||||
|
||||
| Stage | Inputs | Derived outputs |
|
||||
|---|---|---|
|
||||
| Evidence source item | source-specific timestamps and source-record state | per-dimension `state`, `freshness_at`, `required` |
|
||||
| Evidence snapshot | item states, snapshot status, summary counts | `artifactExistence`, `contentState`, `freshnessState`, `actionability` |
|
||||
| Tenant review | review status, review completeness, section-state counts, publish blockers, linked snapshot | `artifactExistence`, `contentState`, `freshnessState`, `publicationReadiness`, `actionability` |
|
||||
| Review pack | pack status, evidence resolution, linked review trust burden, linked snapshot burden | `artifactExistence`, `contentState`, `freshnessState`, `publicationReadiness`, `actionability` |
|
||||
| Canonical summary row | tenant label, record timestamps, derived artifact truth envelope | row-level artifact truth, publication signal, freshness signal, next step |
|
||||
|
||||
### 2. SnapshotTruthModel
|
||||
|
||||
Derived from `EvidenceSnapshot` plus `ArtifactTruthPresenter::buildEvidenceSnapshotEnvelope()`.
|
||||
|
||||
| Field | Meaning | Source |
|
||||
|---|---|---|
|
||||
| `artifactExistence` | whether a current or historical snapshot exists | snapshot `status` |
|
||||
| `contentState` | whether the evidence basis is trusted, partial, missing, or empty | snapshot `completeness_state`, `summary.dimension_count` |
|
||||
| `freshnessState` | whether the evidence basis is current or stale | snapshot `completeness_state`, `summary.stale_dimensions`, historical status |
|
||||
| `actionability` | whether the operator must act, may optionally act, or can do nothing | derived from freshness and completeness |
|
||||
| `nextStepText` | operator-facing refresh or wait guidance | existing presenter logic |
|
||||
|
||||
### 3. ReviewTruthModel
|
||||
|
||||
Derived from `TenantReview` plus `ArtifactTruthPresenter::buildTenantReviewEnvelope()`.
|
||||
|
||||
| Field | Meaning | Source |
|
||||
|---|---|---|
|
||||
| `artifactExistence` | whether the review is current, failed, or historical | review status |
|
||||
| `contentState` | whether the review body is complete enough or partial | review completeness |
|
||||
| `freshnessState` | whether the review evidence basis is stale | review completeness and `summary.section_state_counts.stale` |
|
||||
| `publicationReadiness` | whether the review is blocked, internal-only, or publishable | review status, publish blockers, and this feature's stricter freshness/partiality propagation |
|
||||
| `actionability` | whether the operator must resolve blockers, should refresh, or can leave the review alone | derived from publication and freshness burden |
|
||||
| `nextStepText` | resolve blockers, complete work, refresh evidence, or no action needed | existing presenter logic tightened by this feature |
|
||||
|
||||
### 4. PackTruthModel
|
||||
|
||||
Derived from `ReviewPack` plus `ArtifactTruthPresenter::buildReviewPackEnvelope()`.
|
||||
|
||||
| Field | Meaning | Source |
|
||||
|---|---|---|
|
||||
| `artifactExistence` | whether a current, failed, or historical pack exists | pack status |
|
||||
| `contentState` | whether the pack has a trustworthy source basis | evidence resolution and source review burden |
|
||||
| `freshnessState` | whether the pack should be treated as current or stale for operator trust | pack expiration plus propagated source review/evidence staleness |
|
||||
| `publicationReadiness` | whether the pack is blocked, internal-only, or publishable | pack status plus propagated review and evidence burden |
|
||||
| `actionability` | whether the operator must revisit the review or simply note caution | derived from the trust posture |
|
||||
| `nextStepText` | open source review, refresh evidence, or no action needed | existing presenter logic tightened by this feature |
|
||||
|
||||
### 5. CanonicalSummaryRowModel
|
||||
|
||||
Used conceptually by both `EvidenceOverview` and `ReviewRegister`.
|
||||
|
||||
| Field | Type | Purpose |
|
||||
|---|---|---|
|
||||
| `tenantName` | string | Maintain tenant context in canonical pages |
|
||||
| `recordId` | int | Link the summary row back to the tenant-scoped detail page |
|
||||
| `artifactTruth` | label + badge spec + explanation | Primary trust summary shown in the row |
|
||||
| `freshness` | badge spec | Evidence overview freshness summary |
|
||||
| `publication` | badge spec | Review register publication summary |
|
||||
| `nextStep` | string | Operator-facing follow-up guidance that matches detail surfaces |
|
||||
| `viewUrl` | string | Drill-through to the tenant-scoped detail page |
|
||||
|
||||
Rules:
|
||||
|
||||
- Canonical rows must never appear calmer than the corresponding detail pages.
|
||||
- `nextStep` may be shorter than detail guidance, but not contradictory.
|
||||
- Canonical rows must stay derived from the same truth envelope rather than page-local heuristics.
|
||||
|
||||
## Validation Rules
|
||||
|
||||
- A snapshot can be structurally complete and still stale; the derived truth must preserve that distinction.
|
||||
- A review can be internally useful while not being publishable; the derived truth must preserve that distinction.
|
||||
- A pack must not be calmer than its source review or source evidence basis.
|
||||
- Canonical overview and register rows must not contradict the tenant-scoped detail view for the same artifact.
|
||||
- Freshness, completeness, and publication readiness remain separate dimensions even when they jointly influence the primary label.
|
||||
|
||||
## State Notes
|
||||
|
||||
This feature introduces no new persisted state.
|
||||
|
||||
Existing state and badge families that remain canonical:
|
||||
|
||||
- `EvidenceCompletenessState`
|
||||
- `EvidenceSnapshotStatus`
|
||||
- `TenantReviewCompletenessState`
|
||||
- `TenantReviewStatus`
|
||||
- `ReviewPackStatus`
|
||||
- `BadgeDomain::GovernanceArtifactFreshness`
|
||||
- `BadgeDomain::GovernanceArtifactPublicationReadiness`
|
||||
|
||||
The feature only changes how these existing states combine into operator-facing trust across multiple related surfaces.
|
||||
294
specs/174-evidence-freshness-publication-trust/plan.md
Normal file
294
specs/174-evidence-freshness-publication-trust/plan.md
Normal file
@ -0,0 +1,294 @@
|
||||
# Implementation Plan: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Branch**: `174-evidence-freshness-publication-trust` | **Date**: 2026-04-04 | **Spec**: `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/spec.md`
|
||||
**Input**: Feature specification from `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/spec.md`
|
||||
|
||||
## Summary
|
||||
|
||||
Harden evidence freshness and publication trust across the existing evidence snapshot, tenant review, review pack, evidence overview, and canonical review register surfaces without adding new persistence, a new trust layer, or a new reporting subsystem. The implementation will reuse the source-derived stale semantics and their existing source-defined freshness thresholds, tighten propagation in `ArtifactTruthPresenter`, keep review readiness and publication readiness distinct, preserve the current tenant and canonical routes and action inventory, and close the existing cross-surface gap where stale or partial evidence can still look publishable.
|
||||
|
||||
Key approach: keep the work inside the current `EvidenceSnapshotService` freshness semantics, `TenantReviewReadinessGate`, `ArtifactTruthPresenter`, tenant-scoped Filament resources, and canonical summary pages. The slice is primarily about better derivation and consistent display, not about new models or new workflows.
|
||||
|
||||
## Technical Context
|
||||
|
||||
**Language/Version**: PHP 8.4, Laravel 12, Filament v5, Livewire v4, Blade
|
||||
**Primary Dependencies**: Filament v5, Livewire v4, Pest v4, Laravel Sail, existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, `TenantReviewReadinessGate`, `EvidenceSnapshotService`, `TenantReviewRegisterService`, and current evidence/review/review-pack resources and pages
|
||||
**Storage**: PostgreSQL with existing `evidence_snapshots`, `evidence_snapshot_items`, `tenant_reviews`, and `review_packs` tables using current summary JSON and timestamps; no schema change planned
|
||||
**Testing**: Pest feature tests and Livewire page tests run via Sail, plus existing governance-artifact fixture helpers
|
||||
**Target Platform**: Laravel web application in Sail locally and containerized Linux deployment in staging and production
|
||||
**Project Type**: Laravel monolith web application
|
||||
**Performance Goals**: Preserve DB-only render behavior on detail and canonical surfaces, avoid any render-time external calls, keep list-row truth derivation lightweight enough for canonical table scans, and keep operator trust signals readable within a 5-10 second scan on summary surfaces
|
||||
**Constraints**: No new tables, no new enum families, no new presenter or resolver subsystem, no route changes, no RBAC drift, no destructive-action placement drift, no global asset changes, and no new global freshness engine if existing source-derived stale semantics are sufficient
|
||||
**Scale/Scope**: Five operator-facing surfaces (`/admin/evidence/overview`, `/admin/reviews`, `/admin/t/{tenant}/evidence/{snapshot}`, `/admin/t/{tenant}/reviews/{review}`, `/admin/t/{tenant}/review-packs/{pack}`), one central truth presenter, existing readiness helpers, and focused regression coverage across fresh, stale, partial, blocked, internal-only, and publishable scenarios
|
||||
|
||||
## Constitution Check
|
||||
|
||||
*GATE: Passed before Phase 0 research. Re-checked after Phase 1 design and still passing.*
|
||||
|
||||
| Principle | Status | Notes |
|
||||
|-----------|--------|-------|
|
||||
| Inventory-first | Pass | Evidence freshness remains derived from the existing snapshot-item and source-evaluation chain; no new snapshot ownership semantics |
|
||||
| Read/write separation | Pass | This slice primarily changes truth derivation and display; existing mutate actions remain unchanged |
|
||||
| Graph contract path | Pass | No new Graph calls or contract-registry changes are introduced |
|
||||
| Deterministic capabilities | Pass | No new capability derivation or role mapping is added |
|
||||
| RBAC-UX planes and 404 vs 403 | Pass | Tenant-scoped resources remain tenant-scoped; canonical `/admin` pages stay workspace- and tenant-entitlement-safe |
|
||||
| Workspace isolation | Pass | Canonical summary pages continue to derive rows only from entitled tenants in the current workspace |
|
||||
| Tenant isolation | Pass | Drill-through links remain tenant-scoped and non-entitled users remain deny-as-not-found |
|
||||
| Destructive confirmation | Pass | Existing destructive actions (`Expire snapshot`, `Archive review`, `Expire pack`) already require confirmation and remain unchanged |
|
||||
| Global search safety | Pass | No global-search behavior is added or broadened; `EvidenceSnapshotResource`, `TenantReviewResource`, and `ReviewPackResource` already have view pages |
|
||||
| Run observability | Pass | Existing evidence, review, and pack generation flows keep their current `OperationRun` types and ownership; no new run type is introduced |
|
||||
| Ops-UX 3-surface feedback | Pass | No toast, progress, or terminal-notification behavior changes |
|
||||
| Ops-UX lifecycle ownership | Pass | No `OperationRun.status` or `outcome` transition logic is touched |
|
||||
| Ops-UX summary counts | Pass | No changes to `summary_counts` contracts are required |
|
||||
| Ops-UX guards | Pass | Existing operation lifecycle guards stay in place; this feature adds truth-surface regression tests instead |
|
||||
| Data minimization | Pass | No new payload exposure or raw-report surface is introduced |
|
||||
| Proportionality (PROP-001) | Pass | The implementation stays inside existing freshness, readiness, and truth layers rather than adding persistence or abstraction |
|
||||
| No premature abstraction (ABSTR-001) | Pass | No new resolver, gate, presenter family, registry, or taxonomy is planned |
|
||||
| Persisted truth (PERSIST-001) | Pass | All new semantics remain derived from existing timestamps, summary state, and linked records |
|
||||
| Behavioral state (STATE-001) | Pass | No new persisted states are introduced; existing stale/partial/publishable/internal-only semantics become stricter |
|
||||
| UI semantics (UI-SEM-001) | Pass | Existing badge and truth primitives are reused; no second interpretation framework is introduced |
|
||||
| V1 explicitness / few layers (V1-EXP-001, LAYER-001) | Pass | One central presenter and existing pages remain the implementation seam |
|
||||
| Badge semantics (BADGE-001) | Pass | Existing freshness, completeness, publication-readiness, and artifact-truth badge domains stay canonical |
|
||||
| Filament-native UI (UI-FIL-001) | Pass | Existing Filament resources, pages, badges, tables, and infolists are reused; no page-local status language is added |
|
||||
| UI/UX surface taxonomy (UI-CONST-001 / UI-SURF-001) | Pass | Evidence snapshot, tenant review, and review pack remain `CRUD / List-first Resource` surfaces with dedicated detail pages, while evidence overview and review register remain `Read-only Registry / Report Surface` surfaces |
|
||||
| UI/UX inspect model (UI-HARD-001) | Pass | Clickable-row inspect remains primary on the affected lists; no redundant view action is introduced |
|
||||
| UI/UX action hierarchy (UI-HARD-001 / UI-EX-001) | Pass | Existing one-inline-safe-shortcut patterns remain; no new row-level destructive actions are added |
|
||||
| UI/UX scope, truth, and naming (UI-HARD-001 / UI-NAMING-001 / OPSURF-001) | Pass | The feature strengthens default-visible trust truth while preserving canonical nouns and existing verbs |
|
||||
| List-surface review checklist (UI-STD-001) | Pass | The affected list and report surfaces will be reviewed against `docs/product/standards/list-surface-review-checklist.md` during implementation and final verification |
|
||||
| Filament Action Surface Contract | Pass | Current surface declarations already match the required list/detail behavior; the feature changes truth semantics, not action topology |
|
||||
| Filament UX-001 | Pass | Existing Infolist and table layouts remain; this slice strengthens the truth surfaces inside them |
|
||||
| Filament v5 / Livewire v4 compliance | Pass | The work remains inside the current Filament v5 + Livewire v4 stack |
|
||||
| Provider registration location | Pass | No panel/provider changes; Laravel 11+ provider registration remains in `bootstrap/providers.php` |
|
||||
| Asset strategy | Pass | No new panel or shared assets are required; deployment `filament:assets` behavior remains unchanged |
|
||||
|
||||
## Phase 0 Research
|
||||
|
||||
Research outcomes are captured in `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/research.md`.
|
||||
|
||||
Key decisions:
|
||||
|
||||
- Reuse the existing source-derived stale semantics from evidence providers and `EvidenceCompletenessEvaluator` instead of creating a new global freshness engine.
|
||||
- Tighten `ArtifactTruthPresenter` rather than introducing a new publication-trust resolver or freshness-trust gate.
|
||||
- Degrade tenant review and review pack publication trust when freshness is stale and downgrade partial evidence to `internal_only` unless stronger existing blockers already make the artifact `blocked`.
|
||||
- Make review packs inherit stale and partial burden from their linked review and evidence basis instead of treating pack freshness as `current` whenever the file itself is not expired.
|
||||
- Keep canonical register and overview surfaces aligned by reusing the same truth envelope and next-step language rather than adding page-local taxonomies or ad-hoc columns.
|
||||
- Expand existing Pest coverage and fixture builders rather than creating a new UI test harness.
|
||||
|
||||
## Phase 1 Design
|
||||
|
||||
Design artifacts are created under `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/`:
|
||||
|
||||
- `data-model.md`: derived trust-propagation model for evidence snapshots, tenant reviews, review packs, and canonical summary rows
|
||||
- `contracts/evidence-review-trust-surfaces.openapi.yaml`: internal page-contract schema for the affected rendered HTML surfaces and their structured truth payloads
|
||||
- `quickstart.md`: focused verification workflow for manual and automated validation
|
||||
|
||||
Design decisions:
|
||||
|
||||
- No schema migration is required; freshness remains derived from existing evidence-source timestamps and summary state.
|
||||
- The primary implementation seam is `ArtifactTruthPresenter`, supported by the current evidence and review readiness services and existing page row builders.
|
||||
- `TenantReviewReadinessGate` remains the publish-blocker authority for required stale or missing sections; this feature tightens how that burden is translated into operator-facing trust and publication surfaces.
|
||||
- `EvidenceOverview` and `ReviewRegister` continue to render read-only summary rows, but must no longer sound calmer than the corresponding tenant-scoped detail surfaces.
|
||||
- Existing destructive actions and capabilities remain unchanged; only truth presentation, next-step guidance, and consistency rules are hardened.
|
||||
|
||||
## Project Structure
|
||||
|
||||
### Documentation (this feature)
|
||||
|
||||
```text
|
||||
specs/174-evidence-freshness-publication-trust/
|
||||
├── spec.md
|
||||
├── plan.md
|
||||
├── research.md
|
||||
├── data-model.md
|
||||
├── quickstart.md
|
||||
├── contracts/
|
||||
│ └── evidence-review-trust-surfaces.openapi.yaml
|
||||
├── checklists/
|
||||
│ └── requirements.md
|
||||
└── tasks.md
|
||||
```
|
||||
|
||||
### Source Code (repository root)
|
||||
|
||||
```text
|
||||
app/
|
||||
├── Filament/
|
||||
│ ├── Pages/
|
||||
│ │ ├── Monitoring/
|
||||
│ │ │ └── EvidenceOverview.php
|
||||
│ │ └── Reviews/
|
||||
│ │ └── ReviewRegister.php
|
||||
│ └── Resources/
|
||||
│ ├── EvidenceSnapshotResource.php
|
||||
│ ├── ReviewPackResource.php
|
||||
│ ├── TenantReviewResource.php
|
||||
│ ├── EvidenceSnapshotResource/
|
||||
│ │ └── Pages/
|
||||
│ │ └── ViewEvidenceSnapshot.php
|
||||
│ ├── ReviewPackResource/
|
||||
│ │ └── Pages/
|
||||
│ │ └── ViewReviewPack.php
|
||||
│ └── TenantReviewResource/
|
||||
│ └── Pages/
|
||||
│ └── ViewTenantReview.php
|
||||
├── Models/
|
||||
│ ├── EvidenceSnapshot.php
|
||||
│ ├── EvidenceSnapshotItem.php
|
||||
│ ├── ReviewPack.php
|
||||
│ └── TenantReview.php
|
||||
├── Services/
|
||||
│ ├── Evidence/
|
||||
│ │ ├── EvidenceCompletenessEvaluator.php
|
||||
│ │ ├── EvidenceSnapshotService.php
|
||||
│ │ └── Sources/
|
||||
│ │ ├── BaselineDriftPostureSource.php
|
||||
│ │ ├── EntraAdminRolesSource.php
|
||||
│ │ ├── FindingsSummarySource.php
|
||||
│ │ ├── OperationsSummarySource.php
|
||||
│ │ └── PermissionPostureSource.php
|
||||
│ └── TenantReviews/
|
||||
│ ├── TenantReviewReadinessGate.php
|
||||
│ └── TenantReviewRegisterService.php
|
||||
└── Support/
|
||||
└── Ui/
|
||||
└── GovernanceArtifactTruth/
|
||||
├── ArtifactTruthEnvelope.php
|
||||
└── ArtifactTruthPresenter.php
|
||||
|
||||
resources/
|
||||
└── views/
|
||||
└── filament/
|
||||
├── infolists/
|
||||
│ └── entries/
|
||||
│ └── governance-artifact-truth.blade.php
|
||||
└── pages/
|
||||
├── monitoring/
|
||||
│ └── evidence-overview.blade.php
|
||||
└── reviews/
|
||||
└── review-register.blade.php
|
||||
|
||||
routes/
|
||||
└── web.php
|
||||
|
||||
tests/
|
||||
├── Feature/
|
||||
│ ├── Concerns/
|
||||
│ │ └── BuildsGovernanceArtifactTruthFixtures.php
|
||||
│ ├── Evidence/
|
||||
│ │ ├── EvidenceOverviewPageTest.php
|
||||
│ │ └── EvidenceSnapshotResourceTest.php
|
||||
│ ├── Monitoring/
|
||||
│ │ └── ArtifactTruthRunDetailTest.php
|
||||
│ ├── ReviewPack/
|
||||
│ │ └── ReviewPackResourceTest.php
|
||||
│ └── TenantReview/
|
||||
│ ├── TenantReviewLifecycleTest.php
|
||||
│ └── TenantReviewRegisterTest.php
|
||||
└── Pest.php
|
||||
```
|
||||
|
||||
**Structure Decision**: Standard Laravel monolith. The change is concentrated in one existing truth-presenter seam, current readiness helpers, a small set of existing Filament resources/pages, and focused Pest coverage. No new base directories, services, or presentation frameworks are required.
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### Phase A — Preserve Source-Derived Freshness As The Canonical Input
|
||||
|
||||
**Goal**: Keep existing provider-level stale semantics as the source of truth and document them clearly in the implementation so the feature does not accidentally invent a second freshness system.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| A.1 | `app/Services/Evidence/EvidenceCompletenessEvaluator.php` | Confirm that source-level `stale` evaluation and snapshot completeness remain the canonical freshness input used by the UI truth layer |
|
||||
| A.2 | `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` | Keep evidence-snapshot truth derived from snapshot status, completeness, and `summary.stale_dimensions` rather than introducing new page-local age logic |
|
||||
| A.3 | `specs/174-evidence-freshness-publication-trust/research.md` and `data-model.md` | Record the source-derived freshness chain so implementation does not drift into a new threshold engine |
|
||||
|
||||
### Phase B — Downgrade Tenant Review Publication Trust When Freshness Or Completeness Weakens Confidence
|
||||
|
||||
**Goal**: Ensure tenant reviews can remain useful internally while no longer appearing publishable when their evidence basis is stale or partial.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| B.1 | `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` | Tighten `buildTenantReviewEnvelope()` so stale freshness and partial evidence degrade publication readiness and next-step guidance appropriately |
|
||||
| B.2 | `app/Services/TenantReviews/TenantReviewReadinessGate.php` | Reuse existing required-section stale and missing blocker semantics; do not create a second publish-blocker system |
|
||||
| B.3 | `app/Filament/Resources/TenantReviewResource.php` and `app/Filament/Resources/TenantReviewResource/Pages/ViewTenantReview.php` | Verify the tightened truth envelope is visible on list and detail surfaces without changing action topology or copy vocabulary |
|
||||
|
||||
### Phase C — Propagate Source Review And Evidence Burden Into Review Pack Trust
|
||||
|
||||
**Goal**: Prevent review packs from appearing calmer than the review or evidence basis they were generated from.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| C.1 | `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` | Tighten `buildReviewPackEnvelope()` so pack freshness and publication readiness inherit stale or partial burden from the source review and evidence resolution |
|
||||
| C.2 | `app/Filament/Resources/ReviewPackResource.php` and `app/Filament/Resources/ReviewPackResource/Pages/ViewReviewPack.php` | Ensure pack list/detail surfaces expose internal-only or cautionary trust and next-step caveats before download or sharing |
|
||||
| C.3 | `resources/views/filament/infolists/entries/governance-artifact-truth.blade.php` | Reuse the existing truth partial to surface freshness and publication dimensions with stronger consistency rather than new local markup |
|
||||
|
||||
### Phase D — Align Canonical Overview And Register Rows With Tenant-Scoped Detail Truth
|
||||
|
||||
**Goal**: Ensure `/admin/evidence/overview` and `/admin/reviews` summarize the same truth direction as the tenant-scoped detail pages.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| D.1 | `app/Filament/Pages/Monitoring/EvidenceOverview.php` | Keep row truth and next-step guidance sourced from the same envelope semantics used by snapshot detail |
|
||||
| D.2 | `app/Filament/Pages/Reviews/ReviewRegister.php` | Keep artifact truth, publication readiness, and next-step rows aligned with tenant review detail without adding new ad-hoc row taxonomy |
|
||||
| D.3 | `routes/web.php` and current navigation helpers | Preserve existing canonical route shape and tenant-prefilter continuity; no routing change |
|
||||
|
||||
### Phase E — Regression Protection And Focused Validation
|
||||
|
||||
**Goal**: Add the smallest useful test set that protects stale propagation, partial-evidence trust, review/pack consistency, and canonical summary alignment.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| E.1 | `tests/Feature/Concerns/BuildsGovernanceArtifactTruthFixtures.php` | Add fixture helpers for stale and partial evidence scenarios so tests do not duplicate setup logic |
|
||||
| E.2 | `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php` | Add fresh-vs-stale snapshot truth assertions, including stale-dimension next-step behavior |
|
||||
| E.3 | `tests/Feature/TenantReview/TenantReviewLifecycleTest.php` | Add stale and partial review publication-trust assertions without changing lifecycle behavior |
|
||||
| E.4 | `tests/Feature/ReviewPack/ReviewPackResourceTest.php` | Add pack trust propagation assertions for stale or partial source review/evidence combinations |
|
||||
| E.5 | `tests/Feature/TenantReview/TenantReviewRegisterTest.php` and `tests/Feature/Evidence/EvidenceOverviewPageTest.php` | Add canonical row-alignment assertions so summary pages do not sound calmer than detail |
|
||||
| E.6 | `vendor/bin/sail bin pint --dirty --format agent` and focused Pest runs | Required formatting and targeted verification before task completion |
|
||||
|
||||
## Key Design Decisions
|
||||
|
||||
### D-001 — Source-specific stale evaluation stays canonical
|
||||
|
||||
Evidence sources already produce `stale` item states using their own domain-appropriate recency logic, and `EvidenceCompletenessEvaluator` already rolls those into snapshot completeness. The plan reuses that chain instead of inventing a separate global age-policy system.
|
||||
|
||||
### D-002 — `ArtifactTruthPresenter` remains the single trust-propagation seam
|
||||
|
||||
The current code already centralizes evidence snapshot, tenant review, and review pack trust in one presenter. Tightening that presenter is narrower and safer than introducing a new publication-trust resolver or freshness framework.
|
||||
|
||||
### D-003 — Publication readiness remains distinct from freshness and completeness
|
||||
|
||||
The feature must not collapse all trust dimensions into one vague `ready` state. Freshness, completeness, and publication readiness remain separate dimensions, but stale evidence downgrades share safety and partial evidence downgrades publication readiness to `internal_only` unless existing blockers already make the artifact `blocked`.
|
||||
|
||||
### D-004 — Canonical summary pages must reuse existing truth, not invent row-local semantics
|
||||
|
||||
`EvidenceOverview` and `ReviewRegister` already surface artifact truth, publication, and next-step information. The right fix is to align their inputs with the tightened truth envelope, not to add page-specific badges or prose.
|
||||
|
||||
### D-005 — No new persistence or reporting subsystem is justified
|
||||
|
||||
This is a current-release operator-trust problem, but it is still a derived-truth problem. Existing timestamps, summary state, and linked artifacts are enough to solve it without a StoredReport viewer, new export-governance model, or separate publication-trust entity.
|
||||
|
||||
## Risk Assessment
|
||||
|
||||
| Risk | Impact | Likelihood | Mitigation |
|
||||
|------|--------|------------|------------|
|
||||
| Review publication trust becomes too strict and downgrades healthy reviews | Medium | Medium | Base downgrades on existing stale/partial semantics already produced by evidence and review services rather than a new heuristic |
|
||||
| Review pack truth diverges from review truth because pack code and review code evolve separately | High | Medium | Centralize propagation in `ArtifactTruthPresenter` and add explicit review-vs-pack consistency tests |
|
||||
| Canonical summary pages become denser or harder to scan | Medium | Low | Reuse existing columns and next-step fields instead of adding more row furniture |
|
||||
| `fresh` versus non-`fresh` envelope variants diverge across surfaces | Medium | Low | Keep one truth-building path and only use `fresh` variants when cache bypass is genuinely needed |
|
||||
| Implementation accidentally introduces a new freshness policy or new abstraction | Medium | Low | Lock the design to current source-derived stale semantics and reject new persistence or resolver additions in review |
|
||||
|
||||
## Test Strategy
|
||||
|
||||
- Extend the current evidence, tenant review, review pack, and canonical summary Pest tests instead of adding a new testing layer.
|
||||
- Use `BuildsGovernanceArtifactTruthFixtures` and existing `composeTenantReviewForTest()` helpers to build fresh, stale, and partial scenarios consistently.
|
||||
- Add explicit assertions for fresh versus stale evidence snapshots, partial versus complete review evidence, review-pack versus review trust alignment, and canonical row truth alignment.
|
||||
- Preserve existing authorization semantics: non-entitled users remain `404`, in-scope users without manage capability remain `403` for actions, and summary truth remains visible only within entitled scope.
|
||||
- Keep destructive actions and operation-launch semantics unchanged; test additions should focus on trust consequences, not on unrelated lifecycle behavior.
|
||||
- Focused verification targets: `EvidenceSnapshotResourceTest`, `TenantReviewLifecycleTest`, `ReviewPackResourceTest`, `TenantReviewRegisterTest`, `EvidenceOverviewPageTest`, and fixture helpers.
|
||||
|
||||
## Complexity Tracking
|
||||
|
||||
No constitution violations or justified complexity exceptions were identified.
|
||||
|
||||
## Proportionality Review
|
||||
|
||||
Not triggered beyond the already-passed spec review. The plan introduces no new enum/status family, DTO/presenter family, persisted entity, registry, resolver, taxonomy, or cross-domain UI framework.
|
||||
141
specs/174-evidence-freshness-publication-trust/quickstart.md
Normal file
141
specs/174-evidence-freshness-publication-trust/quickstart.md
Normal file
@ -0,0 +1,141 @@
|
||||
# Quickstart: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
## Goal
|
||||
|
||||
Validate that stale and partial evidence now degrade review and pack trust consistently across tenant-scoped detail pages and canonical summary pages, without changing routes, authorization semantics, or the current action inventory.
|
||||
|
||||
## Prerequisites
|
||||
|
||||
1. Start Sail if it is not already running.
|
||||
2. Ensure the acting user is a valid workspace member and entitled to the target tenant or tenants.
|
||||
3. Prepare representative fixtures for these cases:
|
||||
- fresh and complete evidence snapshot
|
||||
- stale evidence snapshot
|
||||
- partial evidence snapshot or review with partial sections
|
||||
- review with publication blockers
|
||||
- ready review pack derived from a fresh review
|
||||
- ready review pack derived from a stale or partial review
|
||||
|
||||
## Focused Automated Verification
|
||||
|
||||
Run the smallest existing test set that guards the affected surfaces first:
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Evidence/EvidenceSnapshotResourceTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewLifecycleTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackResourceTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewRegisterTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Evidence/EvidenceOverviewPageTest.php
|
||||
```
|
||||
|
||||
If implementation extends shared truth helpers or run-detail truth copy, also run:
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Monitoring/ArtifactTruthRunDetailTest.php
|
||||
```
|
||||
|
||||
## Manual Validation Pass
|
||||
|
||||
Use one fresh tenant and one stale or partial tenant, or equivalent seeded records in the same tenant.
|
||||
|
||||
### 1. Evidence snapshot detail trust
|
||||
|
||||
Open the tenant-scoped evidence snapshot detail page for a fresh snapshot and a stale snapshot.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- both snapshots can still exist structurally,
|
||||
- the stale snapshot is clearly shown as stale or cautionary,
|
||||
- the fresh snapshot remains current,
|
||||
- next-step guidance differs appropriately,
|
||||
- and no raw JSON is required to understand why the stale snapshot is less trustworthy.
|
||||
|
||||
### 2. Review detail trust
|
||||
|
||||
Open tenant reviews anchored to:
|
||||
|
||||
- fresh complete evidence,
|
||||
- stale evidence,
|
||||
- partial evidence.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- review freshness and publication readiness remain separate concepts,
|
||||
- stale or partial reviews can still be useful internally,
|
||||
- but they do not present the same calm publishable posture as fresh complete reviews,
|
||||
- and next-step guidance points toward refresh or completion work when needed.
|
||||
|
||||
### 3. Review pack trust
|
||||
|
||||
Open the review pack list and review packs linked to the reviews above.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- the review-pack list row already surfaces the same internal-only or publishable caveat before the operator opens detail or clicks `Download`,
|
||||
- a pack generated from stale or partial evidence no longer looks calmer than the source review,
|
||||
- any internal-only or cautionary posture is visible before download,
|
||||
- and the pack points back to the source review when corrective action is needed.
|
||||
|
||||
### 4. Canonical summary alignment
|
||||
|
||||
Open:
|
||||
|
||||
- `/admin/evidence/overview`
|
||||
- `/admin/reviews`
|
||||
|
||||
Confirm that:
|
||||
|
||||
- stale or partial artifacts are visible as such in the row summaries,
|
||||
- the next-step language is directionally the same as on detail pages,
|
||||
- a tenant with fresh evidence but no current review shows a next step that points toward review creation rather than implying review readiness already exists,
|
||||
- and drill-through links preserve tenant context and do not reveal non-entitled tenants.
|
||||
|
||||
### 5. Ten-second scan validation
|
||||
|
||||
Timebox the first visible scan of one snapshot detail page, one tenant review detail page, and one review pack detail page to 10 seconds each.
|
||||
|
||||
Confirm that within that time an operator can tell:
|
||||
|
||||
- whether the artifact is fresh enough,
|
||||
- whether it is only internally useful or publishable,
|
||||
- and what the next action is.
|
||||
|
||||
### 6. Authorization and action non-regression
|
||||
|
||||
Confirm that:
|
||||
|
||||
- view-only users can still inspect truth but not execute manage actions,
|
||||
- non-entitled users still receive deny-as-not-found behavior,
|
||||
- existing destructive actions still require confirmation,
|
||||
- touched refresh, publish, export, regenerate, or create-next-review handlers still dispatch the existing services and current `OperationRun` types where applicable,
|
||||
- and no new actions or route changes were introduced as part of the hardening.
|
||||
|
||||
### 7. Shared list-surface review checklist
|
||||
|
||||
Review `docs/product/standards/list-surface-review-checklist.md` against the touched list and report surfaces.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- `/admin/evidence/overview` and `/admin/reviews` still use row click as the primary inspect model,
|
||||
- the tenant-scoped review-pack list keeps its row-level trust caveat visible before drill-through or download,
|
||||
- existing inline safe shortcuts and header actions remain in their established positions,
|
||||
- empty and filtered states still read clearly without hiding trust truth,
|
||||
- and default-visible row summaries still surface freshness, publishable posture, and next step without requiring drill-through.
|
||||
|
||||
### 8. Performance and render guardrails
|
||||
|
||||
Confirm from the implementation diff and final surface behavior that:
|
||||
|
||||
- the touched detail and canonical surfaces still render from existing database-backed truth inputs,
|
||||
- no new render-time external calls, background dispatches, or route changes were introduced,
|
||||
- and canonical row truth remains lightweight enough for a normal operator scan without adding a new per-row derivation layer.
|
||||
|
||||
## Formatting And Final Verification
|
||||
|
||||
Before finalizing implementation work:
|
||||
|
||||
```bash
|
||||
vendor/bin/sail bin pint --dirty --format agent
|
||||
```
|
||||
|
||||
Then rerun the smallest affected test set. If the user wants broader confidence afterward, offer the full suite.
|
||||
60
specs/174-evidence-freshness-publication-trust/research.md
Normal file
60
specs/174-evidence-freshness-publication-trust/research.md
Normal file
@ -0,0 +1,60 @@
|
||||
# Research: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
## Decision 1: Reuse the existing source-derived stale semantics instead of introducing a global freshness engine
|
||||
|
||||
- Decision: Treat provider-level `stale` evaluation and the existing `EvidenceCompletenessEvaluator` as the canonical source of temporal freshness for this feature.
|
||||
- Rationale: Evidence freshness is already derived upstream in the evidence domain. `EvidenceSnapshotService` collects per-dimension payloads, providers such as `BaselineDriftPostureSource` already mark data stale using domain-appropriate recency rules, and `EvidenceCompletenessEvaluator` already escalates any required stale dimension into snapshot completeness. A second global threshold engine would duplicate truth and risk disagreement with the evidence domain.
|
||||
- Alternatives considered:
|
||||
- Add a new global `freshness_threshold_hours` configuration and recompute staleness on the page layer. Rejected because the existing evidence sources already encode domain-aware freshness and the page layer should not create its own recency semantics.
|
||||
- Derive staleness purely from `generated_at` on snapshots and reviews. Rejected because the meaningful freshness signal already exists at the dimension level, and a snapshot can be freshly generated from stale inputs.
|
||||
|
||||
## Decision 2: Tighten `ArtifactTruthPresenter` instead of adding a new trust or publication resolver
|
||||
|
||||
- Decision: Keep `ArtifactTruthPresenter` as the single seam for evidence snapshot, tenant review, and review pack trust propagation.
|
||||
- Rationale: The presenter already builds envelopes for `EvidenceSnapshot`, `TenantReview`, and `ReviewPack`, including freshness, content, publication, actionability, and next-step guidance. The current bug is not the absence of a trust layer, but that stale and partial semantics are not fully propagated through the existing one.
|
||||
- Alternatives considered:
|
||||
- Create a dedicated `PublicationReadinessResolver` or `FreshnessTrustGate`. Rejected because the current architecture already centralizes the needed truth and a second layer would violate the repo's proportionality and few-layers rules.
|
||||
- Push the logic into page classes. Rejected because it would fragment truth across summary pages and detail resources.
|
||||
|
||||
## Decision 3: Tenant review publication readiness must degrade when freshness is stale
|
||||
|
||||
- Decision: Make stale review freshness capable of downgrading a review from publishable to an internal-only or cautionary posture even when the review status is `ready` or `published`.
|
||||
- Rationale: `TenantReviewReadinessGate` already treats stale required sections as publication blockers at composition time, and `buildTenantReviewEnvelope()` already calculates a `freshnessState` of `stale`. The current contradiction is that publication readiness still becomes `publishable` from status alone, which lets stale reviews sound calmer than the evidence basis justifies.
|
||||
- Rule: A stale review may remain internally useful, but it must not remain `publishable` solely because its lifecycle status is `ready` or `published`. If stronger blockers already exist, `blocked` still takes precedence.
|
||||
- Alternatives considered:
|
||||
- Leave publication readiness based only on status and blocker arrays. Rejected because it allows a stale review to look publishable even when the same presenter calls it stale.
|
||||
- Introduce a new persisted review trust field. Rejected because the stale condition is already derivable from review completeness and section counts.
|
||||
|
||||
## Decision 4: Partial evidence must lower publication confidence even when it does not fully block review use
|
||||
|
||||
- Decision: Distinguish between reviews that are usable internally and reviews that are truly publishable when the evidence basis is partial.
|
||||
- Rationale: The spec requires a meaningful difference between internal-use artifacts and publishable artifacts. The current truth model already supports separate `contentState`, `freshnessState`, `publicationReadiness`, and `actionability` dimensions, so the implementation can express this nuance without new state families.
|
||||
- Rule: Partial evidence downgrades publication readiness to `internal_only` unless stronger existing blockers already make the artifact `blocked`.
|
||||
- Alternatives considered:
|
||||
- Treat partial evidence exactly like complete evidence whenever hard blockers are absent. Rejected because that is the current trust problem.
|
||||
- Convert all partial evidence into hard publish blockers. Rejected because the spec wants internal-use versus publishable to remain distinct, not collapsed into blocked versus not blocked.
|
||||
|
||||
## Decision 5: Review packs must inherit stale and partial burden from the linked review and evidence basis
|
||||
|
||||
- Decision: Make `ReviewPack` truth inherit source review and evidence burden rather than treating a ready, non-expired file as inherently current and publishable.
|
||||
- Rationale: `buildReviewPackEnvelope()` currently treats pack freshness as `current` whenever the file is not expired, even if the source review or source evidence is stale. That allows packs to appear calmer than the review they were generated from, which is exactly the contradiction this spec is meant to close.
|
||||
- Rule: A pack is only `publishable` when its source review remains current and strong enough to publish. Stale or partial source burden must downgrade the pack to `internal_only`, unless stronger blockers already make it `blocked`.
|
||||
- Alternatives considered:
|
||||
- Keep pack freshness tied only to file expiration. Rejected because a current file can still be generated from stale governance evidence.
|
||||
- Persist a separate pack trust state. Rejected because the necessary source review and evidence inputs already exist.
|
||||
|
||||
## Decision 6: Canonical summary pages should reuse the same truth envelope and next-step semantics
|
||||
|
||||
- Decision: Keep `EvidenceOverview` and `ReviewRegister` aligned by reusing the same envelope semantics that power the tenant-scoped detail pages.
|
||||
- Rationale: Both canonical pages already display artifact truth and next-step or publication surfaces. The current risk is not missing UI slots, but summary rows sounding calmer than the detail pages because stale and partial burden are not fully represented in the underlying truth.
|
||||
- Alternatives considered:
|
||||
- Add new page-specific columns, banners, or taxonomy labels. Rejected because the repo already has canonical truth and badge primitives.
|
||||
- Leave canonical summary rows untouched and rely on drill-through. Rejected because the spec explicitly targets trust propagation on summary surfaces.
|
||||
|
||||
## Decision 7: Expand the current Pest test surfaces and fixture helpers instead of creating a new test harness
|
||||
|
||||
- Decision: Extend the current evidence, review, pack, review-register, and evidence-overview tests, and strengthen shared governance-artifact fixtures.
|
||||
- Rationale: The current suite already covers resource routing, basic artifact truth visibility, review publication blockers, and canonical row scoping. The missing coverage is specific: fresh versus stale propagation, partial-evidence publication trust, and review-versus-pack consistency.
|
||||
- Alternatives considered:
|
||||
- Rely on manual browser validation only. Rejected because this feature is about preventing semantic drift across multiple related surfaces.
|
||||
- Add a separate browser suite as the primary guard. Rejected because the existing Pest feature surfaces are already well aligned with the affected code paths and will be faster and cheaper to maintain.
|
||||
237
specs/174-evidence-freshness-publication-trust/spec.md
Normal file
237
specs/174-evidence-freshness-publication-trust/spec.md
Normal file
@ -0,0 +1,237 @@
|
||||
# Feature Specification: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Feature Branch**: `174-evidence-freshness-publication-trust`
|
||||
**Created**: 2026-04-04
|
||||
**Status**: Draft
|
||||
**Input**: User description: "Spec 174 — Evidence Temporal Freshness & Review Publication Trust"
|
||||
|
||||
## Spec Scope Fields *(mandatory)*
|
||||
|
||||
- **Scope**: tenant + canonical-view
|
||||
- **Primary Routes**:
|
||||
- `/admin/t/{tenant}/evidence` and `/admin/t/{tenant}/evidence/{snapshot}` for tenant-scoped evidence snapshot inspection
|
||||
- `/admin/t/{tenant}/reviews` and `/admin/t/{tenant}/reviews/{review}` for tenant-scoped review lifecycle and publication decisions
|
||||
- `/admin/t/{tenant}/review-packs` and `/admin/t/{tenant}/review-packs/{pack}` for tenant-scoped executive pack generation, download, and trust communication
|
||||
- `/admin/reviews` for the canonical review register across entitled tenants
|
||||
- `route('admin.evidence.overview')` for the canonical evidence overview across entitled tenants
|
||||
- **Data Ownership**:
|
||||
- Tenant-owned: stored reports, evidence snapshots, evidence snapshot items, tenant reviews, and review packs remain tenant-scoped artifacts anchored to one tenant's governance history
|
||||
- Workspace-owned but tenant-filtered: canonical register and overview pages aggregate only within the operator's entitled workspace and tenant set, without changing ownership of the underlying artifacts
|
||||
- This feature introduces no new persisted trust record, no new freshness record, and no new export-tracking entity; truth remains derived from existing timestamps, completeness states, and artifact links
|
||||
- **RBAC**:
|
||||
- Workspace membership and tenant entitlement remain required for all tenant-scoped evidence, review, and pack routes
|
||||
- Existing capabilities remain authoritative: `evidence.view` / `evidence.manage`, `tenant_review.view` / `tenant_review.manage`, and `review_pack.view` / `review_pack.manage`
|
||||
- Canonical review and evidence surfaces must preserve deny-as-not-found semantics for non-members and non-entitled users, and must not expose cross-tenant artifact existence, trust posture, or readiness hints outside the authorized tenant set
|
||||
|
||||
For canonical-view specs, the spec MUST define:
|
||||
|
||||
- **Default filter behavior when tenant-context is active**: When an operator opens the canonical review register or canonical evidence overview from a tenant-scoped surface, the destination opens prefiltered to that tenant through the existing tenant-prefilter mechanisms so the operator stays in the same tenant world they clicked from.
|
||||
- **Explicit entitlement checks preventing cross-tenant leakage**: Canonical review rows, evidence rows, artifact-truth badges, publication-readiness badges, next-step text, filters, and drill-through links must only be built after workspace membership and tenant-entitlement checks. Non-entitled users must not learn whether another tenant has a current review, a stale evidence snapshot, or an exportable pack.
|
||||
|
||||
## UI/UX Surface Classification *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
Affected list and report surfaces in this spec MUST also be reviewed against `docs/product/standards/list-surface-review-checklist.md` before implementation sign-off so row-click behavior, inline action discipline, empty states, and summary truth remain aligned with the shared operator-surface standard.
|
||||
|
||||
| Surface | Surface Type | Primary Inspect/Open Model | Row Click | Secondary Actions Placement | Destructive Actions Placement | Canonical Collection Route | Canonical Detail Route | Scope Signals | Canonical Noun | Critical Truth Visible by Default | Exception Type |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Evidence snapshot resource | CRUD / List-first Resource | Full-row click from list to snapshot detail | required | One `More` menu for non-primary list actions | `Expire snapshot` in `More` or detail header | `/admin/t/{tenant}/evidence` | `/admin/t/{tenant}/evidence/{snapshot}` | Tenant context and evidence completeness badges scope every row and action | Evidence / Evidence snapshot | Artifact truth, completeness, freshness pressure, and next step | none |
|
||||
| Tenant review resource | CRUD / List-first Resource | Full-row click from list to tenant review detail | required | One inline safe shortcut (`Export executive pack`) plus detail-header support actions | `Archive review` in detail header `More` group | `/admin/t/{tenant}/reviews` | `/admin/t/{tenant}/reviews/{review}` | Tenant context, review status, completeness, publication readiness, and evidence basis stay explicit | Reviews / Review | Artifact truth, completeness, publication readiness, and next step | none |
|
||||
| Canonical review register | Read-only Registry / Report Surface | Clickable row to the tenant-scoped review detail that matches the row | required | One inline safe shortcut (`Export executive pack`) plus header clear-filters action | none | `/admin/reviews` | Tenant-scoped review detail for the selected row | Tenant labels, publication badges, completeness badges, and tenant-prefilter state | Reviews / Review | Cross-tenant review truth, publication readiness, and next step | canonical-view registry |
|
||||
| Review pack resource | CRUD / List-first Resource | Full-row click from list to pack detail | required | One inline safe shortcut (`Download`) plus detail-header support actions | `Expire` in overflow or detail header | `/admin/t/{tenant}/review-packs` | `/admin/t/{tenant}/review-packs/{pack}` | Tenant context, linked review, review status, pack status, and artifact truth remain visible | Review Packs / Review pack | Publication readiness, freshness burden, and whether export is internal-only or publishable | none |
|
||||
| Evidence overview | Read-only Registry / Report Surface | Clickable row to the tenant-scoped evidence snapshot detail for the selected tenant | required | Header clear-filters action only | none | `route('admin.evidence.overview')` | `/admin/t/{tenant}/evidence/{snapshot}` for the selected row | Tenant labels, artifact truth, freshness badges, and next-step text keep the overview scoped | Evidence / Evidence snapshot | Freshness and completeness truth across entitled tenants | canonical-view registry |
|
||||
|
||||
## Operator Surface Contract *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
| Surface | Primary Persona | Surface Type | Primary Operator Question | Default-visible Information | Diagnostics-only Information | Status Dimensions Used | Mutation Scope | Primary Actions | Dangerous Actions |
|
||||
|---|---|---|---|---|---|---|---|---|---|
|
||||
| Evidence snapshot detail | Tenant operator | Detail-first Operational Surface | Is this evidence basis complete enough, fresh enough, and trustworthy enough to use right now? | Artifact truth, completeness state, freshness pressure, missing or stale dimensions, and next-step guidance | Raw summary JSON, deep dimension payloads, fingerprints, source record IDs | artifact existence, content completeness, temporal freshness, actionability | TenantPilot evidence lifecycle only | Refresh evidence, view linked operation, inspect dimensions | Expire snapshot |
|
||||
| Tenant review detail | Tenant operator | Detail-first Operational Surface | Is this review merely stored, ready for internal use, or strong enough to publish externally? | Artifact truth, completeness, publication readiness, review blockers or warnings, evidence basis, and next-step guidance | Full section payloads, raw summary JSON, historical audit context, operation metadata | artifact existence, completeness, temporal freshness, publication readiness, actionability | TenantPilot review lifecycle and export initiation | Refresh review, publish review, export executive pack, create next review, open evidence | Archive review |
|
||||
| Canonical review register | Workspace auditor or operator | Read-only Registry / Report Surface | Which tenants currently have review artifacts that are fresh enough, publication-ready enough, or in need of follow-up? | Review status, artifact truth, completeness, publication readiness, and next-step text per tenant | Deep section content, raw evidence payloads, audit internals | review lifecycle, artifact truth, completeness, publication readiness | Read-only registry plus export initiation where already allowed | Open review, export executive pack | none |
|
||||
| Review pack detail | Tenant operator | Detail-first Operational Surface | Is this pack merely downloadable, or is it publishable enough to treat as a stakeholder-facing export? | Artifact truth, pack status, linked review, evidence basis summary, publication readiness, and download caveat when needed | Fingerprints, previous fingerprint, low-level generation metadata | artifact existence, freshness pressure, publication readiness, expiration state | TenantPilot export lifecycle only | Download, regenerate pack, open linked review | Expire pack |
|
||||
| Evidence overview | Workspace auditor or operator | Read-only Registry / Report Surface | Which entitled tenants currently have fresh, complete evidence and which require follow-up before review or publication? | Tenant, artifact truth, freshness state, missing or stale dimensions, and next step | Per-dimension detail payloads and raw summary JSON remain on snapshot detail | artifact truth, freshness, completeness | none | Open evidence snapshot | none |
|
||||
|
||||
## Proportionality Review *(mandatory when structural complexity is introduced)*
|
||||
|
||||
- **New source of truth?**: No. Evidence snapshots, review records, review packs, and the existing artifact-truth layer remain the authoritative truth sources.
|
||||
- **New persisted entity/table/artifact?**: No. This feature explicitly avoids new persistence and must derive freshness and publication trust from existing timestamps, completeness states, and links.
|
||||
- **New abstraction?**: No. The narrowest correct implementation is to harden the existing `ArtifactTruthPresenter`, readiness gates, and surface mappings rather than adding a second trust framework.
|
||||
- **New enum/state/reason family?**: No. Existing freshness and publication-readiness dimensions should be tightened, not replaced with a new persisted status family.
|
||||
- **New cross-domain UI framework/taxonomy?**: No. This is a surface-truth hardening slice inside the existing evidence/review/export chain.
|
||||
- **Current operator problem**: Structurally complete evidence can currently read as current enough and publishable enough even when it is too old or only partial, which risks operators exporting or publishing artifacts that are not decision-grade.
|
||||
- **Existing structure is insufficient because**: Completeness and publication surfaces already exist, but temporal freshness and partial-evidence burden are not strong enough in the artifact-truth and review-readiness chain to keep surfaces from sounding calmer than the underlying evidence basis.
|
||||
- **Narrowest correct implementation**: Tighten the existing artifact-truth and readiness evaluation to degrade stale or partial artifacts visibly on evidence, review, register, and pack surfaces, while preserving current resources and actions.
|
||||
- **Ownership cost**: The repo takes on a small amount of additional cross-surface regression coverage and ongoing maintenance for freshness-threshold and publication-caveat rules.
|
||||
- **Alternative intentionally rejected**: A new StoredReport resource, a new export governance table, or a separate portfolio-trust layer was rejected because the immediate product risk can be solved by tightening the current evidence/review/export truth chain.
|
||||
- **Release truth**: Current-release truth. Operators can already act on these surfaces today, so trust hardening cannot wait for a later reporting overhaul.
|
||||
|
||||
## User Scenarios & Testing *(mandatory)*
|
||||
|
||||
### User Story 1 - Detect Stale Evidence Before Reusing It (Priority: P1)
|
||||
|
||||
As a tenant operator, I want evidence, reviews, and packs to tell me when their underlying evidence basis is too old to rely on confidently, so that I do not make governance decisions on structurally complete but outdated artifacts.
|
||||
|
||||
**Why this priority**: Silent evidence aging is the highest trust risk in this domain because it can make calm-looking artifacts unsafe for real decisions.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding fresh and old evidence snapshots with the same structural completeness and verifying that only the fresh artifacts read as current enough for confident reuse.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** an evidence snapshot is structurally complete but one or more required evidence dimensions have aged past their canonical source-defined freshness thresholds, **When** an operator opens the snapshot, linked review, or linked pack surface, **Then** the artifact is shown as stale or cautionary rather than quietly current.
|
||||
2. **Given** an evidence snapshot is structurally complete and still within the freshness threshold, **When** an operator opens the snapshot, linked review, or linked pack surface, **Then** the freshness dimension allows the artifact to remain in a current or fresher state when no other trust limiter applies.
|
||||
3. **Given** a canonical register or overview lists both fresh and stale artifacts, **When** the operator scans the table, **Then** freshness burden is visible without opening every row.
|
||||
|
||||
---
|
||||
|
||||
### User Story 2 - Distinguish Internal-Use Reviews From Publishable Reviews (Priority: P1)
|
||||
|
||||
As a tenant operator, I want review and pack surfaces to distinguish between internally useful artifacts and truly publishable artifacts, so that I do not treat downloadability or technical readiness as proof that a report is publishable.
|
||||
|
||||
**Why this priority**: Export and publication are the moments where a misleadingly calm artifact becomes an external trust problem.
|
||||
|
||||
**Independent Test**: Can be fully tested by rendering reviews and packs built from complete evidence, partial evidence, and stale evidence, then verifying that their readiness and publication signals diverge appropriately.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** a tenant review is structurally ready but built on partial evidence, **When** the operator views the review, **Then** the surface shows a cautionary or internal-only publication posture rather than the same calm signal used for publishable reviews.
|
||||
2. **Given** a review pack is downloadable but derived from stale or partial evidence, **When** the operator opens or downloads the pack, **Then** the surface discloses that the pack is better suited to internal use or review refresh rather than quiet external sharing.
|
||||
3. **Given** a tenant review and its current export pack share the same stale or partial evidence burden, **When** the operator compares their surfaces, **Then** both surfaces communicate consistent trust and publication signals.
|
||||
|
||||
---
|
||||
|
||||
### User Story 3 - Recover The Evidence Basis Across Review Surfaces (Priority: P2)
|
||||
|
||||
As a workspace operator reviewing multiple tenants, I want canonical review and evidence surfaces to preserve the link between review status, evidence freshness, and next action, so that I can tell which tenants are review-ready and which need evidence refresh before publication.
|
||||
|
||||
**Why this priority**: Portfolio-level review work depends on summary surfaces carrying the same truth as the detail surfaces they summarize.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding tenants with mixed evidence freshness and review readiness and verifying that review-register and evidence-overview rows present the same trust direction as the underlying detail pages.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** two tenants have reviews with different evidence freshness burdens, **When** the operator scans the review register, **Then** the table communicates which review is fresher and which needs follow-up.
|
||||
2. **Given** a tenant has fresh evidence but no current review, **When** the operator scans canonical surfaces, **Then** the surfaces show a next step that points toward review creation rather than implying review readiness already exists.
|
||||
3. **Given** a tenant has stale evidence and a previously generated pack, **When** the operator follows drill-through links between overview and detail pages, **Then** the trust explanation remains coherent across the journey.
|
||||
|
||||
### Edge Cases
|
||||
|
||||
- A run can complete and create an evidence snapshot, but the snapshot can later age past the acceptable freshness window without any structural completeness change.
|
||||
- A review can have all sections present yet still rely on partial sections whose evidence basis should reduce publication confidence.
|
||||
- A pack can remain downloadable after its linked review or evidence basis becomes stale; the surface must warn rather than silently remain calm.
|
||||
- A stored report referenced by an evidence item can be pruned by retention while the evidence snapshot still exists; this feature must not require a new raw-report viewer to remain truthful.
|
||||
- A user may be entitled to a tenant review but not to export or manage it; readiness and trust truth may still be visible, while actions remain capability-gated.
|
||||
- Canonical register and overview pages may be prefiltered from a tenant context; they must remain semantically consistent without leaking artifacts from non-entitled tenants.
|
||||
|
||||
## Requirements *(mandatory)*
|
||||
|
||||
**Constitution alignment (required):** This feature introduces no new Microsoft Graph calls and no new long-running flow. It hardens how existing evidence, review, and pack artifacts communicate trust. Existing review and pack actions continue to use their current services and current `OperationRun` types. No new contract registry entry or queued process is added.
|
||||
|
||||
**Constitution alignment (PROP-001 / ABSTR-001 / PERSIST-001 / STATE-001 / BLOAT-001):** This slice adds no persistence, no new abstraction layer, and no new persisted status family. The current operator problem is that structurally complete artifacts can look newer and safer than they are. Existing structure is insufficient because completeness and publication surfaces are not yet hard enough against age and partial evidence. The narrowest correct implementation is to strengthen the existing artifact-truth and readiness logic. Ownership cost is limited to regression coverage and threshold maintenance. A separate reporting or StoredReport framework is intentionally rejected in this slice.
|
||||
|
||||
**Constitution alignment (OPS-UX):** No new `OperationRun` type is added. Existing evidence snapshot generation, review composition, review refresh, and review-pack generation continue to own execution lifecycle through current services and current run types. This feature only changes how resulting artifacts communicate trust and next action after those runs complete.
|
||||
|
||||
**Constitution alignment (RBAC-UX):** The feature affects the tenant/admin plane for tenant-scoped evidence, reviews, and review packs, plus canonical admin pages for the review register and evidence overview. Non-members and non-entitled users remain `404`. In-scope members lacking `evidence.manage`, `tenant_review.manage`, or `review_pack.manage` remain `403` for the corresponding actions. Export and publication affordances must stay capability-aware while still allowing truth signals to appear for view-only users.
|
||||
|
||||
**Constitution alignment (OPS-EX-AUTH-001):** Not applicable. No authentication handshake behavior is changed.
|
||||
|
||||
**Constitution alignment (BADGE-001):** Existing centralized badge domains for tenant review status, tenant review completeness, evidence completeness, review pack status, governance artifact freshness, and related artifact-truth labels remain the semantic source. This feature may change when those badge families show caution or downgrade states, but must not introduce local page-only badge mappings.
|
||||
|
||||
**Constitution alignment (UI-FIL-001):** The feature reuses native Filament resources, infolists, tables, actions, badges, sections, and existing governance artifact-truth entry views. Local replacement markup for core truth surfaces should be avoided. Any stronger stale or internal-only emphasis should still be expressed through Filament props and central badge or truth primitives rather than page-local color languages.
|
||||
|
||||
**Constitution alignment (UI-NAMING-001):** The target objects are evidence snapshots, reviews, and review packs. Primary operator-facing vocabulary remains `Create snapshot`, `Refresh evidence`, `Create review`, `Refresh review`, `Publish review`, `Export executive pack`, `Generate first pack`, `Download`, and `Expire`. New or revised copy must preserve the difference between `current`, `stale`, `partial`, `internal use`, `publication ready`, and `blocked`, and must avoid implementation-first wording such as `snapshot age rule`, `trust envelope`, or `derived state` in primary operator labels.
|
||||
|
||||
**Constitution alignment (UI-CONST-001 / UI-SURF-001 / UI-HARD-001 / UI-EX-001 / UI-REVIEW-001):** The affected surfaces consist of `CRUD / List-first Resource` lists for snapshots, reviews, and review packs, `Read-only Registry / Report Surface` pages for the canonical overview and register, and dedicated `Detail-first Operational Surface` pages for artifact inspection and action context. Each keeps one primary inspect model: row-click for snapshot, review, register, and pack tables; detail-header actions for lifecycle mutations; and diagnostic subsections for raw summaries. Critical truth visible by default must include artifact truth, freshness burden, completeness burden, publication readiness, and next step where relevant. This feature does not introduce redundant `View` affordances or move destructive actions out of their current safe placements.
|
||||
|
||||
**Constitution alignment (OPSURF-001):** Operator-first content on evidence, review, and pack surfaces must separate execution truth, artifact existence, completeness, freshness, and publication readiness rather than flattening them into one vague `ready` state. Diagnostics such as raw summary JSON, fingerprints, and low-level IDs remain secondary. Mutating actions continue to act on TenantPilot-managed artifacts only.
|
||||
|
||||
**Constitution alignment (UI-SEM-001 / LAYER-001 / TEST-TRUTH-001):** Direct mapping from persisted artifact status alone is insufficient because artifact trust depends on cross-cutting freshness and completeness context. This feature must strengthen the existing artifact-truth layer rather than adding a parallel presenter family. Tests must verify business consequences such as stale artifacts not appearing publishable, partial evidence downgrading publication trust, and review/pack surfaces staying consistent.
|
||||
|
||||
**Constitution alignment (Filament Action Surfaces):** The Action Surface Contract remains satisfied. Evidence, review, and pack resources keep one primary inspect model per list, no redundant row-level view actions, and confirmation-gated destructive actions where applicable. Review register and evidence overview remain read-only registry surfaces. UI-FIL-001 remains satisfied with no new exception required.
|
||||
|
||||
**Constitution alignment (UX-001 — Layout & Information Architecture):** Existing detail screens remain sectioned Infolist-style pages. This feature strengthens the top-level truth and caveat zones on those screens rather than converting them into forms or custom layouts. Tables remain searchable, sortable, and filterable where already supported.
|
||||
|
||||
### Functional Requirements
|
||||
|
||||
- **FR-174-001**: Evidence snapshots and every artifact derived from them MUST distinguish structural completeness from temporal freshness. A structurally complete artifact MUST NOT automatically read as current enough solely because all expected dimensions are present.
|
||||
- **FR-174-002**: Temporal freshness MUST be evaluated from existing evidence timestamps using a clearly defined freshness policy for each evidence dimension. Where source-specific freshness thresholds are already canonical in the evidence domain, this feature MUST reuse them rather than inventing a second global threshold.
|
||||
- **FR-174-003**: When one or more required evidence dimensions exceed their canonical freshness policy, the snapshot, any review anchored to it, and any review pack anchored to that review or snapshot MUST visibly degrade into a stale or cautionary trust state.
|
||||
- **FR-174-004**: Stale evidence MUST influence the artifact-truth summary that operators see on evidence snapshot detail, tenant review detail, review register rows, review pack detail, review pack list rows, and evidence overview rows.
|
||||
- **FR-174-005**: A tenant review or review pack based on stale evidence MUST NOT present the same calm `current`, `ready`, or publishable impression as a fresh artifact.
|
||||
- **FR-174-006**: Partial evidence MUST materially affect review and pack trust. If a review or review pack is structurally complete but its evidence basis is partial, the surface MUST downgrade publication readiness to `internal_only`, unless existing stronger publish blockers already make it `blocked`, instead of using the same publishable posture used for stronger evidence.
|
||||
- **FR-174-007**: Review readiness and publication readiness MUST remain visibly distinct. An artifact may be ready for internal inspection while still requiring caution or restriction for external sharing.
|
||||
- **FR-174-008**: Download or export affordances for review packs MUST surface when a pack is safer for internal use than for external sharing. A technically downloadable pack MUST NOT silently imply publishable trust.
|
||||
- **FR-174-009**: Review and pack surfaces MUST explain the principal reason for trust reduction when freshness or evidence quality lowers confidence, including stale evidence, partial sections, or missing or stale dimensions where relevant.
|
||||
- **FR-174-010**: When an artifact is stale, partial, internal-only, or otherwise not publishable, the surface MUST provide a clear next step such as refreshing evidence, refreshing the review, resolving missing evidence, or generating a new pack.
|
||||
- **FR-174-011**: Canonical review and evidence registry surfaces MUST stay semantically aligned with their tenant-scoped detail surfaces. A row that reads stale, partial, or internal-only on a detail page MUST not read calm or publishable in its register row.
|
||||
- **FR-174-012**: Tenant review detail and review pack detail MUST not send contradictory publication or trust signals for artifacts that share the same stale or partial evidence burden.
|
||||
- **FR-174-013**: This feature MUST preserve existing tenant-scoped and canonical prefilter navigation semantics so operators can follow truth from snapshot to review to pack without losing tenant context.
|
||||
- **FR-174-014**: The feature MUST not require a new StoredReport surface, a new persistence model, or a new export-governance artifact in order to become truthful about stale or partial evidence.
|
||||
- **FR-174-015**: Existing evidence, review, and pack actions MUST keep their current capability checks, confirmation behavior, and run-launch semantics while the surrounding truth language becomes stricter.
|
||||
- **FR-174-016**: Regression coverage MUST verify fresh vs stale evidence behavior, complete vs partial evidence behavior, review vs pack truth consistency, and download or export caveat behavior without relying on a new schema artifact.
|
||||
|
||||
## UI Action Matrix *(mandatory when Filament is changed)*
|
||||
|
||||
| Surface | Location | Header Actions | Inspect Affordance (List/Table) | Row Actions (max 2 visible) | Bulk Actions (grouped) | Empty-State CTA(s) | View Header Actions | Create/Edit Save+Cancel | Audit log? | Notes / Exemptions |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Evidence snapshot resource | `app/Filament/Resources/EvidenceSnapshotResource.php` | `Create snapshot` on list header | `recordUrl()` clickable row to snapshot detail | `More` group currently carries `Expire snapshot` | none | `Create first snapshot` | `Refresh evidence`, `Expire snapshot`, existing related links | n/a | existing evidence lifecycle audit remains | This spec changes truth presentation and next-step guidance, not the action inventory |
|
||||
| Tenant review resource | `app/Filament/Resources/TenantReviewResource.php` and `Pages/ViewTenantReview.php` | `Create review` on list header | `recordUrl()` clickable row to review detail | `Export executive pack` inline shortcut on list | none | `Create first review` | `Open operation`, `View executive pack`, `View evidence snapshot`, `Refresh review`, `Publish review`, `Export executive pack`, `Create next review`, `Archive review` | n/a | existing review lifecycle audit remains | Publication-trust hardening must apply consistently across list and detail |
|
||||
| Canonical review register | `app/Filament/Pages/Reviews/ReviewRegister.php` | `Clear filters` | `recordUrl()` clickable row to tenant-scoped review detail | `Export executive pack` safe row action where currently allowed | none | `Clear filters` | n/a | n/a | no new audit behavior | Canonical registry remains read-only apart from the existing export shortcut |
|
||||
| Review pack resource | `app/Filament/Resources/ReviewPackResource.php` | `Generate pack` on list header | `recordUrl()` clickable row to pack detail | `Download` | none | `Generate first pack` | `Download`, `Regenerate`, `Expire`, and existing related links | n/a | existing pack lifecycle audit remains | Download remains allowed where currently allowed, but its trust caveat must become explicit |
|
||||
| Evidence overview | `app/Filament/Pages/Monitoring/EvidenceOverview.php` | `Clear filters` when tenant-prefilter is active | Clickable row to tenant-scoped evidence snapshot detail | none | none | `Clear filters` in the empty state | n/a | n/a | no new audit behavior | Read-only canonical overview; this spec makes freshness truth stronger here |
|
||||
|
||||
### Key Entities *(include if feature involves data)*
|
||||
|
||||
- **StoredReport**: Raw tenant-scoped point-in-time source data such as permission posture or Entra admin roles captures. It is an input to evidence, not itself a review-grade artifact.
|
||||
- **EvidenceSnapshot**: Immutable tenant-scoped evidence basis composed from multiple dimensions and evaluated for completeness and freshness.
|
||||
- **EvidenceSnapshotItem**: A dimension-level evidence record linking an evidence snapshot to its source kind, source record, fingerprint, measured time, and completeness state.
|
||||
- **TenantReview**: A review artifact anchored to one evidence snapshot and evaluated for completeness, publication readiness, and next action.
|
||||
- **ReviewPack**: A tenant-scoped export artifact derived from a review or evidence basis, intended for download and potential sharing, with integrity and lifecycle metadata.
|
||||
- **Artifact truth**: The operator-facing evaluation of artifact existence, completeness, freshness, publication readiness, and actionability that determines whether an artifact is merely stored, internally useful, or safe enough to publish.
|
||||
|
||||
## Success Criteria *(mandatory)*
|
||||
|
||||
### Measurable Outcomes
|
||||
|
||||
- **SC-174-001**: In seeded review exercises, operators can determine within 10 seconds whether an evidence snapshot, tenant review, or review pack is fresh enough, stale, partial, or publishable without opening raw JSON or source records.
|
||||
- **SC-174-002**: In regression coverage, every scenario built on stale evidence or partial evidence shows a more cautious trust or publication state than the equivalent fresh-and-complete scenario across snapshot, review, and pack surfaces.
|
||||
- **SC-174-003**: In regression coverage, review-register rows, evidence-overview rows, tenant review detail, and review-pack detail agree on the trust direction of the same underlying artifact in 100% of covered stale and partial scenarios.
|
||||
- **SC-174-004**: In operator validation, downloadable but internal-only or cautionary packs are recognizably different from publishable packs before the operator clicks `Download`.
|
||||
- **SC-174-005**: The feature ships without a required schema migration, a new persisted trust artifact, or a new raw StoredReport resource.
|
||||
|
||||
## Assumptions
|
||||
|
||||
- Existing evidence snapshot timestamps and item timestamps are sufficient to derive temporal freshness without creating a new persistence model.
|
||||
- Existing artifact-truth and review-readiness logic are the right places to strengthen stale and partial-evidence semantics.
|
||||
- Existing review-pack download behavior can remain technically available while its trust and sharing guidance becomes more explicit.
|
||||
- StoredReport observability and source-liveness follow-up work may still be useful later, but are not prerequisites for this truth-hardening slice.
|
||||
|
||||
## Non-Goals
|
||||
|
||||
- Creating a dedicated StoredReport resource or raw report viewer
|
||||
- Building a live-state-versus-historical-state diff engine for published reviews
|
||||
- Adding stakeholder-delivery tracking or external-share audit semantics
|
||||
- Rebuilding Evidence Overview or Review Register into a new portfolio application
|
||||
- Introducing new tables, new status enums, or a second artifact-truth framework
|
||||
|
||||
## Dependencies
|
||||
|
||||
- Existing `EvidenceSnapshotResource`, `TenantReviewResource`, `ReviewPackResource`, `ReviewRegister`, and `EvidenceOverview` surfaces
|
||||
- Existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, review readiness logic, and review-pack generation services
|
||||
- Existing capability and tenant-entitlement enforcement for evidence, reviews, and packs
|
||||
- Existing evidence-domain, tenant-review, and review-pack foundational specs already implemented in the repo
|
||||
|
||||
## Follow-up Spec Candidates
|
||||
|
||||
- **StoredReport Observability & Source Liveness** for explicit raw-report diagnostics and pruned-source visibility
|
||||
- **Evidence / Review Portfolio Cross-Linking** for tighter canonical navigation between evidence overview and review register
|
||||
- **Published Review Drift & Superseded Evidence Signals** for signaling when a published review no longer reflects the current evidence basis
|
||||
|
||||
## Definition of Done
|
||||
|
||||
Spec 174 is complete when:
|
||||
|
||||
- structurally complete artifacts no longer read as current enough when their evidence basis is too old,
|
||||
- partial evidence produces a visibly more cautious review and pack trust posture,
|
||||
- review and pack surfaces stay consistent about the same stale or partial burden,
|
||||
- export and download actions no longer imply stronger trust than the underlying artifact supports,
|
||||
- canonical register and overview surfaces reflect the same truth direction as tenant-scoped detail surfaces,
|
||||
- and the hardening is achieved without new persistence or a new reporting subsystem.
|
||||
226
specs/174-evidence-freshness-publication-trust/tasks.md
Normal file
226
specs/174-evidence-freshness-publication-trust/tasks.md
Normal file
@ -0,0 +1,226 @@
|
||||
# Tasks: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Input**: Design documents from `/specs/174-evidence-freshness-publication-trust/`
|
||||
**Prerequisites**: `plan.md` (required), `spec.md` (required for user stories), `research.md`, `data-model.md`, `contracts/`
|
||||
|
||||
**Tests**: Tests are REQUIRED for this feature. Use focused Pest coverage in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/Evidence/EvidenceOverviewPageTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, `tests/Feature/TenantReview/TenantReviewRegisterTest.php`, `tests/Feature/ReviewPack/ReviewPackResourceTest.php`, and existing truth-support fixtures.
|
||||
**Operations**: This feature reuses existing evidence snapshot, tenant review, and review pack generation flows and their current `OperationRun` types. No new `OperationRun` creation, lifecycle transition, notification, or `summary_counts` producer work is introduced.
|
||||
**RBAC**: Existing tenant entitlement, workspace entitlement, and capability gating must remain unchanged. Tests must preserve deny-as-not-found behavior for non-entitled users and manage-action capability gating for view-only users.
|
||||
**Operator Surfaces**: Evidence snapshot detail, tenant review detail, review pack detail, evidence overview, and the canonical review register must stay operator-first, with freshness, completeness, publication readiness, and next step visible by default where relevant.
|
||||
**Filament UI Action Surfaces**: No new actions are introduced. Existing list inspect affordances, inline safe shortcuts, destructive action placement, and confirmation behavior must remain intact while truth semantics become stricter.
|
||||
**Filament UI UX-001**: Existing Infolist and table layouts remain; this feature hardens top-level trust and caveat semantics rather than creating new screens.
|
||||
**Badges**: Freshness, completeness, publication-readiness, and artifact-truth semantics must continue to use centralized badge domains and the existing governance truth partial.
|
||||
|
||||
**Organization**: Tasks are grouped by user story so each story can be implemented and tested as an independent increment after the shared truth scaffolding is in place.
|
||||
|
||||
## Phase 1: Setup (Shared Test Scaffolding)
|
||||
|
||||
**Purpose**: Prepare reusable stale and partial evidence fixtures that all stories can build on.
|
||||
|
||||
- [X] T001 Extend shared stale and partial governance artifact fixture builders in `tests/Feature/Concerns/BuildsGovernanceArtifactTruthFixtures.php`
|
||||
- [X] T002 [P] Add or refine stale evidence seeding helpers used by evidence and review tests in `tests/Pest.php`
|
||||
|
||||
---
|
||||
|
||||
## Phase 2: Foundational (Blocking Truth Propagation Prerequisite)
|
||||
|
||||
**Purpose**: Tighten the shared trust-propagation seam before any surface-specific story work begins.
|
||||
|
||||
**⚠️ CRITICAL**: No user story work should begin until this phase is complete.
|
||||
|
||||
- [X] T003 Refactor shared freshness-source and evidence-burden inputs used by evidence, review, and pack truth envelopes in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` without introducing a new resolver layer
|
||||
- [X] T004 [P] Preserve source-derived stale semantics and required-section blocker behavior without adding a new freshness engine in `app/Services/Evidence/EvidenceCompletenessEvaluator.php` and `app/Services/TenantReviews/TenantReviewReadinessGate.php`
|
||||
|
||||
**Checkpoint**: The central truth seam is ready for story-specific stale and publication hardening without introducing a second freshness framework.
|
||||
|
||||
---
|
||||
|
||||
## Phase 3: User Story 1 - Detect Stale Evidence Before Reusing It (Priority: P1) 🎯 MVP
|
||||
|
||||
**Goal**: Make stale evidence visible on snapshot, review, pack, and evidence-overview surfaces before operators reuse the artifact.
|
||||
|
||||
**Independent Test**: Seed fresh and stale evidence snapshots with the same structural completeness and verify that snapshot, linked review, linked pack, and evidence-overview rows downgrade only for the stale case.
|
||||
|
||||
### Tests for User Story 1
|
||||
|
||||
- [X] T005 [P] [US1] Add fresh-versus-stale snapshot detail assertions in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`
|
||||
- [X] T006 [P] [US1] Add stale-evidence overview row assertions in `tests/Feature/Evidence/EvidenceOverviewPageTest.php`
|
||||
- [X] T007 [P] [US1] Add stale-evidence trust assertions for linked reviews and packs in `tests/Feature/TenantReview/TenantReviewLifecycleTest.php` and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
### Implementation for User Story 1
|
||||
|
||||
- [X] T008 [US1] Surface stale snapshot truth and next-step guidance on tenant evidence detail in `app/Filament/Resources/EvidenceSnapshotResource.php` and `app/Filament/Resources/EvidenceSnapshotResource/Pages/ViewEvidenceSnapshot.php`
|
||||
- [X] T009 [US1] Surface stale-evidence burden on tenant review detail without changing action topology in `app/Filament/Resources/TenantReviewResource.php` and `app/Filament/Resources/TenantReviewResource/Pages/ViewTenantReview.php`
|
||||
- [X] T010 [US1] Surface stale-evidence burden on review pack list and detail before download in `app/Filament/Resources/ReviewPackResource.php` and `app/Filament/Resources/ReviewPackResource/Pages/ViewReviewPack.php`
|
||||
- [X] T011 [US1] Keep canonical evidence freshness rows aligned with snapshot detail in `app/Filament/Pages/Monitoring/EvidenceOverview.php` and `resources/views/filament/pages/monitoring/evidence-overview.blade.php`
|
||||
- [X] T012 [US1] Run the focused stale-evidence verification pack in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/Evidence/EvidenceOverviewPageTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
**Checkpoint**: Operators can now tell when evidence is stale before relying on snapshots, reviews, packs, or evidence-overview rows.
|
||||
|
||||
---
|
||||
|
||||
## Phase 4: User Story 2 - Distinguish Internal-Use Reviews From Publishable Reviews (Priority: P1)
|
||||
|
||||
**Goal**: Make partial or stale review evidence degrade review and pack publication posture into internal-only or cautionary states instead of looking publishable.
|
||||
|
||||
**Independent Test**: Render reviews and packs built from complete evidence, stale evidence, and partial evidence and verify that only the strongest case appears publishable.
|
||||
|
||||
### Tests for User Story 2
|
||||
|
||||
- [X] T013 [P] [US2] Add partial-evidence and stale-publication-readiness assertions for tenant reviews in `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`
|
||||
- [X] T014 [P] [US2] Add internal-only versus publishable pack assertions and download caveat coverage in `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
### Implementation for User Story 2
|
||||
|
||||
- [X] T015 [US2] Tighten tenant review publication-readiness, next-step, and explanatory trust semantics for stale or partial evidence in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` and `app/Filament/Resources/TenantReviewResource.php`
|
||||
- [X] T016 [US2] Tighten review pack publication-readiness and source-review caveat semantics for stale or partial evidence in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` and `app/Filament/Resources/ReviewPackResource.php`
|
||||
- [X] T017 [US2] Keep the shared governance truth partial explicit about freshness versus publication readiness without adding page-local status language in `resources/views/filament/infolists/entries/governance-artifact-truth.blade.php`
|
||||
- [X] T018 [US2] Verify review and pack detail surfaces stay consistent about internal-only versus publishable trust in `tests/Feature/TenantReview/TenantReviewLifecycleTest.php` and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
**Checkpoint**: Review and pack surfaces now distinguish internal-use artifacts from publishable artifacts and no longer imply publication safety from mere downloadability or status alone.
|
||||
|
||||
---
|
||||
|
||||
## Phase 5: User Story 3 - Recover The Evidence Basis Across Review Surfaces (Priority: P2)
|
||||
|
||||
**Goal**: Keep canonical review and evidence summary surfaces aligned with the tenant-scoped truth they summarize.
|
||||
|
||||
**Independent Test**: Seed tenants with mixed freshness and review readiness, then verify that the review register and evidence overview rows match the corresponding detail-page trust direction and preserve tenant-safe drill-through.
|
||||
|
||||
### Tests for User Story 3
|
||||
|
||||
- [X] T019 [P] [US3] Add stale and partial canonical review-register alignment assertions in `tests/Feature/TenantReview/TenantReviewRegisterTest.php`
|
||||
- [X] T020 [P] [US3] Add cross-surface drill-through, no-current-review next-step, and tenant-safe evidence-overview alignment assertions in `tests/Feature/Evidence/EvidenceOverviewPageTest.php` and `tests/Feature/TenantReview/TenantReviewRegisterTest.php`
|
||||
|
||||
### Implementation for User Story 3
|
||||
|
||||
- [X] T021 [US3] Align canonical review-register artifact truth, publication, and next-step rows with tenant review detail in `app/Filament/Pages/Reviews/ReviewRegister.php`
|
||||
- [X] T022 [US3] Preserve tenant-prefilter continuity, truthful drill-through, and the fresh-evidence-with-no-current-review next step between overview, register, and tenant detail surfaces in `app/Filament/Pages/Monitoring/EvidenceOverview.php` and `app/Filament/Pages/Reviews/ReviewRegister.php`
|
||||
- [X] T023 [US3] Keep tenant-scoped snapshot, review, and pack resources consistent with canonical summary language in `app/Filament/Resources/EvidenceSnapshotResource.php`, `app/Filament/Resources/TenantReviewResource.php`, and `app/Filament/Resources/ReviewPackResource.php`
|
||||
- [X] T024 [US3] Run the focused canonical-summary alignment verification pack in `tests/Feature/TenantReview/TenantReviewRegisterTest.php` and `tests/Feature/Evidence/EvidenceOverviewPageTest.php`
|
||||
|
||||
**Checkpoint**: Canonical summary surfaces now carry the same trust direction as the tenant-scoped detail pages they summarize.
|
||||
|
||||
---
|
||||
|
||||
## Phase 6: Polish & Cross-Cutting Concerns
|
||||
|
||||
**Purpose**: Final consistency, authorization non-regression, formatting, and focused verification across all stories.
|
||||
|
||||
- [X] T025 [P] Review and align operator-facing truth copy across the shared presenter and truth partial in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` and `resources/views/filament/infolists/entries/governance-artifact-truth.blade.php`
|
||||
- [X] T026 [P] Add manage-action and tenant-entitlement non-regression coverage for touched evidence, review, and pack surfaces in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
- [X] T027 Run formatting for touched files using `vendor/bin/sail bin pint --dirty --format agent`
|
||||
- [X] T028 Run the final focused verification pack from `specs/174-evidence-freshness-publication-trust/quickstart.md`, including the SC-174-001 10-second manual scan validation, the shared list-surface review checklist in `docs/product/standards/list-surface-review-checklist.md`, the DB-only render and lightweight canonical-row-derivation guardrails in `specs/174-evidence-freshness-publication-trust/plan.md`, and the existing action run-launch semantics in `app/Filament/Resources/EvidenceSnapshotResource.php`, `app/Filament/Resources/TenantReviewResource.php`, and `app/Filament/Resources/ReviewPackResource.php`, against `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/Evidence/EvidenceOverviewPageTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, `tests/Feature/TenantReview/TenantReviewRegisterTest.php`, and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
---
|
||||
|
||||
## Dependencies & Execution Order
|
||||
|
||||
### Phase Dependencies
|
||||
|
||||
- **Setup (Phase 1)**: Starts immediately and prepares shared stale and partial fixtures.
|
||||
- **Foundational (Phase 2)**: Depends on Setup and blocks all story work until the central truth propagation seam is tightened.
|
||||
- **User Story 1 (Phase 3)**: Starts after Foundational and delivers the MVP stale-evidence visibility across key surfaces.
|
||||
- **User Story 2 (Phase 4)**: Starts after Foundational; it can build on User Story 1 or proceed immediately after the presenter seam is stable, but should follow US1 for the cleanest rollout.
|
||||
- **User Story 3 (Phase 5)**: Starts after Foundational and depends on tightened truth semantics from earlier phases to align canonical rows.
|
||||
- **Polish (Phase 6)**: Starts after the desired user stories are complete.
|
||||
|
||||
### User Story Dependencies
|
||||
|
||||
- **User Story 1 (P1)**: Depends only on the shared truth propagation seam from Phase 2.
|
||||
- **User Story 2 (P1)**: Depends on the shared truth propagation seam from Phase 2 and benefits from the stale-surface work in US1.
|
||||
- **User Story 3 (P2)**: Depends on the shared truth propagation seam from Phase 2 and should consume the tightened truth semantics delivered by US1 and US2.
|
||||
|
||||
### Within Each User Story
|
||||
|
||||
- Shared fixture work must land before story-specific tests rely on new stale or partial scenarios.
|
||||
- Tests should be updated before or alongside the related implementation tasks and must fail before the behavior change is considered complete.
|
||||
- `ArtifactTruthPresenter` changes should land before downstream Filament resource and page copy cleanup for the same story.
|
||||
- Focused story-level test runs should complete before moving to the next story.
|
||||
|
||||
### Parallel Opportunities
|
||||
|
||||
- `T001` and `T002` can run in parallel once the shared stale and partial scenario matrix is agreed.
|
||||
- `T005`, `T006`, and `T007` can run in parallel for User Story 1.
|
||||
- `T013` and `T014` can run in parallel for User Story 2.
|
||||
- `T019` and `T020` can run in parallel for User Story 3.
|
||||
- `T025` and `T026` can run in parallel once implementation work is complete.
|
||||
|
||||
---
|
||||
|
||||
## Parallel Example: User Story 1
|
||||
|
||||
```bash
|
||||
# Story 1 tests in parallel:
|
||||
Task: T005 tests/Feature/Evidence/EvidenceSnapshotResourceTest.php
|
||||
Task: T006 tests/Feature/Evidence/EvidenceOverviewPageTest.php
|
||||
Task: T007 tests/Feature/TenantReview/TenantReviewLifecycleTest.php and tests/Feature/ReviewPack/ReviewPackResourceTest.php
|
||||
|
||||
# Story 1 implementation split after truth propagation is stable:
|
||||
Task: T008 app/Filament/Resources/EvidenceSnapshotResource.php and app/Filament/Resources/EvidenceSnapshotResource/Pages/ViewEvidenceSnapshot.php
|
||||
Task: T009 app/Filament/Resources/TenantReviewResource.php and app/Filament/Resources/TenantReviewResource/Pages/ViewTenantReview.php
|
||||
Task: T010 app/Filament/Resources/ReviewPackResource.php and app/Filament/Resources/ReviewPackResource/Pages/ViewReviewPack.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 2
|
||||
|
||||
```bash
|
||||
# Story 2 tests in parallel:
|
||||
Task: T013 tests/Feature/TenantReview/TenantReviewLifecycleTest.php
|
||||
Task: T014 tests/Feature/ReviewPack/ReviewPackResourceTest.php
|
||||
|
||||
# Story 2 implementation split after failing assertions are in place:
|
||||
Task: T015 app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php and app/Filament/Resources/TenantReviewResource.php
|
||||
Task: T016 app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php and app/Filament/Resources/ReviewPackResource.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 3
|
||||
|
||||
```bash
|
||||
# Story 3 tests in parallel:
|
||||
Task: T019 tests/Feature/TenantReview/TenantReviewRegisterTest.php
|
||||
Task: T020 tests/Feature/Evidence/EvidenceOverviewPageTest.php and tests/Feature/TenantReview/TenantReviewRegisterTest.php
|
||||
|
||||
# Story 3 implementation split after row-level truth expectations are clear:
|
||||
Task: T021 app/Filament/Pages/Reviews/ReviewRegister.php
|
||||
Task: T022 app/Filament/Pages/Monitoring/EvidenceOverview.php and app/Filament/Pages/Reviews/ReviewRegister.php
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### MVP First (User Story 1 Only)
|
||||
|
||||
1. Complete Phase 1: Setup.
|
||||
2. Complete Phase 2: Foundational.
|
||||
3. Complete Phase 3: User Story 1.
|
||||
4. **STOP and VALIDATE**: Verify stale evidence is visible across snapshot, linked review, linked pack, and evidence overview surfaces.
|
||||
5. Deploy or demo if the MVP confidence level is sufficient.
|
||||
|
||||
### Incremental Delivery
|
||||
|
||||
1. Complete Setup + Foundational so the central truth seam is stable.
|
||||
2. Add User Story 1 and validate stale-evidence visibility.
|
||||
3. Add User Story 2 and validate internal-only versus publishable trust.
|
||||
4. Add User Story 3 and validate canonical summary alignment.
|
||||
5. Finish with cross-cutting copy, authorization non-regression, formatting, and focused verification.
|
||||
|
||||
### Parallel Team Strategy
|
||||
|
||||
With multiple developers:
|
||||
|
||||
1. Complete Setup + Foundational together.
|
||||
2. Once Foundational is done:
|
||||
- Developer A: User Story 1
|
||||
- Developer B: User Story 2
|
||||
- Developer C: User Story 3
|
||||
3. Reconcile in Phase 6 with shared copy, authorization non-regression, formatting, and final focused tests.
|
||||
|
||||
---
|
||||
|
||||
## Notes
|
||||
|
||||
- [P] tasks indicate different files and no dependency on incomplete predecessor tasks.
|
||||
- The same touched file may appear in multiple stories because each story hardens a different user-visible outcome on the same existing surface.
|
||||
- No task introduces a new persistence model, a new abstraction layer, or a new reporting subsystem.
|
||||
@ -0,0 +1,36 @@
|
||||
# Specification Quality Checklist: Spec 175 - Workspace Governance Attention Foundation
|
||||
|
||||
**Purpose**: Validate specification completeness and quality before proceeding to planning
|
||||
**Created**: 2026-04-04
|
||||
**Feature**: [spec.md](../spec.md)
|
||||
|
||||
## Content Quality
|
||||
|
||||
- [x] No implementation details (languages, frameworks, APIs)
|
||||
- [x] Focused on user value and business needs
|
||||
- [x] Written for non-technical stakeholders
|
||||
- [x] All mandatory sections completed
|
||||
|
||||
## Requirement Completeness
|
||||
|
||||
- [x] No [NEEDS CLARIFICATION] markers remain
|
||||
- [x] Requirements are testable and unambiguous
|
||||
- [x] Success criteria are measurable
|
||||
- [x] Success criteria are technology-agnostic (no implementation details)
|
||||
- [x] All acceptance scenarios are defined
|
||||
- [x] Edge cases are identified
|
||||
- [x] Scope is clearly bounded
|
||||
- [x] Dependencies and assumptions identified
|
||||
|
||||
## Feature Readiness
|
||||
|
||||
- [x] All functional requirements have clear acceptance criteria
|
||||
- [x] User scenarios cover primary flows
|
||||
- [x] Feature meets measurable outcomes defined in Success Criteria
|
||||
- [x] No implementation details leak into specification
|
||||
|
||||
## Notes
|
||||
|
||||
- Validation pass completed against the written spec on 2026-04-04.
|
||||
- No clarification markers were needed because the supplied feature description already defined scope, priorities, constraints, and desired outcomes precisely.
|
||||
- The spec stays intentionally narrow: it hardens existing workspace surfaces using already-available tenant truth and explicitly rejects new persistence, scores, or matrix-style redesign in this slice.
|
||||
@ -0,0 +1,541 @@
|
||||
openapi: 3.1.0
|
||||
info:
|
||||
title: Workspace Governance Attention Internal Surface Contract
|
||||
version: 0.1.0
|
||||
summary: Internal logical contract for governance-aware workspace overview semantics
|
||||
description: |
|
||||
This contract is an internal planning artifact for Spec 175. It documents how
|
||||
the existing workspace overview must derive governance-aware summary metrics,
|
||||
attention items, calmness claims, and drill-through destinations from visible
|
||||
tenant truth. The rendered routes still return HTML. The structured schemas
|
||||
below describe the internal page and widget models that must be derivable
|
||||
before rendering. This does not add a public HTTP API.
|
||||
servers:
|
||||
- url: /internal
|
||||
x-overview-consumers:
|
||||
- surface: workspace.overview.summary_stats
|
||||
summarySource:
|
||||
- workspace_overview_builder
|
||||
- tenant_governance_aggregate
|
||||
- operation_run_activity
|
||||
- alert_delivery_activity
|
||||
guardScope:
|
||||
- app/Support/Workspaces/WorkspaceOverviewBuilder.php
|
||||
- app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php
|
||||
expectedContract:
|
||||
- governance_metrics_count_visible_tenants_not_raw_issue_totals
|
||||
- governance_metrics_are_distinct_from_activity_metrics
|
||||
- surface: workspace.overview.needs_attention
|
||||
summarySource:
|
||||
- workspace_overview_builder
|
||||
- tenant_governance_aggregate
|
||||
- existing_evidence_review_truth
|
||||
- operation_run_activity
|
||||
- alert_delivery_activity
|
||||
guardScope:
|
||||
- app/Support/Workspaces/WorkspaceOverviewBuilder.php
|
||||
- app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php
|
||||
- resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php
|
||||
expectedContract:
|
||||
- each_item_identifies_the_visible_tenant_when_tenant_bound
|
||||
- all_attention_items_are_tenant_bound
|
||||
- governance_issues_rank_above_activity_only_items
|
||||
- compare_attention_only_uses_stale_or_compare_specific_action_required_signals
|
||||
- each_item_has_one_matching_destination_or_a_safe_disabled_state
|
||||
- surface: workspace.overview.calmness
|
||||
summarySource:
|
||||
- workspace_overview_builder
|
||||
- tenant_governance_aggregate
|
||||
- operation_run_activity
|
||||
- alert_delivery_activity
|
||||
guardScope:
|
||||
- app/Support/Workspaces/WorkspaceOverviewBuilder.php
|
||||
- resources/views/filament/pages/workspace-overview.blade.php
|
||||
expectedContract:
|
||||
- operations_quiet_alone_is_not_enough_for_calmness
|
||||
- zero_tenant_and_low_permission_states_do_not_masquerade_as_healthy_calm
|
||||
- zero_tenant_recovery_uses_switch_workspace_and_low_permission_recovery_uses_operations_index
|
||||
- surface: workspace.overview.recent_operations
|
||||
summarySource:
|
||||
- workspace_overview_builder
|
||||
- operation_run_recency_query
|
||||
guardScope:
|
||||
- app/Filament/Widgets/Workspace/WorkspaceRecentOperations.php
|
||||
- resources/views/filament/widgets/workspace/workspace-recent-operations.blade.php
|
||||
expectedContract:
|
||||
- surface_role_is_diagnostic_recency_not_primary_governance_summary
|
||||
- recent_operations_remain_filtered_to_visible_tenant_scope
|
||||
- recent_operations_are_bounded_to_five
|
||||
paths:
|
||||
/admin:
|
||||
get:
|
||||
summary: Render the governance-aware workspace overview bundle
|
||||
operationId: viewWorkspaceGovernanceAttentionOverview
|
||||
responses:
|
||||
'200':
|
||||
description: Workspace overview rendered with governance-aware summary, attention, calmness, and recency semantics
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.workspace-governance-attention+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/WorkspaceGovernanceOverviewBundle'
|
||||
'302':
|
||||
description: No workspace context is active yet, so the request is redirected to `/admin/choose-workspace`
|
||||
'404':
|
||||
description: Workspace is outside entitlement scope
|
||||
/admin/choose-tenant:
|
||||
get:
|
||||
summary: Explicit tenant-entry destination used by workspace drill-down when the operator wants to pick a tenant deliberately
|
||||
operationId: openChooseTenantFromWorkspaceOverview
|
||||
responses:
|
||||
'200':
|
||||
description: Choose-tenant page opened inside the authenticated admin panel and may bootstrap workspace context from the selected tenant if no workspace is currently active
|
||||
/admin/choose-workspace:
|
||||
get:
|
||||
summary: Default workspace-switch recovery destination for zero-tenant or wrong-workspace states
|
||||
operationId: openChooseWorkspaceFromWorkspaceOverview
|
||||
responses:
|
||||
'200':
|
||||
description: Choose-workspace page opened so the operator can recover to another entitled workspace context even when no workspace is currently active
|
||||
/admin/t/{tenant}:
|
||||
get:
|
||||
summary: Tenant dashboard fallback or broad tenant drill-through from workspace attention
|
||||
operationId: openTenantDashboardFromWorkspaceAttention
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant dashboard opened for the visible tenant named by the workspace item when the dashboard is the allowed fallback or primary tenant landing
|
||||
'404':
|
||||
description: Tenant is outside entitlement scope
|
||||
/admin/t/{tenant}/findings:
|
||||
get:
|
||||
summary: Tenant findings destination used by workspace governance and findings attention
|
||||
operationId: openTenantFindingsFromWorkspaceAttention
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: tab
|
||||
in: query
|
||||
required: false
|
||||
schema:
|
||||
$ref: '#/components/schemas/FindingsTab'
|
||||
- name: high_severity
|
||||
in: query
|
||||
required: false
|
||||
schema:
|
||||
type: boolean
|
||||
- name: governance_validity
|
||||
in: query
|
||||
required: false
|
||||
schema:
|
||||
$ref: '#/components/schemas/GovernanceValidityFilter'
|
||||
description: Reproduces directly filterable governance-validity subsets such as `missing_support` or `expiring`; aggregate lapsed-governance attention falls back to the tenant dashboard when the full invalid-governance family cannot be reproduced without narrowing.
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant findings list opened with a subset matching the originating workspace attention item
|
||||
'403':
|
||||
description: Actor is in scope but lacks findings inspection capability
|
||||
'404':
|
||||
description: Tenant is outside entitlement scope
|
||||
/admin/t/{tenant}/baseline-compare-landing:
|
||||
get:
|
||||
summary: Tenant baseline compare landing used by workspace compare attention
|
||||
operationId: openTenantBaselineCompareFromWorkspaceAttention
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant baseline compare landing opened with the same compare posture family summarized by the workspace item
|
||||
'403':
|
||||
description: Actor is in scope but lacks the current tenant-view capability required by the compare landing
|
||||
'404':
|
||||
description: Tenant is outside entitlement scope
|
||||
/admin/t/{tenant}/evidence:
|
||||
get:
|
||||
summary: Tenant evidence destination used only when existing evidence truth is the most precise workspace next jump
|
||||
operationId: openTenantEvidenceFromWorkspaceAttention
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant evidence surface opened for the visible tenant named by the workspace item
|
||||
'403':
|
||||
description: Actor is in scope but lacks evidence inspection capability
|
||||
'404':
|
||||
description: Tenant is outside entitlement scope
|
||||
/admin/t/{tenant}/reviews:
|
||||
get:
|
||||
summary: Tenant reviews destination used only when existing review truth is the most precise workspace next jump
|
||||
operationId: openTenantReviewsFromWorkspaceAttention
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant reviews surface opened for the visible tenant named by the workspace item
|
||||
'403':
|
||||
description: Actor is in scope but lacks review inspection capability
|
||||
'404':
|
||||
description: Tenant is outside entitlement scope
|
||||
/admin/operations:
|
||||
get:
|
||||
summary: Canonical operations index used by workspace activity and operations-follow-up signals
|
||||
operationId: openOperationsFromWorkspaceOverview
|
||||
parameters:
|
||||
- name: tenant_id
|
||||
in: query
|
||||
required: false
|
||||
schema:
|
||||
type:
|
||||
- integer
|
||||
- string
|
||||
description: Optional tenant filter when the workspace item points to one tenant's operations follow-up.
|
||||
- name: activeTab
|
||||
in: query
|
||||
required: false
|
||||
schema:
|
||||
$ref: '#/components/schemas/OperationsTab'
|
||||
responses:
|
||||
'200':
|
||||
description: Canonical operations index opened with any tenant and tab continuity required by the workspace signal; this remains the workspace-member-safe fallback for low-permission workspace states
|
||||
'404':
|
||||
description: Requested tenant context is outside entitlement scope
|
||||
/admin/operations/{run}:
|
||||
get:
|
||||
summary: Canonical operation detail opened from workspace recent operations or operations attention
|
||||
operationId: openOperationDetailFromWorkspaceOverview
|
||||
parameters:
|
||||
- name: run
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type:
|
||||
- integer
|
||||
- string
|
||||
responses:
|
||||
'200':
|
||||
description: Canonical operation detail opened for the visible run
|
||||
'403':
|
||||
description: Actor is in scope but lacks operation detail capability
|
||||
'404':
|
||||
description: Operation run is outside entitlement scope
|
||||
/admin/alerts:
|
||||
get:
|
||||
summary: Canonical alerts overview used for alert-only follow-up from the workspace home
|
||||
operationId: openAlertsOverviewFromWorkspaceOverview
|
||||
responses:
|
||||
'200':
|
||||
description: Alerts overview opened for the current workspace, including delivery follow-up and alert-health context
|
||||
'403':
|
||||
description: Actor is in scope but lacks alerts inspection capability
|
||||
'404':
|
||||
description: Workspace is outside entitlement scope
|
||||
components:
|
||||
schemas:
|
||||
MetricCategory:
|
||||
type: string
|
||||
enum:
|
||||
- scope
|
||||
- governance_risk
|
||||
- activity
|
||||
- alerts
|
||||
AttentionFamily:
|
||||
type: string
|
||||
enum:
|
||||
- governance
|
||||
- findings
|
||||
- compare
|
||||
- evidence
|
||||
- review
|
||||
- operations
|
||||
- alerts
|
||||
AttentionUrgency:
|
||||
type: string
|
||||
enum:
|
||||
- critical
|
||||
- high
|
||||
- medium
|
||||
- supporting
|
||||
DestinationKind:
|
||||
type: string
|
||||
enum:
|
||||
- choose_tenant
|
||||
- tenant_dashboard
|
||||
- tenant_findings
|
||||
- baseline_compare_landing
|
||||
- tenant_evidence
|
||||
- tenant_reviews
|
||||
- operations_index
|
||||
- operation_detail
|
||||
- alerts_overview
|
||||
- switch_workspace
|
||||
- none
|
||||
CheckedDomain:
|
||||
type: string
|
||||
enum:
|
||||
- governance
|
||||
- findings
|
||||
- compare
|
||||
- evidence
|
||||
- review
|
||||
- operations
|
||||
- alerts
|
||||
- tenant_access
|
||||
FindingsTab:
|
||||
type: string
|
||||
enum:
|
||||
- all
|
||||
- needs_action
|
||||
- overdue
|
||||
- risk_accepted
|
||||
- resolved
|
||||
GovernanceValidityFilter:
|
||||
type: string
|
||||
enum:
|
||||
- missing_support
|
||||
- expiring
|
||||
- valid
|
||||
OperationsTab:
|
||||
type: string
|
||||
enum:
|
||||
- all
|
||||
- active
|
||||
- blocked
|
||||
- failed
|
||||
- partial
|
||||
- succeeded
|
||||
DrillthroughTarget:
|
||||
type: object
|
||||
additionalProperties: false
|
||||
required:
|
||||
- kind
|
||||
- disabled
|
||||
properties:
|
||||
kind:
|
||||
$ref: '#/components/schemas/DestinationKind'
|
||||
url:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
tenantRouteKey:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
label:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
disabled:
|
||||
type: boolean
|
||||
helperText:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
filters:
|
||||
type:
|
||||
- object
|
||||
- 'null'
|
||||
additionalProperties: true
|
||||
WorkspaceSummaryMetric:
|
||||
type: object
|
||||
additionalProperties: false
|
||||
required:
|
||||
- key
|
||||
- label
|
||||
- value
|
||||
- category
|
||||
- description
|
||||
- color
|
||||
properties:
|
||||
key:
|
||||
type: string
|
||||
label:
|
||||
type: string
|
||||
value:
|
||||
type: integer
|
||||
minimum: 0
|
||||
category:
|
||||
$ref: '#/components/schemas/MetricCategory'
|
||||
description:
|
||||
type: string
|
||||
color:
|
||||
type: string
|
||||
destination:
|
||||
oneOf:
|
||||
- $ref: '#/components/schemas/DrillthroughTarget'
|
||||
- type: 'null'
|
||||
WorkspaceAttentionItem:
|
||||
type: object
|
||||
additionalProperties: false
|
||||
required:
|
||||
- key
|
||||
- tenantId
|
||||
- tenantLabel
|
||||
- family
|
||||
- urgency
|
||||
- title
|
||||
- body
|
||||
- badge
|
||||
- badgeColor
|
||||
anyOf:
|
||||
- required:
|
||||
- destination
|
||||
properties:
|
||||
destination:
|
||||
$ref: '#/components/schemas/DrillthroughTarget'
|
||||
- required:
|
||||
- actionDisabled
|
||||
- helperText
|
||||
properties:
|
||||
actionDisabled:
|
||||
const: true
|
||||
helperText:
|
||||
type: string
|
||||
properties:
|
||||
key:
|
||||
type: string
|
||||
tenantId:
|
||||
type: integer
|
||||
tenantLabel:
|
||||
type: string
|
||||
family:
|
||||
$ref: '#/components/schemas/AttentionFamily'
|
||||
urgency:
|
||||
$ref: '#/components/schemas/AttentionUrgency'
|
||||
title:
|
||||
type: string
|
||||
body:
|
||||
type: string
|
||||
supportingMessage:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
badge:
|
||||
type: string
|
||||
badgeColor:
|
||||
type: string
|
||||
destination:
|
||||
oneOf:
|
||||
- $ref: '#/components/schemas/DrillthroughTarget'
|
||||
- type: 'null'
|
||||
actionDisabled:
|
||||
type:
|
||||
- boolean
|
||||
- 'null'
|
||||
helperText:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
WorkspaceRecentOperation:
|
||||
type: object
|
||||
additionalProperties: false
|
||||
required:
|
||||
- id
|
||||
- title
|
||||
- statusLabel
|
||||
- statusColor
|
||||
- outcomeLabel
|
||||
- outcomeColor
|
||||
- startedAt
|
||||
- destination
|
||||
properties:
|
||||
id:
|
||||
type: integer
|
||||
title:
|
||||
type: string
|
||||
tenantLabel:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
statusLabel:
|
||||
type: string
|
||||
statusColor:
|
||||
type: string
|
||||
outcomeLabel:
|
||||
type: string
|
||||
outcomeColor:
|
||||
type: string
|
||||
guidance:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
startedAt:
|
||||
type: string
|
||||
destination:
|
||||
$ref: '#/components/schemas/DrillthroughTarget'
|
||||
WorkspaceCalmnessState:
|
||||
type: object
|
||||
additionalProperties: false
|
||||
required:
|
||||
- isCalm
|
||||
- checkedDomains
|
||||
- title
|
||||
- body
|
||||
- nextAction
|
||||
properties:
|
||||
isCalm:
|
||||
type: boolean
|
||||
checkedDomains:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/CheckedDomain'
|
||||
title:
|
||||
type: string
|
||||
body:
|
||||
type: string
|
||||
nextAction:
|
||||
description: Defaults to `switch_workspace` for zero-tenant recovery and `operations_index` for low-permission workspace-state recovery unless a more specific allowed action exists.
|
||||
$ref: '#/components/schemas/DrillthroughTarget'
|
||||
WorkspaceGovernanceOverviewBundle:
|
||||
type: object
|
||||
additionalProperties: false
|
||||
required:
|
||||
- workspaceId
|
||||
- workspaceName
|
||||
- summaryMetrics
|
||||
- attentionItems
|
||||
- recentOperations
|
||||
- calmness
|
||||
properties:
|
||||
workspaceId:
|
||||
type: integer
|
||||
workspaceName:
|
||||
type: string
|
||||
summaryMetrics:
|
||||
type: array
|
||||
maxItems: 8
|
||||
items:
|
||||
$ref: '#/components/schemas/WorkspaceSummaryMetric'
|
||||
attentionItems:
|
||||
type: array
|
||||
maxItems: 5
|
||||
items:
|
||||
$ref: '#/components/schemas/WorkspaceAttentionItem'
|
||||
recentOperations:
|
||||
type: array
|
||||
maxItems: 5
|
||||
items:
|
||||
$ref: '#/components/schemas/WorkspaceRecentOperation'
|
||||
calmness:
|
||||
$ref: '#/components/schemas/WorkspaceCalmnessState'
|
||||
313
specs/175-workspace-governance-attention/data-model.md
Normal file
313
specs/175-workspace-governance-attention/data-model.md
Normal file
@ -0,0 +1,313 @@
|
||||
# Phase 1 Data Model: Workspace Governance Attention Foundation
|
||||
|
||||
## Overview
|
||||
|
||||
This feature does not add a table, persisted workspace summary, or new cross-domain runtime subsystem. It aligns the existing workspace overview surface with already-available tenant truth so the workspace home can answer which visible tenants need governance attention, why they need it, and where the operator should jump next.
|
||||
|
||||
## Persistent Source Truths
|
||||
|
||||
### Workspace
|
||||
|
||||
**Purpose**: Scope boundary for the workspace home and all workspace-safe aggregates.
|
||||
|
||||
**Key fields**:
|
||||
- `id`
|
||||
- `name`
|
||||
- `slug`
|
||||
|
||||
**Validation rules**:
|
||||
- Workspace overview aggregation must always resolve for one explicit workspace.
|
||||
- Non-members must receive deny-as-not-found behavior before any workspace truth is rendered.
|
||||
|
||||
### Tenant
|
||||
|
||||
**Purpose**: Scope boundary and identity anchor for every governance-aware workspace attention item.
|
||||
|
||||
**Key fields**:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `external_id`
|
||||
- `name`
|
||||
- `status`
|
||||
|
||||
**Validation rules**:
|
||||
- Only active tenants inside the current workspace and inside the current user's entitled tenant slice may contribute to workspace attention or governance-risk metrics.
|
||||
- Every workspace attention item must identify one visible tenant explicitly.
|
||||
|
||||
### Finding
|
||||
|
||||
**Purpose**: Source of overdue findings, high-severity active findings, and other governance workflow pressure promoted into workspace attention.
|
||||
|
||||
**Key fields**:
|
||||
- `tenant_id`
|
||||
- `workspace_id`
|
||||
- `finding_type`
|
||||
- `status`
|
||||
- `severity`
|
||||
- `due_at`
|
||||
- `scope_key`
|
||||
|
||||
**Validation rules**:
|
||||
- Canonical open and active semantics remain sourced from existing finding query helpers.
|
||||
- Workspace promotion must not invent a second finding status universe.
|
||||
|
||||
### FindingException / Governance Validity
|
||||
|
||||
**Purpose**: Source of lapsed governance and expiring governance truth for risk-accepted findings.
|
||||
|
||||
**Key fields**:
|
||||
- `tenant_id`
|
||||
- `workspace_id`
|
||||
- `finding_id`
|
||||
- `status`
|
||||
- `current_validity_state`
|
||||
- `review_due_at`
|
||||
- `expires_at`
|
||||
|
||||
**Validation rules**:
|
||||
- Lapsed and expiring governance remain derived from existing validity-state rules.
|
||||
- Workspace promotion must not replace existing governance-validity semantics with a new workspace-specific status family.
|
||||
|
||||
### OperationRun
|
||||
|
||||
**Purpose**: Source of workspace activity, operation failures, and canonical operation drill-through.
|
||||
|
||||
**Key fields**:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `type`
|
||||
- `status`
|
||||
- `outcome`
|
||||
- `created_at`
|
||||
- `completed_at`
|
||||
|
||||
**Validation rules**:
|
||||
- Active operations and failed or warning operations remain activity truths, not governance truths.
|
||||
- Workspace attention may still include operations follow-up, but those items must remain semantically distinct from governance items.
|
||||
|
||||
### AlertDelivery
|
||||
|
||||
**Purpose**: Source of workspace alert-delivery failures that remain supporting attention but no longer define workspace calmness by themselves.
|
||||
|
||||
**Key fields**:
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `status`
|
||||
- `created_at`
|
||||
|
||||
**Validation rules**:
|
||||
- Alert-delivery failures remain lower-priority supporting signals once governance-critical tenant states exist.
|
||||
|
||||
### EvidenceSnapshot and TenantReview
|
||||
|
||||
**Purpose**: Existing tenant-level evidence and review truth that may serve as a precise workspace drill-through target when already-available truth makes them the best next jump.
|
||||
|
||||
**Key fields**:
|
||||
- `tenant_id`
|
||||
- `workspace_id`
|
||||
- `status` or completeness fields on the owning model
|
||||
- associated detail identifiers needed by tenant evidence or review resources
|
||||
|
||||
**Validation rules**:
|
||||
- This slice does not add a new workspace evidence or review aggregate.
|
||||
- Evidence or review destinations may only be used when existing tenant truth already makes them the most precise action target.
|
||||
|
||||
## Existing Runtime Source Objects
|
||||
|
||||
### TenantGovernanceAggregate
|
||||
|
||||
**Purpose**: Existing derived tenant summary that already combines compare posture with overdue, expiring, lapsed, and high-severity counts.
|
||||
|
||||
**Key consumed fields**:
|
||||
- `tenantId`
|
||||
- `workspaceId`
|
||||
- `compareState`
|
||||
- `stateFamily`
|
||||
- `tone`
|
||||
- `headline`
|
||||
- `supportingMessage`
|
||||
- `overdueOpenFindingsCount`
|
||||
- `expiringGovernanceCount`
|
||||
- `lapsedGovernanceCount`
|
||||
- `highSeverityActiveFindingsCount`
|
||||
- `nextActionLabel`
|
||||
- `nextActionTarget`
|
||||
- `positiveClaimAllowed`
|
||||
- `summaryAssessment`
|
||||
|
||||
**Validation rules**:
|
||||
- Workspace promotion should consume this existing summary contract before considering lower-level recomputation.
|
||||
- Any workspace calmness or ranking rule based on compare or governance must remain consistent with this aggregate.
|
||||
|
||||
### BaselineCompareStats
|
||||
|
||||
**Purpose**: Existing compare-backed statistics object underlying the tenant governance aggregate.
|
||||
|
||||
**Key consumed fields**:
|
||||
- `overdueOpenFindingsCount`
|
||||
- `expiringGovernanceCount`
|
||||
- `lapsedGovernanceCount`
|
||||
- `highSeverityActiveFindingsCount`
|
||||
- compare posture state and evidence-gap fields needed by `summaryAssessment`
|
||||
|
||||
**Validation rules**:
|
||||
- Workspace code should not fork a second compare-summary model while this object already provides the necessary facts.
|
||||
|
||||
### BaselineCompareSummaryAssessment
|
||||
|
||||
**Purpose**: Existing compare posture contract that maps compare stats into a state family, tone, headline, and next-action intent.
|
||||
|
||||
**Key consumed fields**:
|
||||
- `stateFamily`
|
||||
- `tone`
|
||||
- `headline`
|
||||
- `supportingMessage`
|
||||
- `reasonCode`
|
||||
- `nextActionTarget()` semantics as reflected into the aggregate
|
||||
|
||||
**Validation rules**:
|
||||
- Workspace compare attention and calmness suppression should reuse this assessment path rather than inventing a workspace-only tone system.
|
||||
|
||||
### WorkspaceOverviewBuilder Payload
|
||||
|
||||
**Purpose**: Existing page-level payload that already carries summary metrics, attention items, recent operations, quick actions, and empty states for `/admin`.
|
||||
|
||||
**Validation rules**:
|
||||
- Governance hardening extends this payload shape rather than replacing the page with a new surface framework.
|
||||
- Existing visible-tenant filtering remains the workspace aggregation guardrail.
|
||||
|
||||
## Derived Workspace View Contracts
|
||||
|
||||
### Workspace Summary Metric
|
||||
|
||||
**Purpose**: Compact workspace stat that answers one scope, governance-risk, or activity question and optionally opens one matching destination.
|
||||
|
||||
#### Fields
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `key` | string | yes | Stable metric identity such as `accessible_tenants`, `governance_attention_tenants`, `overdue_findings_tenants`, or `active_operations` |
|
||||
| `label` | string | yes | Operator-facing label that must accurately describe the counted universe |
|
||||
| `value` | integer | yes | Metric value |
|
||||
| `category` | enum | yes | `scope`, `governance_risk`, `activity`, or `alerts` |
|
||||
| `description` | string | yes | Short explanation of what the metric means |
|
||||
| `color` | string | yes | Existing tone family used by the widget |
|
||||
| `destination` | object nullable | no | Shared drill-through contract when the metric is actionable |
|
||||
|
||||
#### Validation rules
|
||||
|
||||
- Governance-risk metrics count affected visible tenants, not raw issue totals.
|
||||
- Activity metrics remain activity-only and must not imply governance health.
|
||||
- The stat strip must make the difference between `governance_risk` and `activity` categories obvious.
|
||||
|
||||
### Workspace Attention Item
|
||||
|
||||
**Purpose**: One prioritized workspace triage item that names a visible tenant problem and one next jump.
|
||||
|
||||
#### Fields
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `key` | string | yes | Stable attention identity such as `tenant_overdue_findings`, `tenant_lapsed_governance`, `tenant_compare_attention`, or `tenant_failed_operation` |
|
||||
| `tenantId` | integer | yes | Visible tenant identifier |
|
||||
| `tenantLabel` | string | yes | Tenant name shown to the operator |
|
||||
| `family` | enum | yes | `governance`, `findings`, `compare`, `evidence`, `review`, `operations`, or `alerts` |
|
||||
| `urgency` | enum | yes | `critical`, `high`, `medium`, or `supporting` |
|
||||
| `title` | string | yes | Primary operator-facing summary |
|
||||
| `body` | string | yes | Short explanation of why this needs attention |
|
||||
| `badge` | string | yes | Existing family label shown in the UI |
|
||||
| `badgeColor` | string | yes | Existing tone family used for the item |
|
||||
| `supportingMessage` | string nullable | no | Secondary explanatory text when needed |
|
||||
| `destination` | object nullable | no | Shared drill-through contract |
|
||||
| `actionDisabled` | boolean nullable | no | Whether the visible next step is intentionally disabled |
|
||||
| `helperText` | string nullable | no | Explanation when the visible next step is disabled |
|
||||
|
||||
#### Validation rules
|
||||
|
||||
- Every workspace attention item is tenant-bound and must include both `tenantId` and `tenantLabel`.
|
||||
- Governance, findings, compare, evidence or review, and operations items must remain semantically distinct.
|
||||
- Compare attention promotes `BaselineCompareSummaryAssessment::STATE_STALE` directly and only treats `BaselineCompareSummaryAssessment::STATE_ACTION_REQUIRED` as materially degraded compare posture when the aggregate's next action remains compare-specific rather than findings-driven.
|
||||
- `BaselineCompareSummaryAssessment::STATE_CAUTION` stays below the workspace-attention threshold unless another governance signal independently warrants promotion.
|
||||
- Workspace-wide operations or alert totals remain in summary metrics or recent operations until they can be attributed to one visible tenant.
|
||||
- Each item may expose one primary destination only.
|
||||
- Every item must either expose a non-null destination or set `actionDisabled=true` with explanatory `helperText`; null destination without an explicit disabled state is invalid.
|
||||
- If the most precise destination is not available to the current in-scope user, the item must either use an allowed fallback or expose a disabled explanatory state instead of a clickable dead end.
|
||||
|
||||
### Workspace Recent Operation
|
||||
|
||||
**Purpose**: One bounded recent-operations entry shown on the workspace overview as diagnostic recency, not governance posture.
|
||||
|
||||
#### Fields
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `id` | integer | yes | Operation run identifier |
|
||||
| `title` | string | yes | Operator-facing operation label |
|
||||
| `tenantLabel` | string nullable | no | Tenant name when the run is tenant-bound |
|
||||
| `statusLabel` | string | yes | Human-readable run status |
|
||||
| `statusColor` | string | yes | Existing tone family for the run status |
|
||||
| `outcomeLabel` | string | yes | Human-readable run outcome |
|
||||
| `outcomeColor` | string | yes | Existing tone family for the run outcome |
|
||||
| `guidance` | string nullable | no | Short follow-up guidance when helpful |
|
||||
| `startedAt` | string | yes | Render-ready recency label |
|
||||
| `destination` | object | yes | Canonical operation-detail drill-through target |
|
||||
|
||||
#### Validation rules
|
||||
|
||||
- The recent-operations collection is bounded to the five most recent visible runs.
|
||||
- Recent operations remain diagnostic context and do not define calmness on their own.
|
||||
- `tenantLabel` may be null only when the run is genuinely workspace-wide rather than tenant-bound.
|
||||
|
||||
### Workspace Drill-Through Target
|
||||
|
||||
**Purpose**: Shared navigation contract used by summary metrics and attention items.
|
||||
|
||||
#### Fields
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `kind` | enum | yes | `choose_tenant`, `tenant_dashboard`, `tenant_findings`, `baseline_compare_landing`, `tenant_evidence`, `tenant_reviews`, `operations_index`, `operation_detail`, `alerts_overview`, `switch_workspace`, or `none` |
|
||||
| `url` | string nullable | no | Destination URL when the target is actionable |
|
||||
| `tenantRouteKey` | string nullable | no | Tenant route scope when the destination is tenant-bound |
|
||||
| `filters` | object nullable | no | Query or state needed to reproduce the same subset on the destination |
|
||||
| `label` | string nullable | no | Primary action label |
|
||||
| `disabled` | boolean | yes | Whether the target is intentionally non-clickable |
|
||||
| `helperText` | string nullable | no | Explanation shown when the target is disabled |
|
||||
|
||||
#### Validation rules
|
||||
|
||||
- `kind=none` may only be used for intentionally passive reassurance states.
|
||||
- `tenant_findings` must carry the filter state needed to reproduce overdue, high-severity, expiring-governance, or other directly filterable findings subsets when applicable.
|
||||
- Aggregate lapsed-governance attention uses `tenant_dashboard` when the current tenant findings filters would otherwise narrow the full invalid-governance family to a smaller subset such as `missing_support`.
|
||||
- `operations_index` may carry tenant and tab filters but must remain the canonical admin operations route and the workspace-member-safe fallback for low-permission workspace states.
|
||||
- `alerts_overview` targets the existing alerts overview at `/admin/alerts`, which remains the canonical alert-delivery follow-up surface for this slice.
|
||||
- `switch_workspace` targets `/admin/choose-workspace` and is the default zero-tenant recovery action.
|
||||
|
||||
### Workspace Calmness State
|
||||
|
||||
**Purpose**: The derived claim that the workspace is currently calm enough for an empty or reassurance state.
|
||||
|
||||
#### Fields
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `isCalm` | boolean | yes | Whether the workspace may currently make a calmness claim |
|
||||
| `checkedDomains` | array<enum> | yes | Domains actually checked before the claim was made: `governance`, `findings`, `compare`, `evidence`, `review`, `operations`, `alerts`, `tenant_access` |
|
||||
| `title` | string | yes | Empty-state or reassurance title |
|
||||
| `body` | string | yes | Supporting explanation constrained to the checked domains |
|
||||
| `nextAction` | object | yes | One bounded next action |
|
||||
|
||||
#### Validation rules
|
||||
|
||||
- `isCalm=true` is invalid whenever any visible tenant has governance-critical conditions inside the checked domains.
|
||||
- Zero-tenant states and low-permission states must not masquerade as healthy calmness states.
|
||||
- Zero-tenant states default `nextAction.kind` to `switch_workspace`, while low-permission states default `nextAction.kind` to `operations_index` unless a more specific allowed in-scope recovery action exists.
|
||||
- Calm wording must not imply portfolio health beyond the `checkedDomains` list.
|
||||
|
||||
## Ranking Rules
|
||||
|
||||
1. Governance-critical tenant conditions outrank activity-only and alert-only items.
|
||||
2. A single tenant may contribute multiple raw issues, but workspace attention should surface a bounded prioritized subset.
|
||||
3. The stat strip answers portfolio counts by tenant, while the attention list answers which tenant to open next.
|
||||
4. Recent operations remain supporting recency context and do not participate in calmness unless explicitly modeled as an operations-follow-up issue.
|
||||
332
specs/175-workspace-governance-attention/plan.md
Normal file
332
specs/175-workspace-governance-attention/plan.md
Normal file
@ -0,0 +1,332 @@
|
||||
# Implementation Plan: Workspace Governance Attention Foundation
|
||||
|
||||
**Branch**: `175-workspace-governance-attention` | **Date**: 2026-04-04 | **Spec**: `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/175-workspace-governance-attention/spec.md`
|
||||
**Input**: Feature specification from `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/175-workspace-governance-attention/spec.md`
|
||||
|
||||
**Note**: This plan follows the existing TenantPilot workspace and tenant-truth architecture. It hardens the current workspace overview instead of introducing a new workspace posture subsystem.
|
||||
|
||||
## Summary
|
||||
|
||||
Promote existing tenant governance truth into the existing workspace overview so `/admin` becomes a trustworthy multi-tenant governance attention surface instead of an operations-first calm surface. The implementation will keep `WorkspaceOverviewBuilder` as the orchestration point, reuse `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, existing findings and compare destinations, and optionally already-available evidence or review surfaces where they provide a more precise next jump. The first slice will harden summary metrics, attention ranking, tenant identification, compare breadth across stale, failed, and degraded states, and calmness semantics; the second slice will preserve activity versus governance separation and protect the new contract with focused workspace overview regression tests.
|
||||
|
||||
## Technical Context
|
||||
|
||||
**Language/Version**: PHP 8.4.15
|
||||
**Primary Dependencies**: Laravel 12, Filament v5, Livewire v4, Pest v4, existing `WorkspaceOverviewBuilder`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `WorkspaceSummaryStats`, `WorkspaceNeedsAttention`, `WorkspaceRecentOperations`, `WorkspaceCapabilityResolver`, `CapabilityResolver`, `FindingResource`, `BaselineCompareLanding`, `EvidenceSnapshotResource`, `TenantReviewResource`, and canonical admin Operations routes
|
||||
**Storage**: PostgreSQL unchanged; no new persistence, cache table, or materialized aggregate is introduced
|
||||
**Testing**: Pest 4 feature and Livewire-style widget tests through Laravel Sail using existing workspace overview tests plus new governance attention and drill-through coverage
|
||||
**Target Platform**: Laravel monolith web application in Sail locally and containerized Linux deployment in staging and production
|
||||
**Project Type**: web application
|
||||
**Performance Goals**: Keep `/admin` DB-only at render time, keep workspace attention bounded, reuse request-scoped derived-state caching for tenant governance aggregates, and avoid uncontrolled polling or unbounded cross-tenant queries
|
||||
**Constraints**: No new table, no new workspace posture score, no full portfolio matrix, no new panel/provider, no cross-tenant leakage, no dead-end drill-throughs for visible states, no ad-hoc status taxonomy, and no broad workspace IA redesign
|
||||
**Scale/Scope**: One workspace landing page, three existing workspace widgets, one builder, one accessible-tenant slice per workspace, six central governance signal families, and focused regression coverage for workspace calmness, ranking, drill-through continuity, and RBAC-safe omission or fallback behavior
|
||||
|
||||
## Constitution Check
|
||||
|
||||
*GATE: Passed before Phase 0 research. Re-check after Phase 1 design.*
|
||||
|
||||
| Principle | Pre-Research | Post-Design | Notes |
|
||||
|-----------|--------------|-------------|-------|
|
||||
| Inventory-first / snapshots-second | PASS | PASS | The feature adds no new inventory or snapshot truth. It only changes read-time workspace aggregation over existing records. |
|
||||
| Read/write separation | PASS | PASS | The slice is read-only workspace overview hardening. No new write path, preview flow, or destructive action is introduced. |
|
||||
| Graph contract path | N/A | N/A | No Graph call or `config/graph_contracts.php` change is required. |
|
||||
| Deterministic capabilities | PASS | PASS | Existing workspace membership and tenant capability checks remain authoritative for aggregation and drill-through behavior. |
|
||||
| RBAC-UX authorization semantics | PASS | PASS | `/admin` remains workspace-scoped, tenant destinations remain tenant-scoped, non-members stay `404`, and members missing downstream capability must not receive dead-end links. |
|
||||
| Workspace and tenant isolation | PASS | PASS | Aggregation stays limited to visible tenants in the active workspace and uses existing `scopeToAuthorizedTenants()` style filtering. |
|
||||
| Run observability / Ops-UX | PASS | PASS | No new `OperationRun` type, feedback surface, or lifecycle change is added. Existing operations destinations remain canonical. |
|
||||
| Data minimization | PASS | PASS | The plan adds no new persistence and no broader route exposure. Only already-visible tenant truth is promoted into the workspace home. |
|
||||
| Proportionality / no premature abstraction | PASS | PASS | The plan reuses `WorkspaceOverviewBuilder` and `TenantGovernanceAggregateResolver` instead of adding a new workspace posture framework or aggregate layer. |
|
||||
| Persisted truth / behavioral state | PASS | PASS | No new table, enum, status family, or persisted summary artifact is planned. |
|
||||
| UI semantics / few layers | PASS | PASS | The feature aligns existing widget semantics rather than introducing a new presenter or badge taxonomy. |
|
||||
| Badge semantics (BADGE-001) | PASS | PASS | Existing badge and tone domains remain the source for operations and compare posture meaning. New workspace items reuse those semantics rather than inventing new colors or labels. |
|
||||
| Filament-native UI / Action Surface Contract | PASS | PASS | `WorkspaceOverview` and its widgets remain navigation and inspection surfaces only. No destructive or redundant action model is added. |
|
||||
| Filament UX-001 | PASS | PASS | No create or edit page is touched. The design keeps governance attention above recent operations and uses bounded empty-state wording. |
|
||||
| Filament v5 / Livewire v4 compliance | PASS | PASS | The design stays within the current Filament v5 + Livewire v4 stack. |
|
||||
| Provider registration location | PASS | PASS | No panel/provider registration change is required. Laravel 11+ provider registration remains in `bootstrap/providers.php`. |
|
||||
| Global search hard rule | PASS | PASS | No global-searchable resource behavior is changed in this slice. |
|
||||
| Destructive action safety | PASS | PASS | The feature introduces no destructive action. |
|
||||
| Asset strategy | PASS | PASS | No new assets or `filament:assets` deployment change is required. |
|
||||
| Testing truth (TEST-TRUTH-001) | PASS | PASS | The plan adds tests around business consequences: false calmness, tenant identification, ordering, continuity, and RBAC-safe navigation behavior. |
|
||||
|
||||
## Phase 0 Research
|
||||
|
||||
Research outcomes are captured in `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/175-workspace-governance-attention/research.md`.
|
||||
|
||||
Key decisions:
|
||||
|
||||
- Reuse `WorkspaceOverviewBuilder` as the single orchestration point instead of creating a new workspace posture service.
|
||||
- Reuse `TenantGovernanceAggregateResolver` and `BaselineCompareStats` per visible tenant as the primary source for lapsed governance, overdue findings, expiring governance, high-severity active findings, and stale, failed, or materially degraded compare posture.
|
||||
- Count governance risk at the tenant level for workspace summary metrics so the workspace answer is “how many tenants need attention,” not “how many raw issues exist.”
|
||||
- Rank governance-critical tenant states above activity-only or alert-delivery-only items, while keeping operations and alerts available as lower-priority supporting attention.
|
||||
- Make every workspace attention item tenant-identifiable and map it to exactly one matching destination, with an RBAC-safe fallback or disabled/non-clickable explanatory state when the exact destination is not allowed.
|
||||
- Default zero-tenant recovery to the existing choose-workspace route and keep alert-only follow-up on the existing alerts overview route.
|
||||
- Keep `WorkspaceRecentOperations` as a diagnostic activity surface, not a governance surface.
|
||||
- Promote evidence or review truth only when an existing tenant-level evidence or review surface already carries a clearer next jump than the tenant dashboard fallback.
|
||||
- Lean on request-scoped derived-state caching to keep per-tenant aggregate resolution viable for normal workspace sizes without new persistence.
|
||||
|
||||
## Phase 1 Design
|
||||
|
||||
Design artifacts are created under `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/175-workspace-governance-attention/`:
|
||||
|
||||
- `data-model.md`: persistent source truths and derived workspace attention contracts for this slice
|
||||
- `contracts/workspace-governance-attention.openapi.yaml`: internal surface contract for workspace governance-aware overview semantics and drill-through continuity
|
||||
- `quickstart.md`: focused implementation and verification workflow
|
||||
|
||||
Design highlights:
|
||||
|
||||
- `WorkspaceOverviewBuilder` remains the builder boundary and becomes responsible for deriving governance-aware summary metrics, attention candidates, and calmness claims from visible tenants only.
|
||||
- `TenantGovernanceAggregateResolver` is the primary source for governance-related tenant promotion, mirroring the mature tenant dashboard semantics rather than reinterpreting the same truth a second time.
|
||||
- Workspace summary metrics are split into scope, governance-risk, and activity categories so the stat strip can no longer blur portfolio activity with portfolio risk.
|
||||
- Workspace attention items become structured tenant-bound records carrying tenant label, problem family, urgency, and one primary drill-through target.
|
||||
- `WorkspaceNeedsAttention` remains bounded and prioritized, favoring the highest-value tenant signal per item instead of dumping every raw issue into the workspace surface.
|
||||
- Compare-driven workspace attention must preserve stale, failed, and materially degraded posture families rather than collapsing them into a single degraded-only bucket.
|
||||
- Compare attention promotes `STATE_STALE` directly and only treats `STATE_ACTION_REQUIRED` as materially degraded compare posture when the aggregate's next action remains compare-specific rather than findings-driven; `STATE_CAUTION` remains below the workspace-attention threshold unless another governance signal independently warrants promotion.
|
||||
- Existing evidence and review surfaces stay optional targets in this slice: they are only used when already-available truth makes them the most precise next jump.
|
||||
- Zero-tenant recovery defaults to `ChooseWorkspace`, and alert-only follow-up reuses the existing alerts overview at `/admin/alerts`.
|
||||
- `WorkspaceRecentOperations` remains a recency surface and is intentionally prevented from defining calmness on its own.
|
||||
|
||||
## Phase 1 — Agent Context Update
|
||||
|
||||
Run after artifact generation:
|
||||
|
||||
- `.specify/scripts/bash/update-agent-context.sh copilot`
|
||||
|
||||
## Project Structure
|
||||
|
||||
### Documentation (this feature)
|
||||
|
||||
```text
|
||||
specs/175-workspace-governance-attention/
|
||||
├── spec.md
|
||||
├── plan.md
|
||||
├── research.md
|
||||
├── data-model.md
|
||||
├── quickstart.md
|
||||
├── contracts/
|
||||
│ └── workspace-governance-attention.openapi.yaml
|
||||
├── checklists/
|
||||
│ └── requirements.md
|
||||
└── tasks.md
|
||||
```
|
||||
|
||||
### Source Code (repository root)
|
||||
|
||||
```text
|
||||
app/
|
||||
├── Filament/
|
||||
│ ├── Pages/
|
||||
│ │ ├── WorkspaceOverview.php
|
||||
│ │ ├── ChooseTenant.php
|
||||
│ │ ├── TenantDashboard.php
|
||||
│ │ └── BaselineCompareLanding.php
|
||||
│ ├── Resources/
|
||||
│ │ ├── FindingResource.php
|
||||
│ │ ├── EvidenceSnapshotResource.php
|
||||
│ │ └── TenantReviewResource.php
|
||||
│ └── Widgets/
|
||||
│ ├── Dashboard/
|
||||
│ │ └── NeedsAttention.php
|
||||
│ └── Workspace/
|
||||
│ ├── WorkspaceSummaryStats.php
|
||||
│ ├── WorkspaceNeedsAttention.php
|
||||
│ └── WorkspaceRecentOperations.php
|
||||
├── Models/
|
||||
│ ├── Finding.php
|
||||
│ ├── AlertDelivery.php
|
||||
│ ├── OperationRun.php
|
||||
│ ├── EvidenceSnapshot.php
|
||||
│ └── TenantReview.php
|
||||
├── Services/
|
||||
│ └── Auth/
|
||||
│ ├── WorkspaceCapabilityResolver.php
|
||||
│ └── CapabilityResolver.php
|
||||
└── Support/
|
||||
├── Auth/
|
||||
│ └── Capabilities.php
|
||||
├── Baselines/
|
||||
│ ├── BaselineCompareStats.php
|
||||
│ ├── BaselineCompareSummaryAssessment.php
|
||||
│ ├── BaselineCompareSummaryAssessor.php
|
||||
│ ├── TenantGovernanceAggregate.php
|
||||
│ └── TenantGovernanceAggregateResolver.php
|
||||
├── OperationRunLinks.php
|
||||
└── Workspaces/
|
||||
└── WorkspaceOverviewBuilder.php
|
||||
|
||||
resources/
|
||||
└── views/
|
||||
└── filament/
|
||||
├── pages/
|
||||
│ └── workspace-overview.blade.php
|
||||
└── widgets/
|
||||
└── workspace/
|
||||
├── workspace-needs-attention.blade.php
|
||||
└── workspace-recent-operations.blade.php
|
||||
|
||||
tests/
|
||||
└── Feature/
|
||||
└── Filament/
|
||||
├── WorkspaceOverviewAccessTest.php
|
||||
├── WorkspaceOverviewAuthorizationTest.php
|
||||
├── WorkspaceOverviewContentTest.php
|
||||
├── WorkspaceOverviewEmptyStatesTest.php
|
||||
├── WorkspaceOverviewLandingTest.php
|
||||
├── WorkspaceOverviewNavigationTest.php
|
||||
├── WorkspaceOverviewOperationsTest.php
|
||||
├── WorkspaceOverviewPermissionVisibilityTest.php
|
||||
├── WorkspaceOverviewGovernanceAttentionTest.php
|
||||
├── WorkspaceOverviewDbOnlyTest.php
|
||||
├── WorkspaceOverviewDrilldownContinuityTest.php
|
||||
└── WorkspaceOverviewSummaryMetricsTest.php
|
||||
```
|
||||
|
||||
**Structure Decision**: Keep the feature entirely inside the existing Laravel/Filament monolith. Extend the current workspace overview builder, workspace widgets, tenant truth helpers, and existing destination resources or pages instead of creating a new workspace domain layer.
|
||||
|
||||
## Complexity Tracking
|
||||
|
||||
> No Constitution Check violations are planned. No exceptions are currently justified.
|
||||
|
||||
| Violation | Why Needed | Simpler Alternative Rejected Because |
|
||||
|-----------|------------|-------------------------------------|
|
||||
| — | — | — |
|
||||
|
||||
## Proportionality Review
|
||||
|
||||
> No new enum/status family, persisted entity, abstraction layer, taxonomy, or cross-domain UI framework is planned in this slice.
|
||||
|
||||
- **Current operator problem**: The workspace home can look calm even when visible tenants already carry governance-critical problems.
|
||||
- **Existing structure is insufficient because**: Workspace aggregation currently stops at operations and alerts and fails to propagate already-mature tenant governance truth.
|
||||
- **Narrowest correct implementation**: Extend the existing workspace overview builder and widgets to consume existing tenant aggregates and destination contracts.
|
||||
- **Ownership cost created**: Modest additional workspace-level aggregation logic and focused regression coverage.
|
||||
- **Alternative intentionally rejected**: A new workspace posture subsystem, new persistence, or a matrix-style redesign.
|
||||
- **Release truth**: Current-release truth.
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### Phase A — Reuse Existing Tenant Truth In The Workspace Builder
|
||||
|
||||
**Goal**: Make `WorkspaceOverviewBuilder` governance-aware without creating a parallel truth layer.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| A.1 | `app/Support/Workspaces/WorkspaceOverviewBuilder.php` | Add a visible-tenant governance promotion pass that resolves `TenantGovernanceAggregate` for accessible tenants and builds a bounded set of governance candidates from overdue findings, lapsed governance, expiring governance, high-severity active findings, stale, failed, or materially degraded compare posture, and optionally already-available evidence or review attention. |
|
||||
| A.2 | `app/Support/Baselines/TenantGovernanceAggregateResolver.php` and existing tenant truth classes | Reuse existing aggregate outputs as-is; only add plan-level consumption, not a second interpretation layer. |
|
||||
| A.3 | `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php` plus existing overview tests | Prove that visible governance-critical tenants now surface on the workspace home even when operations are quiet. |
|
||||
|
||||
### Phase B — Separate Governance Metrics From Activity Metrics
|
||||
|
||||
**Goal**: Make the stat strip clearly answer risk versus activity instead of flattening them into one line of numbers.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| B.1 | `app/Support/Workspaces/WorkspaceOverviewBuilder.php` | Replace or augment the current `needs_attention` stat with one or more tenant-level governance-risk metrics such as tenants needing governance attention, tenants with overdue findings, tenants with lapsed governance, or tenants with stale, failed, or materially degraded compare posture. |
|
||||
| B.2 | `app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php` and `resources/views/filament/pages/workspace-overview.blade.php` | Preserve the existing stat strip but ensure risk metrics and activity metrics are semantically and visually distinguishable through grouping, wording, and destination meaning. |
|
||||
| B.3 | `tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php` and existing content tests | Prove that governance metrics count affected visible tenants, activity metrics remain activity-only, and the two meanings are not mixed. |
|
||||
|
||||
### Phase C — Make Workspace Attention Tenant-Addressable And Actionable
|
||||
|
||||
**Goal**: Turn workspace attention into a real start surface with tenant identity, reason, priority, and next jump.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| C.1 | `app/Support/Workspaces/WorkspaceOverviewBuilder.php` | Expand the attention item payload to include tenant label, tenant route key or id, problem family, urgency, and one primary target kind. Keep every attention item tenant-bound, leave workspace-wide operations or alert totals in metrics or recency surfaces, and rank governance issues above activity-only items while keeping the list bounded. |
|
||||
| C.2 | `resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php` | Render tenant identity, family, urgency, and one explicit primary action or a disabled explanatory state when the exact destination is not allowed. |
|
||||
| C.3 | `tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php` and `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php` | Prove that each central attention family leads to the correct tenant dashboard, findings, compare, evidence, review, or operation destination and that dead-end links are not exposed. |
|
||||
|
||||
### Phase D — Fix Workspace Calmness And Empty-State Semantics
|
||||
|
||||
**Goal**: Stop the workspace home from claiming calmness when only operations are quiet.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| D.1 | `app/Support/Workspaces/WorkspaceOverviewBuilder.php` | Change empty-state and calmness logic so calm claims are suppressed whenever visible tenant governance or compare issues exist, even if operations and alerts are healthy. Keep zero-tenant states distinct from healthy states and default their recovery action to the existing choose-workspace route. |
|
||||
| D.2 | `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php`, `resources/views/filament/pages/workspace-overview.blade.php`, and `resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php` | Tighten copy so the workspace can say “nothing urgent” only for the domains actually checked and only when no visible governance-critical tenant state exists. |
|
||||
| D.3 | `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php` and new governance attention coverage | Prove false calmness is suppressed and low-permission or zero-tenant scenarios remain clearly distinct from healthy calm. |
|
||||
|
||||
### Phase E — Preserve Operations As Diagnostic Recency, Not Portfolio Posture
|
||||
|
||||
**Goal**: Keep `WorkspaceRecentOperations` useful without letting it dominate workspace risk semantics.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| E.1 | `app/Filament/Widgets/Workspace/WorkspaceRecentOperations.php` and `resources/views/filament/widgets/workspace/workspace-recent-operations.blade.php` | Preserve existing recency behavior and row-open model, but ensure surrounding copy and page hierarchy keep it clearly subordinate to governance attention and summary metrics. |
|
||||
| E.2 | `tests/Feature/Filament/WorkspaceOverviewOperationsTest.php` and content tests | Prove operations remain filtered to the visible tenant slice, remain non-polling by default, and no longer define calmness on their own. |
|
||||
|
||||
### Phase F — Tighten RBAC-Safe Destination Selection
|
||||
|
||||
**Goal**: Ensure visible truth never creates a broken or misleading navigation path.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| F.1 | `app/Support/Workspaces/WorkspaceOverviewBuilder.php`, `app/Services/Auth/WorkspaceCapabilityResolver.php`, `app/Services/Auth/CapabilityResolver.php`, and tenant resource URL helpers | For each attention family, choose the most precise destination the current in-scope user may actually open; otherwise fall back to an allowed tenant dashboard or disabled explanatory state. Aggregate lapsed-governance attention stays tenant-bound but falls back to the tenant dashboard when the current findings filters would narrow the invalid-governance family. Alert-only follow-up reuses `/admin/alerts`, and zero-tenant recovery reuses `/admin/choose-workspace`. |
|
||||
| F.2 | `tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php`, `WorkspaceOverviewAuthorizationTest.php`, and new drilldown tests | Prove non-members still receive `404`, hidden tenants do not affect visible output, and members missing downstream capability do not receive clickable dead-end links. |
|
||||
|
||||
### Phase G — Verification And Formatting
|
||||
|
||||
**Goal**: Lock the new workspace truth and performance contract in place.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| G.1 | Workspace overview focused test pack | Add or extend tests for governance promotion, stale, failed, and materially degraded compare breadth, ordering, tenant identity, summary metric separation, calmness suppression, zero-tenant next-step recovery, low-permission operations fallback, drill-through continuity, DB-only query-bounded rendering, and permission-safe fallbacks. |
|
||||
| G.2 | `vendor/bin/sail bin pint --dirty --format agent` and focused Pest runs | Apply formatting and run the smallest verification pack that covers the builder, workspace view rendering, and navigation behavior. |
|
||||
|
||||
## Key Design Decisions
|
||||
|
||||
### D-001 — Keep `WorkspaceOverviewBuilder` as the single orchestration boundary
|
||||
|
||||
The repo already has one place that constructs the workspace overview payload. Extending that builder is narrower than inventing a separate workspace governance service or presenter layer.
|
||||
|
||||
### D-002 — Promote tenant truth by tenant, not by raw issue count
|
||||
|
||||
The workspace operator needs to know which tenants need attention first. A tenant-level risk count is a better workspace answer than raw issue totals because it preserves the MSP triage shape and avoids making one noisy tenant dominate the stat strip.
|
||||
|
||||
### D-003 — Reuse `TenantGovernanceAggregate` before touching lower-level logic
|
||||
|
||||
The tenant dashboard already uses a mature governance aggregate. Workspace attention should consume that same truth path rather than rebuilding overdue, lapsed, or compare logic with new ad-hoc queries.
|
||||
|
||||
### D-004 — Keep workspace attention bounded and prioritized
|
||||
|
||||
The spec hardens the workspace entry point, not a portfolio matrix. The workspace home should surface the top visible reasons to act, not every raw tenant issue. One high-value item per visible problem family is preferable to a noisy stream.
|
||||
|
||||
### D-005 — Treat evidence and review as opportunistic precision targets
|
||||
|
||||
Evidence and reviews are in scope only when they already represent the best existing tenant-level next jump. They are not a reason to create a new workspace evidence or review aggregate in this slice.
|
||||
|
||||
### D-006 — Calmness is a checked-domain claim, not a decorative empty state
|
||||
|
||||
The workspace may only look calm when both governance and activity signals in visible scope are calm. Operations-only quietness is never enough.
|
||||
|
||||
### D-007 — Disabled or fallback navigation is preferable to dead-end clicks
|
||||
|
||||
If the current in-scope user can see that a tenant has a problem but cannot open the most precise destination, the UI must not offer a clickable link that fails later. The surface must either choose an allowed fallback or render a disabled explanatory state.
|
||||
|
||||
## Risk Assessment
|
||||
|
||||
| Risk | Impact | Likelihood | Mitigation |
|
||||
|------|--------|------------|------------|
|
||||
| Workspace attention becomes noisy by promoting too many tenant signals | High | Medium | Bound the list, rank governance-critical families first, and cap per-page attention items. |
|
||||
| Per-tenant aggregate resolution introduces avoidable N+1 behavior | High | Medium | Reuse `TenantGovernanceAggregateResolver` request-scoped caching and keep the visible tenant slice bounded. |
|
||||
| Workspace and tenant truth diverge because workspace logic starts reinterpreting the same facts | High | Medium | Consume `TenantGovernanceAggregate` and existing destinations instead of rebuilding semantics with ad-hoc query logic. |
|
||||
| Capability gaps create misleading or broken drill-throughs | High | Medium | Implement explicit destination selection with fallback or disabled states and cover it with focused tests. |
|
||||
| Calmness copy still overstates health after the change | Medium | Medium | Add explicit calmness-suppression tests covering quiet-ops but risky-governance scenarios. |
|
||||
|
||||
## Test Strategy
|
||||
|
||||
- Extend existing workspace overview tests to preserve landing, navigation, authorization, permission visibility, and operations-slice behavior.
|
||||
- Add focused governance attention coverage for overdue findings, lapsed governance, expiring governance, high-severity active findings, stale, failed, or materially degraded compare posture, and quiet-ops-but-risky-governance scenarios.
|
||||
- Add summary-metric tests proving governance-risk metrics count affected visible tenants rather than raw issue counts and remain distinct from activity metrics.
|
||||
- Add drill-through continuity tests covering tenant dashboard fallback, findings filters, baseline compare landing, evidence or review targets where applicable, and canonical operation detail or index routes.
|
||||
- Add permission-sensitive tests ensuring non-members remain `404`, invisible tenants do not affect visible output, members missing a downstream capability get a safe fallback or disabled state rather than a clickable dead end, and zero-tenant members receive the choose-workspace recovery action instead of healthy calm messaging.
|
||||
- Add DB-only and query-bounding verification so render-time aggregation stays inside the plan's performance constraints and benefits from existing request-scoped caching.
|
||||
- Keep the verification pack Sail-first and run `vendor/bin/sail bin pint --dirty --format agent` before closing implementation.
|
||||
|
||||
## Constitution Check (Post-Design)
|
||||
|
||||
Re-check result: PASS.
|
||||
|
||||
- Livewire v4.0+ compliance: preserved because the design stays inside existing Filament v5 widgets and pages.
|
||||
- Provider registration location: unchanged; no panel/provider registration work is needed beyond the existing `bootstrap/providers.php` setup.
|
||||
- Global-searchable resources: unchanged; no resource search behavior is altered.
|
||||
- Destructive actions: unchanged; the feature adds no destructive action and therefore no new confirmation flow.
|
||||
- Asset strategy: unchanged; no new asset bundle or deploy-time asset step is introduced.
|
||||
- Testing plan: focused Pest coverage will be added or extended for workspace overview rendering, governance promotion, calmness suppression, summary metric separation, drill-through continuity, and RBAC-safe behavior.
|
||||
121
specs/175-workspace-governance-attention/quickstart.md
Normal file
121
specs/175-workspace-governance-attention/quickstart.md
Normal file
@ -0,0 +1,121 @@
|
||||
# Quickstart: Workspace Governance Attention Foundation
|
||||
|
||||
## Goal
|
||||
|
||||
Validate that `/admin` no longer appears calm when visible tenants carry governance-critical conditions, that workspace summary metrics distinguish risk from activity, and that workspace attention items identify the correct tenant and open the correct next surface.
|
||||
|
||||
## Prerequisites
|
||||
|
||||
1. Start Sail.
|
||||
2. Ensure you have one workspace with multiple visible tenants and current workspace session context.
|
||||
3. Prepare seeded tenant scenarios for:
|
||||
- no governance-critical conditions and no unusual activity
|
||||
- overdue findings with otherwise quiet operations
|
||||
- lapsed governance
|
||||
- expiring governance
|
||||
- high-severity active findings
|
||||
- stale, failed, or materially degraded compare posture
|
||||
- activity-only workspace noise with otherwise healthy governance posture
|
||||
- optional existing evidence or review attention if those truth surfaces are already available
|
||||
4. Prepare one workspace member who can see the workspace home but lacks at least one downstream tenant destination capability so disabled or fallback attention behavior can be verified.
|
||||
5. Prepare one workspace member who belongs to the workspace but has zero accessible tenants so the choose-workspace recovery path can be verified.
|
||||
|
||||
## Implementation Validation Order
|
||||
|
||||
### 1. Run the existing workspace overview baseline pack
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewAccessTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewLandingTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewNavigationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewContentTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewOperationsTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- The existing workspace home still renders, remains workspace-scoped, and preserves current access and operations behavior.
|
||||
|
||||
### 2. Run focused governance-attention coverage
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Visible tenants with overdue findings, lapsed governance, expiring governance, high-severity active findings, or stale, failed, or materially degraded compare posture now promote governance attention into the workspace home.
|
||||
- Governance-risk metrics count affected tenants and remain distinct from operations or alerts volume.
|
||||
|
||||
### 3. Run drill-through continuity and RBAC-safe navigation coverage
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Workspace attention items carry tenant context and open the correct findings, compare, evidence, review, tenant dashboard, or operations destination.
|
||||
- Members missing a downstream capability do not receive clickable dead-end links.
|
||||
|
||||
### 4. Re-run workspace empty-state and calmness coverage
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php --filter=calm
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- The workspace no longer renders a calm or “nothing urgent” state when visible governance-critical tenant conditions exist.
|
||||
- Zero-tenant and low-permission states remain clearly distinct from healthy calmness, zero-tenant recovery defaults to `Switch workspace`, and permission-limited recovery defaults to `Open operations` unless a more specific allowed action exists.
|
||||
|
||||
### 5. Format touched files
|
||||
|
||||
```bash
|
||||
vendor/bin/sail bin pint --dirty --format agent
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- All changed implementation files conform to project formatting rules.
|
||||
|
||||
### 6. Run the final focused verification pack
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewAccessTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewLandingTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewNavigationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewContentTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewOperationsTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- The formatted implementation preserves landing, authorization, content, empty-state, operations, governance-attention, stat-separation, and drill-through contracts for the workspace home.
|
||||
|
||||
## Manual Smoke Check
|
||||
|
||||
1. Open `/admin` for a workspace where one visible tenant has overdue findings but operations are quiet.
|
||||
2. Confirm the workspace home does not read as calm and identifies the tenant explicitly.
|
||||
3. Open `/admin` for a workspace where a visible tenant has lapsed governance or stale, failed, or materially degraded compare posture and confirm that tenant is prioritized above activity-only items.
|
||||
4. Click a governance attention item and confirm the destination reproduces the same tenant problem family.
|
||||
5. Verify that the summary strip clearly distinguishes tenant risk from active operations.
|
||||
6. Switch to a healthy workspace and confirm calm wording only appears when both governance and activity domains are truly calm within visible scope.
|
||||
7. Sign in as the zero-tenant workspace member and confirm the workspace does not look healthy and instead offers `Switch workspace` as the next action.
|
||||
8. Sign in as the permission-limited workspace member and confirm visible attention does not expose a clickable dead-end link and the page still presents `Open operations` as the valid workspace-safe next action.
|
||||
|
||||
## Non-Goals For This Slice
|
||||
|
||||
- No database migration.
|
||||
- No new Graph contract or provider workflow.
|
||||
- No full portfolio matrix or posture score.
|
||||
- No new workspace evidence or review aggregate.
|
||||
- No conversion of recent operations into a primary governance queue.
|
||||
105
specs/175-workspace-governance-attention/research.md
Normal file
105
specs/175-workspace-governance-attention/research.md
Normal file
@ -0,0 +1,105 @@
|
||||
# Phase 0 Research: Workspace Governance Attention Foundation
|
||||
|
||||
## Decision: Reuse `WorkspaceOverviewBuilder` as the single orchestration point for workspace governance attention
|
||||
|
||||
**Rationale**: The current workspace home already builds one typed payload through `WorkspaceOverviewBuilder`, and it already applies visible-tenant scoping plus workspace capability checks before computing metrics, attention, and recency. The missing behavior is not a missing builder seam; it is that the builder currently stops at operations and alerts. Extending that existing orchestration point is narrower than creating a second workspace posture service.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Create a new workspace posture builder or presenter layer: rejected because it would duplicate ownership and violate the repo's bias toward few layers.
|
||||
- Push governance promotion into widget-local queries: rejected because it would spread truth ownership across multiple workspace widgets.
|
||||
|
||||
## Decision: Reuse `TenantGovernanceAggregateResolver` and `BaselineCompareStats` per visible tenant instead of inventing workspace-local governance logic
|
||||
|
||||
**Rationale**: The tenant dashboard already uses `TenantGovernanceAggregate`, `BaselineCompareStats`, and `BaselineCompareSummaryAssessor` to answer exactly the governance questions Spec 175 wants to surface at workspace level: overdue findings, lapsed governance, expiring governance, high-severity active findings, and stale, failed, or materially degraded compare posture. Workspace attention should promote that existing tenant truth, not reinterpret it with a weaker query path.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Create a workspace-only aggregation query for overdue, lapsed, and compare states: rejected because it would split truth ownership away from the existing tenant governance path.
|
||||
- Create a persisted workspace governance summary: rejected because the spec explicitly forbids new persistence and the problem is request-time semantics, not lifecycle truth.
|
||||
|
||||
## Decision: Count governance risk by affected tenant, not by raw issue total, in workspace summary metrics
|
||||
|
||||
**Rationale**: The workspace question is “which tenants need attention” rather than “how many findings exist.” Counting visible tenants with overdue findings, lapsed governance, or stale, failed, or materially degraded compare posture gives the operator a portfolio answer and avoids one noisy tenant dominating the workspace strip.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Show raw totals for overdue findings or lapsed exceptions across the whole workspace: rejected because it weakens triage value and makes the summary less tenant-actionable.
|
||||
- Keep the existing single `needs attention` count derived from operations and alerts only: rejected because it preserves the false-calm problem.
|
||||
|
||||
## Decision: Rank governance-critical tenant states above activity-only and alert-delivery-only items
|
||||
|
||||
**Rationale**: The spec explicitly requires governance-critical states such as lapsed governance, overdue findings, high-severity active findings, and stale, failed, or materially degraded compare posture to outrank active operations and alert-delivery failures. Workspace attention should still include operations or alerts, but only after governance-critical tenant problems have had a chance to surface.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Keep current recency-first ordering with governance added lower down: rejected because it still lets busy but healthier workspaces look more urgent than risky but quiet ones.
|
||||
- Remove operations and alerts entirely: rejected because they remain useful as supporting attention once governance-critical signals are represented.
|
||||
|
||||
## Decision: Make every workspace attention item tenant-identifiable with one primary destination
|
||||
|
||||
**Rationale**: The current workspace attention items are generic operations or alert items. Spec 175 requires tenant identity, problem family, relevance, and next jump. A bounded item contract with tenant label plus one primary destination is the narrowest way to satisfy this without turning the workspace home into a matrix or a second diagnostics page.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Continue using generic titles like “operations are still running”: rejected because it does not answer which tenant to open first.
|
||||
- Add multiple buttons per item: rejected because it makes the attention surface noisier and less decisive.
|
||||
|
||||
## Decision: Use RBAC-safe fallback or disabled explanatory states instead of dead-end drill-throughs
|
||||
|
||||
**Rationale**: Some workspace members may be able to see that a tenant has a problem but may not hold the most precise downstream capability, such as findings inspection. The constitution permits visible disabled states for in-scope members. The safest behavior is to choose an allowed fallback such as the tenant dashboard or to render a disabled explanatory state instead of a clickable link that ends in `403`.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Hide the tenant problem entirely when the precise destination is not allowed: rejected because it can make the workspace appear calmer than reality.
|
||||
- Always link to the precise destination and rely on downstream authorization failure: rejected because the spec forbids dead-end drill-throughs.
|
||||
|
||||
## Decision: Default zero-tenant recovery to the existing choose-workspace route
|
||||
|
||||
**Rationale**: The current admin workspace flow already uses `/admin/choose-workspace` as the canonical recovery surface when no usable workspace or tenant context is available. Reusing that existing route keeps the workspace overview honest for zero-tenant members without inventing a new recovery surface or asking them to infer the next step.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Treat zero-tenant state as a healthy calm empty state: rejected because it hides a scope problem as a health signal.
|
||||
- Default zero-tenant recovery to a workspace-management surface: rejected because many members can switch workspace but cannot manage workspace memberships.
|
||||
|
||||
## Decision: Route alert-only follow-up to the existing alerts overview at `/admin/alerts`
|
||||
|
||||
**Rationale**: The app already has an admin alerts overview that serves as the canonical entry point for alert health, rules, and delivery follow-up. Using that route for workspace alert-only attention is narrower and more stable than inventing a new alert-delivery deep-link contract inside this slice.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Send alert-only attention directly to an alert-deliveries list route: rejected because the current operator surface is the alerts overview at `/admin/alerts`.
|
||||
- Drop alert-only follow-up entirely: rejected because alert delivery remains a valid supporting attention family once governance-critical items are represented.
|
||||
|
||||
## Decision: Keep evidence and review promotion opportunistic, not foundational, in this slice
|
||||
|
||||
**Rationale**: The codebase already has tenant evidence and review resources, but the current workspace overview has no evidence or review aggregation. Spec 175 allows evidence or review issues where already available. The narrow implementation is to use those surfaces only when existing tenant truth already provides a clear problem family and a clear target, not to build a new workspace evidence or review subsystem.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Exclude evidence and review entirely: rejected because the spec explicitly leaves room for them where they already provide value.
|
||||
- Build a dedicated workspace evidence or review aggregate now: rejected because it exceeds the foundation scope of the feature.
|
||||
|
||||
## Decision: Keep `WorkspaceRecentOperations` as diagnostic recency, not portfolio posture
|
||||
|
||||
**Rationale**: The current recent-operations widget already serves a clear supporting role and is covered by existing tests that verify visible-tenant filtering and the absence of polling. The spec does not require changing its query model; it requires preventing that surface from being mistaken for the workspace's main truth surface.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Expand recent operations into the primary attention owner: rejected because it would keep the workspace entry point operations-centered.
|
||||
- Remove recent operations from the overview: rejected because it still provides useful context when subordinated to governance attention.
|
||||
|
||||
## Decision: Treat workspace calmness as a checked-domain claim instead of an operations-only empty state
|
||||
|
||||
**Rationale**: The current `WorkspaceNeedsAttention` empty state says “Nothing urgent in your current scope” and explains that recent operations and alert deliveries look healthy. That wording is only valid if the page is consciously limiting its claim to those domains. After governance promotion, calm messaging must be based on both governance and activity signals in visible scope, or else be narrowed explicitly.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Keep the current empty-state wording and rely on new governance items to suppress it sometimes: rejected because the wording still over-claims portfolio health.
|
||||
- Remove calm messaging entirely: rejected because a truthful all-clear remains useful when the covered domains are genuinely calm.
|
||||
|
||||
## Decision: Lean on request-scoped derived-state caching instead of new persistence for performance
|
||||
|
||||
**Rationale**: `TenantGovernanceAggregateResolver` already uses request-scoped derived-state caching. That makes per-visible-tenant governance resolution viable for the workspace overview without introducing a new summary table or materialized view. This keeps the implementation within the spec's no-new-persistence constraint.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Add a cached database aggregate or background precompute job: rejected because it introduces durability and lifecycle cost the feature does not need.
|
||||
- Resolve all tenant governance truth from raw ad-hoc queries without using the resolver: rejected because it ignores an existing request-scope caching seam and increases drift risk.
|
||||
|
||||
## Decision: Protect the feature with focused workspace overview regression tests instead of manual review alone
|
||||
|
||||
**Rationale**: The highest-risk failures are semantic: false calmness, wrong tenant prioritization, missing tenant labels, or broken destinations. Existing workspace overview tests already cover access, landing, navigation, permission visibility, empty states, content, and operations slice behavior. Extending that suite with governance attention and drill-through coverage is the narrowest way to keep this contract stable.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Rely on manual browser review only: rejected because semantic regressions are subtle and easy to reintroduce.
|
||||
- Build a full browser-based suite first: rejected because focused Pest coverage is already the repo's normal enforcement layer for Filament truth contracts.
|
||||
238
specs/175-workspace-governance-attention/spec.md
Normal file
238
specs/175-workspace-governance-attention/spec.md
Normal file
@ -0,0 +1,238 @@
|
||||
# Feature Specification: Spec 175 - Workspace Governance Attention Foundation
|
||||
|
||||
**Feature Branch**: `175-workspace-governance-attention`
|
||||
**Created**: 2026-04-04
|
||||
**Status**: Draft
|
||||
**Input**: User description: "Spec 175 — Workspace Governance Attention Foundation"
|
||||
|
||||
## Spec Scope Fields *(mandatory)*
|
||||
|
||||
- **Scope**: workspace + canonical-view
|
||||
- **Primary Routes**:
|
||||
- `/admin` as the workspace-level overview where `WorkspaceOverview`, `WorkspaceSummaryStats`, `WorkspaceNeedsAttention`, and `WorkspaceRecentOperations` establish the first portfolio triage impression
|
||||
- `/admin/choose-workspace` as the default workspace-switch recovery surface for zero-tenant or wrong-workspace states
|
||||
- `/admin/choose-tenant` as the deliberate tenant-entry surface when the operator needs to move from workspace triage into one tenant
|
||||
- `/admin/t/{tenant}` as the tenant dashboard destination for tenant-wide recovery when a workspace attention item needs a broad tenant landing point
|
||||
- `/admin/t/{tenant}/findings` and tenant finding detail routes as the primary findings and governance drill-through destinations
|
||||
- `/admin/t/{tenant}/baseline-compare-landing` as the compare-posture destination for stale, failed, or materially degraded compare states
|
||||
- `/admin/alerts` as the canonical alert overview and delivery follow-up destination for workspace alert issues
|
||||
- `/admin/operations` and canonical operation detail routes as the operations and execution follow-up destinations
|
||||
- `/admin/t/{tenant}/evidence` and `/admin/t/{tenant}/reviews` only when an attention item is backed by already-visible evidence or review truth that is more precise than a generic tenant landing
|
||||
- **Data Ownership**:
|
||||
- Workspace-owned: workspace context, workspace home composition, workspace-scoped recent operations, and alert-delivery history already summarized on the workspace home
|
||||
- Tenant-owned but workspace-filtered: visible tenant governance state, findings workflow state, evidence and review truth, and tenant-scoped compare posture that may be promoted into workspace attention
|
||||
- This feature introduces no new workspace summary record; workspace attention, calmness, and governance stats remain derived over existing workspace and tenant truth
|
||||
- **RBAC**:
|
||||
- Workspace membership remains required to render `/admin` and all workspace-level overview aggregates
|
||||
- Only tenants that are visible within the current operator's entitled workspace scope may contribute to workspace counts, calmness suppression, or attention items
|
||||
- Alert-related destinations continue to require the existing alert visibility permission, while tenant drill-through destinations continue to require the current tenant-level inspection capability for that surface; baseline compare currently rides on general `tenant.view` rather than a dedicated compare-specific capability
|
||||
- Non-members or out-of-scope actors remain deny-as-not-found, and the workspace home must not leak hidden tenant posture through counts, wording, or drill-through affordances
|
||||
|
||||
For canonical-view specs, the spec MUST define:
|
||||
|
||||
- **Default filter behavior when tenant-context is active**: The workspace home remains workspace-scoped even if a tenant was selected earlier in the session. The overview itself must not silently collapse into one tenant. Any drill-through launched from workspace attention or governance stats must preserve the originating tenant and problem family through tenant context or an equivalent pre-applied destination filter.
|
||||
- **Explicit entitlement checks preventing cross-tenant leakage**: Workspace counts, calmness claims, priority order, and drill-through destinations must be computed only from visible tenants and visible truth surfaces. Inaccessible tenants must not contribute to `needs attention`, governance-risk stats, or empty-state suppression. If a precise destination is not authorized for the current in-scope user, the workspace surface must use an allowed fallback or remove the clickable affordance instead of hinting at hidden data.
|
||||
|
||||
## UI/UX Surface Classification *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
| Surface | Surface Type | Primary Inspect/Open Model | Row Click | Secondary Actions Placement | Destructive Actions Placement | Canonical Collection Route | Canonical Detail Route | Scope Signals | Canonical Noun | Critical Truth Visible by Default | Exception Type |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Workspace overview page | Workspace landing page | The page itself is the canonical workspace entry and hosts the embedded triage surfaces | forbidden | quick actions section only | none | `/admin` | none | Active workspace identity stays visible and embedded items must keep tenant labels explicit | Overview | Whether the workspace currently has governance attention and how that differs from raw activity | Singleton landing surface |
|
||||
| Workspace `Needs Attention` | Embedded triage summary | Each attention item opens one matching working surface for the named tenant problem | required | none | none | `/admin` | Existing tenant dashboard, findings, baseline compare, evidence, review, or operation detail destination depending on item type | Tenant name, problem family, and urgency must be visible on the item before navigation | Attention / Attention item | The most important visible tenant problems and where to go next | Multi-destination triage surface |
|
||||
| Workspace summary stats | Embedded status summary / drill-in surface | Each stat opens one matching destination or remains intentionally passive when no actionable set exists | forbidden | none | none | `/admin` | Matching destination for the metric, such as choose tenant, findings, compare, or operations | Workspace identity and a clear split between governance risk and activity volume | Governance attention and Operations | Portfolio risk counts are separated from portfolio activity counts | Mixed metric summary surface |
|
||||
| Workspace recent operations | Embedded diagnostic recency surface | Each operation row or card opens the canonical operation detail | required | none | none | `/admin/operations` | Existing canonical operation detail route | Workspace context plus visible tenant label on each operation keeps the recency list anchored to one tenant when relevant | Operations / Operation | Recent execution context without pretending to be the main portfolio-risk summary | Diagnostic recency surface |
|
||||
|
||||
## Operator Surface Contract *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
| Surface | Primary Persona | Surface Type | Primary Operator Question | Default-visible Information | Diagnostics-only Information | Status Dimensions Used | Mutation Scope | Primary Actions | Dangerous Actions |
|
||||
|---|---|---|---|---|---|---|---|---|---|
|
||||
| Workspace overview page | Workspace operator | Workspace landing page | Which tenants need attention first, and is this workspace actually calm or only operationally quiet? | Workspace identity, governance-aware summary stats, prioritized attention, and recent activity as supporting context | Deep run metadata, raw compare internals, and low-level workflow detail remain on downstream pages | governance attention, compare posture, findings pressure, evidence or review trust where already available, operations activity | none | Choose tenant, open an attention item destination, open operations | none |
|
||||
| Workspace `Needs Attention` | Workspace operator | Embedded triage summary | Which tenant needs attention now, why, and where should I jump? | Tenant label, problem family, urgency, and one clear next destination | Low-level evidence payloads, verbose status histories, and raw query context remain secondary | governance issue, findings issue, compare issue, evidence or review issue, operations issue | none | Open the matching tenant dashboard, findings list, compare landing, evidence or review surface, or operation detail | none |
|
||||
| Workspace summary stats | Workspace operator | Embedded status summary / drill-in surface | How much of this workspace is active, and how much of it is governance risk? | Small set of trustworthy counts with explicit governance versus activity meaning | Full tenant-by-tenant breakdown and historical trends remain outside the stat strip | governance attention volume, activity volume | none | Open the matching aggregate destination or tenant entry point | none |
|
||||
| Workspace recent operations | Workspace operator | Embedded diagnostic recency surface | What has run recently if I need execution context? | Recent operations with tenant label, status, outcome, and recency | Full operation timeline, payload diagnostics, and longer history remain in operations surfaces | recency, execution status, execution outcome | none | Open the selected operation detail | none |
|
||||
|
||||
## Proportionality Review *(mandatory when structural complexity is introduced)*
|
||||
|
||||
- **New source of truth?**: No. Existing tenant governance, findings, compare, evidence, review, operations, and alert truth remain authoritative.
|
||||
- **New persisted entity/table/artifact?**: No. This feature explicitly avoids a new workspace posture record or aggregate table.
|
||||
- **New abstraction?**: No. The narrow change is to tighten workspace aggregation and presentation semantics on existing surfaces.
|
||||
- **New enum/state/reason family?**: No. Existing governance, compare, findings, and operations state families remain authoritative.
|
||||
- **New cross-domain UI framework/taxonomy?**: No. The feature aligns existing workspace and tenant surfaces without creating a new posture framework or score system.
|
||||
- **Current operator problem**: The workspace home can look calm while visible tenants already have governance-critical conditions, which makes the portfolio entry point weaker than the tenant truth operators already rely on.
|
||||
- **Existing structure is insufficient because**: The current workspace overview summarizes operations and alert activity well enough, but it does not promote tenant governance truth strongly enough to stop false calmness or answer which tenant to open first.
|
||||
- **Narrowest correct implementation**: Reuse existing tenant governance, findings, compare, and already-available evidence or review truth to harden workspace stats, attention, and empty-state semantics on the current workspace home.
|
||||
- **Ownership cost**: The repo takes on stricter workspace aggregation rules, a modest amount of copy tightening, and regression coverage for priority order, calmness suppression, and drill-through continuity.
|
||||
- **Alternative intentionally rejected**: A full portfolio matrix, a workspace posture score, a major workspace redesign, or a new persisted posture model was rejected because the immediate gap is truth propagation on the existing workspace entry point.
|
||||
- **Release truth**: Current-release truth. The semantic risk already exists on the shipped workspace overview.
|
||||
|
||||
## User Scenarios & Testing *(mandatory)*
|
||||
|
||||
### User Story 1 - See The Right Tenant First (Priority: P1)
|
||||
|
||||
As a workspace operator, I want the workspace home to surface governance-critical tenants before operational noise so that I can start triage from the riskiest visible tenant instead of from the most recent activity.
|
||||
|
||||
**Why this priority**: The feature only delivers value if the workspace entry point stops feeling quieter than the visible tenant truth.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding multiple visible tenants with mixes of overdue findings, lapsed governance, stale, failed, or materially degraded compare posture, high-severity active findings, alert failures, and active operations, then verifying that workspace attention promotes governance-critical tenants first.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** one visible tenant has lapsed governance and another only has active operations, **When** the operator opens `/admin`, **Then** the governance-critical tenant is surfaced as higher-priority workspace attention.
|
||||
2. **Given** a visible tenant has overdue findings while operations and alerts look healthy, **When** the workspace home loads, **Then** the page still presents governance attention instead of an all-clear impression.
|
||||
3. **Given** a visible tenant has stale, failed, or materially degraded compare posture but little recent activity, **When** the workspace home loads, **Then** compare risk remains visible on the workspace entry point.
|
||||
|
||||
---
|
||||
|
||||
### User Story 2 - Distinguish Risk From Activity (Priority: P1)
|
||||
|
||||
As a workspace operator, I want the workspace home to separate governance risk from operations activity so that I can tell whether the portfolio is risky, merely busy, or genuinely calm.
|
||||
|
||||
**Why this priority**: A workspace overview that mixes posture and activity cannot support MSP triage with confidence.
|
||||
|
||||
**Independent Test**: Can be fully tested by rendering the workspace home in scenarios that contain only activity, only governance risk, both, or neither, then verifying that stats, attention, and empty states describe those cases differently.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** the workspace has active operations but no visible governance-critical tenant states, **When** the overview renders, **Then** activity appears without governance-risk wording.
|
||||
2. **Given** the workspace has no failed runs or alert failures but visible overdue findings exist, **When** the overview renders, **Then** the page does not present a calm empty state.
|
||||
3. **Given** the workspace has no visible governance-critical states and no unusual operations issues, **When** the overview renders, **Then** calm messaging may appear and must match the covered truth domains.
|
||||
|
||||
---
|
||||
|
||||
### User Story 3 - Jump Into The Right Tenant Surface (Priority: P2)
|
||||
|
||||
As a workspace operator, I want each attention item to carry tenant identity and a trustworthy next jump so that I can recover the same problem family immediately on a tenant-level working surface.
|
||||
|
||||
**Why this priority**: Workspace attention is only trustworthy if the operator can click it and rediscover the same tenant problem without guesswork.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding representative workspace attention cases and verifying that each item names the tenant, names the problem family, and lands on the matching tenant dashboard, findings, compare, evidence, review, or operation destination.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** a workspace attention item represents overdue findings for one visible tenant, **When** the operator opens it, **Then** the destination is that tenant's findings surface or a precise allowed fallback that preserves the same problem meaning.
|
||||
2. **Given** a workspace attention item represents stale, failed, or materially degraded compare posture, **When** the operator opens it, **Then** the destination is the same tenant's baseline compare landing.
|
||||
3. **Given** the operator can see a tenant on the workspace home but lacks a precise downstream capability, **When** the attention surface renders, **Then** it uses an allowed fallback or a disabled non-clickable state instead of a dead-end drill-through.
|
||||
|
||||
### Edge Cases
|
||||
|
||||
- A single visible tenant may have multiple governance-critical conditions at the same time; the workspace home must stay bounded while still exposing the tenant identity and the highest-priority next action.
|
||||
- A workspace may be operationally quiet while one or more visible tenants still have overdue findings, lapsed governance, high-severity active findings, or stale, failed, or materially degraded compare posture; calm messaging must stay suppressed in that case.
|
||||
- A workspace may be busy but healthy from a governance perspective; governance-risk stats and attention must remain calm even when recent operations are active.
|
||||
- Some visible tenants may contribute only through a broader tenant dashboard drill-through because the operator lacks a more specific downstream capability; the workspace home must not create dead-end links or authorization surprises.
|
||||
- A user may belong to the workspace but have zero accessible tenants; the zero-tenant state must remain distinct from a healthy calm state and must still provide one valid next step.
|
||||
- Evidence or review truth may already indicate attention for a visible tenant even when operations are quiet; if that truth is already surfaced on tenant-level pages, the workspace home should be able to promote it without inventing a parallel status language.
|
||||
|
||||
## Requirements *(mandatory)*
|
||||
|
||||
**Constitution alignment (required):** This feature introduces no new Microsoft Graph call, no new write workflow, and no new queued or scheduled operation. It hardens the workspace home by promoting already-existing tenant-level truth into existing workspace surfaces.
|
||||
|
||||
**Constitution alignment (PROP-001 / ABSTR-001 / PERSIST-001 / STATE-001 / BLOAT-001):** This feature is intentionally narrow. It adds no new persistence, no new abstraction layer, no new status family, and no new posture framework. The required change is truthful workspace aggregation over existing tenant truth.
|
||||
|
||||
**Constitution alignment (OPS-UX):** No new `OperationRun` type, progress surface, or execution path is introduced. Existing operations surfaces remain the sole execution-truth surfaces. This slice only changes how the workspace home summarizes and points to those existing operations.
|
||||
|
||||
**Constitution alignment (RBAC-UX):** The feature lives in the admin workspace plane at `/admin` with drill-through into tenant-context or canonical admin destinations. Non-members or out-of-scope actors remain `404`. In-scope members lacking a downstream capability remain governed by existing server-side authorization on that destination. Workspace aggregation must stay capability-safe and tenant-safe: hidden tenants must not influence visible counts or wording, and attention items must not become clickable dead ends. If the semantically correct destination is not authorized, the item may only remain if an allowed fallback still preserves tenant and problem meaning. No destructive action is introduced.
|
||||
|
||||
**Constitution alignment (OPS-EX-AUTH-001):** Not applicable. No authentication-handshake behavior is changed.
|
||||
|
||||
**Constitution alignment (BADGE-001):** Existing centralized badge or tone semantics for findings severity, compare posture, and operations status or outcome remain the semantic source. This feature may expose those existing meanings at workspace level, but it must not invent page-local badge vocabularies for calmness, risk, or urgency.
|
||||
|
||||
**Constitution alignment (UI-FIL-001):** The feature reuses the existing Filament page and workspace widgets, existing stat cards, and existing shared status primitives. It should harden semantics through aligned copy, ordering, and drill-through meaning rather than through custom local status markup or a new widget family.
|
||||
|
||||
**Constitution alignment (UI-NAMING-001):** Operator-facing vocabulary must keep `Governance`, `Findings`, `Baseline Compare`, `Evidence`, `Reviews`, `Operations`, and `Needs attention` distinct. Calm wording must not imply portfolio health when the page only proves operational quietness.
|
||||
|
||||
**Constitution alignment (UI-CONST-001 / UI-SURF-001 / UI-HARD-001 / UI-EX-001 / UI-REVIEW-001):** The workspace overview remains the canonical workspace landing surface. `WorkspaceNeedsAttention` is the primary workspace triage surface. `WorkspaceSummaryStats` is a supporting summary strip and must separate risk from activity. `WorkspaceRecentOperations` remains diagnostic recency, not posture. Each affected surface must keep one primary inspect or open model and must not add redundant affordances.
|
||||
|
||||
**Constitution alignment (OPSURF-001):** Default-visible content on `/admin` must stay operator-first. Workspace identity, governance attention, and the distinction between risk and activity must remain visible before any diagnostic detail. Mutation scope remains none for all affected surfaces.
|
||||
|
||||
**Constitution alignment (UI-SEM-001 / LAYER-001 / TEST-TRUTH-001):** The feature must not create a new workspace posture layer, presenter framework, or persisted summary. It should instead align workspace semantics directly on top of existing tenant governance, findings, compare, evidence, review, and operations truth. Tests must protect business consequences such as false calmness, missing tenant labels, or broken drill-through continuity.
|
||||
|
||||
**Constitution alignment (Filament Action Surfaces):** The Action Surface Contract remains satisfied. `WorkspaceOverview` and its widgets remain inspection and drill-through surfaces with no destructive actions, no empty action groups, and no redundant `View` actions. Embedded widgets are exempt from list-action conventions where they are not tables, but each still needs one primary open model.
|
||||
|
||||
**Constitution alignment (UX-001 — Layout & Information Architecture):** This feature does not add create or edit screens. It refines the existing workspace landing page. Governance attention must stay above recent operations context, and empty states must use specific, bounded wording plus exactly one next step instead of broad health claims.
|
||||
|
||||
### Functional Requirements
|
||||
|
||||
- **FR-175-001**: The workspace home MUST become governance-aware rather than remaining a purely operations and alerts summary.
|
||||
- **FR-175-002**: Workspace attention MUST be able to surface, when present within visible scope, at least lapsed governance, overdue findings, high-severity active findings, and stale, failed, or materially degraded compare posture.
|
||||
- **FR-175-003**: Workspace attention SHOULD also be able to promote already-available evidence or review truth when that truth is more actionable than a generic tenant landing.
|
||||
- **FR-175-004**: Every workspace attention item MUST clearly identify the tenant, the problem family, the urgency or relevance, and one clear next jump.
|
||||
- **FR-175-005**: Workspace attention MUST semantically distinguish governance issues, findings issues, compare posture issues, evidence or review issues, and operations issues rather than flattening them into one generic alert stream.
|
||||
- **FR-175-006**: Governance-critical tenant states MUST rank at least as high as, and ordinarily above, active-operations-only or alert-delivery-only items in workspace attention ordering.
|
||||
- **FR-175-007**: The workspace home MUST NOT appear calmer or healthier than the worst visible tenant condition covered by its workspace attention and summary surfaces.
|
||||
- **FR-175-008**: Calm or empty states on the workspace home MUST only claim calmness across the signal families that were actually checked and MUST NOT imply full portfolio health merely because operations or alerts are quiet.
|
||||
- **FR-175-009**: Workspace summary stats MUST include at least one real governance-risk metric such as tenants needing governance attention, tenants with overdue findings, tenants with lapsed governance, or tenants with stale, failed, or materially degraded compare posture.
|
||||
- **FR-175-010**: Workspace summary stats MUST clearly separate governance attention from activity or volume so an operator can tell whether the portfolio is risky, busy, both, or neither.
|
||||
- **FR-175-011**: Every workspace attention item MUST resolve to one semantically matching destination surface such as the tenant dashboard, tenant findings, tenant baseline compare, tenant evidence, tenant reviews, or canonical operations detail.
|
||||
- **FR-175-012**: When the exact matching destination is not authorized for the current in-scope user, the workspace home MUST use an allowed fallback that preserves tenant and problem meaning or suppress the clickable affordance rather than exposing a dead-end drill-through.
|
||||
- **FR-175-013**: Workspace aggregation MUST reuse existing tenant governance aggregate, findings workflow and governance validity truth, compare assessment, and already-shipped evidence or review truth rather than introducing a weaker parallel workspace-only interpretation.
|
||||
- **FR-175-014**: `WorkspaceRecentOperations` MUST remain an activity and recency surface and MUST NOT be treated as the workspace's primary posture or governance summary.
|
||||
- **FR-175-015**: Zero-tenant and low-permission workspace states MUST remain distinct from calm or healthy portfolio states and MUST still provide one valid next action. Zero-tenant recovery MUST default to `Switch workspace`, and low-permission workspace-state recovery MUST default to `Open operations` unless a more specific allowed in-scope recovery action exists.
|
||||
- **FR-175-016**: The feature MUST be achievable without a new table, new persisted workspace summary model, or heavy pre-aggregated materialized view.
|
||||
- **FR-175-017**: Regression coverage MUST verify governance-attention promotion, priority order, calmness suppression, tenant identification, governance-versus-operations separation, drill-through continuity, RBAC-safe omission or fallback behavior, DB-only query-bounded render behavior, and the absence of schema requirements.
|
||||
|
||||
## UI Action Matrix *(mandatory when Filament is changed)*
|
||||
|
||||
| Surface | Location | Header Actions | Inspect Affordance (List/Table) | Row Actions (max 2 visible) | Bulk Actions (grouped) | Empty-State CTA(s) | View Header Actions | Create/Edit Save+Cancel | Audit log? | Notes / Exemptions |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Workspace overview page | `app/Filament/Pages/WorkspaceOverview.php` | Existing page chrome only; no new page-header action required | n/a | n/a | none | One bounded CTA per empty state, aligned to the specific empty condition | n/a | n/a | no new audit behavior | Singleton landing surface whose main job is truthful orientation, not mutation |
|
||||
| `WorkspaceSummaryStats` | `app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php` | none | Explicit stat click only when the metric has a matching actionable destination | none | none | Zero-value reassurance remains intentionally passive unless a specific next step is required | n/a | n/a | no new audit behavior | Stat meanings must stay honest about whether they represent risk or activity |
|
||||
| `WorkspaceNeedsAttention` | `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php` | none | One explicit destination or one full-item primary open model per attention item | none | none | Healthy fallback remains read-only reassurance only when no covered attention condition exists | n/a | n/a | no new audit behavior | Multi-destination triage widget; no destructive action and no redundant secondary action model |
|
||||
| `WorkspaceRecentOperations` | `app/Filament/Widgets/Workspace/WorkspaceRecentOperations.php` | none | Each operation row or card opens canonical operation detail | none | none | Existing empty state remains diagnostic and must not imply broader portfolio health | n/a | n/a | no new audit behavior | Diagnostic recency surface; keeps operations context visible without redefining workspace posture |
|
||||
|
||||
### Key Entities *(include if feature involves data)*
|
||||
|
||||
- **Visible tenant governance state**: The already-derived tenant condition that tells whether a visible tenant currently carries overdue findings, lapsed or expiring governance, stale, failed, or materially degraded compare posture, high-severity active findings, or already-surfaced evidence or review attention.
|
||||
- **Workspace governance attention item**: A bounded workspace-level triage item that promotes one visible tenant problem into the workspace home with tenant identity, problem family, urgency, and a next jump.
|
||||
- **Workspace governance metric**: A workspace-level count that describes how many visible tenants currently require governance attention, independent from operations volume.
|
||||
- **Workspace calmness claim**: Any workspace wording or empty state that implies the portfolio is calm; it is only valid when the covered governance and activity signals are genuinely calm within visible scope.
|
||||
- **Workspace drill-through contract**: The semantic promise that a workspace stat or attention item can be rediscovered on the surface it opens without losing tenant identity or problem meaning.
|
||||
|
||||
## Success Criteria *(mandatory)*
|
||||
|
||||
### Measurable Outcomes
|
||||
|
||||
- **SC-175-001**: In regression coverage, every seeded workspace scenario containing at least one visible tenant with lapsed governance, overdue findings, high-severity active findings, or stale, failed, or materially degraded compare posture produces at least one governance attention signal on the workspace home and no calm empty state.
|
||||
- **SC-175-002**: In regression coverage, 100% of covered workspace attention items display tenant context, problem-family context, and either a matching destination or an allowed disabled or fallback state when the exact destination is not authorized.
|
||||
- **SC-175-003**: In seeded operator review, an operator can identify within 10 seconds which tenant to open first, why that tenant needs attention, and whether the issue is governance or operations.
|
||||
- **SC-175-004**: In regression coverage, operations-only activity scenarios do not trigger governance-risk wording, and governance-critical tenant scenarios are not ranked beneath pure activity-only or alert-delivery-only items.
|
||||
- **SC-175-005**: The feature ships without a required schema migration, a new persisted workspace posture model, or a required materialized aggregate view.
|
||||
- **SC-175-006**: In regression coverage, a dedicated DB-only workspace overview test proves render-time aggregation stays query-bounded for representative visible-tenant scenarios and does not rely on uncontrolled polling or unbounded per-tenant query fanout.
|
||||
|
||||
## Assumptions
|
||||
|
||||
- Existing tenant governance aggregate, findings workflow state, compare assessment, and already-available evidence or review truth are sufficient to harden the workspace home without inventing a new posture system.
|
||||
- Existing tenant dashboard, findings, baseline compare, evidence, review, and operations surfaces remain the correct downstream destinations for workspace drill-through.
|
||||
- The current workspace overview page structure remains in place for this slice; the work changes truth ordering and meaning, not the overall workspace information architecture.
|
||||
|
||||
## Non-Goals
|
||||
|
||||
- Building a full portfolio matrix or tenant grid
|
||||
- Introducing a global workspace posture score, grade, or traffic-light system
|
||||
- Redesigning the entire workspace overview layout
|
||||
- Adding choose-tenant posture annotations
|
||||
- Creating new persistence, materialized views, or a new workspace summary artifact
|
||||
- Extending the work into cross-workspace or platform-wide operator surfaces
|
||||
|
||||
## Dependencies
|
||||
|
||||
- Existing workspace overview page and workspace widgets
|
||||
- Existing tenant governance truth, compare assessment, findings governance state, and evidence or review trust work
|
||||
- Existing tenant dashboard, findings, compare, evidence, review, and operations destinations used as canonical drill-through surfaces
|
||||
- Existing workspace and tenant RBAC plus capability-safe query scoping
|
||||
|
||||
## Follow-up Spec Candidates
|
||||
|
||||
- **Spec 176 — Workspace Portfolio Posture Surface** for per-tenant posture summaries, risk concentration, and a first true portfolio matrix
|
||||
- **Spec 177 — Choose Tenant Posture Annotation** for posture-aware tenant selection and faster triage from tenant pickers
|
||||
- **Spec 178 — Workspace Portfolio Stats Redesign** for a broader governance-oriented workspace stat model that goes beyond this foundation slice
|
||||
|
||||
## Definition of Done
|
||||
|
||||
Spec 175 is complete when:
|
||||
|
||||
- workspace attention is no longer purely operations-centered,
|
||||
- governance-relevant tenant problems are visible on the workspace home,
|
||||
- workspace calmness no longer reads healthier than the worst visible tenant conditions,
|
||||
- attention items carry tenant identity, problem type, and a meaningful drill-through,
|
||||
- workspace summary stats include at least one real governance-risk metric and clearly separate risk from activity,
|
||||
- and the improvement ships without a new persistence structure or a full workspace redesign.
|
||||
207
specs/175-workspace-governance-attention/tasks.md
Normal file
207
specs/175-workspace-governance-attention/tasks.md
Normal file
@ -0,0 +1,207 @@
|
||||
# Tasks: Workspace Governance Attention Foundation
|
||||
|
||||
**Input**: Design documents from `/specs/175-workspace-governance-attention/` (`spec.md`, `plan.md`, `research.md`, `data-model.md`, `contracts/`, `quickstart.md`)
|
||||
**Prerequisites**: `/specs/175-workspace-governance-attention/plan.md` (required), `/specs/175-workspace-governance-attention/spec.md` (required for user stories)
|
||||
|
||||
**Tests**: REQUIRED (Pest) for all runtime behavior changes in this repo. Use focused workspace overview coverage in `tests/Feature/Filament/WorkspaceOverviewAccessTest.php`, `tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php`, `tests/Feature/Filament/WorkspaceOverviewLandingTest.php`, `tests/Feature/Filament/WorkspaceOverviewNavigationTest.php`, `tests/Feature/Filament/WorkspaceOverviewContentTest.php`, `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php`, `tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php`, `tests/Feature/Filament/WorkspaceOverviewOperationsTest.php`, `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php`, `tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php`, `tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php`, and `tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php`.
|
||||
**Operations**: This feature does not create a new `OperationRun` type or change operations lifecycle ownership. Existing canonical Operations routes remain the only operations destinations involved, and the work here is limited to truthful workspace aggregation and destination continuity.
|
||||
**RBAC**: Preserve workspace membership enforcement on `/admin`, deny-as-not-found `404` for non-members or out-of-scope tenants, capability-safe fallback or disabled states for drill-through items, and visible-tenant-only aggregation.
|
||||
**Operator Surfaces**: `WorkspaceOverview`, `WorkspaceSummaryStats`, `WorkspaceNeedsAttention`, and `WorkspaceRecentOperations` must stay operator-first, with governance truth above recency context and no dead-end navigation.
|
||||
**Filament UI Action Surfaces**: No destructive actions or redundant inspect affordances are added. `WorkspaceSummaryStats` and `WorkspaceNeedsAttention` remain drill-through summary surfaces, and `WorkspaceRecentOperations` remains a row-open diagnostic surface.
|
||||
**Filament UI UX-001**: No new create, edit, or view pages are introduced. Existing workspace landing layout remains in place while semantics, ordering, and empty-state wording are hardened.
|
||||
**Badges**: Existing badge semantics for findings severity, compare posture, governance validity, operations status, and operations outcome remain authoritative; no new page-local badge vocabulary is introduced.
|
||||
|
||||
**Organization**: Tasks are grouped by user story so each story can be implemented and verified as an independent increment.
|
||||
|
||||
## Phase 1: Setup (Context And Existing Surface Review)
|
||||
|
||||
**Purpose**: Reconfirm the exact workspace overview seams, tenant truth sources, and canonical destinations before changing `/admin` semantics.
|
||||
|
||||
- [X] T001 Review current workspace overview composition in `app/Support/Workspaces/WorkspaceOverviewBuilder.php`, `app/Filament/Pages/WorkspaceOverview.php`, `app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php`, `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php`, and `app/Filament/Widgets/Workspace/WorkspaceRecentOperations.php`
|
||||
- [X] T002 [P] Review existing tenant governance and compare truth sources in `app/Support/Baselines/TenantGovernanceAggregateResolver.php`, `app/Support/Baselines/TenantGovernanceAggregate.php`, `app/Support/Baselines/BaselineCompareStats.php`, `app/Support/Baselines/BaselineCompareSummaryAssessor.php`, and `app/Filament/Widgets/Dashboard/NeedsAttention.php`
|
||||
- [X] T003 [P] Review canonical drill-through destinations and current workspace overview regression seams in `app/Filament/Pages/TenantDashboard.php`, `app/Filament/Pages/BaselineCompareLanding.php`, `app/Filament/Resources/FindingResource/Pages/ListFindings.php`, `app/Filament/Pages/Monitoring/Operations.php`, and `tests/Feature/Filament/WorkspaceOverview*.php`
|
||||
|
||||
---
|
||||
|
||||
## Phase 2: Foundational (Blocking Payload And Continuity Seams)
|
||||
|
||||
**Purpose**: Establish the shared workspace payload and continuity helpers that every user story depends on.
|
||||
|
||||
**⚠️ CRITICAL**: No user story work should begin until this phase is complete.
|
||||
|
||||
- [X] T004 Create governance-attention and performance regression scaffolding in `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php`, `tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php`, `tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php`, and `tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php`
|
||||
- [X] T005 Extend the shared workspace overview payload to match `specs/175-workspace-governance-attention/contracts/workspace-governance-attention.openapi.yaml` for metric categories, calmness state, zero-tenant recovery, and structured attention destinations in `app/Support/Workspaces/WorkspaceOverviewBuilder.php`
|
||||
- [X] T006 [P] Prepare canonical findings-subset, alerts-overview, and operations-continuity seams for workspace-originated drill-through in `app/Filament/Resources/FindingResource/Pages/ListFindings.php`, `app/Filament/Pages/Monitoring/Alerts.php`, and `app/Support/OperationRunLinks.php`
|
||||
- [X] T007 [P] Add shared authorization, visibility, zero-tenant recovery, and DB-only query-bounded assertions for workspace governance destinations in `tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php`, `tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php`, `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php`, and `tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php`
|
||||
|
||||
**Checkpoint**: The builder exposes the shared payload shape, the destination seams are ready, and the new regression files exist.
|
||||
|
||||
---
|
||||
|
||||
## Phase 3: User Story 1 - See The Right Tenant First (Priority: P1) 🎯 MVP
|
||||
|
||||
**Goal**: Make `/admin` surface governance-critical tenants ahead of operational noise so the riskiest visible tenant is obvious first.
|
||||
|
||||
**Independent Test**: Seed multiple visible tenants with overdue findings, lapsed governance, expiring governance, stale, failed, or materially degraded compare posture, high-severity active findings, alerts, and operations, then verify governance-critical tenants rank above activity-only and alert-only items and suppress false calmness.
|
||||
|
||||
### Tests for User Story 1
|
||||
|
||||
- [X] T008 [P] [US1] Add governance-ranking scenarios for overdue findings, lapsed governance, expiring governance, high-severity active findings, stale, failed, or materially degraded compare posture, and alert-only supporting items in `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php`
|
||||
- [X] T009 [P] [US1] Add false-calmness and zero-tenant distinctness scenarios for quiet operations but risky governance in `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php` and `tests/Feature/Filament/WorkspaceOverviewContentTest.php`
|
||||
|
||||
### Implementation for User Story 1
|
||||
|
||||
- [X] T010 [US1] Promote visible-tenant governance aggregate states into bounded governance-first attention candidates, including expiring governance, stale, failed, or materially degraded compare posture, and lower-priority alert-only supporting items when they can be attributed to one visible tenant, in `app/Support/Workspaces/WorkspaceOverviewBuilder.php`
|
||||
- [X] T011 [US1] Render tenant label, problem family, urgency, and governance-first ordering in `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php` and `resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php`
|
||||
- [X] T012 [US1] Align workspace landing copy and calmness framing so operations-only quiet never implies portfolio health in `app/Filament/Pages/WorkspaceOverview.php` and `resources/views/filament/pages/workspace-overview.blade.php`
|
||||
- [X] T013 [US1] Run focused US1 verification against `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php`, `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php`, and `tests/Feature/Filament/WorkspaceOverviewContentTest.php`
|
||||
|
||||
**Checkpoint**: The workspace home no longer looks calmer than the worst visible tenant governance state.
|
||||
|
||||
---
|
||||
|
||||
## Phase 4: User Story 2 - Distinguish Risk From Activity (Priority: P1)
|
||||
|
||||
**Goal**: Make the workspace home clearly separate governance risk from operational activity so the portfolio can be read as risky, busy, both, or calm.
|
||||
|
||||
**Independent Test**: Render `/admin` in governance-only, activity-only, mixed, and healthy scenarios, then verify metrics, attention, and empty states describe those cases differently and truthfully.
|
||||
|
||||
### Tests for User Story 2
|
||||
|
||||
- [X] T014 [P] [US2] Add governance-risk-versus-activity metric scenarios, including expiring governance and stale, failed, or materially degraded compare posture counts, in `tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php` and `tests/Feature/Filament/WorkspaceOverviewContentTest.php`
|
||||
- [X] T015 [P] [US2] Add operations-only, risk-only, mixed, healthy-state, and zero-tenant recovery scenarios in `tests/Feature/Filament/WorkspaceOverviewOperationsTest.php` and `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php`
|
||||
|
||||
### Implementation for User Story 2
|
||||
|
||||
- [X] T016 [US2] Split workspace summary metrics into scope, governance-risk, activity, and alert categories, preserving expiring governance and stale, failed, or materially degraded compare posture as governance-risk inputs, in `app/Support/Workspaces/WorkspaceOverviewBuilder.php`
|
||||
- [X] T017 [US2] Update stat-card labels, descriptions, and destination semantics for governance-risk versus activity counts in `app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php` and `resources/views/filament/pages/workspace-overview.blade.php`
|
||||
- [X] T018 [US2] Keep recent operations diagnostic-only and remove its ability to define calmness on its own in `app/Filament/Widgets/Workspace/WorkspaceRecentOperations.php`, `resources/views/filament/widgets/workspace/workspace-recent-operations.blade.php`, and `app/Support/Workspaces/WorkspaceOverviewBuilder.php`
|
||||
- [X] T019 [US2] Run focused US2 verification against `tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php`, `tests/Feature/Filament/WorkspaceOverviewOperationsTest.php`, `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php`, and `tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php`
|
||||
|
||||
**Checkpoint**: The summary strip and surrounding copy now distinguish portfolio risk from portfolio activity.
|
||||
|
||||
---
|
||||
|
||||
## Phase 5: User Story 3 - Jump Into The Right Tenant Surface (Priority: P2)
|
||||
|
||||
**Goal**: Make each attention item identify the tenant and open a trustworthy next surface for the same problem family.
|
||||
|
||||
**Independent Test**: Seed representative findings, stale, failed, or materially degraded compare, evidence, review, alert, and operations cases, then verify each workspace attention item preserves tenant identity and reaches the correct destination or a safe fallback or disabled state.
|
||||
|
||||
### Tests for User Story 3
|
||||
|
||||
- [X] T020 [P] [US3] Add drill-through continuity coverage for tenant dashboard, findings, stale, failed, or materially degraded compare posture, evidence, review, alerts overview, and operations destinations in `tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php`
|
||||
- [X] T021 [P] [US3] Add capability-limited fallback, non-clickable state, zero-tenant choose-workspace recovery, and low-permission operations fallback coverage in `tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php` and `tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php`
|
||||
|
||||
### Implementation for User Story 3
|
||||
|
||||
- [X] T022 [US3] Implement per-family primary destination selection with tenant-safe fallback or disabled states, explicit alerts-overview routing, `switch_workspace` as the zero-tenant default next action, `operations_index` as the low-permission workspace-state fallback, aggregate lapsed-governance fallback to the tenant dashboard when findings filters would narrow the invalid-governance family, and tenant-scope authorization checks through `app/Services/Auth/CapabilityResolver.php` alongside `app/Services/Auth/WorkspaceCapabilityResolver.php` in `app/Support/Workspaces/WorkspaceOverviewBuilder.php`
|
||||
- [X] T023 [US3] Wire primary actions and helper text for workspace attention items across findings, compare, evidence, reviews, alerts, and operations, keeping every promoted item tenant-identified, in `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php`, `resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php`, and `app/Filament/Pages/WorkspaceOverview.php`
|
||||
- [X] T024 [US3] Preserve canonical subset continuity for workspace-originated findings and operations drill-throughs, and route aggregate lapsed-governance attention through the tenant dashboard when a findings filter would otherwise narrow the invalid-governance family, in `app/Filament/Resources/FindingResource/Pages/ListFindings.php`, `app/Filament/Pages/Monitoring/Operations.php`, and `app/Support/Workspaces/WorkspaceOverviewBuilder.php`
|
||||
- [X] T025 [US3] Run focused US3 verification against `tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php`, `tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php`, and `tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php`
|
||||
|
||||
**Checkpoint**: Every central attention family now opens the correct tenant surface or a safe, non-deceptive fallback state.
|
||||
|
||||
---
|
||||
|
||||
## Phase 6: Polish & Cross-Cutting Concerns
|
||||
|
||||
**Purpose**: Finish copy alignment, formatting, and the final focused verification pack across all stories.
|
||||
|
||||
- [X] T026 [P] Align final operator copy, urgency labels, disabled helper text, zero-tenant recovery wording, and low-permission `Open operations` fallback wording across `app/Filament/Pages/WorkspaceOverview.php`, `app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php`, `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php`, `resources/views/filament/pages/workspace-overview.blade.php`, and `resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php`
|
||||
- [X] T027 Run formatting with `vendor/bin/sail bin pint --dirty --format agent` for `app/Support/Workspaces/WorkspaceOverviewBuilder.php`, `app/Filament/Pages/WorkspaceOverview.php`, `app/Filament/Widgets/Workspace/WorkspaceSummaryStats.php`, `app/Filament/Widgets/Workspace/WorkspaceNeedsAttention.php`, `app/Filament/Widgets/Workspace/WorkspaceRecentOperations.php`, `resources/views/filament/pages/workspace-overview.blade.php`, `resources/views/filament/widgets/workspace/workspace-needs-attention.blade.php`, and `resources/views/filament/widgets/workspace/workspace-recent-operations.blade.php`
|
||||
- [X] T028 Run the final quickstart verification pack from `specs/175-workspace-governance-attention/quickstart.md` against `tests/Feature/Filament/WorkspaceOverviewAccessTest.php`, `tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php`, `tests/Feature/Filament/WorkspaceOverviewLandingTest.php`, `tests/Feature/Filament/WorkspaceOverviewNavigationTest.php`, `tests/Feature/Filament/WorkspaceOverviewContentTest.php`, `tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php`, `tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php`, `tests/Feature/Filament/WorkspaceOverviewOperationsTest.php`, `tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php`, `tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php`, `tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php`, and `tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php`
|
||||
- [X] T029 Run the manual smoke checks in `specs/175-workspace-governance-attention/quickstart.md` for quiet-operations-risky-governance, stale or failed compare posture, healthy workspace, zero-tenant recovery, and permission-limited member scenarios
|
||||
- [X] T030 Fix the low-permission workspace operations fallback so workspace-originated drill-through clears tenant context and immediately shows workspace-wide follow-up in `app/Support/Workspaces/WorkspaceOverviewBuilder.php`, `app/Support/OperationRunLinks.php`, `app/Filament/Pages/Monitoring/Operations.php`, `tests/Feature/Monitoring/OperationsDashboardDrillthroughTest.php`, and `tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php`
|
||||
|
||||
---
|
||||
|
||||
## Dependencies & Execution Order
|
||||
|
||||
### Phase Dependencies
|
||||
|
||||
- **Setup (Phase 1)**: No dependencies; can start immediately.
|
||||
- **Foundational (Phase 2)**: Depends on Setup; blocks all user stories.
|
||||
- **User Story 1 (Phase 3)**: Depends on Foundational completion.
|
||||
- **User Story 2 (Phase 4)**: Depends on Foundational completion and stays independently testable, though it overlaps with the same workspace builder and page shell.
|
||||
- **User Story 3 (Phase 5)**: Depends on Foundational completion and benefits from User Stories 1 and 2 because the destination contract is clearer once governance promotion and metric separation are in place.
|
||||
- **Polish (Phase 6)**: Depends on all desired user stories being complete.
|
||||
|
||||
### User Story Dependencies
|
||||
|
||||
- **User Story 1 (P1)**: First deliverable and recommended MVP. No dependency on other user stories after Foundational work.
|
||||
- **User Story 2 (P1)**: Can start after Foundational completion and remains independently testable, though it shares the builder and page shell with US1.
|
||||
- **User Story 3 (P2)**: Can start after Foundational completion and is best delivered after US1 and US2 because it hardens the attention items already introduced there.
|
||||
|
||||
### Within Each User Story
|
||||
|
||||
- Story tests should be added before or alongside implementation and must fail before the story is considered complete.
|
||||
- Builder changes should land before widget and page copy refinements that depend on the new payload.
|
||||
- Destination continuity changes should land before story-level verification runs.
|
||||
- Story-level verification should complete before moving on to polish.
|
||||
|
||||
### Parallel Opportunities
|
||||
|
||||
- Setup review tasks `T002` and `T003` can run in parallel.
|
||||
- In Foundational work, `T006` and `T007` can run in parallel after `T005` defines the payload contract.
|
||||
- In US1, `T008` and `T009` can run in parallel.
|
||||
- In US2, `T014` and `T015` can run in parallel.
|
||||
- In US3, `T020` and `T021` can run in parallel.
|
||||
- In Phase 6, `T026` can run while the final verification command set for `T028` is being prepared.
|
||||
|
||||
---
|
||||
|
||||
## Parallel Example: User Story 1
|
||||
|
||||
```bash
|
||||
# Launch US1 tests in parallel:
|
||||
T008 tests/Feature/Filament/WorkspaceOverviewGovernanceAttentionTest.php
|
||||
T009 tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php + tests/Feature/Filament/WorkspaceOverviewContentTest.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 2
|
||||
|
||||
```bash
|
||||
# Launch US2 test work in parallel:
|
||||
T014 tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php + tests/Feature/Filament/WorkspaceOverviewContentTest.php
|
||||
T015 tests/Feature/Filament/WorkspaceOverviewOperationsTest.php + tests/Feature/Filament/WorkspaceOverviewEmptyStatesTest.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 3
|
||||
|
||||
```bash
|
||||
# Launch US3 drill-through and fallback tests in parallel:
|
||||
T020 tests/Feature/Filament/WorkspaceOverviewDrilldownContinuityTest.php
|
||||
T021 tests/Feature/Filament/WorkspaceOverviewPermissionVisibilityTest.php + tests/Feature/Filament/WorkspaceOverviewAuthorizationTest.php
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### MVP First (User Story 1 Only)
|
||||
|
||||
1. Complete Phase 1: Setup.
|
||||
2. Complete Phase 2: Foundational.
|
||||
3. Complete Phase 3: User Story 1.
|
||||
4. Validate that `/admin` no longer emits a false calm signal when visible tenant governance issues exist.
|
||||
|
||||
### Incremental Delivery
|
||||
|
||||
1. Ship US1 to make the workspace home governance-aware and suppress false calmness.
|
||||
2. Add US2 to separate governance risk from activity and protect calmness semantics.
|
||||
3. Add US3 to harden drill-through continuity and capability-safe fallbacks.
|
||||
4. Finish with copy alignment, formatting, the quickstart verification pack, and manual smoke checks.
|
||||
|
||||
### Suggested MVP Scope
|
||||
|
||||
- MVP = Phases 1 through 3 only.
|
||||
|
||||
---
|
||||
|
||||
## Format Validation
|
||||
|
||||
- Every task follows the checklist format `- [ ] T### [P?] [US?] Description with file path`.
|
||||
- Setup, Foundational, and Polish phases intentionally omit story labels.
|
||||
- User story phases use `[US1]`, `[US2]`, and `[US3]` labels.
|
||||
- Parallel markers are used only on tasks that can proceed independently without conflicting incomplete prerequisites.
|
||||
36
specs/179-provider-truth-cleanup/checklists/requirements.md
Normal file
36
specs/179-provider-truth-cleanup/checklists/requirements.md
Normal file
@ -0,0 +1,36 @@
|
||||
# Specification Quality Checklist: Spec 179 - Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
**Purpose**: Validate specification completeness and quality before proceeding to planning
|
||||
**Created**: 2026-04-04
|
||||
**Feature**: [spec.md](../spec.md)
|
||||
|
||||
## Content Quality
|
||||
|
||||
- [x] No implementation details (languages, frameworks, APIs)
|
||||
- [x] Focused on user value and business needs
|
||||
- [x] Written for non-technical stakeholders
|
||||
- [x] All mandatory sections completed
|
||||
|
||||
## Requirement Completeness
|
||||
|
||||
- [x] No [NEEDS CLARIFICATION] markers remain
|
||||
- [x] Requirements are testable and unambiguous
|
||||
- [x] Success criteria are measurable
|
||||
- [x] Success criteria are technology-agnostic (no implementation details)
|
||||
- [x] All acceptance scenarios are defined
|
||||
- [x] Edge cases are identified
|
||||
- [x] Scope is clearly bounded
|
||||
- [x] Dependencies and assumptions identified
|
||||
|
||||
## Feature Readiness
|
||||
|
||||
- [x] All functional requirements have clear acceptance criteria
|
||||
- [x] User scenarios cover primary flows
|
||||
- [x] Feature meets measurable outcomes defined in Success Criteria
|
||||
- [x] No implementation details leak into specification
|
||||
|
||||
## Notes
|
||||
|
||||
- Validation pass completed on 2026-04-04.
|
||||
- Constitution-required route and action-surface references are intentionally confined to the surface contract and action matrix.
|
||||
- No clarification questions were required because the requested truth rules, scope boundaries, and follow-up exclusions were explicit.
|
||||
@ -0,0 +1,390 @@
|
||||
openapi: 3.1.0
|
||||
info:
|
||||
title: Provider Truth Cleanup Internal Surface Contract
|
||||
version: 0.1.0
|
||||
summary: Internal planning contract for tenant and provider status-truth cleanup
|
||||
description: |
|
||||
This contract is an internal planning artifact for Spec 179. The affected
|
||||
routes continue to render HTML. The schemas below describe the structured
|
||||
truth that must be derivable before rendering so tenant and provider
|
||||
surfaces stop elevating legacy status projections over lifecycle, consent,
|
||||
and verification.
|
||||
servers:
|
||||
- url: /internal
|
||||
x-surface-consumers:
|
||||
- surface: tenant.list
|
||||
summarySource:
|
||||
- tenant.lifecycle
|
||||
- optional_bounded_provider_signal
|
||||
guardScope:
|
||||
- app/Filament/Resources/TenantResource.php
|
||||
expectedContract:
|
||||
- lifecycle_is_primary_tenant_truth
|
||||
- legacy_app_status_is_not_default_visible
|
||||
- provider_signal_may_be_omitted_if_no_truthful_bounded_summary_exists
|
||||
- surface: tenant.detail.provider_summary
|
||||
summarySource:
|
||||
- tenant.lifecycle
|
||||
- tenant.provider_connection_state_helper
|
||||
- provider_connection.consent_status
|
||||
- provider_connection.verification_status
|
||||
- latest_provider_connection_check_run
|
||||
guardScope:
|
||||
- app/Filament/Resources/TenantResource.php
|
||||
- resources/views/filament/infolists/entries/provider-connection-state.blade.php
|
||||
- app/Filament/Widgets/Tenant/TenantVerificationReport.php
|
||||
expectedContract:
|
||||
- lifecycle_is_separate_from_provider_truth
|
||||
- provider_summary_leads_with_consent_and_verification
|
||||
- legacy_status_and_health_are_diagnostic_only
|
||||
- missing_default_connection_never_reads_as_ready
|
||||
- surface: provider_connections.list
|
||||
summarySource:
|
||||
- provider_connection.consent_status
|
||||
- provider_connection.verification_status
|
||||
- provider_connection.connection_type
|
||||
- provider_connection.is_default
|
||||
- provider_connection.legacy_diagnostics
|
||||
guardScope:
|
||||
- app/Filament/Resources/ProviderConnectionResource.php
|
||||
- app/Filament/Resources/ProviderConnectionResource/Pages/ListProviderConnections.php
|
||||
expectedContract:
|
||||
- consent_and_verification_are_default_visible_axes
|
||||
- legacy_status_and_health_are_secondary
|
||||
- core_filters_follow_leading_truth
|
||||
- surface: provider_connections.detail
|
||||
summarySource:
|
||||
- provider_connection.consent_status
|
||||
- provider_connection.verification_status
|
||||
- provider_connection.legacy_diagnostics
|
||||
guardScope:
|
||||
- app/Filament/Resources/ProviderConnectionResource.php
|
||||
- app/Filament/Resources/ProviderConnectionResource/Pages/ViewProviderConnection.php
|
||||
- app/Filament/Resources/ProviderConnectionResource/Pages/EditProviderConnection.php
|
||||
expectedContract:
|
||||
- current_state_and_diagnostics_are_visually_separate
|
||||
- configured_or_consented_is_not_equated_with_verified
|
||||
- legacy_diagnostics_do_not_dominate
|
||||
paths:
|
||||
/admin/tenants:
|
||||
get:
|
||||
summary: Render the tenant list with lifecycle-led truth and no legacy app-status prominence
|
||||
operationId: viewTenantListTruthCleanup
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant list rendered with lifecycle as the primary tenant truth and no default-visible app-status truth
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.tenant-list-truth+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/TenantListTruthBundle'
|
||||
'404':
|
||||
description: Workspace or tenant scope is outside entitlement
|
||||
/admin/tenants/{tenant}:
|
||||
get:
|
||||
summary: Render tenant detail with lifecycle and provider truth separated
|
||||
operationId: viewTenantTruthDetail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
responses:
|
||||
'200':
|
||||
description: Tenant detail rendered with lifecycle separate from provider consent and provider verification
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.tenant-detail-truth+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/TenantDetailTruthModel'
|
||||
'404':
|
||||
description: Tenant is outside entitlement scope
|
||||
/admin/provider-connections:
|
||||
get:
|
||||
summary: Render the canonical provider-connections list with consent and verification as primary axes
|
||||
operationId: viewProviderConnectionsTruthList
|
||||
responses:
|
||||
'200':
|
||||
description: Provider-connection list rendered with current-state truth leading and legacy diagnostics secondary
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.provider-connections-list-truth+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ProviderConnectionListTruthBundle'
|
||||
'302':
|
||||
description: Workspace members without an active tenant filter or equivalent context may be redirected according to existing canonical-admin rules
|
||||
'404':
|
||||
description: Workspace or tenant scope is outside entitlement
|
||||
/admin/provider-connections/{record}:
|
||||
get:
|
||||
summary: Render provider connection detail with current state and diagnostics separated
|
||||
operationId: viewProviderConnectionTruthDetail
|
||||
parameters:
|
||||
- name: record
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type:
|
||||
- integer
|
||||
- string
|
||||
responses:
|
||||
'200':
|
||||
description: Provider-connection detail rendered with consent and verification as the leading state contract
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.provider-connection-detail-truth+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ProviderConnectionDetailTruthModel'
|
||||
'403':
|
||||
description: Actor is in scope but lacks the capability required for a protected action on the page
|
||||
'404':
|
||||
description: Provider connection is outside entitlement scope
|
||||
/admin/provider-connections/{record}/edit:
|
||||
get:
|
||||
summary: Render provider connection edit with current state context before mutations
|
||||
operationId: editProviderConnectionTruthDetail
|
||||
parameters:
|
||||
- name: record
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type:
|
||||
- integer
|
||||
- string
|
||||
responses:
|
||||
'200':
|
||||
description: Provider-connection edit page rendered with current consent and verification context and separate diagnostics
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.provider-connection-edit-truth+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ProviderConnectionDetailTruthModel'
|
||||
'403':
|
||||
description: Actor is in scope but lacks manage capability
|
||||
'404':
|
||||
description: Provider connection is outside entitlement scope
|
||||
components:
|
||||
schemas:
|
||||
VisibilityMode:
|
||||
type: string
|
||||
enum:
|
||||
- hidden
|
||||
- diagnostic
|
||||
- primary
|
||||
ProviderSignal:
|
||||
type: object
|
||||
required:
|
||||
- mode
|
||||
- explanation
|
||||
properties:
|
||||
mode:
|
||||
type: string
|
||||
enum:
|
||||
- omitted
|
||||
- missing_default_connection
|
||||
- consent_verification_summary
|
||||
consentStatus:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
verificationStatus:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
explanation:
|
||||
type: string
|
||||
TenantListRow:
|
||||
type: object
|
||||
required:
|
||||
- tenantId
|
||||
- tenantLabel
|
||||
- lifecycle
|
||||
- legacyAppStatusVisibility
|
||||
- primaryInspectUrl
|
||||
properties:
|
||||
tenantId:
|
||||
type: integer
|
||||
tenantLabel:
|
||||
type: string
|
||||
lifecycle:
|
||||
type: string
|
||||
providerSignal:
|
||||
oneOf:
|
||||
- $ref: '#/components/schemas/ProviderSignal'
|
||||
- type: 'null'
|
||||
legacyAppStatusVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
primaryInspectUrl:
|
||||
type: string
|
||||
TenantListTruthBundle:
|
||||
type: object
|
||||
required:
|
||||
- rows
|
||||
properties:
|
||||
rows:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/TenantListRow'
|
||||
TenantProviderSummary:
|
||||
type: object
|
||||
required:
|
||||
- connectionPresence
|
||||
- ctaUrl
|
||||
- legacyStatusVisibility
|
||||
- legacyHealthVisibility
|
||||
properties:
|
||||
connectionPresence:
|
||||
type: string
|
||||
enum:
|
||||
- missing
|
||||
- configured
|
||||
- default_configured
|
||||
ctaUrl:
|
||||
type: string
|
||||
displayName:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
provider:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
consentStatus:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
verificationStatus:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
lastCheckedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
lastErrorReasonCode:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
legacyStatusVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
legacyHealthVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
TenantDetailTruthModel:
|
||||
type: object
|
||||
required:
|
||||
- tenantId
|
||||
- lifecycle
|
||||
- providerSummary
|
||||
properties:
|
||||
tenantId:
|
||||
type: integer
|
||||
lifecycle:
|
||||
type: string
|
||||
providerSummary:
|
||||
$ref: '#/components/schemas/TenantProviderSummary'
|
||||
verificationReportSurface:
|
||||
type: string
|
||||
description: Existing tenant verification widget remains the deep-dive verification surface
|
||||
ProviderConnectionListItem:
|
||||
type: object
|
||||
required:
|
||||
- connectionId
|
||||
- displayName
|
||||
- provider
|
||||
- connectionType
|
||||
- isDefault
|
||||
- consentStatus
|
||||
- verificationStatus
|
||||
- legacyStatusVisibility
|
||||
- legacyHealthVisibility
|
||||
- primaryInspectUrl
|
||||
properties:
|
||||
connectionId:
|
||||
type: integer
|
||||
tenantLabel:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
displayName:
|
||||
type: string
|
||||
provider:
|
||||
type: string
|
||||
connectionType:
|
||||
type: string
|
||||
isDefault:
|
||||
type: boolean
|
||||
consentStatus:
|
||||
type: string
|
||||
verificationStatus:
|
||||
type: string
|
||||
legacyStatusVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
legacyHealthVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
primaryInspectUrl:
|
||||
type: string
|
||||
ProviderConnectionListTruthBundle:
|
||||
type: object
|
||||
required:
|
||||
- rows
|
||||
properties:
|
||||
rows:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/ProviderConnectionListItem'
|
||||
ProviderConnectionDetailTruthModel:
|
||||
type: object
|
||||
required:
|
||||
- connectionId
|
||||
- displayName
|
||||
- provider
|
||||
- connectionType
|
||||
- isDefault
|
||||
- consentStatus
|
||||
- verificationStatus
|
||||
- legacyStatusVisibility
|
||||
- legacyHealthVisibility
|
||||
properties:
|
||||
connectionId:
|
||||
type: integer
|
||||
displayName:
|
||||
type: string
|
||||
provider:
|
||||
type: string
|
||||
connectionType:
|
||||
type: string
|
||||
isDefault:
|
||||
type: boolean
|
||||
consentStatus:
|
||||
type: string
|
||||
verificationStatus:
|
||||
type: string
|
||||
lastCheckedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
lastErrorReasonCode:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
lastErrorMessage:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
migrationReviewRequired:
|
||||
type: boolean
|
||||
legacyStatusVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
legacyHealthVisibility:
|
||||
$ref: '#/components/schemas/VisibilityMode'
|
||||
222
specs/179-provider-truth-cleanup/data-model.md
Normal file
222
specs/179-provider-truth-cleanup/data-model.md
Normal file
@ -0,0 +1,222 @@
|
||||
# Phase 1 Data Model: Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
## Overview
|
||||
|
||||
This feature adds no table, no new enum, and no persisted readiness artifact. It reclassifies which already-stored fields are allowed to act as leading operator truth on tenant and provider connection surfaces.
|
||||
|
||||
## Persistent Source Truths
|
||||
|
||||
### Tenant
|
||||
|
||||
**Purpose**: Tenant identity and lifecycle boundary for all tenant-facing operator surfaces.
|
||||
|
||||
**Key fields**:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `external_id`
|
||||
- `name`
|
||||
- `status`
|
||||
- `app_status` (legacy tenant-level projection)
|
||||
- `rbac_status`
|
||||
|
||||
**Relationships**:
|
||||
- `Tenant` has many `ProviderConnection`
|
||||
|
||||
**Validation rules**:
|
||||
- `status` remains the authoritative tenant lifecycle input and maps through `TenantLifecycle`.
|
||||
- `app_status` remains persisted but is no longer allowed to act as leading operator truth on targeted tenant surfaces.
|
||||
- `rbac_status` remains a separate domain and must not substitute for provider readiness.
|
||||
|
||||
### ProviderConnection
|
||||
|
||||
**Purpose**: Canonical stored provider-connection record for tenant-scoped provider integration state.
|
||||
|
||||
**Key fields**:
|
||||
- `id`
|
||||
- `tenant_id`
|
||||
- `workspace_id`
|
||||
- `provider`
|
||||
- `display_name`
|
||||
- `is_default`
|
||||
- `connection_type`
|
||||
- `consent_status`
|
||||
- `verification_status`
|
||||
- `status` (legacy connection-state projection)
|
||||
- `health_status` (legacy health projection)
|
||||
- `last_health_check_at`
|
||||
- `last_error_reason_code`
|
||||
- `last_error_message`
|
||||
- `migration_review_required`
|
||||
|
||||
**Relationships**:
|
||||
- `ProviderConnection` belongs to `Tenant`
|
||||
- `ProviderConnection` belongs to `Workspace`
|
||||
- `ProviderConnection` has one `ProviderCredential`
|
||||
|
||||
**Validation rules**:
|
||||
- `consent_status` is the primary stored truth for consent progression.
|
||||
- `verification_status` is the primary stored truth for current provider verification outcome.
|
||||
- `status` and `health_status` may remain persisted and updated by existing projections, but targeted operator surfaces must treat them as secondary diagnostics only.
|
||||
- `is_default` remains the routing anchor for tenant-facing provider summaries where a single connection must be chosen.
|
||||
|
||||
### ProviderCredential
|
||||
|
||||
**Purpose**: Encrypted credential storage associated with a provider connection.
|
||||
|
||||
**Key fields**:
|
||||
- `provider_connection_id`
|
||||
- encrypted credential payload fields
|
||||
|
||||
**Relationships**:
|
||||
- `ProviderCredential` belongs to `ProviderConnection`
|
||||
|
||||
**Validation rules**:
|
||||
- This spec does not change credential persistence, mutation rules, or encryption handling.
|
||||
- Credential presence may continue to influence diagnostic projections, but it is not itself rendered as a leading readiness label on the targeted surfaces.
|
||||
|
||||
### OperationRun / Verification Report
|
||||
|
||||
**Purpose**: Stored verification evidence used by tenant verification and provider check surfaces.
|
||||
|
||||
**Key fields**:
|
||||
- `tenant_id`
|
||||
- `type` with `provider.connection.check`
|
||||
- `status`
|
||||
- `outcome`
|
||||
- `context`
|
||||
- stored verification report payload derived from the run
|
||||
|
||||
**Relationships**:
|
||||
- `OperationRun` belongs to `Tenant` when tenant-bound
|
||||
|
||||
**Validation rules**:
|
||||
- The latest stored verification report remains the deep-dive verification surface for tenant detail.
|
||||
- This spec does not change run lifecycle, queueing, or verification report persistence.
|
||||
|
||||
## Existing Domain State Families
|
||||
|
||||
### TenantLifecycle
|
||||
|
||||
**Values**:
|
||||
- `draft`
|
||||
- `onboarding`
|
||||
- `active`
|
||||
- `archived`
|
||||
|
||||
**Rule**:
|
||||
- Lifecycle answers whether the tenant is in the normal lifecycle. It does not answer provider consent, provider verification, or provider readiness.
|
||||
|
||||
### ProviderConsentStatus
|
||||
|
||||
**Values**:
|
||||
- `unknown`
|
||||
- `required`
|
||||
- `granted`
|
||||
- `failed`
|
||||
- `revoked`
|
||||
|
||||
**Rule**:
|
||||
- Consent answers whether the permission or consent step has been completed. It does not prove provider verification health.
|
||||
|
||||
### ProviderVerificationStatus
|
||||
|
||||
**Values**:
|
||||
- `unknown`
|
||||
- `pending`
|
||||
- `healthy`
|
||||
- `degraded`
|
||||
- `blocked`
|
||||
- `error`
|
||||
|
||||
**Rule**:
|
||||
- Verification is the primary current provider-state axis for whether a connection has been checked and what that check currently proves.
|
||||
|
||||
### Legacy Diagnostic Projections
|
||||
|
||||
**Known provider projection values in current surfaces**:
|
||||
- `status`: commonly `connected`, `needs_consent`, `error`, `disabled`
|
||||
- `health_status`: commonly `ok`, `degraded`, `down`, `unknown`
|
||||
|
||||
**Rule**:
|
||||
- These values remain diagnostics or projections. They must not compete with consent and verification as primary operator truth on targeted surfaces.
|
||||
|
||||
## Derived Surface Contracts
|
||||
|
||||
### Tenant List Row Truth (derived, non-persisted)
|
||||
|
||||
**Purpose**: Minimal row-level truth for `/admin/tenants`.
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `tenantId` | integer | yes | Tenant identifier |
|
||||
| `tenantLabel` | string | yes | Tenant name |
|
||||
| `lifecycle` | string | yes | Lifecycle label derived from `TenantLifecycle` |
|
||||
| `providerSignal` | object nullable | no | Optional bounded provider summary derived from current truth; may be absent in this slice |
|
||||
| `legacyAppStatusVisible` | boolean | yes | Must be `false` on default-visible tenant list surfaces |
|
||||
| `primaryInspectUrl` | string | yes | Canonical tenant detail destination |
|
||||
|
||||
**Validation rules**:
|
||||
- `providerSignal` may be omitted when a truthful single-row summary cannot be stated without inventing a readiness model.
|
||||
- `legacyAppStatusVisible` must be `false` for the default tenant list configuration.
|
||||
|
||||
### Tenant Detail Provider Summary (derived, non-persisted)
|
||||
|
||||
**Purpose**: Compact provider-state summary rendered inside the tenant detail `Provider` section.
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `connectionPresence` | enum | yes | `missing`, `configured`, or `default_configured` |
|
||||
| `ctaUrl` | string | yes | Canonical provider-connections destination |
|
||||
| `displayName` | string nullable | no | Default or chosen connection display name |
|
||||
| `provider` | string nullable | no | Provider label |
|
||||
| `consentStatus` | string nullable | no | Current consent state from the chosen connection |
|
||||
| `verificationStatus` | string nullable | no | Current verification state from the chosen connection |
|
||||
| `lastCheckedAt` | string nullable | no | Stored last-check timestamp |
|
||||
| `lastErrorReasonCode` | string nullable | no | Diagnostic reason code when present |
|
||||
| `legacyStatus` | string nullable | no | Legacy diagnostic projection |
|
||||
| `legacyHealthStatus` | string nullable | no | Legacy health projection |
|
||||
|
||||
**Validation rules**:
|
||||
- Consent and verification are the leading fields in this summary.
|
||||
- Legacy status and health may remain available only as diagnostics.
|
||||
- When no default Microsoft provider connection exists, the summary must explicitly say action is needed and must not invent a healthy or ready label.
|
||||
|
||||
### Provider Connection Surface Truth (derived, non-persisted)
|
||||
|
||||
**Purpose**: Shared truth hierarchy for provider connection list, view, and edit surfaces.
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|------|------|----------|-------------|
|
||||
| `connectionId` | integer | yes | Provider connection identifier |
|
||||
| `tenantLabel` | string nullable | no | Tenant label when rendered on tenantless canonical surfaces |
|
||||
| `displayName` | string | yes | Connection display name |
|
||||
| `provider` | string | yes | Provider key or label |
|
||||
| `connectionType` | string | yes | Platform or dedicated |
|
||||
| `isDefault` | boolean | yes | Default designation |
|
||||
| `consentStatus` | string | yes | Leading consent truth |
|
||||
| `verificationStatus` | string | yes | Leading verification truth |
|
||||
| `legacyStatus` | string nullable | no | Secondary diagnostic projection |
|
||||
| `legacyHealthStatus` | string nullable | no | Secondary diagnostic projection |
|
||||
| `migrationReviewRequired` | boolean | yes | Secondary diagnostic flag |
|
||||
| `lastCheckedAt` | string nullable | no | Last stored check timestamp |
|
||||
| `lastErrorReasonCode` | string nullable | no | Stored diagnostic reason code |
|
||||
|
||||
**Validation rules**:
|
||||
- List, view, and edit surfaces must display `consentStatus` and `verificationStatus` before any legacy projection fields.
|
||||
- Legacy fields may remain filterable or visible only when clearly marked and positioned as diagnostics.
|
||||
- `connectionType` and `isDefault` remain supporting facts, not substitutes for readiness.
|
||||
|
||||
## Surface Truth Hierarchy Rules
|
||||
|
||||
1. Tenant lifecycle is the primary tenant-state axis.
|
||||
2. Provider consent and provider verification are the primary provider-state axes.
|
||||
3. RBAC remains a separate tenant-management domain.
|
||||
4. Legacy tenant app status, provider status, and provider health are diagnostic-only on targeted surfaces.
|
||||
5. No derived surface contract in this feature may collapse `active`, `connected`, or `consented` into a synthetic `ready` value.
|
||||
|
||||
## No New Persistence
|
||||
|
||||
- No new table is introduced.
|
||||
- No new enum or reason family is introduced.
|
||||
- No new persisted readiness summary is introduced.
|
||||
- Existing persisted legacy fields remain for compatibility, but their surface role is reduced.
|
||||
322
specs/179-provider-truth-cleanup/plan.md
Normal file
322
specs/179-provider-truth-cleanup/plan.md
Normal file
@ -0,0 +1,322 @@
|
||||
# Implementation Plan: Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
**Branch**: `179-provider-truth-cleanup` | **Date**: 2026-04-04 | **Spec**: `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/179-provider-truth-cleanup/spec.md`
|
||||
**Input**: Feature specification from `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/179-provider-truth-cleanup/spec.md`
|
||||
|
||||
**Note**: This plan keeps the current tenant and provider connection model intact. It cleans up which already-stored fields are allowed to act as leading operator truth and explicitly avoids introducing a new readiness model, new persistence, or a new semantic framework.
|
||||
|
||||
## Summary
|
||||
|
||||
Harden the existing tenant and provider operator surfaces so lifecycle, consent, and verification become the only leading truth axes on the targeted pages. The implementation will remove `Tenant.app_status` from primary tenant surfaces, repoint the tenant-detail Provider section from legacy connection `status` and `health_status` to current consent and verification, and reorganize provider connection list, view, and edit surfaces so legacy projections become secondary diagnostics. The narrowest safe tenant-list choice in this slice is to omit a new row-level provider readiness signal rather than invent one. The provider list will instead promote consent and verification to the default-visible connection-state axes, while existing legacy fields remain persisted and available only as secondary diagnostics.
|
||||
|
||||
## Technical Context
|
||||
|
||||
**Language/Version**: PHP 8.4.15
|
||||
**Primary Dependencies**: Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantResource`, `ProviderConnectionResource`, `TenantVerificationReport`, `BadgeCatalog`, `BadgeRenderer`, `TenantOperabilityService`, `ProviderConsentStatus`, `ProviderVerificationStatus`, and shared provider-state Blade partials
|
||||
**Storage**: PostgreSQL unchanged; no new table, column, or persisted artifact is introduced
|
||||
**Testing**: Pest 4 feature tests and Livewire-style Filament surface tests through Laravel Sail, reusing existing tenant and provider surface tests plus focused Spec 179 truth-cleanup coverage
|
||||
**Target Platform**: Laravel monolith web application running in Sail locally and containerized Linux environments in staging and production
|
||||
**Project Type**: web application
|
||||
**Performance Goals**: Keep existing DB-only render guarantees, avoid adding uncontrolled per-row provider queries to the tenant list, and keep provider and tenant detail rendering bounded to already-loaded or single-record derived state
|
||||
**Constraints**: No new readiness enum or score, no new persisted truth, no new presenter or taxonomy framework, no authorization widening, no cross-tenant leakage, no new asset pipeline work, and no false equivalence between `active`, `connected`, `consented`, and `ready`
|
||||
**Scale/Scope**: Two existing Filament resources, five operator-facing surfaces, one existing tenant provider-summary partial, one tenant verification widget, three legacy badge domains under review, and a focused regression pack around truth hierarchy and filter semantics
|
||||
|
||||
## Constitution Check
|
||||
|
||||
*GATE: Passed before Phase 0 research. Re-check after Phase 1 design.*
|
||||
|
||||
| Principle | Pre-Research | Post-Design | Notes |
|
||||
|-----------|--------------|-------------|-------|
|
||||
| Inventory-first / snapshots-second | PASS | PASS | The feature changes only read-time presentation of already-stored tenant and provider truth. No snapshot or inventory contract changes are introduced. |
|
||||
| Read/write separation | PASS | PASS | No new mutation path, preview flow, or destructive action is added. Existing provider and tenant mutations remain unchanged. |
|
||||
| Graph contract path | N/A | N/A | No Graph contract or `config/graph_contracts.php` change is required. |
|
||||
| Deterministic capabilities | PASS | PASS | Existing provider view/manage and tenant membership rules remain authoritative. |
|
||||
| RBAC-UX authorization semantics | PASS | PASS | All touched surfaces remain in `/admin`, preserve tenant and workspace scoping, keep non-members at `404`, and keep member-without-capability behavior unchanged. |
|
||||
| Workspace and tenant isolation | PASS | PASS | No new route or query broadens tenant visibility. Canonical tenantless provider routes remain tenant-aware and scoped. |
|
||||
| Run observability / Ops-UX | PASS | PASS | No new `OperationRun` type or queueing behavior is introduced. Existing verification and provider-run actions keep their current semantics. |
|
||||
| Data minimization | PASS | PASS | No new persisted data, logs, or surface payloads are introduced. |
|
||||
| Proportionality / no premature abstraction | PASS | PASS | The plan reuses existing resources, helpers, and partials instead of adding a new readiness service, presenter, or DTO layer. |
|
||||
| Persisted truth / behavioral state | PASS | PASS | No new state family or table is planned. Existing legacy fields remain persisted for compatibility but lose leading surface prominence. |
|
||||
| UI semantics / few layers | PASS | PASS | The plan uses direct lifecycle, consent, and verification truth instead of introducing a new readiness interpreter. |
|
||||
| Badge semantics (BADGE-001) | PASS | PASS | Existing badge semantics remain centralized. Where provider consent or verification need status-like badges, the plan extends `BadgeCatalog` and `BadgeRenderer` through narrow centralized mappings instead of page-local labels or a synthetic readiness domain. |
|
||||
| Filament-native UI / Action Surface Contract | PASS | PASS | Existing Filament resources, sections, tables, infolists, view entries, and action groups are reused. No redundant inspect action or empty group is introduced. |
|
||||
| Filament UX-001 | PASS | PASS | No new screen type is introduced. Existing list, view, and edit surfaces remain within current Filament layout patterns while truth hierarchy changes inside those sections. |
|
||||
| Filament v5 / Livewire v4 compliance | PASS | PASS | The design stays within the current Filament v5 and Livewire v4 stack. |
|
||||
| Provider registration location | PASS | PASS | No provider or panel registration change is required; Laravel 11+ provider registration remains in `bootstrap/providers.php`. |
|
||||
| Global search hard rule | PASS | PASS | `TenantResource` remains globally searchable and already has view and edit pages. `ProviderConnectionResource` remains non-globally-searchable. |
|
||||
| Destructive action safety | PASS | PASS | No new destructive action is introduced. Existing archive, restore, force-delete, credential deletion, and disable flows remain confirmed and capability-gated. |
|
||||
| Asset strategy | PASS | PASS | No new asset bundle or deploy-time `filament:assets` change is required. |
|
||||
| Testing truth (TEST-TRUTH-001) | PASS | PASS | The plan adds focused regression coverage for default-visible truth hierarchy, filter semantics, and non-readiness interpretation. |
|
||||
|
||||
## Phase 0 Research
|
||||
|
||||
Research outcomes are captured in `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/179-provider-truth-cleanup/research.md`.
|
||||
|
||||
Key decisions:
|
||||
|
||||
- Remove tenant-list `app_status` prominence entirely instead of replacing it with a premature readiness badge.
|
||||
- Reuse the existing tenant-detail Provider section and `providerConnectionState()` helper, but make consent and verification the leading provider summary fields.
|
||||
- Keep `TenantVerificationReport` as the verification deep-dive and do not repurpose tenant operability gating as provider readiness truth.
|
||||
- Promote provider connection `consent_status` and `verification_status` to the list’s default-visible current-state axes.
|
||||
- Split provider connection detail and edit pages into current-state truth versus diagnostics rather than one mixed `Status` section.
|
||||
- Keep legacy persisted fields and existing projection writers intact; this slice is presentation cleanup only.
|
||||
- Update provider filters so the main operator filter language follows consent and verification rather than legacy status projections.
|
||||
- Extend existing surface-truth tests and add one focused provider-surface truth test instead of introducing a broader test framework.
|
||||
|
||||
## Phase 1 Design
|
||||
|
||||
Design artifacts are created under `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/179-provider-truth-cleanup/`:
|
||||
|
||||
- `research.md`: planning decisions and rejected alternatives
|
||||
- `data-model.md`: persistent source truths and derived surface truth contracts
|
||||
- `contracts/provider-truth-cleanup.openapi.yaml`: internal route and surface contract for tenant and provider truth cleanup
|
||||
- `quickstart.md`: focused implementation and validation workflow
|
||||
|
||||
Design highlights:
|
||||
|
||||
- The tenant list will remain lifecycle-led and will not gain a new speculative readiness badge in this slice.
|
||||
- `TenantResource::providerConnectionState()` and the shared Provider infolist entry will be repointed to current consent and verification truth, with legacy `status` and `health_status` relegated to diagnostics.
|
||||
- `Tenant.app_status` will be removed from the leading tenant-list and tenant-detail operator contract rather than simply hidden behind a toggle.
|
||||
- `ProviderConnectionResource` will make consent and verification the default-visible list columns and primary detail/edit state section, while legacy status and health become secondary diagnostics.
|
||||
- No new readiness framework, readiness enum, or provider-state presenter will be introduced. Existing badge infrastructure will be extended only as needed with narrow centralized mappings for provider consent and provider verification, while legacy lifecycle and diagnostic mappings remain centralized.
|
||||
- Existing provider mutation, verification, and authorization behavior stays intact; only the truth hierarchy on touched surfaces changes.
|
||||
|
||||
## Phase 1 — Agent Context Update
|
||||
|
||||
Run after artifact generation:
|
||||
|
||||
- `.specify/scripts/bash/update-agent-context.sh copilot`
|
||||
|
||||
## Project Structure
|
||||
|
||||
### Documentation (this feature)
|
||||
|
||||
```text
|
||||
specs/179-provider-truth-cleanup/
|
||||
├── spec.md
|
||||
├── plan.md
|
||||
├── research.md
|
||||
├── data-model.md
|
||||
├── quickstart.md
|
||||
├── contracts/
|
||||
│ └── provider-truth-cleanup.openapi.yaml
|
||||
├── checklists/
|
||||
│ └── requirements.md
|
||||
└── tasks.md
|
||||
```
|
||||
|
||||
### Source Code (repository root)
|
||||
|
||||
```text
|
||||
app/
|
||||
├── Filament/
|
||||
│ ├── Resources/
|
||||
│ │ ├── TenantResource.php
|
||||
│ │ ├── TenantResource/
|
||||
│ │ │ └── Pages/
|
||||
│ │ │ ├── ListTenants.php
|
||||
│ │ │ └── ViewTenant.php
|
||||
│ │ ├── ProviderConnectionResource.php
|
||||
│ │ └── ProviderConnectionResource/
|
||||
│ │ └── Pages/
|
||||
│ │ ├── ListProviderConnections.php
|
||||
│ │ ├── ViewProviderConnection.php
|
||||
│ │ └── EditProviderConnection.php
|
||||
│ └── Widgets/
|
||||
│ └── Tenant/
|
||||
│ └── TenantVerificationReport.php
|
||||
├── Models/
|
||||
│ ├── Tenant.php
|
||||
│ ├── ProviderConnection.php
|
||||
│ ├── ProviderCredential.php
|
||||
│ └── OperationRun.php
|
||||
├── Services/
|
||||
│ └── Tenants/
|
||||
│ └── TenantOperabilityService.php
|
||||
└── Support/
|
||||
├── Badges/
|
||||
│ ├── BadgeCatalog.php
|
||||
│ ├── BadgeDomain.php
|
||||
│ └── Domains/
|
||||
│ ├── TenantAppStatusBadge.php
|
||||
│ ├── ProviderConnectionStatusBadge.php
|
||||
│ └── ProviderConnectionHealthBadge.php
|
||||
├── Providers/
|
||||
│ ├── ProviderConsentStatus.php
|
||||
│ └── ProviderVerificationStatus.php
|
||||
└── Tenants/
|
||||
└── TenantLifecycle.php
|
||||
|
||||
resources/
|
||||
└── views/
|
||||
└── filament/
|
||||
├── infolists/
|
||||
│ └── entries/
|
||||
│ └── provider-connection-state.blade.php
|
||||
└── widgets/
|
||||
└── tenant/
|
||||
└── tenant-verification-report.blade.php
|
||||
|
||||
tests/
|
||||
├── Feature/
|
||||
│ ├── Filament/
|
||||
│ │ ├── TenantLifecycleStatusDomainSeparationTest.php
|
||||
│ │ ├── TenantTruthCleanupSpec179Test.php
|
||||
│ │ └── ProviderConnectionsDbOnlyTest.php
|
||||
│ ├── ProviderConnections/
|
||||
│ │ ├── ProviderConnectionTruthCleanupSpec179Test.php
|
||||
│ │ ├── ProviderConnectionListAuthorizationTest.php
|
||||
│ │ ├── ProviderConnectionAuthorizationTest.php
|
||||
│ │ └── RequiredFiltersTest.php
|
||||
│ ├── Tenants/
|
||||
│ │ └── TenantProviderConnectionsCtaTest.php
|
||||
│ └── Rbac/
|
||||
│ └── TenantResourceAuthorizationTest.php
|
||||
└── Unit/
|
||||
└── Badges/
|
||||
├── TenantBadgesTest.php
|
||||
└── ProviderConnectionBadgesTest.php
|
||||
```
|
||||
|
||||
**Structure Decision**: Keep the feature entirely inside the existing Laravel/Filament monolith. Update the current resources, shared provider-summary partial, tenant verification widget contract, and focused test files instead of creating a new provider-readiness subsystem.
|
||||
|
||||
## Complexity Tracking
|
||||
|
||||
> No Constitution Check violations are planned. No exception or bloat trigger is currently justified.
|
||||
|
||||
| Violation | Why Needed | Simpler Alternative Rejected Because |
|
||||
|-----------|------------|-------------------------------------|
|
||||
| — | — | — |
|
||||
|
||||
## Proportionality Review
|
||||
|
||||
> No new enum, persisted entity, abstraction layer, taxonomy, or cross-domain UI framework is planned in this slice.
|
||||
|
||||
- **Current operator problem**: Current tenant and provider surfaces let legacy status fields sound more authoritative than current lifecycle, consent, and verification truth.
|
||||
- **Existing structure is insufficient because**: The model already stores better truth, but the resources and shared provider-summary partial still foreground the wrong fields.
|
||||
- **Narrowest correct implementation**: Rewire the existing tenant and provider surfaces to consume the current truth hierarchy without inventing a new readiness model or dropping persisted compatibility fields.
|
||||
- **Ownership cost created**: Focused resource updates, one shared partial rewrite, and a small regression suite for surface truth hierarchy.
|
||||
- **Alternative intentionally rejected**: A new readiness enum, new presenter layer, or schema cleanup.
|
||||
- **Release truth**: Current-release truth cleanup.
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### Phase A — Remove Legacy Tenant App Status From Primary Tenant Surfaces
|
||||
|
||||
**Goal**: Make tenant lifecycle the only default-visible tenant status axis on the tenant list and tenant detail identity block.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| A.1 | `app/Filament/Resources/TenantResource.php` | Remove `app_status` from the default-visible tenant list column set and stop treating it as a primary list filter. Keep lifecycle and other tenant identity fields intact. |
|
||||
| A.2 | `app/Filament/Resources/TenantResource.php` | Remove `app_status` from the tenant-detail `Identity` section’s leading status contract rather than simply hiding it behind a toggle. |
|
||||
| A.3 | `tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php` and `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php` | Prove tenant list and tenant detail no longer use `app_status` as primary operator truth. |
|
||||
|
||||
### Phase B — Repoint Tenant Detail Provider Summary To Current Provider Truth
|
||||
|
||||
**Goal**: Make tenant detail show provider consent and verification rather than legacy provider connection status and health.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| B.1 | `app/Filament/Resources/TenantResource.php` | Refactor `providerConnectionState()` to derive provider summary fields from the chosen Microsoft connection’s `consent_status`, `verification_status`, `is_default`, `last_health_check_at`, and `last_error_reason_code`, while keeping missing-connection handling explicit. |
|
||||
| B.2 | `resources/views/filament/infolists/entries/provider-connection-state.blade.php` | Rewrite the Provider summary entry so consent and verification are the leading displayed values and legacy `status` and `health_status` move to optional diagnostics. |
|
||||
| B.3 | `app/Filament/Widgets/Tenant/TenantVerificationReport.php` and its Blade view | Keep the existing verification widget as the deep-dive stored-report surface and ensure the surrounding tenant-detail semantics do not duplicate or contradict it. |
|
||||
| B.4 | `tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php` and `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php` | Prove the tenant-detail provider CTA remains correct and the Provider section no longer implies readiness from legacy fields. |
|
||||
|
||||
### Phase C — Promote Consent And Verification On Provider Connection List Surfaces
|
||||
|
||||
**Goal**: Make the provider connections list answer the current provider-state questions from consent and verification first.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| C.1 | `app/Filament/Resources/ProviderConnectionResource.php` | Add default-visible consent and verification columns using existing label helpers and keep connection type and default designation as supporting facts. |
|
||||
| C.2 | `app/Filament/Resources/ProviderConnectionResource.php` | Move legacy `status` and `health_status` columns to toggleable or explicitly diagnostic visibility and adjust visible-column defaults accordingly. |
|
||||
| C.3 | `app/Filament/Resources/ProviderConnectionResource.php` | Replace or demote core `status` and `health_status` filters so the leading filter language becomes consent and verification, with legacy filters retained only if clearly diagnostic. |
|
||||
| C.4 | `tests/Feature/ProviderConnections/RequiredFiltersTest.php`, `tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php`, and `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` | Prove default-visible columns and filters follow the new hierarchy without breaking DB-only rendering. |
|
||||
|
||||
### Phase D — Split Provider Connection View And Edit Into Current State Versus Diagnostics
|
||||
|
||||
**Goal**: Prevent provider connection detail and edit pages from showing current and legacy status axes as peers.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| D.1 | `app/Filament/Resources/ProviderConnectionResource.php` | Replace the mixed `Status` infolist section with a primary current-state section for consent and verification and a secondary diagnostics section for legacy status, legacy health, migration review, and last-error fields. |
|
||||
| D.2 | `app/Filament/Resources/ProviderConnectionResource.php` | Apply the same separation to the edit form’s read-only state context so mutations happen in the presence of current consent and verification truth, with legacy fields shown only as diagnostics if retained. |
|
||||
| D.3 | `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` | Prove current state and diagnostics are visually and semantically separate on provider connection view and edit surfaces. |
|
||||
|
||||
### Phase E — Preserve Central Truth Mapping Without Adding A New Badge Framework
|
||||
|
||||
**Goal**: Keep badge and presentation semantics centralized while avoiding a new readiness taxonomy.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| E.1 | `app/Support/Badges/BadgeCatalog.php`, `app/Support/Badges/BadgeDomain.php`, `app/Support/Badges/Domains/ProviderConsentStatusBadge.php`, `app/Support/Badges/Domains/ProviderVerificationStatusBadge.php`, and existing legacy badge-domain classes | Add narrow centralized badge mappings for `consent_status` and `verification_status`, keep legacy app-status or connection-status mappings diagnostic-only, and do not introduce a synthetic readiness badge domain in this slice. |
|
||||
| E.2 | `tests/Unit/Badges/TenantBadgesTest.php` and `tests/Unit/Badges/ProviderConnectionBadgesTest.php` | Update unit badge coverage for the centralized provider consent and provider verification mappings and keep legacy diagnostic mapping expectations explicit. |
|
||||
|
||||
### Phase F — Protect Authorization, DB-only Rendering, And Formatting
|
||||
|
||||
**Goal**: Keep the cleanup semantically tight and operationally safe.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| F.1 | Existing tenant and provider authorization tests | Re-run and extend current authorization coverage only where surface visibility or filter behavior changes could affect scope boundaries. |
|
||||
| F.2 | Focused Pest verification pack | Add or update tests proving legacy-status suppression, provider current-state promotion, filter truth alignment, DB-only rendering, and denial semantics. |
|
||||
| F.3 | `vendor/bin/sail bin pint --dirty --format agent` and focused Pest runs | Apply formatting and run the minimum Sail-first verification pack before implementation is considered complete. |
|
||||
|
||||
## Key Design Decisions
|
||||
|
||||
### D-001 — Do not create a new readiness model in a truth-cleanup spec
|
||||
|
||||
The current feature exists to stop misleading primary surfaces, not to coin a new readiness taxonomy. Lifecycle, consent, and verification already provide the necessary authoritative inputs.
|
||||
|
||||
### D-002 — The tenant list should consciously omit provider readiness rather than compress it unsafely
|
||||
|
||||
Any row-level provider readiness badge would require non-trivial aggregation and semantic compression across provider connections. Omitting that signal is safer and matches the spec’s fallback allowance.
|
||||
|
||||
### D-003 — Reuse the existing tenant-detail Provider section instead of adding another summary layer
|
||||
|
||||
`providerConnectionState()` and the shared infolist entry already own the tenant-detail provider summary. Repointing that contract is narrower than building a new widget or presenter.
|
||||
|
||||
### D-004 — Provider detail pages need one current-state section and one diagnostics section
|
||||
|
||||
Equal-weight status groupings are the core current UI problem. Separating current state from diagnostics is the smallest structural change that makes the leading truth obvious.
|
||||
|
||||
### D-005 — Keep legacy persisted fields, but remove their authority on targeted surfaces
|
||||
|
||||
The model and some jobs still project `status` and `health_status`, and tenant `app_status` still exists in storage. This slice preserves compatibility while eliminating misleading prominence.
|
||||
|
||||
### D-006 — Do not use tenant operability gating as provider readiness truth
|
||||
|
||||
`TenantOperabilityService` answers lifecycle and capability eligibility questions. It is not a substitute for consent or verification health and must stay separate in both implementation and messaging.
|
||||
|
||||
## Risk Assessment
|
||||
|
||||
| Risk | Impact | Likelihood | Mitigation |
|
||||
|------|--------|------------|------------|
|
||||
| Removing `app_status` from the tenant list may reduce scanability before a later readiness spec lands | Medium | Medium | Keep the tenant list lifecycle-led, keep the provider CTA obvious on tenant detail, and treat any future list signal as follow-up work rather than a rushed addition now. |
|
||||
| Tenant detail may still show the wrong provider connection when multiple connections exist | High | Medium | Continue to prefer the default Microsoft connection when present and render an explicit missing or configured state rather than an optimistic readiness label. |
|
||||
| Provider list could retain legacy semantics if filters change more slowly than columns | High | Medium | Update both default-visible columns and core filter set together and protect them with `RequiredFiltersTest` plus a focused truth test. |
|
||||
| Existing tests currently asserting `app_status` visibility will fail noisily | Medium | High | Update the intentional tenant truth-separation test first and add a spec-specific replacement that encodes the new contract. |
|
||||
| New tenant-list provider queries could create unnecessary DB cost | Medium | Low | Avoid adding a new per-row provider signal on the tenant list in this slice. |
|
||||
|
||||
## Test Strategy
|
||||
|
||||
- Update `tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php` so it protects the new tenant truth hierarchy instead of asserting legacy `app_status` prominence.
|
||||
- Add `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php` to cover tenant list default-visible truth and tenant detail Provider section semantics.
|
||||
- Add `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` to cover provider connection list, view, and edit truth hierarchy.
|
||||
- Update `tests/Feature/ProviderConnections/RequiredFiltersTest.php` so the core filter contract follows consent and verification instead of legacy status or health.
|
||||
- Update `tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php` so visible-column expectations and DB-only rendering stay valid after the list contract changes.
|
||||
- Keep `tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php` and existing authorization tests in the focused pack so route and scope semantics do not regress.
|
||||
- Keep tenant global-search safety and provider-connection global-search exclusion in the focused pack so discovery behavior does not regress.
|
||||
- Finish the feature with an explicit no-migration and no-new-persistence diff validation gate in addition to runtime regression coverage.
|
||||
- Run the focused Sail-first pack defined in `quickstart.md`, then run `vendor/bin/sail bin pint --dirty --format agent` before closing implementation.
|
||||
|
||||
## Constitution Check (Post-Design)
|
||||
|
||||
Re-check result: PASS.
|
||||
|
||||
- Livewire v4.0+ compliance: preserved because the plan stays within the current Filament v5 + Livewire v4 resources, widgets, and pages.
|
||||
- Provider registration location: unchanged; no panel or provider registration work is needed beyond the existing `bootstrap/providers.php` setup.
|
||||
- Global-searchable resources: `TenantResource` remains globally searchable and already has both view and edit pages; `ProviderConnectionResource` remains non-globally-searchable, so no global-search conflict is introduced.
|
||||
- Destructive actions: no new destructive action is added. Existing tenant archive, restore, and force-delete flows and existing provider credential or connection-state mutations remain confirmation-protected and capability-gated.
|
||||
- Asset strategy: unchanged; no new assets are introduced and the deploy-time `php artisan filament:assets` process remains unaffected.
|
||||
- Testing plan: focused Pest coverage will protect tenant legacy-status suppression, tenant-detail provider summary truth, provider current-state promotion, filter hierarchy, DB-only rendering, and unchanged authorization boundaries.
|
||||
147
specs/179-provider-truth-cleanup/quickstart.md
Normal file
147
specs/179-provider-truth-cleanup/quickstart.md
Normal file
@ -0,0 +1,147 @@
|
||||
# Quickstart: Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
## Goal
|
||||
|
||||
Validate that tenant and provider operator surfaces no longer elevate `Tenant.app_status`, `ProviderConnection.status`, or `ProviderConnection.health_status` as leading truth, and that lifecycle, consent, and verification now answer the primary operator questions.
|
||||
|
||||
## Prerequisites
|
||||
|
||||
1. Start Sail.
|
||||
2. Prepare one workspace member with at least one visible tenant and provider connection management access.
|
||||
3. Seed or create tenant scenarios for:
|
||||
- active tenant with `app_status` populated but provider verification `unknown`
|
||||
- onboarding tenant with granted consent and blocked verification
|
||||
- tenant with no default Microsoft provider connection
|
||||
4. Seed or create provider connection scenarios for:
|
||||
- consent `granted`, verification `degraded`, legacy `status=connected`, legacy `health_status=ok`
|
||||
- consent `required` or `revoked`, verification `blocked`, legacy `status` still optimistic
|
||||
- configured connection that has never been verified
|
||||
- disabled connection with retained legacy status or health values
|
||||
5. Prepare one non-member or cross-workspace actor for deny-as-not-found checks.
|
||||
|
||||
## Implementation Validation Order
|
||||
|
||||
### 1. Run the current baseline tenant and provider surface tests
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/RequiredFiltersTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Existing tenant detail, provider connection pages, canonical tenantless provider route, and provider CTA behavior still render correctly before the cleanup changes are applied.
|
||||
|
||||
### 2. Run focused tenant truth-cleanup coverage
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantTruthCleanupSpec179Test.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Tenant list no longer shows `app_status` as default-visible truth.
|
||||
- Tenant detail keeps lifecycle separate from provider consent and verification.
|
||||
- Tenant detail Provider section stops leading with legacy `status` and `health_status`.
|
||||
|
||||
### 3. Run focused provider truth-cleanup coverage
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/RequiredFiltersTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Provider connection list promotes consent and verification to the default-visible columns.
|
||||
- Provider connection view and edit pages show current state separately from diagnostics.
|
||||
- Legacy `status` and `health_status` remain secondary or hidden by default.
|
||||
|
||||
### 4. Re-run authorization and discovery-safety coverage on touched resources
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Rbac/TenantResourceAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Rbac/AdminGlobalSearchContextSafetyTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantScopingTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Workspace and tenant scoping remain unchanged.
|
||||
- Non-members still receive deny-as-not-found behavior.
|
||||
- Members without capability do not gain new visibility or mutation access.
|
||||
- Tenant global search remains workspace-safe.
|
||||
- Provider connections remain excluded from global search.
|
||||
|
||||
### 5. Run badge-mapping coverage
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Unit/Badges/TenantBadgesTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Unit/Badges/ProviderConnectionBadgesTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- Lifecycle, provider consent, provider verification, and retained legacy diagnostic badges resolve through centralized badge mappings only.
|
||||
|
||||
### 6. Format touched files
|
||||
|
||||
```bash
|
||||
vendor/bin/sail bin pint --dirty --format agent
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- All touched implementation files conform to project formatting rules.
|
||||
|
||||
### 7. Run the final focused verification pack
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantTruthCleanupSpec179Test.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/RequiredFiltersTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Rbac/TenantResourceAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Rbac/AdminGlobalSearchContextSafetyTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Filament/TenantScopingTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Unit/Badges/TenantBadgesTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Unit/Badges/ProviderConnectionBadgesTest.php
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- The targeted tenant and provider surfaces keep truthful status hierarchy, keep DB-only rendering where already promised, and preserve existing authorization boundaries.
|
||||
|
||||
### 8. Validate no migration and no new persisted truth were introduced
|
||||
|
||||
```bash
|
||||
git diff --name-only -- database/migrations app/Models app/Support/Providers app/Support/Badges/BadgeDomain.php app/Support/Badges/BadgeCatalog.php app/Support/Badges/Domains/ProviderConsentStatusBadge.php app/Support/Badges/Domains/ProviderVerificationStatusBadge.php app/Support/Badges/Domains/TenantAppStatusBadge.php app/Support/Badges/Domains/ProviderConnectionStatusBadge.php app/Support/Badges/Domains/ProviderConnectionHealthBadge.php specs/179-provider-truth-cleanup
|
||||
```
|
||||
|
||||
Expected outcome:
|
||||
- No new migration file is introduced for this feature.
|
||||
- No new persisted readiness artifact or new provider-status family appears outside the approved centralized badge mapping work.
|
||||
- Central badge changes are limited to the approved consent, verification, and retained diagnostic badge mappers.
|
||||
|
||||
## Manual Smoke Check
|
||||
|
||||
1. Open `/admin/tenants` and confirm lifecycle remains visible while `app_status` is no longer a default-visible status badge.
|
||||
2. Open one tenant detail page and confirm the `Provider` section now leads with consent and verification, not connection `status` and `health`.
|
||||
3. Confirm the `Verification report` widget still provides the deeper stored verification surface and does not depend on outbound HTTP at render time.
|
||||
4. Open `/admin/provider-connections` and confirm consent and verification are the primary default-visible state columns.
|
||||
5. Confirm any retained legacy `status` or `health` values are secondary diagnostics rather than peer badges.
|
||||
6. Open a provider connection view page and confirm `configured`, `connected`, or `consented` no longer read as equivalent to verified or ready.
|
||||
7. Open a provider connection edit page and confirm current consent and verification context are visible before any mutation, while diagnostics remain secondary.
|
||||
8. Repeat one tenant and one provider URL as a non-member or out-of-scope actor and confirm deny-as-not-found behavior still holds.
|
||||
|
||||
## Non-Goals For This Slice
|
||||
|
||||
- No database migration.
|
||||
- No new readiness enum, score, or persisted summary.
|
||||
- No change to verification queueing, `OperationRun` semantics, or provider mutation workflows.
|
||||
- No removal of legacy database fields or projection writers.
|
||||
74
specs/179-provider-truth-cleanup/research.md
Normal file
74
specs/179-provider-truth-cleanup/research.md
Normal file
@ -0,0 +1,74 @@
|
||||
# Phase 0 Research: Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
## Decision: Remove legacy `app_status` from tenant list primary truth and do not replace it with a new row-level readiness badge in this slice
|
||||
|
||||
**Rationale**: The current tenant list exposes `app_status` as a default-visible badge and filter even though the feature goal is to stop projecting frozen or semantically stale provider truth from tenant-level legacy fields. A new per-row provider readiness badge would require choosing one provider connection, compressing multi-connection state, and implicitly inventing a readiness model. The narrowest safe move is to let the tenant list remain lifecycle-led and to consciously omit provider readiness from the row when it cannot be stated without semantic overreach.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Introduce a new tenant readiness badge on the list: rejected because it would create a new semantic layer before the later readiness spec.
|
||||
- Keep `app_status` but toggle it off by default: rejected because the spec explicitly warns that hidden-by-default legacy truth still leaks back into operator interpretation.
|
||||
|
||||
## Decision: Reuse the existing tenant Provider section, but repoint it from legacy `status` and `health_status` to consent and verification
|
||||
|
||||
**Rationale**: Tenant detail already has a dedicated `Provider` section backed by `TenantResource::providerConnectionState()` and the shared Blade entry `provider-connection-state.blade.php`. That section is the narrowest place to present current provider truth without inventing a new widget or presenter. The helper should continue to resolve the default Microsoft provider connection or a missing-connection state, but its leading fields should become `consent_status` and `verification_status`, with legacy status and health demoted to optional diagnostics.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Build a new tenant provider summary widget: rejected because the current section already exists and the spec does not justify another surface layer.
|
||||
- Remove the Provider section entirely and rely only on the verification widget: rejected because the spec requires clear consent and verification semantics, and the verification widget is a deep-dive report, not the only summary contract.
|
||||
|
||||
## Decision: Keep `TenantVerificationReport` as the verification deep-dive and do not turn `TenantOperability` into provider truth
|
||||
|
||||
**Rationale**: `TenantVerificationReport` already gives tenant detail a DB-only verification deep-dive using the latest `provider.connection.check` run. `TenantOperabilityService` and `verificationReadinessOutcome()` answer whether a verification action may be started in a given lifecycle and capability context, not whether the provider is operationally healthy. The cleanup should continue to use the verification report for stored verification detail and must not promote operability gating into readiness truth.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Use `TenantOperabilityDecision` as a tenant provider readiness signal: rejected because it mixes lifecycle and permission gating with provider-state truth.
|
||||
- Collapse verification detail into the Provider section and remove the verification widget: rejected because the widget already provides the deeper stored-report surface and no new readiness model is needed.
|
||||
|
||||
## Decision: Promote `consent_status` and `verification_status` to the default-visible provider connection list axes
|
||||
|
||||
**Rationale**: The provider connections list currently defaults to `status` and `health_status`, even though the model already stores `consent_status` and `verification_status` and the resource already has label helpers for them. Surfacing consent and verification in the table is the clearest way to answer whether a connection is consented and whether it has been checked. Legacy `status` and `health_status` may remain available as hidden diagnostics for compatibility, but they should stop being the primary scan path.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Keep `status` and `health_status` visible because they are shorter to scan: rejected because that preserves the competing-truth problem the spec exists to remove.
|
||||
- Remove legacy columns completely from the list: rejected because the fields may still help diagnostics and internal compatibility during the transition.
|
||||
|
||||
## Decision: Split provider connection detail and edit surfaces into current state versus diagnostics instead of one equal-weight Status section
|
||||
|
||||
**Rationale**: The current provider connection infolist and form both render consent, verification, legacy status, and health at the same hierarchy level in one `Status` section. The cleanup should create a primary current-state section for consent and verification, and a separate diagnostics section for legacy status, health, migration review, and last-error metadata. This keeps the existing resource and existing fields while making the leading truth explicit.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Keep one Status section and merely reorder the fields: rejected because equal visual grouping would still overstate the legacy fields.
|
||||
- Delete legacy fields from detail and edit immediately: rejected because the spec allows the fields to remain as long as they stop acting like leading truth.
|
||||
|
||||
## Decision: Extend the existing badge catalog with narrow provider consent and provider verification mappings while keeping legacy badge domains diagnostic-only
|
||||
|
||||
**Rationale**: BADGE-001 requires status-like values to render through `BadgeCatalog` and `BadgeRenderer`. `BadgeCatalog` already centralizes legacy `TenantAppStatus`, `ProviderConnectionStatus`, and `ProviderConnectionHealth` mappings, so the narrowest compliant move is to add centralized provider consent and provider verification mappings inside the existing badge system. This keeps lifecycle, consent, verification, and legacy diagnostics on one central semantic path without creating a synthetic `Ready` or `ProviderReadiness` domain.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Continue using plain labels or local helper output for consent and verification: rejected because BADGE-001 requires centralized status-like badge semantics.
|
||||
- Add a new `ProviderReadiness` badge domain: rejected because it would front-run the later readiness spec and violate proportionality.
|
||||
- Remove legacy badge mappers entirely: rejected because diagnostic surfaces and internal compatibility still reference them.
|
||||
|
||||
## Decision: Keep legacy persisted fields and current projection writers intact in this slice
|
||||
|
||||
**Rationale**: `ProviderConnection` still projects `status` and `health_status` during classification and enable or disable flows, and tenant records still persist `app_status`. The spec explicitly forbids a schema change or aggressive technical removal. The correct scope is presentation cleanup first, not domain-field deletion.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Drop legacy columns now: rejected because existing jobs, projections, audit metadata, and compatibility paths still write or reference them.
|
||||
- Stop writing the fields immediately as part of this spec: rejected because it would turn a surface-truth cleanup into a broader behavioral change.
|
||||
|
||||
## Decision: Update provider list filters to follow the leading truth hierarchy
|
||||
|
||||
**Rationale**: The current provider list filter set centers `status` and `health_status`. If the table’s leading truth becomes consent and verification, the list’s core filters should follow the same hierarchy. Legacy filters may remain only as explicitly diagnostic filters, not as the primary filter language for current provider state.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Leave legacy filters untouched while changing only columns: rejected because that keeps the old semantics in the main operator interaction path.
|
||||
- Remove all legacy filters outright: rejected because diagnostic filtering may still be useful while the fields remain persisted.
|
||||
|
||||
## Decision: Extend existing truth-separation tests and add one focused provider-surface truth test instead of inventing a large new test harness
|
||||
|
||||
**Rationale**: The repo already has `TenantLifecycleStatusDomainSeparationTest`, `ProviderConnectionsDbOnlyTest`, `RequiredFiltersTest`, and badge tests. The spec’s main risk is business-truth regression on a few surfaces. Focused feature tests that assert default-visible fields, section hierarchy, and filter names are enough to protect this contract without creating a broad new testing abstraction.
|
||||
|
||||
**Alternatives considered**:
|
||||
- Rely on manual browser inspection only: rejected because truth regressions on default-visible surfaces are easy to reintroduce.
|
||||
- Create a large generic presenter test framework first: rejected because the cleanup intentionally avoids adding a new presenter layer.
|
||||
226
specs/179-provider-truth-cleanup/spec.md
Normal file
226
specs/179-provider-truth-cleanup/spec.md
Normal file
@ -0,0 +1,226 @@
|
||||
# Feature Specification: Spec 179 - Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
**Feature Branch**: `179-provider-truth-cleanup`
|
||||
**Created**: 2026-04-04
|
||||
**Status**: Draft
|
||||
**Input**: User description: "Spec 179 — Provider Readiness Source-of-Truth Cleanup"
|
||||
|
||||
## Spec Scope Fields *(mandatory)*
|
||||
|
||||
- **Scope**: workspace + tenant
|
||||
- **Primary Routes**:
|
||||
- `/admin/tenants`
|
||||
- `/admin/tenants/{tenant}`
|
||||
- `/admin/provider-connections`
|
||||
- `/admin/provider-connections/{record}`
|
||||
- `/admin/provider-connections/{record}/edit`
|
||||
- **Data Ownership**:
|
||||
- Tenant-owned truth already exists in tenant lifecycle state, provider connection consent state, provider connection verification state, provider connection metadata, and stored verification outputs tied to a tenant.
|
||||
- Workspace-owned context remains the selected workspace and its membership filter, which determines which tenants and provider connections are visible in `/admin`.
|
||||
- This feature introduces no new persisted truth. It only removes misleading prominence from existing legacy status fields and reorders presentation of already-stored truth.
|
||||
- **RBAC**:
|
||||
- Workspace membership remains required for the tenant and provider resources in `/admin`.
|
||||
- Tenant membership remains the isolation boundary for tenant and provider records.
|
||||
- Existing provider view and provider manage capability checks remain authoritative for view and mutation surfaces.
|
||||
- No authorization broadening is allowed; non-members remain deny-as-not-found and members without capability remain forbidden for protected actions.
|
||||
|
||||
## UI/UX Surface Classification *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
| Surface | Surface Type | Primary Inspect/Open Model | Row Click | Secondary Actions Placement | Destructive Actions Placement | Canonical Collection Route | Canonical Detail Route | Scope Signals | Canonical Noun | Critical Truth Visible by Default | Exception Type |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Tenant list | CRUD / List-first Resource | Full-row click into tenant view | required | Header `Add tenant`; non-inspect row actions stay in `More` | Existing archive, restore, and force-delete actions remain secondary in `More`; unchanged by this spec | `/admin/tenants` | `/admin/tenants/{tenant}` | Active workspace, tenant name, environment, and existing tenant scope | Tenants / Tenant | Tenant lifecycle, plus an optional bounded provider signal only when it is derived from current provider truth | none |
|
||||
| Tenant view | Detail / view-first resource | Tenant view page itself | forbidden | Header `ActionGroup` remains the secondary action container | Existing destructive lifecycle actions stay grouped and confirmed; unchanged by this spec | `/admin/tenants` | `/admin/tenants/{tenant}` | Tenant identity, workspace context, and existing tenant-scoped widgets | Tenant | Tenant lifecycle first; provider consent and provider verification separate from lifecycle and RBAC | none |
|
||||
| Provider connections list | CRUD / List-first Resource | Full-row click into provider connection view | required | Header `New connection`; operational and management actions stay in row `More` | Existing set-default, enable or disable, and credential mutations stay secondary and confirmed where already required | `/admin/provider-connections` | `/admin/provider-connections/{record}` | Active workspace plus tenant filter or tenant query context, tenant name, provider name, and default marker | Provider Connections / Provider Connection | Consent state and verification state, not legacy connection status or health | Tenantless canonical route with tenant-aware filtering |
|
||||
| Provider connection view | Detail / view-first resource | Provider connection view page itself | forbidden | Header actions and grouped header mutations remain the secondary action area | Existing credential and connection-state mutations remain grouped, confirmed, and capability-gated | `/admin/provider-connections` | `/admin/provider-connections/{record}` | Tenant identity, provider identity, connection type, and default marker | Provider Connection | Consent state and verification state as the leading diagnosis | none |
|
||||
| Provider connection edit | Edit form | Provider connection edit page itself | forbidden | Save and cancel remain the form actions; grouped header actions remain secondary | Existing credential and connection-state mutations remain grouped, confirmed, and capability-gated | `/admin/provider-connections` | `/admin/provider-connections/{record}/edit` | Tenant identity, provider identity, connection type, and default marker | Provider Connection | Current consent and verification context before any configuration mutation; legacy fields are not allowed to dominate the form | none |
|
||||
|
||||
## Operator Surface Contract *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
| Surface | Primary Persona | Surface Type | Primary Operator Question | Default-visible Information | Diagnostics-only Information | Status Dimensions Used | Mutation Scope | Primary Actions | Dangerous Actions |
|
||||
|---|---|---|---|---|---|---|---|---|---|
|
||||
| Tenant list | Workspace or tenant operator | List | Which tenants are in a normal lifecycle state, and is there any trustworthy provider concern I should notice without assuming readiness? | Tenant name, lifecycle, environment, and either a bounded provider signal from current provider truth or no provider signal at all | Legacy app-status projections and frozen provider surrogates are not default-visible | lifecycle, optional provider consent or verification summary | none on the list itself; existing row actions remain unchanged | Open tenant, Add tenant | Existing archive, restore, and force-delete actions remain secondary and are not reinterpreted as provider readiness signals |
|
||||
| Tenant view | Tenant operator | Detail | What is this tenant's lifecycle, and what does the current provider base actually prove? | Lifecycle summary, provider consent, provider verification, verification summary, and RBAC shown as a separate domain when present | Legacy app status, historical provider projections, and raw verification internals stay diagnostic-only if retained at all | lifecycle, provider consent, provider verification, RBAC status as a separate domain | Existing verification and tenant management actions remain unchanged | Provider connections, Verify configuration, Edit, Grant admin consent, Open in Entra | Existing archive, restore, and force-delete actions remain grouped, confirmed, and clearly separate from provider truth |
|
||||
| Provider connections list | Tenant operator or tenant admin | List | Which connections are consented, which are verified, and which still need attention? | Tenant, provider, default marker, consent state, verification state, and connection type when useful | Legacy connection status, legacy health, migration-review metadata, and raw error text stay secondary | consent, verification, default designation | Existing provider operations and management actions remain unchanged | Open provider connection, New connection | Set as default, enable or disable connection, dedicated-credential actions, and provider-run actions remain secondary and capability-gated |
|
||||
| Provider connection view | Tenant operator or tenant admin | Detail | Is this connection only configured, or has it actually been checked and verified? | Consent state, verification state, provider identity, default designation, and next-step links | Legacy status and health, raw identifiers, and low-level technical fields stay secondary | consent, verification, connection type | Existing connection-check and provider-management actions remain unchanged | Check connection, Grant admin consent, Edit, View last check run | Enable dedicated override, rotate or delete dedicated credential, revert to platform, enable or disable connection, and set default remain grouped, confirmed, and authorized |
|
||||
| Provider connection edit | Tenant admin | Edit | What can I safely change, and what do the current consent and verification states tell me before I mutate this connection? | Editable configuration, consent state, verification state, save and cancel, and the same tenant scope cues as the view page | Legacy status and health, raw technical metadata, and historical projections stay diagnostic-only if retained | consent, verification, connection type | Existing provider configuration mutation scope remains unchanged | Save changes, Cancel, Check connection, View last check run | Existing dedicated-credential and enable or disable actions remain grouped, confirmed, and authorized |
|
||||
|
||||
## Proportionality Review *(mandatory when structural complexity is introduced)*
|
||||
|
||||
- **New source of truth?**: No.
|
||||
- **New persisted entity/table/artifact?**: No.
|
||||
- **New abstraction?**: No.
|
||||
- **New enum/state/reason family?**: No.
|
||||
- **New cross-domain UI framework/taxonomy?**: No.
|
||||
- **Current operator problem**: A tenant or provider connection can currently look active, connected, or healthy on a leading surface even when the provider basis is unclear, stale, blocked, or semantically contradicted by newer status fields.
|
||||
- **Existing structure is insufficient because**: The current model already has clearer truth axes for lifecycle, consent, and verification, but primary tenant and provider surfaces still elevate legacy fields such as tenant app status, provider connection status, and provider health as if they were current truth.
|
||||
- **Narrowest correct implementation**: Rework only the existing tenant and provider presentation layers, default-visible fields, filters, and badge mappings so that lifecycle, consent, and verification become the primary operator-facing truth without inventing a new readiness model.
|
||||
- **Ownership cost**: The repo takes on focused UI cleanup, badge or filter adjustments, and regression coverage for truth ordering, but no new persistence, taxonomy, or cross-cutting semantic framework.
|
||||
- **Alternative intentionally rejected**: A new tenant readiness enum, a full readiness assessment, or a new persisted summary artifact is rejected for this slice because the immediate risk is conflicting surface truth, not the absence of another status model.
|
||||
- **Release truth**: Current-release truth cleanup that also prepares the codebase for later readiness and gating work.
|
||||
|
||||
## User Scenarios & Testing *(mandatory)*
|
||||
|
||||
### User Story 1 - Read truthful tenant surfaces (Priority: P1)
|
||||
|
||||
As an operator, I can open the tenant list and tenant view and understand tenant lifecycle separately from provider consent and provider verification, so an `active` tenant does not silently read as provider-ready.
|
||||
|
||||
**Why this priority**: The biggest current risk is false confidence on the main tenant-facing surfaces.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding tenants whose lifecycle, legacy app status, consent, and verification states disagree, then rendering the tenant list and tenant view to verify that lifecycle remains separate and legacy app status no longer drives the leading operator truth.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** a tenant is `active` and its provider verification is `unknown`, **When** the operator opens the tenant list or tenant view, **Then** the surface shows lifecycle without implying the tenant is provider-ready.
|
||||
2. **Given** a tenant is onboarding, consent is granted, and verification is blocked, **When** the operator opens the tenant view, **Then** onboarding remains the tenant lifecycle truth and the provider issue remains separately visible.
|
||||
3. **Given** a tenant still has a populated legacy app-status value, **When** the operator opens a primary tenant surface, **Then** that legacy field is not presented as the current leading status.
|
||||
|
||||
---
|
||||
|
||||
### User Story 2 - Diagnose provider connections from current axes (Priority: P1)
|
||||
|
||||
As an operator, I can use provider connection list, view, and edit surfaces to see consent and verification as the leading provider state axes, even when legacy connection status fields still contain data.
|
||||
|
||||
**Why this priority**: Provider connection pages are the canonical diagnostic surfaces for this domain and must stop showing parallel state systems as peers.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding provider connections whose legacy `status` and `health_status` disagree with `consent_status` and `verification_status`, then verifying that list, view, and edit surfaces elevate consent and verification while demoting or hiding the legacy fields.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** a provider connection has consent granted, verification degraded, legacy status `connected`, and legacy health `ok`, **When** the operator opens the provider connections list or detail pages, **Then** consent and degraded verification are the leading truths and the legacy fields do not appear at equal prominence.
|
||||
2. **Given** a provider connection is configured but never verified, **When** the operator opens its view or edit page, **Then** the page makes clear that the connection is not yet proven healthy.
|
||||
3. **Given** a provider connection is disabled, **When** the operator opens the list or detail page, **Then** connection-state actions remain secondary and do not override consent or verification semantics.
|
||||
|
||||
---
|
||||
|
||||
### User Story 3 - Avoid false readiness language across surfaces (Priority: P2)
|
||||
|
||||
As an operator, I can move between tenant and provider surfaces without seeing `active`, `connected`, `consented`, or similar labels treated as if they automatically mean `ready`.
|
||||
|
||||
**Why this priority**: This slice is a truth cleanup, not a final readiness model, so it must reduce semantic overreach before any follow-up readiness work starts.
|
||||
|
||||
**Independent Test**: Can be fully tested by rendering primary tenant and provider surfaces for records that look favorable in one status family but unfavorable in another and verifying that no default-visible wording or badge composition collapses them into one readiness conclusion.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** a tenant is active and the default provider connection is consented but verification is error or blocked, **When** the operator inspects the tenant and provider surfaces, **Then** neither surface implies that the tenant is operationally ready.
|
||||
2. **Given** the tenant list does not have enough trustworthy provider truth to summarize one tenant safely, **When** the list renders, **Then** it omits that provider readiness signal instead of inventing a legacy or optimistic substitute.
|
||||
3. **Given** RBAC status is also shown on the tenant view, **When** the page renders, **Then** RBAC remains a separate domain and does not masquerade as provider readiness.
|
||||
|
||||
### Edge Cases
|
||||
|
||||
- Legacy app status or legacy provider status fields still contain optimistic values that contradict current verification truth.
|
||||
- A tenant has no provider connection or has multiple provider connections, so the tenant list cannot safely compress provider truth into one scan-time signal.
|
||||
- Consent is granted but verification has never been run, so the system must distinguish configured or consented from verified.
|
||||
- Verification is stale, blocked, degraded, or error while the tenant lifecycle remains active.
|
||||
- RBAC health is present on the tenant view at the same time as provider truth and must remain visibly separate.
|
||||
- A non-member or cross-workspace actor attempts to reach tenant or provider surfaces and must continue to see deny-as-not-found behavior without new hints.
|
||||
|
||||
## Requirements *(mandatory)*
|
||||
|
||||
**Constitution alignment (required):** This feature introduces no new Microsoft Graph contract, no new long-running workflow, and no new write path. Existing verification and provider-run actions remain as they are today. The work is limited to truth cleanup on existing operator-facing surfaces.
|
||||
|
||||
**Constitution alignment (PROP-001 / ABSTR-001 / PERSIST-001 / STATE-001 / BLOAT-001):** This feature is intentionally narrow. It adds no new persistence, abstraction, state family, presenter framework, or readiness taxonomy. It cleans up leading surface truth using already-existing lifecycle, consent, verification, and verification-report data.
|
||||
|
||||
**Constitution alignment (OPS-UX):** No new `OperationRun` type, execution surface, or feedback path is introduced. Existing verification and provider-operation flows keep their current run semantics.
|
||||
|
||||
**Constitution alignment (RBAC-UX):** The work stays in the admin plane at `/admin` on existing tenant and provider resources. Non-members and out-of-scope users remain deny-as-not-found. In-scope members without capability remain forbidden for protected actions. Server-side authorization remains the source of truth. Tenant global search stays safe because the tenant resource already has view and edit pages; provider connections remain non-globally-searchable for this slice. Existing destructive-like actions keep their current confirmation requirements.
|
||||
|
||||
**Constitution alignment (OPS-EX-AUTH-001):** Not applicable. No auth handshake behavior is changed.
|
||||
|
||||
**Constitution alignment (BADGE-001):** Status badge semantics remain centralized. This feature updates leading badge usage so tenant lifecycle, provider consent, and provider verification are the primary operator-facing status hierarchy on targeted surfaces. If provider consent or provider verification require new mappings, they MUST be added through `BadgeCatalog` and `BadgeRenderer` inside the existing badge system rather than through page-local labels or a synthetic readiness framework.
|
||||
|
||||
**Constitution alignment (UI-FIL-001):** The feature reuses existing Filament tables, infolists, widgets, form sections, action groups, and centralized badge helpers. No local replacement markup or page-local status language is needed. No exception is expected.
|
||||
|
||||
**Constitution alignment (UI-NAMING-001):** Operator-facing copy must keep `Lifecycle`, `Consent`, and `Verification` as distinct questions. This slice must not introduce `Ready` as a new leading label. If any legacy field remains visible, it must be named as diagnostic or legacy rather than as primary status.
|
||||
|
||||
**Constitution alignment (UI-CONST-001 / UI-SURF-001 / UI-HARD-001 / UI-EX-001 / UI-REVIEW-001):** Each affected surface keeps one primary inspect or open model, and the surface tables above define collection routes, detail routes, action placement, scope signals, and the default-visible truth. The targeted surfaces must stop treating `app_status`, provider `status`, or provider `health_status` as peer signals to lifecycle, consent, or verification.
|
||||
|
||||
**Constitution alignment (OPSURF-001):** Default-visible content must stay operator-first. Tenant surfaces show lifecycle and, when warranted, provider truth. Provider surfaces show consent and verification first. Diagnostics such as legacy fields, raw identifiers, or historical projections must remain secondary. Existing mutation scope and safe-execution patterns remain unchanged.
|
||||
|
||||
**Constitution alignment (UI-SEM-001 / LAYER-001 / TEST-TRUTH-001):** Direct mapping from existing lifecycle, consent, and verification truth is sufficient once legacy prominence is removed. This feature must not add a new readiness interpreter or semantic wrapper. Tests must protect business truth by proving the absence of false readiness and the demotion of conflicting legacy signals.
|
||||
|
||||
**Constitution alignment (Filament Action Surfaces):** The Action Surface Contract remains satisfied. Affected surfaces keep one primary inspect model, redundant `View` actions remain absent, empty action groups are not introduced, and destructive actions keep their current placement and confirmation rules. UI-FIL-001 is satisfied with no approved exception.
|
||||
|
||||
**Constitution alignment (UX-001 — Layout & Information Architecture):** No new screen type is introduced. Tenant view continues to use a view page with widgets and infolist content. Provider connection view continues to use a view page. Provider connection edit remains a section-based edit form. List pages keep search, sort, and filters, but the default-visible status dimensions and core filters must align to leading truth rather than legacy projections.
|
||||
|
||||
### Functional Requirements
|
||||
|
||||
- **FR-179-001 (Lifecycle remains its own truth)**: Targeted tenant surfaces MUST present tenant lifecycle as a distinct domain and MUST NOT use lifecycle labels to imply provider readiness.
|
||||
- **FR-179-002 (Tenant app status removed from leading truth)**: Targeted tenant surfaces MUST NOT present `app_status` as a default-visible primary badge, summary field, or equivalent current-status signal.
|
||||
- **FR-179-003 (Tenant list uses only trustworthy provider signal)**: The tenant list MUST either show a bounded provider signal derived from current provider consent and verification truth or omit provider status for that row. It MUST NOT rely on `app_status` or another legacy projection as the scan-time provider indicator.
|
||||
- **FR-179-004 (Tenant detail separates provider axes)**: When tenant detail surfaces provider state, they MUST show provider consent and provider verification as separate axes.
|
||||
- **FR-179-005 (No false readiness on tenant detail)**: Tenant detail MUST NOT allow `active`, `connected`, `configured`, or `consented` signals to read as equivalent to verified, healthy, or ready when verification is unknown, blocked, degraded, error, or absent.
|
||||
- **FR-179-006 (RBAC remains separate)**: If RBAC status appears on tenant detail, it MUST remain visibly separate from provider consent and provider verification and MUST NOT substitute for provider readiness.
|
||||
- **FR-179-007 (Provider list leading axes)**: Provider connection list MUST use consent state and verification state as the primary default-visible connection-state axes.
|
||||
- **FR-179-008 (Legacy provider status demoted)**: Provider connection list, view, and edit surfaces MUST NOT present legacy `status` or `health_status` as equal-priority peer truth next to consent and verification.
|
||||
- **FR-179-009 (Legacy diagnostics handling)**: If legacy provider `status` or `health_status` remains visible anywhere on the targeted provider surfaces, it MUST be clearly labeled and positioned as secondary diagnostics, historical projection, or technical metadata.
|
||||
- **FR-179-010 (Provider detail distinguishes configured from proven)**: Provider connection view and edit surfaces MUST make it clear whether a connection is merely configured or consented versus operationally checked and verified.
|
||||
- **FR-179-011 (Badge truth alignment)**: Centralized badge and presentation mappings used by the targeted tenant and provider surfaces MUST elevate lifecycle, consent, and verification over tenant app status, provider connection status, and provider connection health.
|
||||
- **FR-179-012 (No conflicting equal-prominence status mosaic)**: Targeted tenant and provider surfaces MUST NOT render multiple semantically overlapping status badges or fields at the same visual level when only one is authoritative for that operator question.
|
||||
- **FR-179-013 (List filters follow leading truth)**: Default-visible list filters and core list columns on affected surfaces MUST align with the leading truth hierarchy. Legacy status filters may remain only if they are explicitly secondary and do not present themselves as the primary way to judge current provider readiness.
|
||||
- **FR-179-014 (No new persisted truth)**: The feature MUST ship without a new table, without a new persisted readiness artifact, and without a new status family.
|
||||
- **FR-179-015 (Authorization boundaries unchanged)**: Workspace scoping, tenant isolation, and capability checks on all touched surfaces MUST remain unchanged. This cleanup MUST NOT widen visibility or bypass existing server-side authorization.
|
||||
- **FR-179-016 (Global search and discovery stay safe)**: Tenant search behavior may remain in place because the tenant resource already has view and edit pages. Provider connections remain non-globally-searchable in this slice, and no touched surface may introduce new search-based status leakage.
|
||||
- **FR-179-017 (Regression coverage is mandatory)**: Regression coverage MUST verify tenant legacy-status suppression, provider primary-status promotion, contradictory multi-status demotion, badge truth alignment, and global-search safety. Final implementation validation MUST verify the absence of schema requirements and new persisted truth.
|
||||
|
||||
## UI Action Matrix *(mandatory when Filament is changed)*
|
||||
|
||||
| Surface | Location | Header Actions | Inspect Affordance (List/Table) | Row Actions (max 2 visible) | Bulk Actions (grouped) | Empty-State CTA(s) | View Header Actions | Create/Edit Save+Cancel | Audit log? | Notes / Exemptions |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Tenant list | `app/Filament/Resources/TenantResource.php` and `app/Filament/Resources/TenantResource/Pages/ListTenants.php` | `Add tenant` | `recordUrl()` opens the tenant view; one row-primary action slot is preserved | Primary overflow includes `Resume onboarding` or `View related onboarding`; `More` contains `Open`, `Edit`, `Grant admin consent`, `Open in Entra`, `Sync`, `Verify configuration`, `Restore`, `Force delete`, `Archive`, and RBAC helper actions | `Sync selected` stays grouped under `More` | `Add tenant` | n/a | n/a | existing only | Action Surface Contract remains satisfied. This spec changes status truth, not the action inventory. |
|
||||
| Tenant view | `app/Filament/Resources/TenantResource/Pages/ViewTenant.php` | `Provider connections`, `Edit`, `View related onboarding`, `Grant admin consent`, `Open in Entra`, `Verify configuration` inside the existing header `ActionGroup` | direct page | n/a | none | n/a | Existing grouped lifecycle and verification actions remain | n/a | existing only | No new header mutations are introduced. The change is in default-visible status semantics only. |
|
||||
| Provider connections list | `app/Filament/Resources/ProviderConnectionResource.php` and `app/Filament/Resources/ProviderConnectionResource/Pages/ListProviderConnections.php` | `New connection` | `recordUrl()` opens the provider connection view | `More` contains `Edit`, `Check connection`, `Inventory sync`, `Compliance snapshot`, `Set as default`, `Enable dedicated override`, `Rotate dedicated credential`, `Delete dedicated credential`, `Revert to platform`, `Enable connection`, and `Disable connection` | none | `New connection` | n/a | n/a | existing only | Canonical tenantless route stays `/admin/provider-connections`; this spec changes which status fields are treated as primary truth. |
|
||||
| Provider connection view | `app/Filament/Resources/ProviderConnectionResource/Pages/ViewProviderConnection.php` | `Grant admin consent`, `Edit`, plus grouped connection-management actions | direct page | n/a | none | n/a | `Check connection`, `View last check run`, and existing grouped dedicated-credential and connection-state actions remain | n/a | existing only | Existing confirmed and audited mutations remain unchanged. This spec only changes which state is read as primary. |
|
||||
| Provider connection edit | `app/Filament/Resources/ProviderConnectionResource/Pages/EditProviderConnection.php` | Existing grouped connection-management actions remain | direct page | n/a | none | n/a | Existing grouped connection-management actions remain | Default save and cancel actions remain | existing only | UX-001 remains satisfied. The edit surface must show consent and verification as current context without letting legacy fields dominate. |
|
||||
|
||||
### Key Entities *(include if feature involves data)*
|
||||
|
||||
- **Tenant lifecycle**: The tenant's own lifecycle truth, such as onboarding, active, archived, or equivalent states that describe whether the tenant is in the normal lifecycle.
|
||||
- **Provider consent state**: The stored state that answers whether the provider permission or consent step has been completed.
|
||||
- **Provider verification state**: The stored state that answers whether the provider connection has been checked and what that check currently proves.
|
||||
- **Legacy tenant app status**: An older projected tenant-level field that may still exist in storage but is no longer allowed to act as leading operator truth on targeted surfaces.
|
||||
- **Legacy provider connection status and health**: Older connection-level projections that may remain in storage for internal compatibility but are no longer allowed to compete with consent and verification on targeted surfaces.
|
||||
- **Bounded provider signal**: A tightly-scoped tenant-level summary derived from current provider truth that may appear on the tenant list only when it can be expressed without inventing a broader readiness model.
|
||||
|
||||
## Success Criteria *(mandatory)*
|
||||
|
||||
### Measurable Outcomes
|
||||
|
||||
- **SC-179-001**: In regression coverage, 100% of targeted tenant surfaces stop showing legacy tenant app status as a default-visible primary operator truth.
|
||||
- **SC-179-002**: In regression coverage, 100% of targeted provider surfaces show consent state and verification state before any legacy provider status or health field.
|
||||
- **SC-179-003**: In seeded scenarios where a tenant is active but provider verification is unknown, blocked, degraded, or error, 100% of targeted surfaces avoid implying that the tenant is provider-ready by default.
|
||||
- **SC-179-004**: In seeded scenarios where legacy fields contradict current consent or verification truth, 100% of targeted surfaces render the current truth hierarchy consistently.
|
||||
- **SC-179-005**: The feature ships without a required schema migration, a new persisted readiness artifact, or a new cross-surface status family.
|
||||
|
||||
## Assumptions
|
||||
|
||||
- Existing consent and verification fields are sufficiently trustworthy to become the leading provider truth for this cleanup slice.
|
||||
- Existing verification reports and provider next-step guidance remain the correct supporting diagnostics for provider truth.
|
||||
- Existing RBAC status surfaces remain valid as their own domain and do not need redesign in this spec beyond clearer separation from provider truth.
|
||||
- The tenant list may omit a provider signal for some tenants if no bounded, trustworthy summary can be expressed without inventing a readiness model.
|
||||
|
||||
## Non-Goals
|
||||
|
||||
- Introducing a full tenant readiness assessment
|
||||
- Adding a new readiness enum or score
|
||||
- Building cross-dashboard or needs-attention propagation for every provider problem
|
||||
- Adding operation pre-flight gating or blocking rules beyond the current behavior
|
||||
- Introducing verification freshness or scheduled re-verification lifecycle rules
|
||||
- Removing legacy database columns or internal compatibility paths in this slice
|
||||
|
||||
## Dependencies
|
||||
|
||||
- Existing tenant lifecycle model and tenant operator surfaces
|
||||
- Existing provider connection model, consent state, verification state, and verification-report semantics
|
||||
- Existing centralized badge and presentation mappings used on tenant and provider surfaces
|
||||
- Existing workspace and tenant scoping, capability enforcement, and deny-as-not-found boundaries
|
||||
- Existing tenant and provider Filament resources, pages, and regression tests covering truth and authorization behavior
|
||||
|
||||
## Definition of Done
|
||||
|
||||
- Tenant app status no longer appears as leading operator truth on the targeted tenant surfaces.
|
||||
- Provider legacy status and health no longer compete with consent and verification on the targeted provider surfaces.
|
||||
- Tenant lifecycle, provider consent, provider verification, and RBAC remain visibly separate where they coexist.
|
||||
- No targeted tenant or provider surface allows `active`, `connected`, or `consented` to read as equivalent to ready.
|
||||
- Badge and presentation usage reflects the cleaned truth hierarchy without inventing a new readiness model.
|
||||
- The change requires no new persistence structure and is covered by targeted regression tests.
|
||||
203
specs/179-provider-truth-cleanup/tasks.md
Normal file
203
specs/179-provider-truth-cleanup/tasks.md
Normal file
@ -0,0 +1,203 @@
|
||||
# Tasks: Provider Readiness Source-of-Truth Cleanup
|
||||
|
||||
**Input**: Design documents from `/specs/179-provider-truth-cleanup/`
|
||||
**Prerequisites**: `plan.md`, `spec.md`, `research.md`, `data-model.md`, `contracts/provider-truth-cleanup.openapi.yaml`, `quickstart.md`
|
||||
|
||||
**Tests**: Required. Write or update Pest coverage before each behavior change and keep Sail-first verification focused.
|
||||
|
||||
**Organization**: Tasks are grouped by user story so each story can be implemented and validated independently.
|
||||
|
||||
## Phase 1: Setup (Shared Regression Scaffolding)
|
||||
|
||||
**Purpose**: Create the focused regression entry points for Spec 179 before changing operator-facing surfaces.
|
||||
|
||||
- [X] T001 [P] Create the tenant truth-cleanup Pest scaffold in `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php`
|
||||
- [X] T002 [P] Create the provider truth-cleanup Pest scaffold in `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php`
|
||||
|
||||
---
|
||||
|
||||
## Phase 2: Foundational (Blocking Prerequisites)
|
||||
|
||||
**Purpose**: Lock route, scope, and discovery invariants before changing any tenant or provider truth surfaces.
|
||||
|
||||
**⚠️ CRITICAL**: No user story work should begin until this phase is complete.
|
||||
|
||||
- [X] T003 Preserve canonical provider CTA and deny-as-not-found invariants in `tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php`, `tests/Feature/Rbac/TenantResourceAuthorizationTest.php`, `tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php`, and `tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php`
|
||||
- [X] T004 [P] Preserve tenant global-search scope and provider-connection global-search exclusion in `tests/Feature/Rbac/AdminGlobalSearchContextSafetyTest.php`, `tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php`, and `tests/Feature/Filament/TenantScopingTest.php`
|
||||
|
||||
**Checkpoint**: Scope guards and discovery invariants are ready; tenant and provider truth cleanup can now proceed.
|
||||
|
||||
---
|
||||
|
||||
## Phase 3: User Story 1 - Read truthful tenant surfaces (Priority: P1) 🎯 MVP
|
||||
|
||||
**Goal**: Make tenant list and tenant detail lifecycle-led, remove `app_status` as leading truth, and show provider consent and verification separately from lifecycle.
|
||||
|
||||
**Independent Test**: Seed tenants whose lifecycle, legacy `app_status`, consent, and verification disagree, then verify tenant list and tenant detail show lifecycle separately and no longer treat `app_status` as current truth.
|
||||
|
||||
### Tests for User Story 1
|
||||
|
||||
- [X] T005 [P] [US1] Add tenant list truth regression cases in `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php` for active-plus-unknown, onboarding-plus-blocked, missing-default-connection, and multi-connection unsafe-summary omission scenarios
|
||||
- [X] T006 [P] [US1] Rewrite lifecycle-separation expectations in `tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php` so lifecycle and RBAC remain visible while `app_status` stops acting as primary truth
|
||||
|
||||
### Implementation for User Story 1
|
||||
|
||||
- [X] T007 [US1] Remove default-visible `app_status` columns and primary `app_status` filter usage from `app/Filament/Resources/TenantResource.php`, and keep any tenant-list provider signal omitted when current provider truth cannot be compressed safely
|
||||
- [X] T008 [US1] Remove leading `app_status` detail output and repoint `providerConnectionState()` to `consent_status` and `verification_status` in `app/Filament/Resources/TenantResource.php`
|
||||
- [X] T009 [US1] Rewrite the tenant Provider summary in `resources/views/filament/infolists/entries/provider-connection-state.blade.php` to lead with consent and verification and demote legacy status and health to diagnostics
|
||||
- [X] T010 [US1] Align verification deep-dive wording with the new tenant summary contract in `app/Filament/Widgets/Tenant/TenantVerificationReport.php` and `resources/views/filament/widgets/tenant/tenant-verification-report.blade.php`
|
||||
- [X] T011 [US1] Update canonical provider-connections CTA assertions after the tenant detail summary change in `tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php`
|
||||
|
||||
**Checkpoint**: Tenant list and tenant detail now answer lifecycle and provider questions without implying readiness from legacy fields.
|
||||
|
||||
---
|
||||
|
||||
## Phase 4: User Story 2 - Diagnose provider connections from current axes (Priority: P1)
|
||||
|
||||
**Goal**: Make provider connection list, view, and edit surfaces lead with consent and verification while demoting legacy connection status and health to diagnostics.
|
||||
|
||||
**Independent Test**: Seed provider connections whose legacy `status` and `health_status` conflict with `consent_status` and `verification_status`, then verify list, view, and edit surfaces elevate the current axes and keep DB-only rendering intact.
|
||||
|
||||
### Tests for User Story 2
|
||||
|
||||
- [X] T012 [P] [US2] Add provider list, view, and edit truth regression cases in `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` for consent and verification versus legacy status and health conflicts
|
||||
- [X] T013 [P] [US2] Update provider filter expectations in `tests/Feature/ProviderConnections/RequiredFiltersTest.php` to require consent-led and verification-led filters plus `default_only`
|
||||
- [X] T014 [P] [US2] Update DB-only rendering expectations in `tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php` for the new default-visible provider state columns
|
||||
|
||||
### Implementation for User Story 2
|
||||
|
||||
- [X] T015 [US2] Promote `consent_status` and `verification_status` to default-visible list columns and demote legacy `status` and `health_status` columns in `app/Filament/Resources/ProviderConnectionResource.php`
|
||||
- [X] T016 [US2] Replace primary `status` and `health_status` filters with consent-led and verification-led filters and mark any retained legacy filters as diagnostic in `app/Filament/Resources/ProviderConnectionResource.php`
|
||||
- [X] T017 [US2] Split the provider connection view infolist into Current state and Diagnostics sections in `app/Filament/Resources/ProviderConnectionResource.php`
|
||||
- [X] T018 [US2] Split the provider connection edit form context into Current state and Diagnostics sections in `app/Filament/Resources/ProviderConnectionResource.php`
|
||||
|
||||
**Checkpoint**: Provider connection pages now answer whether a connection is consented and verified before showing any legacy projections.
|
||||
|
||||
---
|
||||
|
||||
## Phase 5: User Story 3 - Avoid false readiness language across surfaces (Priority: P2)
|
||||
|
||||
**Goal**: Keep tenant and provider surfaces from collapsing `active`, `connected`, or `consented` into `ready`, and keep RBAC separate from provider truth.
|
||||
|
||||
**Independent Test**: Render tenant and provider surfaces for records that look favorable in one status family but unfavorable in another and verify no default-visible wording, badge, or section title implies readiness.
|
||||
|
||||
### Tests for User Story 3
|
||||
|
||||
- [X] T019 [P] [US3] Add cross-surface false-readiness assertions in `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php` and `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` for active-plus-blocked or error, consented-plus-unknown, and RBAC-separated scenarios
|
||||
- [X] T020 [P] [US3] Re-run scope-leak and capability regression coverage in `tests/Feature/Rbac/TenantResourceAuthorizationTest.php`, `tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php`, and `tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php` against the cleaned surfaces
|
||||
|
||||
### Implementation for User Story 3
|
||||
|
||||
- [X] T021 [US3] Normalize operator-facing labels and section headings to Lifecycle, Consent, Verification, and Diagnostics wording in `app/Filament/Resources/TenantResource.php` and `app/Filament/Resources/ProviderConnectionResource.php`
|
||||
- [X] T022 [US3] Add centralized badge mappings for provider consent and provider verification, keep legacy app-status or connection-status badges diagnostic-only, and avoid any synthetic readiness domain in `app/Support/Badges/BadgeCatalog.php`, `app/Support/Badges/BadgeDomain.php`, `app/Support/Badges/Domains/ProviderConsentStatusBadge.php`, `app/Support/Badges/Domains/ProviderVerificationStatusBadge.php`, `app/Support/Badges/Domains/TenantAppStatusBadge.php`, `app/Support/Badges/Domains/ProviderConnectionStatusBadge.php`, and `app/Support/Badges/Domains/ProviderConnectionHealthBadge.php`
|
||||
- [X] T023 [US3] Update unit badge regression coverage for centralized lifecycle, provider consent, provider verification, and legacy diagnostic mappings in `tests/Unit/Badges/TenantBadgesTest.php` and `tests/Unit/Badges/ProviderConnectionBadgesTest.php`
|
||||
|
||||
**Checkpoint**: No targeted tenant or provider surface uses favorable legacy language to imply provider readiness.
|
||||
|
||||
---
|
||||
|
||||
## Phase 6: Polish & Cross-Cutting Concerns
|
||||
|
||||
**Purpose**: Format, verify, and manually confirm the cleaned truth hierarchy across all affected surfaces.
|
||||
|
||||
- [X] T024 Run `vendor/bin/sail bin pint --dirty --format agent` for touched files under `app/`, `resources/views/`, and `tests/` as governed by `composer.json`
|
||||
- [X] T025 Run the focused Sail verification pack from `specs/179-provider-truth-cleanup/quickstart.md` against `tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php`, `tests/Feature/Filament/TenantTruthCleanupSpec179Test.php`, `tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php`, `tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php`, `tests/Feature/ProviderConnections/RequiredFiltersTest.php`, `tests/Feature/Tenants/TenantProviderConnectionsCtaTest.php`, `tests/Feature/Rbac/TenantResourceAuthorizationTest.php`, `tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php`, `tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php`, `tests/Feature/Rbac/AdminGlobalSearchContextSafetyTest.php`, `tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php`, `tests/Feature/Filament/TenantScopingTest.php`, `tests/Unit/Badges/TenantBadgesTest.php`, and `tests/Unit/Badges/ProviderConnectionBadgesTest.php`
|
||||
- [X] T026 Execute the manual smoke checklist in `specs/179-provider-truth-cleanup/quickstart.md` against `app/Filament/Resources/TenantResource.php` and `app/Filament/Resources/ProviderConnectionResource.php` on `/admin/tenants` and `/admin/provider-connections`
|
||||
- [X] T027 Validate that the final implementation introduces no schema migration, no new persisted truth, and no unplanned status-family expansion by reviewing `database/migrations/`, `app/Models/Tenant.php`, `app/Models/ProviderConnection.php`, `app/Support/Providers/ProviderConsentStatus.php`, `app/Support/Providers/ProviderVerificationStatus.php`, `app/Support/Badges/BadgeDomain.php`, `app/Support/Badges/BadgeCatalog.php`, `app/Support/Badges/Domains/ProviderConsentStatusBadge.php`, `app/Support/Badges/Domains/ProviderVerificationStatusBadge.php`, `app/Support/Badges/Domains/TenantAppStatusBadge.php`, `app/Support/Badges/Domains/ProviderConnectionStatusBadge.php`, `app/Support/Badges/Domains/ProviderConnectionHealthBadge.php`, and `specs/179-provider-truth-cleanup/plan.md` against the final diff
|
||||
|
||||
---
|
||||
|
||||
## Dependencies & Execution Order
|
||||
|
||||
### Phase Dependencies
|
||||
|
||||
- **Setup (Phase 1)**: No dependencies; start immediately.
|
||||
- **Foundational (Phase 2)**: Depends on Setup completion; blocks all user story work.
|
||||
- **User Story 1 (Phase 3)**: Depends on Foundational completion.
|
||||
- **User Story 2 (Phase 4)**: Depends on Foundational completion.
|
||||
- **User Story 3 (Phase 5)**: Depends on User Story 1 and User Story 2 completion because it harmonizes cross-surface wording and diagnostic semantics.
|
||||
- **Polish (Phase 6)**: Depends on all desired user stories being complete.
|
||||
|
||||
### User Story Dependencies
|
||||
|
||||
- **US1**: Independent after Phase 2 and is the recommended MVP slice.
|
||||
- **US2**: Independent after Phase 2 and can run in parallel with US1.
|
||||
- **US3**: Depends on the finished tenant and provider surface hierarchy from US1 and US2.
|
||||
|
||||
### Within Each User Story
|
||||
|
||||
- Write or update the story tests first and confirm they fail for the intended reason.
|
||||
- Update the primary resource or shared surface contract before adjusting dependent Blade or widget output.
|
||||
- Finish story-specific assertions after the implementation lands.
|
||||
- Keep authorization regressions green before advancing to the next story.
|
||||
|
||||
### Parallel Opportunities
|
||||
|
||||
- `T001` and `T002` can run in parallel.
|
||||
- `T003` and `T004` can run in parallel.
|
||||
- `T005` and `T006` can run in parallel.
|
||||
- `T012`, `T013`, and `T014` can run in parallel.
|
||||
- `T019` and `T020` can run in parallel.
|
||||
- Phase 3 and Phase 4 can run in parallel after Phase 2 completes.
|
||||
|
||||
---
|
||||
|
||||
## Parallel Example: User Story 1
|
||||
|
||||
```bash
|
||||
# Launch the tenant truth regressions together before changing tenant surfaces:
|
||||
Task: T005 Add tenant list truth regression cases in tests/Feature/Filament/TenantTruthCleanupSpec179Test.php
|
||||
Task: T006 Rewrite lifecycle-separation expectations in tests/Feature/Filament/TenantLifecycleStatusDomainSeparationTest.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 2
|
||||
|
||||
```bash
|
||||
# Launch the provider list and rendering guards together before changing ProviderConnectionResource:
|
||||
Task: T012 Add provider list, view, and edit truth regression cases in tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php
|
||||
Task: T013 Update provider filter expectations in tests/Feature/ProviderConnections/RequiredFiltersTest.php
|
||||
Task: T014 Update DB-only rendering expectations in tests/Feature/Filament/ProviderConnectionsDbOnlyTest.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 3
|
||||
|
||||
```bash
|
||||
# Lock the cross-surface wording and scope guards together once US1 and US2 are complete:
|
||||
Task: T019 Add cross-surface false-readiness assertions in tests/Feature/Filament/TenantTruthCleanupSpec179Test.php and tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php
|
||||
Task: T020 Re-run scope-leak and capability regression coverage in tests/Feature/Rbac/TenantResourceAuthorizationTest.php, tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php, and tests/Feature/ProviderConnections/ProviderConnectionAuthorizationTest.php
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### MVP First (User Story 1 Only)
|
||||
|
||||
1. Complete Phase 1: Setup.
|
||||
2. Complete Phase 2: Foundational.
|
||||
3. Complete Phase 3: User Story 1.
|
||||
4. Validate tenant surfaces with the US1-focused subset of `specs/179-provider-truth-cleanup/quickstart.md`.
|
||||
5. Demo or review the tenant truth cleanup before expanding to provider surfaces.
|
||||
|
||||
### Incremental Delivery
|
||||
|
||||
1. Finish Setup and Foundational work.
|
||||
2. Deliver US1 and validate tenant truth cleanup.
|
||||
3. Deliver US2 and validate provider truth cleanup.
|
||||
4. Deliver US3 and validate cross-surface wording and diagnostic consistency.
|
||||
5. Finish Phase 6 verification and manual smoke checks.
|
||||
|
||||
### Parallel Team Strategy
|
||||
|
||||
1. One developer completes Phase 1 and Phase 2.
|
||||
2. After Phase 2, one developer takes US1 while another takes US2.
|
||||
3. Rejoin on US3 once both surface hierarchies are stable.
|
||||
4. Finish with shared formatting, focused Sail tests, and manual smoke validation.
|
||||
|
||||
---
|
||||
|
||||
## Notes
|
||||
|
||||
- Every task follows the required checklist format: checkbox, task ID, optional parallel marker, required story label for story phases, and exact file paths.
|
||||
- The task list preserves the plan decision not to invent a new tenant-list readiness badge in this slice.
|
||||
- No task introduces new persistence, a new readiness enum, or a new presenter layer.
|
||||
@ -0,0 +1,194 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Filament\Resources\EvidenceSnapshotResource;
|
||||
use App\Filament\Resources\ReviewPackResource;
|
||||
use App\Filament\Resources\TenantReviewResource;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\TenantReviewCompletenessState;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
pest()->browser()->timeout(15_000);
|
||||
|
||||
it('smokes tenant-scoped evidence freshness and publication trust surfaces', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Browser Smoke Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$partialTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Browser Smoke Partial Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $partialTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleSnapshot = seedStaleTenantReviewEvidence($staleTenant);
|
||||
$partialSnapshot = seedPartialTenantReviewEvidence($partialTenant);
|
||||
|
||||
$partialReview = $this->makeArtifactTruthReview(
|
||||
tenant: $partialTenant,
|
||||
user: $user,
|
||||
snapshot: $partialSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$staleReview = $this->makeArtifactTruthReview(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: $staleSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$stalePack = $this->makeArtifactTruthReviewPack(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: $staleSnapshot,
|
||||
review: $staleReview,
|
||||
summaryOverrides: [
|
||||
'review_status' => TenantReviewStatus::Published->value,
|
||||
'review_completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user)->withSession([
|
||||
WorkspaceContext::SESSION_KEY => (int) $staleTenant->workspace_id,
|
||||
]);
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $staleTenant->workspace_id);
|
||||
|
||||
visit(EvidenceSnapshotResource::getUrl('view', ['record' => $staleSnapshot], tenant: $staleTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Stale')
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot');
|
||||
|
||||
visit(TenantReviewResource::tenantScopedUrl('view', ['record' => $partialReview], $partialTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Complete the evidence basis before publishing this review');
|
||||
|
||||
visit(ReviewPackResource::getUrl('index', tenant: $staleTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the source review before sharing this pack')
|
||||
->assertSee('Download');
|
||||
|
||||
visit(ReviewPackResource::getUrl('view', ['record' => $stalePack], tenant: $staleTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the source review before sharing this pack')
|
||||
->assertSee('Download');
|
||||
});
|
||||
|
||||
it('smokes canonical evidence and review trust surfaces', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Browser Canonical Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$partialTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Browser Canonical Partial Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $partialTenant, user: $user, role: 'owner');
|
||||
|
||||
$freshTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Browser Canonical Fresh Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $freshTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleSnapshot = $this->makeStaleArtifactTruthEvidenceSnapshot($staleTenant);
|
||||
$freshSnapshot = $this->makeArtifactTruthEvidenceSnapshot($freshTenant);
|
||||
$partialSnapshot = seedPartialTenantReviewEvidence($partialTenant);
|
||||
|
||||
$this->makeArtifactTruthReview(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: $staleSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$this->makeArtifactTruthReview(
|
||||
tenant: $partialTenant,
|
||||
user: $user,
|
||||
snapshot: $partialSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user)->withSession([
|
||||
WorkspaceContext::SESSION_KEY => (int) $staleTenant->workspace_id,
|
||||
]);
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $staleTenant->workspace_id);
|
||||
|
||||
visit(route('admin.evidence.overview'))
|
||||
->waitForText('Browser Canonical Stale Tenant')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Browser Canonical Fresh Tenant')
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot')
|
||||
->assertSee('Create a current review from this evidence snapshot');
|
||||
|
||||
visit('/admin/reviews')
|
||||
->waitForText('Browser Canonical Stale Tenant')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Browser Canonical Partial Tenant')
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the evidence basis before publishing this review')
|
||||
->assertSee('Complete the evidence basis before publishing this review')
|
||||
->assertDontSee('Publishable');
|
||||
});
|
||||
@ -57,7 +57,7 @@ public function test_renders_verification_report_on_canonical_detail_without_fil
|
||||
->assertOk()
|
||||
->assertSee('Verification report')
|
||||
->assertDontSee('Verification report unavailable')
|
||||
->assertSee('Open previous verification')
|
||||
->assertSee('Open previous operation')
|
||||
->assertSee('/admin/operations/'.((int) $previousRun->getKey()), false)
|
||||
->assertSee('Token acquisition works');
|
||||
}
|
||||
|
||||
@ -44,9 +44,9 @@ public function test_shows_non_blocking_mismatch_context_when_the_selected_tenan
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $runTenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Current tenant context differs from this run')
|
||||
->assertSee('Current tenant context differs from this operation')
|
||||
->assertSee('Current tenant context: Current Tenant.')
|
||||
->assertSee('Run tenant: Run Tenant.')
|
||||
->assertSee('Operation tenant: Run Tenant.')
|
||||
->assertSee('canonical workspace view');
|
||||
}
|
||||
|
||||
@ -71,7 +71,7 @@ public function test_frames_tenantless_runs_as_workspace_level_even_when_tenant_
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $selectedTenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Workspace-level run')
|
||||
->assertSee('Workspace-level operation')
|
||||
->assertSee('This canonical workspace view is not tied to the current tenant context (Selected Tenant).');
|
||||
}
|
||||
|
||||
@ -97,8 +97,8 @@ public function test_keeps_onboarding_tenant_runs_viewable_with_lifecycle_aware_
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Run tenant is not available in the current tenant selector')
|
||||
->assertSee('Run tenant: Onboarding Tenant.')
|
||||
->assertSee('Operation tenant is not available in the current tenant selector')
|
||||
->assertSee('Operation tenant: Onboarding Tenant.')
|
||||
->assertSee('This tenant is currently onboarding')
|
||||
->assertSee('Back to Operations')
|
||||
->assertDontSee('This tenant is currently active')
|
||||
@ -135,8 +135,8 @@ public function test_keeps_archived_tenant_runs_viewable_with_lifecycle_aware_co
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Run tenant is not available in the current tenant selector')
|
||||
->assertSee('Run tenant: Archived Tenant.')
|
||||
->assertSee('Operation tenant is not available in the current tenant selector')
|
||||
->assertSee('Operation tenant: Archived Tenant.')
|
||||
->assertSee('This tenant is currently archived')
|
||||
->assertSee('Back to Operations')
|
||||
->assertDontSee('deactivated')
|
||||
@ -165,8 +165,8 @@ public function test_keeps_selector_excluded_draft_tenant_runs_viewable_with_lif
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Run tenant is not available in the current tenant selector')
|
||||
->assertSee('Run tenant: Draft Tenant.')
|
||||
->assertSee('Operation tenant is not available in the current tenant selector')
|
||||
->assertSee('Operation tenant: Draft Tenant.')
|
||||
->assertSee('This tenant is currently draft')
|
||||
->assertDontSee('Resume onboarding');
|
||||
}
|
||||
|
||||
@ -125,7 +125,7 @@ function createAssignedBaselineTenant(): array
|
||||
|
||||
expect($assessment->stateFamily)->toBe(BaselineCompareSummaryAssessment::STATE_ACTION_REQUIRED)
|
||||
->and($assessment->evaluationResult)->toBe('failed_result')
|
||||
->and($assessment->nextActionLabel())->toBe('Review the failed run');
|
||||
->and($assessment->nextActionLabel())->toBe('Review the failed operation');
|
||||
});
|
||||
|
||||
it('treats stale compare history as a stale summary state instead of positive', function (): void {
|
||||
|
||||
@ -157,7 +157,7 @@ function createTenantGovernanceException(Tenant $tenant, Finding $finding, User
|
||||
expect($aggregate)->not->toBeNull()
|
||||
->and($aggregate?->stateFamily)->toBe(BaselineCompareSummaryAssessment::STATE_ACTION_REQUIRED)
|
||||
->and($aggregate?->nextActionTarget)->toBe(BaselineCompareSummaryAssessment::NEXT_TARGET_RUN)
|
||||
->and($aggregate?->nextActionLabel)->toBe('Review the failed run')
|
||||
->and($aggregate?->nextActionLabel)->toBe('Review the failed operation')
|
||||
->and($aggregate?->headline)->toBe('The latest baseline compare failed before it produced a usable result.');
|
||||
});
|
||||
|
||||
|
||||
@ -45,6 +45,40 @@ protected function makeArtifactTruthEvidenceSnapshot(
|
||||
return EvidenceSnapshot::query()->create(array_replace($defaults, $snapshotOverrides));
|
||||
}
|
||||
|
||||
protected function makeStaleArtifactTruthEvidenceSnapshot(
|
||||
Tenant $tenant,
|
||||
array $snapshotOverrides = [],
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, $snapshotOverrides, $summaryOverrides);
|
||||
|
||||
return $this->restateArtifactTruthEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Stale,
|
||||
array_replace([
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 2,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
protected function makePartialArtifactTruthEvidenceSnapshot(
|
||||
Tenant $tenant,
|
||||
array $snapshotOverrides = [],
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, $snapshotOverrides, $summaryOverrides);
|
||||
|
||||
return $this->restateArtifactTruthEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Partial,
|
||||
array_replace([
|
||||
'missing_dimensions' => 1,
|
||||
'stale_dimensions' => 0,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
protected function makeArtifactTruthReview(
|
||||
Tenant $tenant,
|
||||
User $user,
|
||||
@ -146,4 +180,47 @@ protected function makeArtifactTruthRun(
|
||||
|
||||
return OperationRun::factory()->create(array_replace($defaults, $attributes));
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $summaryOverrides
|
||||
*/
|
||||
private function restateArtifactTruthEvidenceSnapshot(
|
||||
EvidenceSnapshot $snapshot,
|
||||
EvidenceCompletenessState $completenessState,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
||||
|
||||
$summary = array_replace($summary, match ($completenessState) {
|
||||
EvidenceCompletenessState::Stale => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => max(1, (int) ($summary['stale_dimensions'] ?? 1)),
|
||||
],
|
||||
EvidenceCompletenessState::Partial => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Missing => [
|
||||
'dimension_count' => (int) ($summary['dimension_count'] ?? 0),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Complete => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
});
|
||||
|
||||
$summary = array_replace_recursive($summary, $summaryOverrides);
|
||||
|
||||
$snapshot->forceFill([
|
||||
'completeness_state' => $completenessState->value,
|
||||
'summary' => $summary,
|
||||
])->save();
|
||||
|
||||
return $snapshot->fresh();
|
||||
}
|
||||
}
|
||||
|
||||
@ -10,8 +10,9 @@
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Filament\Facades\Filament;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
it('shows only authorized tenant rows on the workspace evidence overview', function (): void {
|
||||
$tenantA = Tenant::factory()->create();
|
||||
@ -91,3 +92,30 @@
|
||||
->assertSee(EvidenceSnapshotResource::getUrl('view', ['record' => $snapshots[(int) $tenantB->getKey()]], tenant: $tenantB), false)
|
||||
->assertDontSee(EvidenceSnapshotResource::getUrl('view', ['record' => $snapshots[(int) $tenantA->getKey()]], tenant: $tenantA), false);
|
||||
});
|
||||
|
||||
it('shows stale evidence burden and a create-review next step on the overview', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$freshTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Fresh Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $freshTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleSnapshot = $this->makeStaleArtifactTruthEvidenceSnapshot($staleTenant);
|
||||
$freshSnapshot = $this->makeArtifactTruthEvidenceSnapshot($freshTenant);
|
||||
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $staleTenant->workspace_id])
|
||||
->get(route('admin.evidence.overview'))
|
||||
->assertOk()
|
||||
->assertSee($staleTenant->name)
|
||||
->assertSee($freshTenant->name)
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot')
|
||||
->assertSee('Create a current review from this evidence snapshot')
|
||||
->assertSee(EvidenceSnapshotResource::getUrl('view', ['record' => $staleSnapshot], tenant: $staleTenant), false)
|
||||
->assertSee(EvidenceSnapshotResource::getUrl('view', ['record' => $freshSnapshot], tenant: $freshTenant), false);
|
||||
});
|
||||
|
||||
@ -21,8 +21,9 @@
|
||||
use Illuminate\Support\Facades\Gate;
|
||||
use Illuminate\Support\Facades\Queue;
|
||||
use Livewire\Livewire;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
function seedEvidenceDomain(Tenant $tenant): void
|
||||
{
|
||||
@ -172,6 +173,30 @@ function seedEvidenceDomain(Tenant $tenant): void
|
||||
->assertSee('Refresh evidence before using this snapshot');
|
||||
});
|
||||
|
||||
it('shows stale evidence snapshots as cautionary while fresh snapshots remain current', function (): void {
|
||||
$freshTenant = Tenant::factory()->create();
|
||||
[$user, $freshTenant] = createUserWithTenant(tenant: $freshTenant, role: 'owner');
|
||||
$staleTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $freshTenant->workspace_id,
|
||||
]);
|
||||
createUserWithTenant(tenant: $staleTenant, user: $user, role: 'owner');
|
||||
|
||||
$freshSnapshot = $this->makeArtifactTruthEvidenceSnapshot($freshTenant);
|
||||
$staleSnapshot = $this->makeStaleArtifactTruthEvidenceSnapshot($staleTenant);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(EvidenceSnapshotResource::getUrl('view', ['record' => $freshSnapshot], tenant: $freshTenant))
|
||||
->assertOk()
|
||||
->assertSee('No action needed')
|
||||
->assertDontSee('Refresh the stale evidence before relying on this snapshot');
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(EvidenceSnapshotResource::getUrl('view', ['record' => $staleSnapshot], tenant: $staleTenant))
|
||||
->assertOk()
|
||||
->assertSee('Stale')
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot');
|
||||
});
|
||||
|
||||
it('renders readable evidence dimension summaries and keeps raw json available', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
@ -52,11 +52,20 @@
|
||||
->set('tableFilters.default_only.isActive', true);
|
||||
|
||||
$table = $component->instance()->getTable();
|
||||
$visibleColumnNames = collect($table->getVisibleColumns())
|
||||
->map(fn ($column): string => $column->getName())
|
||||
->values()
|
||||
->all();
|
||||
|
||||
expect($table->getPaginationPageOptions())->toBe(\App\Support\Filament\TablePaginationProfiles::resource());
|
||||
expect($table->getEmptyStateHeading())->toBe('No Microsoft connections found');
|
||||
expect($table->getColumn('display_name')?->isSearchable())->toBeTrue();
|
||||
expect($table->getColumn('display_name')?->isSortable())->toBeTrue();
|
||||
expect($visibleColumnNames)->toContain('consent_status', 'verification_status');
|
||||
expect($visibleColumnNames)->not->toContain('status');
|
||||
expect($visibleColumnNames)->not->toContain('health_status');
|
||||
expect($table->getColumn('status')?->isToggledHiddenByDefault())->toBeTrue();
|
||||
expect($table->getColumn('health_status')?->isToggledHiddenByDefault())->toBeTrue();
|
||||
expect($table->getColumn('provider')?->isToggledHiddenByDefault())->toBeTrue();
|
||||
expect($table->getColumn('entra_tenant_id')?->isToggledHiddenByDefault())->toBeTrue();
|
||||
expect($table->getColumn('migration_review_required'))->not->toBeNull();
|
||||
|
||||
@ -32,7 +32,7 @@
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Run tenant is not available in the current tenant selector')
|
||||
->assertSee('Operation tenant is not available in the current tenant selector')
|
||||
->assertSee('This tenant is currently onboarding and may not appear in the tenant selector.')
|
||||
->assertSee('Tenant lifecycle')
|
||||
->assertSee('Onboarding')
|
||||
@ -68,7 +68,7 @@
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Run tenant is not available in the current tenant selector')
|
||||
->assertSee('Operation tenant is not available in the current tenant selector')
|
||||
->assertSee('This tenant is currently archived and may not appear in the tenant selector.')
|
||||
->assertSee('Tenant lifecycle')
|
||||
->assertSee('Archived')
|
||||
|
||||
@ -58,6 +58,8 @@ function tenantSearchTitles($results): array
|
||||
|
||||
expect($results->first()?->url)
|
||||
->not->toBeNull();
|
||||
expect(collect($results)->filter(fn ($result): bool => filled($result->url))->count())
|
||||
->toBe($results->count());
|
||||
});
|
||||
|
||||
it('keeps first-slice taxonomy resources out of global search', function (): void {
|
||||
|
||||
@ -14,7 +14,7 @@
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
|
||||
it('keeps lifecycle, app status, and rbac status separated on the tenant view page', function (): void {
|
||||
it('keeps lifecycle and rbac status separated while removing app status from the tenant view page', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(
|
||||
tenant: Tenant::factory()->create([
|
||||
'status' => Tenant::STATUS_ONBOARDING,
|
||||
@ -32,8 +32,7 @@
|
||||
Livewire::test(ViewTenant::class, ['record' => $tenant->getRouteKey()])
|
||||
->assertSee('Lifecycle summary')
|
||||
->assertSee('This tenant is still onboarding. It remains visible on management and review surfaces, but it is not selectable as active context until onboarding completes.')
|
||||
->assertSee('App status')
|
||||
->assertSee('Consent required')
|
||||
->assertDontSee('App status')
|
||||
->assertSee('RBAC status')
|
||||
->assertSee('Failed');
|
||||
});
|
||||
|
||||
181
tests/Feature/Filament/TenantTruthCleanupSpec179Test.php
Normal file
181
tests/Feature/Filament/TenantTruthCleanupSpec179Test.php
Normal file
@ -0,0 +1,181 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Filament\Resources\TenantResource\Pages\ListTenants;
|
||||
use App\Filament\Resources\TenantResource\Pages\ViewTenant;
|
||||
use App\Models\ProviderConnection;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\Providers\ProviderConsentStatus;
|
||||
use App\Support\Providers\ProviderVerificationStatus;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Filament\Facades\Filament;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Livewire\Livewire;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
|
||||
it('removes tenant app status from tenant list primary truth and filters', function (): void {
|
||||
$tenant = Tenant::factory()->active()->create([
|
||||
'name' => 'Primary Truth Tenant',
|
||||
'app_status' => 'ok',
|
||||
]);
|
||||
|
||||
[$user, $tenant] = createUserWithTenant(
|
||||
tenant: $tenant,
|
||||
role: 'owner',
|
||||
ensureDefaultMicrosoftProviderConnection: false,
|
||||
);
|
||||
|
||||
ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'provider' => 'microsoft',
|
||||
'display_name' => 'Primary Truth Connection',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Unknown->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
$component = Livewire::actingAs($user)
|
||||
->test(ListTenants::class)
|
||||
->assertCanSeeTableRecords([$tenant]);
|
||||
|
||||
$table = $component->instance()->getTable();
|
||||
$filterNames = array_keys($table->getFilters());
|
||||
$visibleColumnNames = collect($table->getVisibleColumns())
|
||||
->map(fn ($column): string => $column->getName())
|
||||
->values()
|
||||
->all();
|
||||
|
||||
expect($filterNames)->not->toContain('app_status')
|
||||
->and($visibleColumnNames)->not->toContain('app_status')
|
||||
->and($visibleColumnNames)->not->toContain('consent_status')
|
||||
->and($visibleColumnNames)->not->toContain('verification_status')
|
||||
->and($visibleColumnNames)->not->toContain('provider_connection_state');
|
||||
});
|
||||
|
||||
it('keeps lifecycle and rbac separate while leading the provider summary with consent and verification', function (): void {
|
||||
$tenant = Tenant::factory()->create([
|
||||
'status' => Tenant::STATUS_ONBOARDING,
|
||||
'app_status' => 'consent_required',
|
||||
'rbac_status' => 'failed',
|
||||
'name' => 'Truth Cleanup Tenant',
|
||||
]);
|
||||
|
||||
[$user, $tenant] = createUserWithTenant(
|
||||
tenant: $tenant,
|
||||
role: 'owner',
|
||||
ensureDefaultMicrosoftProviderConnection: false,
|
||||
);
|
||||
|
||||
ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'provider' => 'microsoft',
|
||||
'display_name' => 'Truth Cleanup Connection',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Blocked->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
Livewire::test(ViewTenant::class, ['record' => $tenant->getRouteKey()])
|
||||
->assertSee('Lifecycle summary')
|
||||
->assertSee('This tenant is still onboarding. It remains visible on management and review surfaces, but it is not selectable as active context until onboarding completes.')
|
||||
->assertSee('RBAC status')
|
||||
->assertSee('Failed')
|
||||
->assertDontSee('App status')
|
||||
->assertSee('Truth Cleanup Connection')
|
||||
->assertSee('Granted')
|
||||
->assertSee('Blocked')
|
||||
->assertSee('Legacy status')
|
||||
->assertSee('Connected')
|
||||
->assertSee('Legacy health')
|
||||
->assertSee('OK');
|
||||
});
|
||||
|
||||
it('flags tenants that have microsoft connections but no default connection configured', function (): void {
|
||||
$tenant = Tenant::factory()->active()->create([
|
||||
'name' => 'Missing Default Tenant',
|
||||
]);
|
||||
|
||||
[$user, $tenant] = createUserWithTenant(
|
||||
tenant: $tenant,
|
||||
role: 'owner',
|
||||
ensureDefaultMicrosoftProviderConnection: false,
|
||||
);
|
||||
|
||||
ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'provider' => 'microsoft',
|
||||
'display_name' => 'Fallback Microsoft Connection',
|
||||
'is_default' => false,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Healthy->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
Livewire::test(ViewTenant::class, ['record' => $tenant->getRouteKey()])
|
||||
->assertSee('Needs action: set a default Microsoft provider connection.')
|
||||
->assertSee('Fallback Microsoft Connection')
|
||||
->assertSee('Open Provider Connections');
|
||||
});
|
||||
|
||||
it('does not collapse active lifecycle and blocked provider verification into readiness language', function (): void {
|
||||
$tenant = Tenant::factory()->active()->create([
|
||||
'name' => 'No False Readiness Tenant',
|
||||
'app_status' => 'ok',
|
||||
'rbac_status' => 'configured',
|
||||
]);
|
||||
|
||||
[$user, $tenant] = createUserWithTenant(
|
||||
tenant: $tenant,
|
||||
role: 'owner',
|
||||
ensureDefaultMicrosoftProviderConnection: false,
|
||||
);
|
||||
|
||||
ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'provider' => 'microsoft',
|
||||
'display_name' => 'Blocked Connection',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Blocked->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
Livewire::test(ViewTenant::class, ['record' => $tenant->getRouteKey()])
|
||||
->assertSee('Active')
|
||||
->assertSee('Granted')
|
||||
->assertSee('Blocked')
|
||||
->assertSee('RBAC status')
|
||||
->assertDontSee('Ready');
|
||||
});
|
||||
@ -22,3 +22,41 @@
|
||||
->get('/admin')
|
||||
->assertNotFound();
|
||||
});
|
||||
|
||||
it('falls back to workspace-safe operations recovery when only workspace-level activity is actionable', function (): void {
|
||||
$tenant = \App\Models\Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenant] = createUserWithTenant($tenant, role: 'readonly', workspaceRole: 'readonly');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
\App\Models\OperationRun::factory()->tenantlessForWorkspace($tenant->workspace()->firstOrFail())->create([
|
||||
'status' => \App\Support\OperationRunStatus::Running->value,
|
||||
'outcome' => \App\Support\OperationRunOutcome::Pending->value,
|
||||
]);
|
||||
|
||||
$workspace = $tenant->workspace()->firstOrFail();
|
||||
$overview = app(\App\Support\Workspaces\WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
|
||||
expect($overview['attention_items'])->toBe([])
|
||||
->and($overview['calmness']['is_calm'])->toBeFalse()
|
||||
->and($overview['calmness']['next_action']['kind'])->toBe('operations_index')
|
||||
->and($overview['calmness']['next_action']['url'])->toContain('tenant_scope=all')
|
||||
->and($overview['calmness']['next_action']['url'])->toContain('activeTab=blocked');
|
||||
});
|
||||
|
||||
it('uses switch workspace as the zero-tenant recovery action', function (): void {
|
||||
$user = User::factory()->create();
|
||||
$workspace = Workspace::factory()->create();
|
||||
|
||||
WorkspaceMembership::factory()->create([
|
||||
'workspace_id' => (int) $workspace->getKey(),
|
||||
'user_id' => (int) $user->getKey(),
|
||||
'role' => 'readonly',
|
||||
]);
|
||||
|
||||
$overview = app(\App\Support\Workspaces\WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
|
||||
expect($overview['calmness']['is_calm'])->toBeFalse()
|
||||
->and($overview['calmness']['next_action']['kind'])->toBe('switch_workspace')
|
||||
->and($overview['attention_empty_state']['action_label'])->toBe('Switch workspace');
|
||||
});
|
||||
|
||||
@ -8,6 +8,8 @@
|
||||
|
||||
it('shows workspace identity, summary cards, recent operations, and quick actions', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
@ -23,6 +25,7 @@
|
||||
->assertOk()
|
||||
->assertSee('Workspace overview')
|
||||
->assertSee('Accessible tenants')
|
||||
->assertSee('Governance attention')
|
||||
->assertSee('Active operations')
|
||||
->assertSee('Needs attention')
|
||||
->assertSee('Recent operations')
|
||||
@ -30,6 +33,7 @@
|
||||
->assertSee('Open operations')
|
||||
->assertSee('Open alerts')
|
||||
->assertSee('Review current and recent workspace-wide operations.')
|
||||
->assertSee('Workspace-wide operations that are still queued or in progress.')
|
||||
->assertSee('Activity only. Active execution does not imply governance health.')
|
||||
->assertSee('Governance risk counts affected tenants')
|
||||
->assertSee('Inventory sync');
|
||||
});
|
||||
|
||||
68
tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php
Normal file
68
tests/Feature/Filament/WorkspaceOverviewDbOnlyTest.php
Normal file
@ -0,0 +1,68 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Models\Finding;
|
||||
use App\Models\OperationRun;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Illuminate\Support\Facades\DB;
|
||||
|
||||
it('renders the workspace overview DB-only with bounded query volume for representative visible-tenant scenarios', function (): void {
|
||||
$tenantA = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profileA, $snapshotA] = seedActiveBaselineForTenant($tenantA);
|
||||
seedBaselineCompareRun($tenantA, $profileA, $snapshotA, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->for($tenantA)->create([
|
||||
'workspace_id' => (int) $tenantA->workspace_id,
|
||||
'status' => Finding::STATUS_TRIAGED,
|
||||
'due_at' => now()->subDay(),
|
||||
]);
|
||||
|
||||
$tenantB = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantA->workspace_id,
|
||||
'name' => 'Second Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantB, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profileB, $snapshotB] = seedActiveBaselineForTenant($tenantB);
|
||||
seedBaselineCompareRun(
|
||||
$tenantB,
|
||||
$profileB,
|
||||
$snapshotB,
|
||||
workspaceOverviewCompareCoverage(),
|
||||
completedAt: now()->subDays(10),
|
||||
);
|
||||
|
||||
$tenantC = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantA->workspace_id,
|
||||
'name' => 'Third Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantC, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profileC, $snapshotC] = seedActiveBaselineForTenant($tenantC);
|
||||
seedBaselineCompareRun($tenantC, $profileC, $snapshotC, workspaceOverviewCompareCoverage());
|
||||
|
||||
OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenantC->getKey(),
|
||||
'workspace_id' => (int) $tenantC->workspace_id,
|
||||
'status' => \App\Support\OperationRunStatus::Running->value,
|
||||
'outcome' => \App\Support\OperationRunOutcome::Pending->value,
|
||||
]);
|
||||
|
||||
DB::flushQueryLog();
|
||||
DB::enableQueryLog();
|
||||
|
||||
$this->actingAs($user);
|
||||
|
||||
assertNoOutboundHttp(function () use ($tenantA): void {
|
||||
$this->withSession([WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id])
|
||||
->get('/admin')
|
||||
->assertOk()
|
||||
->assertSee('Governance attention')
|
||||
->assertSee('Recent operations');
|
||||
});
|
||||
|
||||
expect(count(DB::getQueryLog()))->toBeLessThan(80);
|
||||
});
|
||||
@ -0,0 +1,178 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Filament\Resources\EvidenceSnapshotResource;
|
||||
use App\Filament\Resources\TenantReviewResource;
|
||||
use App\Filament\Widgets\Workspace\WorkspaceNeedsAttention;
|
||||
use App\Models\AlertDelivery;
|
||||
use App\Models\Finding;
|
||||
use App\Models\OperationRun;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\OperationRunOutcome;
|
||||
use App\Support\OperationRunStatus;
|
||||
use App\Support\OperationRunType;
|
||||
use App\Support\Workspaces\WorkspaceOverviewBuilder;
|
||||
use Livewire\Livewire;
|
||||
|
||||
it('preserves canonical findings, compare, alerts, and operations drill-through continuity from the workspace overview', function (): void {
|
||||
$tenantDashboard = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantDashboard] = createUserWithTenant($tenantDashboard, role: 'owner', workspaceRole: 'readonly');
|
||||
[$dashboardProfile, $dashboardSnapshot] = seedActiveBaselineForTenant($tenantDashboard);
|
||||
seedBaselineCompareRun($tenantDashboard, $dashboardProfile, $dashboardSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->riskAccepted()->create([
|
||||
'workspace_id' => (int) $tenantDashboard->workspace_id,
|
||||
'tenant_id' => (int) $tenantDashboard->getKey(),
|
||||
]);
|
||||
|
||||
$tenantFindings = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantDashboard->workspace_id,
|
||||
]);
|
||||
createUserWithTenant($tenantFindings, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$findingsProfile, $findingsSnapshot] = seedActiveBaselineForTenant($tenantFindings);
|
||||
seedBaselineCompareRun($tenantFindings, $findingsProfile, $findingsSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->for($tenantFindings)->create([
|
||||
'workspace_id' => (int) $tenantFindings->workspace_id,
|
||||
'status' => Finding::STATUS_TRIAGED,
|
||||
'due_at' => now()->subDay(),
|
||||
]);
|
||||
|
||||
$tenantCompare = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantDashboard->workspace_id,
|
||||
'name' => 'Compare Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantCompare, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$compareProfile, $compareSnapshot] = seedActiveBaselineForTenant($tenantCompare);
|
||||
seedBaselineCompareRun(
|
||||
$tenantCompare,
|
||||
$compareProfile,
|
||||
$compareSnapshot,
|
||||
workspaceOverviewCompareCoverage(),
|
||||
completedAt: now()->subDays(10),
|
||||
);
|
||||
|
||||
$tenantOperations = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantDashboard->workspace_id,
|
||||
'name' => 'Operations Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantOperations, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$operationsProfile, $operationsSnapshot] = seedActiveBaselineForTenant($tenantOperations);
|
||||
seedBaselineCompareRun($tenantOperations, $operationsProfile, $operationsSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenantOperations->getKey(),
|
||||
'workspace_id' => (int) $tenantOperations->workspace_id,
|
||||
'type' => OperationRunType::PolicySync->value,
|
||||
'status' => OperationRunStatus::Completed->value,
|
||||
'outcome' => OperationRunOutcome::Failed->value,
|
||||
]);
|
||||
|
||||
$tenantAlerts = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantDashboard->workspace_id,
|
||||
'name' => 'Alerts Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantAlerts, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$alertsProfile, $alertsSnapshot] = seedActiveBaselineForTenant($tenantAlerts);
|
||||
seedBaselineCompareRun($tenantAlerts, $alertsProfile, $alertsSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
AlertDelivery::factory()->create([
|
||||
'tenant_id' => (int) $tenantAlerts->getKey(),
|
||||
'workspace_id' => (int) $tenantAlerts->workspace_id,
|
||||
'status' => AlertDelivery::STATUS_FAILED,
|
||||
'created_at' => now(),
|
||||
]);
|
||||
|
||||
$workspace = $tenantDashboard->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
$items = collect($overview['attention_items'])->keyBy('key');
|
||||
|
||||
expect($items->get('tenant_lapsed_governance')['destination']['kind'])->toBe('tenant_dashboard')
|
||||
->and($items->get('tenant_overdue_findings')['destination']['kind'])->toBe('tenant_findings')
|
||||
->and($items->get('tenant_overdue_findings')['destination']['url'])->toContain('tab=overdue')
|
||||
->and($items->get('tenant_compare_attention')['destination']['kind'])->toBe('baseline_compare_landing')
|
||||
->and($items->get('tenant_operations_follow_up')['destination']['kind'])->toBe('operations_index')
|
||||
->and($items->get('tenant_operations_follow_up')['destination']['url'])->toContain('activeTab=blocked')
|
||||
->and($items->get('tenant_operations_follow_up')['destination']['url'])->toContain('tenant_id='.(string) $tenantOperations->getKey())
|
||||
->and($items->get('tenant_alert_delivery_failures')['destination']['kind'])->toBe('alerts_overview')
|
||||
->and($items->get('tenant_alert_delivery_failures')['destination']['url'])->toContain('nav%5Bback_url%5D=');
|
||||
});
|
||||
|
||||
it('renders evidence and review actions through the shared attention-item contract', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner', workspaceRole: 'readonly');
|
||||
$this->actingAs($user);
|
||||
|
||||
$evidenceUrl = EvidenceSnapshotResource::getUrl('index', panel: 'tenant', tenant: $tenant);
|
||||
$reviewUrl = TenantReviewResource::tenantScopedUrl('index', [], $tenant);
|
||||
|
||||
$items = [
|
||||
[
|
||||
'key' => 'tenant_evidence_attention',
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'tenant_label' => (string) $tenant->name,
|
||||
'tenant_route_key' => (string) $tenant->external_id,
|
||||
'family' => 'evidence',
|
||||
'urgency' => 'high',
|
||||
'title' => 'Evidence needs refresh',
|
||||
'body' => 'Current evidence should be refreshed before relying on it.',
|
||||
'supporting_message' => null,
|
||||
'badge' => 'Evidence',
|
||||
'badge_color' => 'warning',
|
||||
'destination' => [
|
||||
'kind' => 'tenant_evidence',
|
||||
'url' => $evidenceUrl,
|
||||
'tenant_route_key' => (string) $tenant->external_id,
|
||||
'label' => 'Open evidence',
|
||||
'disabled' => false,
|
||||
'helper_text' => null,
|
||||
'filters' => null,
|
||||
],
|
||||
'action_disabled' => false,
|
||||
'helper_text' => null,
|
||||
'url' => $evidenceUrl,
|
||||
],
|
||||
[
|
||||
'key' => 'tenant_review_attention',
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'tenant_label' => (string) $tenant->name,
|
||||
'tenant_route_key' => (string) $tenant->external_id,
|
||||
'family' => 'review',
|
||||
'urgency' => 'medium',
|
||||
'title' => 'Review needs publication work',
|
||||
'body' => 'The current review is still internal-only.',
|
||||
'supporting_message' => null,
|
||||
'badge' => 'Review',
|
||||
'badge_color' => 'warning',
|
||||
'destination' => [
|
||||
'kind' => 'tenant_reviews',
|
||||
'url' => $reviewUrl,
|
||||
'tenant_route_key' => (string) $tenant->external_id,
|
||||
'label' => 'Open review',
|
||||
'disabled' => false,
|
||||
'helper_text' => null,
|
||||
'filters' => null,
|
||||
],
|
||||
'action_disabled' => false,
|
||||
'helper_text' => null,
|
||||
'url' => $reviewUrl,
|
||||
],
|
||||
];
|
||||
|
||||
$component = Livewire::test(WorkspaceNeedsAttention::class, [
|
||||
'items' => $items,
|
||||
'emptyState' => [],
|
||||
])
|
||||
->assertSee('Evidence needs refresh')
|
||||
->assertSee('Open evidence')
|
||||
->assertSee('Review needs publication work')
|
||||
->assertSee('Open review');
|
||||
|
||||
expect($component->html())
|
||||
->toContain($evidenceUrl)
|
||||
->toContain($reviewUrl);
|
||||
});
|
||||
@ -2,6 +2,8 @@
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Models\Finding;
|
||||
use App\Models\Tenant;
|
||||
use App\Models\User;
|
||||
use App\Models\Workspace;
|
||||
use App\Models\WorkspaceMembership;
|
||||
@ -22,8 +24,43 @@
|
||||
->get('/admin')
|
||||
->assertOk()
|
||||
->assertSee('No accessible tenants in this workspace')
|
||||
->assertSee('Nothing urgent in your current scope')
|
||||
->assertSee('This workspace is not calm or healthy yet because your current scope has no visible tenants.')
|
||||
->assertSee('No recent operations yet')
|
||||
->assertSee('Switch workspace')
|
||||
->assertDontSee('Choose tenant');
|
||||
});
|
||||
|
||||
it('does not render a calm state when governance risk exists even if operations are quiet', function (): void {
|
||||
$tenant = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->for($tenant)->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'status' => Finding::STATUS_TRIAGED,
|
||||
'due_at' => now()->subDay(),
|
||||
]);
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get('/admin')
|
||||
->assertOk()
|
||||
->assertSee('Overdue findings')
|
||||
->assertDontSee('Nothing urgent in your visible workspace slice')
|
||||
->assertDontSee('Visible governance, findings, compare posture, and activity currently look calm.');
|
||||
});
|
||||
|
||||
it('renders the healthy calm state only when visible governance and activity are genuinely quiet', function (): void {
|
||||
$tenant = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get('/admin')
|
||||
->assertOk()
|
||||
->assertSee('Nothing urgent in your visible workspace slice')
|
||||
->assertSee('Visible governance, findings, compare posture, and activity currently look calm.');
|
||||
});
|
||||
|
||||
@ -0,0 +1,176 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Models\AlertDelivery;
|
||||
use App\Models\Finding;
|
||||
use App\Models\FindingException;
|
||||
use App\Models\OperationRun;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\OperationRunOutcome;
|
||||
use App\Support\OperationRunStatus;
|
||||
use App\Support\OperationRunType;
|
||||
use App\Support\Workspaces\WorkspaceOverviewBuilder;
|
||||
|
||||
it('prioritizes governance-critical tenants above activity-only and alert-only items', function (): void {
|
||||
$tenantGovernance = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantGovernance] = createUserWithTenant($tenantGovernance, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenantGovernance);
|
||||
seedBaselineCompareRun($tenantGovernance, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->for($tenantGovernance)->create([
|
||||
'workspace_id' => (int) $tenantGovernance->workspace_id,
|
||||
'status' => Finding::STATUS_TRIAGED,
|
||||
'due_at' => now()->subDay(),
|
||||
]);
|
||||
|
||||
$tenantActivity = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantGovernance->workspace_id,
|
||||
'name' => 'Busy Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantActivity, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$activityProfile, $activitySnapshot] = seedActiveBaselineForTenant($tenantActivity);
|
||||
seedBaselineCompareRun($tenantActivity, $activityProfile, $activitySnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenantActivity->getKey(),
|
||||
'workspace_id' => (int) $tenantActivity->workspace_id,
|
||||
'type' => OperationRunType::InventorySync->value,
|
||||
'status' => OperationRunStatus::Running->value,
|
||||
'outcome' => OperationRunOutcome::Pending->value,
|
||||
]);
|
||||
|
||||
$tenantAlerts = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantGovernance->workspace_id,
|
||||
'name' => 'Alerts Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantAlerts, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$alertsProfile, $alertsSnapshot] = seedActiveBaselineForTenant($tenantAlerts);
|
||||
seedBaselineCompareRun($tenantAlerts, $alertsProfile, $alertsSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
AlertDelivery::factory()->create([
|
||||
'tenant_id' => (int) $tenantAlerts->getKey(),
|
||||
'workspace_id' => (int) $tenantAlerts->workspace_id,
|
||||
'status' => AlertDelivery::STATUS_FAILED,
|
||||
'created_at' => now(),
|
||||
]);
|
||||
|
||||
$workspace = $tenantGovernance->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
|
||||
expect($overview['calmness']['is_calm'])->toBeFalse()
|
||||
->and($overview['attention_items'])->toHaveCount(3)
|
||||
->and($overview['attention_items'][0]['key'])->toBe('tenant_overdue_findings')
|
||||
->and($overview['attention_items'][0]['tenant_label'])->toBe((string) $tenantGovernance->name)
|
||||
->and($overview['attention_items'][1]['key'])->toBe('tenant_active_operations')
|
||||
->and($overview['attention_items'][2]['key'])->toBe('tenant_alert_delivery_failures');
|
||||
});
|
||||
|
||||
it('surfaces expiring governance and stale compare posture as governance attention without a false calm state', function (): void {
|
||||
$tenantExpiring = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantExpiring] = createUserWithTenant($tenantExpiring, role: 'owner', workspaceRole: 'readonly');
|
||||
[$expiringProfile, $expiringSnapshot] = seedActiveBaselineForTenant($tenantExpiring);
|
||||
seedBaselineCompareRun($tenantExpiring, $expiringProfile, $expiringSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
$finding = Finding::factory()->riskAccepted()->create([
|
||||
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
||||
'tenant_id' => (int) $tenantExpiring->getKey(),
|
||||
]);
|
||||
|
||||
FindingException::query()->create([
|
||||
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
||||
'tenant_id' => (int) $tenantExpiring->getKey(),
|
||||
'finding_id' => (int) $finding->getKey(),
|
||||
'requested_by_user_id' => (int) $user->getKey(),
|
||||
'owner_user_id' => (int) $user->getKey(),
|
||||
'approved_by_user_id' => (int) $user->getKey(),
|
||||
'status' => FindingException::STATUS_EXPIRING,
|
||||
'current_validity_state' => FindingException::VALIDITY_EXPIRING,
|
||||
'request_reason' => 'Governance nearly expired',
|
||||
'approval_reason' => 'Accepted for a short window',
|
||||
'requested_at' => now()->subDays(2),
|
||||
'approved_at' => now()->subDay(),
|
||||
'effective_from' => now()->subDay(),
|
||||
'expires_at' => now()->addDay(),
|
||||
'review_due_at' => now()->addDay(),
|
||||
'evidence_summary' => ['reference_count' => 0],
|
||||
]);
|
||||
|
||||
$tenantStale = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
||||
'name' => 'Stale Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantStale, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$staleProfile, $staleSnapshot] = seedActiveBaselineForTenant($tenantStale);
|
||||
seedBaselineCompareRun(
|
||||
$tenantStale,
|
||||
$staleProfile,
|
||||
$staleSnapshot,
|
||||
workspaceOverviewCompareCoverage(),
|
||||
completedAt: now()->subDays(10),
|
||||
);
|
||||
|
||||
$workspace = $tenantExpiring->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
$items = collect($overview['attention_items'])->keyBy('key');
|
||||
|
||||
expect($overview['calmness']['is_calm'])->toBeFalse()
|
||||
->and($items->keys()->all())->toContain('tenant_expiring_governance', 'tenant_compare_attention')
|
||||
->and($items->get('tenant_compare_attention')['badge'])->toBe('Baseline')
|
||||
->and($items->get('tenant_expiring_governance')['family'])->toBe('governance');
|
||||
});
|
||||
|
||||
it('ranks lapsed governance and failed compare posture ahead of high-severity findings', function (): void {
|
||||
$tenantLapsed = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantLapsed] = createUserWithTenant($tenantLapsed, role: 'owner', workspaceRole: 'readonly');
|
||||
[$lapsedProfile, $lapsedSnapshot] = seedActiveBaselineForTenant($tenantLapsed);
|
||||
seedBaselineCompareRun($tenantLapsed, $lapsedProfile, $lapsedSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->riskAccepted()->create([
|
||||
'workspace_id' => (int) $tenantLapsed->workspace_id,
|
||||
'tenant_id' => (int) $tenantLapsed->getKey(),
|
||||
]);
|
||||
|
||||
$tenantFailedCompare = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantLapsed->workspace_id,
|
||||
'name' => 'Failed Compare Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantFailedCompare, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$failedProfile, $failedSnapshot] = seedActiveBaselineForTenant($tenantFailedCompare);
|
||||
seedBaselineCompareRun(
|
||||
$tenantFailedCompare,
|
||||
$failedProfile,
|
||||
$failedSnapshot,
|
||||
workspaceOverviewCompareCoverage(),
|
||||
outcome: OperationRunOutcome::Failed->value,
|
||||
);
|
||||
|
||||
$tenantHighSeverity = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantLapsed->workspace_id,
|
||||
'name' => 'High Severity Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantHighSeverity, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$highProfile, $highSnapshot] = seedActiveBaselineForTenant($tenantHighSeverity);
|
||||
seedBaselineCompareRun($tenantHighSeverity, $highProfile, $highSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->for($tenantHighSeverity)->create([
|
||||
'workspace_id' => (int) $tenantHighSeverity->workspace_id,
|
||||
'status' => Finding::STATUS_TRIAGED,
|
||||
'severity' => Finding::SEVERITY_CRITICAL,
|
||||
]);
|
||||
|
||||
$workspace = $tenantLapsed->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
|
||||
expect(collect($overview['attention_items'])->pluck('key')->take(3)->all())
|
||||
->toBe([
|
||||
'tenant_lapsed_governance',
|
||||
'tenant_compare_attention',
|
||||
'tenant_high_severity_findings',
|
||||
]);
|
||||
});
|
||||
@ -40,3 +40,24 @@
|
||||
|
||||
expect((string) $response->getContent())->not->toContain('wire:poll');
|
||||
});
|
||||
|
||||
it('keeps recent operations diagnostic and separate from calm governance messaging', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'type' => 'inventory_sync',
|
||||
'status' => \App\Support\OperationRunStatus::Running->value,
|
||||
'outcome' => \App\Support\OperationRunOutcome::Pending->value,
|
||||
]);
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get('/admin')
|
||||
->assertOk()
|
||||
->assertSee('Diagnostic recency across your visible workspace slice. This does not define governance health on its own.')
|
||||
->assertDontSee('Visible governance, findings, compare posture, and activity currently look calm.');
|
||||
});
|
||||
|
||||
@ -3,8 +3,12 @@
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Models\Tenant;
|
||||
use App\Services\Auth\CapabilityResolver;
|
||||
use App\Support\Auth\Capabilities;
|
||||
use App\Support\Workspaces\WorkspaceOverviewBuilder;
|
||||
|
||||
use function Pest\Laravel\mock;
|
||||
|
||||
it('keeps switch workspace visible while hiding manage workspaces and unauthorized tenant counts for readonly members', function (): void {
|
||||
$tenantA = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'readonly');
|
||||
@ -24,3 +28,37 @@
|
||||
->and($quickActionKeys)->toContain('switch_workspace')
|
||||
->and($quickActionKeys)->not->toContain('manage_workspaces');
|
||||
});
|
||||
|
||||
it('keeps governance attention visible but non-clickable when the tenant membership does not grant drill-through capability', function (): void {
|
||||
$tenant = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenant] = createUserWithTenant($tenant, role: 'readonly', workspaceRole: 'readonly');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
\App\Models\Finding::factory()->for($tenant)->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'status' => \App\Models\Finding::STATUS_TRIAGED,
|
||||
'due_at' => now()->subDay(),
|
||||
]);
|
||||
|
||||
mock(CapabilityResolver::class, function ($mock) use ($tenant): void {
|
||||
$mock->shouldReceive('primeMemberships')->once();
|
||||
$mock->shouldReceive('can')
|
||||
->andReturnUsing(static function (\App\Models\User $user, Tenant $resolvedTenant, string $capability) use ($tenant): bool {
|
||||
expect((int) $resolvedTenant->getKey())->toBe((int) $tenant->getKey());
|
||||
|
||||
return match ($capability) {
|
||||
Capabilities::TENANT_VIEW, Capabilities::TENANT_FINDINGS_VIEW => false,
|
||||
default => false,
|
||||
};
|
||||
});
|
||||
});
|
||||
|
||||
$workspace = $tenant->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
$item = collect($overview['attention_items'])->firstWhere('key', 'tenant_overdue_findings');
|
||||
|
||||
expect($item['action_disabled'])->toBeTrue()
|
||||
->and($item['destination']['kind'])->toBe('tenant_findings')
|
||||
->and($item['helper_text'])->not->toBeNull();
|
||||
});
|
||||
|
||||
126
tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php
Normal file
126
tests/Feature/Filament/WorkspaceOverviewSummaryMetricsTest.php
Normal file
@ -0,0 +1,126 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Models\AlertDelivery;
|
||||
use App\Models\Finding;
|
||||
use App\Models\FindingException;
|
||||
use App\Models\OperationRun;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\Workspaces\WorkspaceOverviewBuilder;
|
||||
|
||||
it('counts governance attention by affected tenant instead of raw issue totals', function (): void {
|
||||
$tenantOverdue = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenantOverdue] = createUserWithTenant($tenantOverdue, role: 'owner', workspaceRole: 'readonly');
|
||||
[$overdueProfile, $overdueSnapshot] = seedActiveBaselineForTenant($tenantOverdue);
|
||||
seedBaselineCompareRun($tenantOverdue, $overdueProfile, $overdueSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
Finding::factory()->count(3)->for($tenantOverdue)->create([
|
||||
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
||||
'status' => Finding::STATUS_TRIAGED,
|
||||
'due_at' => now()->subDay(),
|
||||
]);
|
||||
|
||||
$tenantExpiring = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
||||
'name' => 'Expiring Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantExpiring, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$expiringProfile, $expiringSnapshot] = seedActiveBaselineForTenant($tenantExpiring);
|
||||
seedBaselineCompareRun($tenantExpiring, $expiringProfile, $expiringSnapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
$finding = Finding::factory()->riskAccepted()->create([
|
||||
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
||||
'tenant_id' => (int) $tenantExpiring->getKey(),
|
||||
]);
|
||||
|
||||
FindingException::query()->create([
|
||||
'workspace_id' => (int) $tenantExpiring->workspace_id,
|
||||
'tenant_id' => (int) $tenantExpiring->getKey(),
|
||||
'finding_id' => (int) $finding->getKey(),
|
||||
'requested_by_user_id' => (int) $user->getKey(),
|
||||
'owner_user_id' => (int) $user->getKey(),
|
||||
'approved_by_user_id' => (int) $user->getKey(),
|
||||
'status' => FindingException::STATUS_EXPIRING,
|
||||
'current_validity_state' => FindingException::VALIDITY_EXPIRING,
|
||||
'request_reason' => 'Pending governance review',
|
||||
'approval_reason' => 'Short lived exception',
|
||||
'requested_at' => now()->subDays(2),
|
||||
'approved_at' => now()->subDay(),
|
||||
'effective_from' => now()->subDay(),
|
||||
'expires_at' => now()->addDay(),
|
||||
'review_due_at' => now()->addDay(),
|
||||
'evidence_summary' => ['reference_count' => 0],
|
||||
]);
|
||||
|
||||
$tenantStale = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
||||
'name' => 'Stale Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantStale, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$staleProfile, $staleSnapshot] = seedActiveBaselineForTenant($tenantStale);
|
||||
seedBaselineCompareRun(
|
||||
$tenantStale,
|
||||
$staleProfile,
|
||||
$staleSnapshot,
|
||||
workspaceOverviewCompareCoverage(),
|
||||
completedAt: now()->subDays(10),
|
||||
);
|
||||
|
||||
$tenantFailedCompare = Tenant::factory()->create([
|
||||
'status' => 'active',
|
||||
'workspace_id' => (int) $tenantOverdue->workspace_id,
|
||||
'name' => 'Failed Compare Tenant',
|
||||
]);
|
||||
createUserWithTenant($tenantFailedCompare, $user, role: 'owner', workspaceRole: 'readonly');
|
||||
[$failedProfile, $failedSnapshot] = seedActiveBaselineForTenant($tenantFailedCompare);
|
||||
seedBaselineCompareRun(
|
||||
$tenantFailedCompare,
|
||||
$failedProfile,
|
||||
$failedSnapshot,
|
||||
workspaceOverviewCompareCoverage(),
|
||||
outcome: \App\Support\OperationRunOutcome::Failed->value,
|
||||
);
|
||||
|
||||
$workspace = $tenantOverdue->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
$metrics = collect($overview['summary_metrics'])->keyBy('key');
|
||||
|
||||
expect($metrics->get('governance_attention_tenants')['value'])->toBe(4)
|
||||
->and($metrics->get('governance_attention_tenants')['category'])->toBe('governance_risk')
|
||||
->and($metrics->get('governance_attention_tenants')['destination']['kind'])->toBe('choose_tenant');
|
||||
});
|
||||
|
||||
it('keeps activity and alerts metrics separate from governance risk', function (): void {
|
||||
$tenant = Tenant::factory()->create(['status' => 'active']);
|
||||
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner', workspaceRole: 'readonly');
|
||||
[$profile, $snapshot] = seedActiveBaselineForTenant($tenant);
|
||||
seedBaselineCompareRun($tenant, $profile, $snapshot, workspaceOverviewCompareCoverage());
|
||||
|
||||
OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'status' => \App\Support\OperationRunStatus::Running->value,
|
||||
'outcome' => \App\Support\OperationRunOutcome::Pending->value,
|
||||
]);
|
||||
|
||||
AlertDelivery::factory()->create([
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'status' => AlertDelivery::STATUS_FAILED,
|
||||
'created_at' => now(),
|
||||
]);
|
||||
|
||||
$workspace = $tenant->workspace()->firstOrFail();
|
||||
$overview = app(WorkspaceOverviewBuilder::class)->build($workspace, $user);
|
||||
$metrics = collect($overview['summary_metrics'])->keyBy('key');
|
||||
|
||||
expect($metrics->get('governance_attention_tenants')['value'])->toBe(0)
|
||||
->and($metrics->get('active_operations')['value'])->toBe(1)
|
||||
->and($metrics->get('active_operations')['category'])->toBe('activity')
|
||||
->and($metrics->get('active_operations')['destination']['kind'])->toBe('operations_index')
|
||||
->and($metrics->get('alert_failures')['value'])->toBe(1)
|
||||
->and($metrics->get('alert_failures')['category'])->toBe('alerts');
|
||||
});
|
||||
@ -93,12 +93,12 @@
|
||||
->test(AuditLogPage::class)
|
||||
->assertCanSeeTableRecords([$withRunLink, $withoutRunLink])
|
||||
->mountTableAction('inspect', $withRunLink)
|
||||
->assertMountedActionModalSee('Open operation run');
|
||||
->assertMountedActionModalSee('Open operation');
|
||||
|
||||
$component
|
||||
->call('replaceMountedTableAction', 'inspect', (string) $withoutRunLink->getKey())
|
||||
->assertMountedActionModalSee('Workspace selected for Workspace 1')
|
||||
->assertMountedActionModalDontSee('Open operation run')
|
||||
->assertMountedActionModalDontSee('Open operation')
|
||||
->assertMountedActionModalDontSee('Baseline compare completed for Operation run');
|
||||
});
|
||||
|
||||
@ -163,5 +163,5 @@
|
||||
->get(route('admin.monitoring.audit-log'))
|
||||
->assertOk()
|
||||
->assertDontSee('Close details')
|
||||
->assertDontSee('Open operation run');
|
||||
->assertDontSee('Open operation');
|
||||
});
|
||||
|
||||
@ -271,8 +271,8 @@
|
||||
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Tenant scope: Current Tenant')
|
||||
->assertSee('Current tenant context differs from this run')
|
||||
->assertSee('Run tenant: Run Tenant.');
|
||||
->assertSee('Current tenant context differs from this operation')
|
||||
->assertSee('Operation tenant: Run Tenant.');
|
||||
});
|
||||
|
||||
it('shows canonical workspace framing on canonical run pages with no selected tenant context', function (): void {
|
||||
|
||||
@ -45,7 +45,7 @@
|
||||
->get('/admin/operations')
|
||||
->assertOk()
|
||||
->assertSee('Likely stale')
|
||||
->assertSee('run(s) have already been automatically reconciled');
|
||||
->assertSee('operation(s) have already been automatically reconciled');
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
@ -57,7 +57,7 @@
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get(route('admin.operations.view', ['run' => (int) $staleRun->getKey()]))
|
||||
->assertOk()
|
||||
->assertSee('Likely stale run');
|
||||
->assertSee('Likely stale operation');
|
||||
});
|
||||
|
||||
it('renders lifecycle outcome fallbacks when historical runs are missing stored outcomes', function (): void {
|
||||
|
||||
@ -56,7 +56,7 @@
|
||||
$this->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
||||
->get(OperationRunLinks::tenantlessView($run))
|
||||
->assertOk()
|
||||
->assertSee('Run tenant is not available in the current tenant selector')
|
||||
->assertSee('Operation tenant is not available in the current tenant selector')
|
||||
->assertSee('This tenant is currently archived')
|
||||
->assertSee('Back to Operations')
|
||||
->assertDontSee('← Back to Archived Tenant');
|
||||
|
||||
@ -141,6 +141,56 @@
|
||||
->assertCanNotSeeTableRecords([$healthyActive, $otherTenantFailed]);
|
||||
});
|
||||
|
||||
it('allows workspace-originated operations drill-through to clear tenant context and show workspace-wide follow-up', function (): void {
|
||||
$tenantA = Tenant::factory()->create();
|
||||
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
||||
|
||||
$tenantB = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $tenantA->workspace_id,
|
||||
]);
|
||||
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
||||
|
||||
$workspaceRun = OperationRun::factory()->tenantlessForWorkspace($tenantA->workspace()->firstOrFail())->create([
|
||||
'type' => 'inventory_sync',
|
||||
'status' => OperationRunStatus::Queued->value,
|
||||
'outcome' => OperationRunOutcome::Pending->value,
|
||||
'created_at' => now()->subHour(),
|
||||
]);
|
||||
|
||||
$otherTenantFailed = OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenantB->getKey(),
|
||||
'workspace_id' => (int) $tenantB->workspace_id,
|
||||
'type' => 'policy.sync',
|
||||
'status' => OperationRunStatus::Completed->value,
|
||||
'outcome' => OperationRunOutcome::Failed->value,
|
||||
]);
|
||||
|
||||
$healthyActive = OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenantA->getKey(),
|
||||
'workspace_id' => (int) $tenantA->workspace_id,
|
||||
'type' => 'inventory_sync',
|
||||
'status' => OperationRunStatus::Running->value,
|
||||
'outcome' => OperationRunOutcome::Pending->value,
|
||||
'created_at' => now()->subMinute(),
|
||||
'started_at' => now()->subMinute(),
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
Filament::setTenant($tenantA, true);
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenantA->workspace_id);
|
||||
|
||||
Livewire::withQueryParams([
|
||||
'tenant_scope' => 'all',
|
||||
'activeTab' => 'blocked',
|
||||
])
|
||||
->actingAs($user)
|
||||
->test(Operations::class)
|
||||
->assertSet('tableFilters.tenant_id.value', null)
|
||||
->assertSet('activeTab', 'blocked')
|
||||
->assertCanSeeTableRecords([$workspaceRun, $otherTenantFailed])
|
||||
->assertCanNotSeeTableRecords([$healthyActive]);
|
||||
});
|
||||
|
||||
it('builds canonical dashboard operations URLs with tenant and tab continuity', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
|
||||
@ -153,5 +203,10 @@
|
||||
->toBe(route('admin.operations.index', [
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'activeTab' => 'blocked',
|
||||
]))
|
||||
->and(OperationRunLinks::index(activeTab: 'blocked', allTenants: true))
|
||||
->toBe(route('admin.operations.index', [
|
||||
'tenant_scope' => 'all',
|
||||
'activeTab' => 'blocked',
|
||||
]));
|
||||
});
|
||||
|
||||
@ -36,7 +36,7 @@
|
||||
|
||||
$notification = $user->notifications()->latest('id')->first();
|
||||
expect($notification)->not->toBeNull();
|
||||
expect($notification->data['body'] ?? null)->toBe('Queued for execution. Open the run for progress and next steps.');
|
||||
expect($notification->data['body'] ?? null)->toBe('Queued for execution. Open the operation for progress and next steps.');
|
||||
expect($notification->data['actions'][0]['url'] ?? null)
|
||||
->toBe(OperationRunLinks::view($run, $tenant));
|
||||
});
|
||||
@ -87,7 +87,7 @@
|
||||
|
||||
$notification = $user->notifications()->latest('id')->first();
|
||||
expect($notification)->not->toBeNull();
|
||||
expect($notification->data['body'] ?? null)->toBe('Queued for execution. Open the run for progress and next steps.');
|
||||
expect($notification->data['body'] ?? null)->toBe('Queued for execution. Open the operation for progress and next steps.');
|
||||
expect($notification->data['actions'][0]['url'] ?? null)
|
||||
->toBe(OperationRunLinks::tenantlessView($run));
|
||||
});
|
||||
|
||||
@ -8,7 +8,7 @@
|
||||
$toast = OperationUxPresenter::queuedToast('policy.sync');
|
||||
|
||||
expect($toast->getTitle())->toBe('Policy sync queued');
|
||||
expect($toast->getBody())->toBe('Queued for execution. Open the run for progress and next steps.');
|
||||
expect($toast->getBody())->toBe('Queued for execution. Open the operation for progress and next steps.');
|
||||
})->group('ops-ux');
|
||||
|
||||
it('enforces queued toast duration within 3–5 seconds', function (): void {
|
||||
@ -25,5 +25,5 @@
|
||||
$toast = OperationUxPresenter::alreadyQueuedToast('backup_set.add_policies');
|
||||
|
||||
expect($toast->getTitle())->toBe('Backup set update already queued');
|
||||
expect($toast->getBody())->toBe('A matching run is already queued or running. No action needed unless it stays stuck.');
|
||||
expect($toast->getBody())->toBe('A matching operation is already queued or running. No action needed unless it stays stuck.');
|
||||
})->group('ops-ux');
|
||||
|
||||
@ -46,7 +46,7 @@
|
||||
|
||||
expect($body)->toContain('Execution failed.');
|
||||
expect($body)->toContain('This is a very long failure message');
|
||||
expect($body)->toContain('Review the run details before retrying.');
|
||||
expect($body)->toContain('Review the operation details before retrying.');
|
||||
|
||||
// Ensure message is not full-length / multiline.
|
||||
expect($body)->not->toContain(str_repeat('x', 200));
|
||||
|
||||
@ -111,3 +111,30 @@
|
||||
->get(ProviderConnectionResource::getUrl('edit', ['record' => $connectionB], tenant: $tenantA))
|
||||
->assertNotFound();
|
||||
});
|
||||
|
||||
test('provider connection view is not accessible cross-tenant', function () {
|
||||
$tenantA = Tenant::factory()->create();
|
||||
$tenantB = Tenant::factory()->create();
|
||||
|
||||
$connectionB = ProviderConnection::factory()->create([
|
||||
'tenant_id' => $tenantB->getKey(),
|
||||
'display_name' => 'Tenant B Connection',
|
||||
]);
|
||||
|
||||
$user = User::factory()->create();
|
||||
$user->tenants()->syncWithoutDetaching([
|
||||
$tenantA->getKey() => ['role' => 'owner'],
|
||||
$tenantB->getKey() => ['role' => 'owner'],
|
||||
]);
|
||||
|
||||
WorkspaceMembership::factory()->create([
|
||||
'workspace_id' => (int) $tenantA->workspace_id,
|
||||
'user_id' => (int) $user->getKey(),
|
||||
'role' => 'owner',
|
||||
]);
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id])
|
||||
->get(ProviderConnectionResource::getUrl('view', ['record' => $connectionB], tenant: $tenantA))
|
||||
->assertNotFound();
|
||||
});
|
||||
|
||||
@ -0,0 +1,147 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Filament\Resources\ProviderConnectionResource;
|
||||
use App\Filament\Resources\ProviderConnectionResource\Pages\ListProviderConnections;
|
||||
use App\Models\ProviderConnection;
|
||||
use App\Support\Providers\ProviderConsentStatus;
|
||||
use App\Support\Providers\ProviderVerificationStatus;
|
||||
use Filament\Facades\Filament;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Livewire\Livewire;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
|
||||
it('promotes consent and verification to the default-visible provider connection list axes', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
|
||||
$connection = ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'display_name' => 'Contoso',
|
||||
'provider' => 'microsoft',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Degraded->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
$tenant->makeCurrent();
|
||||
Filament::setTenant($tenant, true);
|
||||
|
||||
$component = Livewire::actingAs($user)
|
||||
->test(ListProviderConnections::class)
|
||||
->assertCanSeeTableRecords([$connection]);
|
||||
|
||||
$table = $component->instance()->getTable();
|
||||
$visibleColumnNames = collect($table->getVisibleColumns())
|
||||
->map(fn ($column): string => $column->getName())
|
||||
->values()
|
||||
->all();
|
||||
|
||||
expect($visibleColumnNames)->toContain('consent_status', 'verification_status')
|
||||
->and($visibleColumnNames)->not->toContain('status')
|
||||
->and($visibleColumnNames)->not->toContain('health_status')
|
||||
->and($table->getColumn('status')?->isToggledHiddenByDefault())->toBeTrue()
|
||||
->and($table->getColumn('health_status')?->isToggledHiddenByDefault())->toBeTrue();
|
||||
});
|
||||
|
||||
it('separates current state from diagnostics on the provider connection view page', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
|
||||
$connection = ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'display_name' => 'Truthful Connection',
|
||||
'provider' => 'microsoft',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Degraded->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(ProviderConnectionResource::getUrl('view', ['record' => $connection], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSeeInOrder([
|
||||
'Current state',
|
||||
'Consent',
|
||||
'Granted',
|
||||
'Verification',
|
||||
'Degraded',
|
||||
'Diagnostics',
|
||||
'Legacy status',
|
||||
'Connected',
|
||||
'Legacy health',
|
||||
'OK',
|
||||
]);
|
||||
});
|
||||
|
||||
it('shows current consent and verification context before diagnostics on the provider connection edit page', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
|
||||
$connection = ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'display_name' => 'Editable Truthful Connection',
|
||||
'provider' => 'microsoft',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Blocked->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(ProviderConnectionResource::getUrl('edit', ['record' => $connection], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSeeInOrder([
|
||||
'Current state',
|
||||
'Consent',
|
||||
'Granted',
|
||||
'Verification',
|
||||
'Blocked',
|
||||
'Diagnostics',
|
||||
'Legacy status',
|
||||
'Connected',
|
||||
'Legacy health',
|
||||
'OK',
|
||||
]);
|
||||
});
|
||||
|
||||
it('does not treat consented but unverified connections as ready across provider surfaces', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
|
||||
$connection = ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'display_name' => 'Unknown Verification Connection',
|
||||
'provider' => 'microsoft',
|
||||
'is_default' => true,
|
||||
'consent_status' => ProviderConsentStatus::Granted->value,
|
||||
'verification_status' => ProviderVerificationStatus::Unknown->value,
|
||||
'status' => 'connected',
|
||||
'health_status' => 'ok',
|
||||
]);
|
||||
|
||||
$this->actingAs($user);
|
||||
$tenant->makeCurrent();
|
||||
Filament::setTenant($tenant, true);
|
||||
|
||||
Livewire::actingAs($user)
|
||||
->test(ListProviderConnections::class)
|
||||
->assertCanSeeTableRecords([$connection])
|
||||
->assertSee('Granted')
|
||||
->assertSee('Unknown')
|
||||
->assertDontSee('Ready');
|
||||
|
||||
$this->get(ProviderConnectionResource::getUrl('view', ['record' => $connection], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Granted')
|
||||
->assertSee('Unknown')
|
||||
->assertDontSee('Ready');
|
||||
});
|
||||
@ -32,9 +32,12 @@
|
||||
|
||||
$component = Livewire::test(ListProviderConnections::class);
|
||||
|
||||
$filterNames = array_keys($component->instance()->getTable()->getFilters());
|
||||
$filters = $component->instance()->getTable()->getFilters();
|
||||
$filterNames = array_keys($filters);
|
||||
|
||||
expect($filterNames)->toContain('tenant', 'provider', 'status', 'health_status', 'default_only');
|
||||
expect($filterNames)->toContain('tenant', 'provider', 'consent_status', 'verification_status', 'status', 'health_status', 'default_only');
|
||||
expect($filters['status']->getLabel())->toBe('Diagnostic status');
|
||||
expect($filters['health_status']->getLabel())->toBe('Diagnostic health');
|
||||
|
||||
$component
|
||||
->set('tableFilters.default_only.isActive', true)
|
||||
|
||||
@ -6,6 +6,7 @@
|
||||
use App\Filament\Resources\OperationRunResource;
|
||||
use App\Filament\Resources\PolicyResource;
|
||||
use App\Filament\Resources\PolicyVersionResource;
|
||||
use App\Filament\Resources\ProviderConnectionResource;
|
||||
use App\Filament\Resources\TenantResource;
|
||||
use App\Models\EntraGroup;
|
||||
use App\Models\Policy;
|
||||
@ -53,7 +54,8 @@ function adminGlobalSearchTitles($results): array
|
||||
});
|
||||
|
||||
it('keeps operation runs out of admin global search regardless of remembered context state', function (): void {
|
||||
expect(OperationRunResource::canGloballySearch())->toBeFalse();
|
||||
expect(OperationRunResource::canGloballySearch())->toBeFalse()
|
||||
->and(ProviderConnectionResource::canGloballySearch())->toBeFalse();
|
||||
});
|
||||
|
||||
it('keeps representative first-slice admin global-search behavior aligned to the family registry postures', function (): void {
|
||||
|
||||
@ -61,6 +61,26 @@
|
||||
expect(TenantResource::canEdit($otherTenant))->toBeFalse();
|
||||
});
|
||||
|
||||
it('returns not found for tenant detail pages outside the actor tenant scope', function (): void {
|
||||
[$user] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
$otherTenant = Tenant::factory()->active()->create();
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $otherTenant->workspace_id])
|
||||
->get(TenantResource::getUrl('view', ['record' => $otherTenant], panel: 'admin'))
|
||||
->assertNotFound();
|
||||
});
|
||||
|
||||
it('returns not found for numeric tenant detail paths outside the actor tenant scope', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
$otherTenant = Tenant::factory()->active()->create();
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
||||
->get(TenantResource::getUrl('view', ['record' => (string) $otherTenant->getKey()], panel: 'admin'))
|
||||
->assertNotFound();
|
||||
});
|
||||
|
||||
it('does not grant lifecycle mutation abilities for inaccessible tenants regardless of lifecycle state', function (\Closure $tenantFactory): void {
|
||||
[$user] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
||||
$otherTenant = $tenantFactory();
|
||||
|
||||
@ -21,8 +21,9 @@
|
||||
use Illuminate\Support\Facades\Queue;
|
||||
use Illuminate\Support\Facades\Storage;
|
||||
use Livewire\Livewire;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
beforeEach(function (): void {
|
||||
Storage::fake('exports');
|
||||
@ -366,6 +367,103 @@ function seedReviewPackEvidence(Tenant $tenant): EvidenceSnapshot
|
||||
->assertSee('Open the source review before sharing this pack');
|
||||
});
|
||||
|
||||
it('shows internal-only caveats for packs generated from stale source evidence before download', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
$snapshot = seedStaleTenantReviewEvidence($tenant);
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => 'published',
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => 'complete',
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$pack = $this->makeArtifactTruthReviewPack(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
review: $review,
|
||||
summaryOverrides: [
|
||||
'review_status' => 'published',
|
||||
'review_completeness_state' => 'complete',
|
||||
],
|
||||
);
|
||||
|
||||
$tenant->makeCurrent();
|
||||
Filament::setTenant($tenant, true);
|
||||
|
||||
Livewire::actingAs($user)
|
||||
->test(ListReviewPacks::class)
|
||||
->assertTableActionVisible('download', $pack)
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the source review before sharing this pack');
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(ReviewPackResource::getUrl('view', ['record' => $pack], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Download')
|
||||
->assertSee('Refresh the source review before sharing this pack');
|
||||
});
|
||||
|
||||
it('keeps packs from partial evidence internal only instead of publishable', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
$snapshot = seedPartialTenantReviewEvidence($tenant);
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => 'ready',
|
||||
'completeness_state' => 'complete',
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$pack = $this->makeArtifactTruthReviewPack(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
review: $review,
|
||||
summaryOverrides: [
|
||||
'review_status' => 'ready',
|
||||
'review_completeness_state' => 'complete',
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(ReviewPackResource::getUrl('view', ['record' => $pack], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Complete the source review before sharing this pack')
|
||||
->assertDontSee('Publishable');
|
||||
});
|
||||
|
||||
it('shows download header action on view page for a ready pack', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
@ -60,8 +60,6 @@
|
||||
->get(ReviewPackResource::getUrl('view', ['record' => $pack], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Artifact truth')
|
||||
->assertSee('Publishable')
|
||||
->assertSee('No action needed')
|
||||
->assertSee('#'.$review->getKey())
|
||||
->assertSee('Review status');
|
||||
});
|
||||
|
||||
@ -85,5 +85,5 @@
|
||||
|
||||
$this->get($viewUrl)
|
||||
->assertSuccessful()
|
||||
->assertSee('Run #'.(int) $run?->getKey());
|
||||
->assertSee('Operation #'.(int) $run?->getKey());
|
||||
});
|
||||
|
||||
@ -4,8 +4,12 @@
|
||||
|
||||
use App\Services\TenantReviews\TenantReviewLifecycleService;
|
||||
use App\Services\TenantReviews\TenantReviewReadinessGate;
|
||||
use App\Support\TenantReviewCompletenessState;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Ui\GovernanceArtifactTruth\ArtifactTruthPresenter;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
it('blocks publication when required review sections are missing from the anchored evidence basis', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
@ -35,7 +39,24 @@
|
||||
|
||||
it('publishes ready tenant reviews and archives them without mutating the published evidence history', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
$review = composeTenantReviewForTest($tenant, $user);
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $this->makeArtifactTruthEvidenceSnapshot($tenant),
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$published = app(TenantReviewLifecycleService::class)->publish($review, $user);
|
||||
$publishedAt = $published->published_at?->toIso8601String();
|
||||
@ -58,3 +79,68 @@
|
||||
->and($archivedTruth->publicationReadiness)->toBe('internal_only')
|
||||
->and($archivedTruth->nextStepText())->toBe('No action needed');
|
||||
});
|
||||
|
||||
it('keeps stale published reviews internal only even when the lifecycle status is published', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
$snapshot = seedStaleTenantReviewEvidence($tenant);
|
||||
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$truth = app(ArtifactTruthPresenter::class)->forTenantReview($review);
|
||||
|
||||
expect($truth->freshnessState)->toBe('stale')
|
||||
->and($truth->publicationReadiness)->toBe('internal_only')
|
||||
->and($truth->primaryLabel)->toBe('Internal only')
|
||||
->and($truth->nextStepText())->toBe('Refresh the evidence basis before publishing this review');
|
||||
});
|
||||
|
||||
it('downgrades structurally ready reviews with partial evidence to internal only', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
$snapshot = seedPartialTenantReviewEvidence($tenant);
|
||||
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$truth = app(ArtifactTruthPresenter::class)->forTenantReview($review);
|
||||
|
||||
expect($truth->contentState)->toBe('partial')
|
||||
->and($truth->freshnessState)->toBe('current')
|
||||
->and($truth->publicationReadiness)->toBe('internal_only')
|
||||
->and($truth->primaryLabel)->toBe('Internal only')
|
||||
->and($truth->nextStepText())->toBe('Complete the evidence basis before publishing this review');
|
||||
});
|
||||
|
||||
@ -5,8 +5,13 @@
|
||||
use App\Filament\Pages\Reviews\ReviewRegister;
|
||||
use App\Models\Tenant;
|
||||
use App\Models\User;
|
||||
use App\Support\TenantReviewCompletenessState;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Livewire\Livewire;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
it('lists only entitled tenant reviews in the canonical review register and filters by tenant', function (): void {
|
||||
$tenantA = Tenant::factory()->create(['name' => 'Alpha Tenant']);
|
||||
@ -59,3 +64,66 @@
|
||||
->assertSee('No review records match this view')
|
||||
->assertSee('Clear filters');
|
||||
});
|
||||
|
||||
it('keeps stale and partial review rows aligned with tenant review detail trust', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$partialTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Partial Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $partialTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleReview = $this->makeArtifactTruthReview(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: seedStaleTenantReviewEvidence($staleTenant),
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$partialReview = $this->makeArtifactTruthReview(
|
||||
tenant: $partialTenant,
|
||||
user: $user,
|
||||
snapshot: seedPartialTenantReviewEvidence($partialTenant),
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user);
|
||||
setAdminPanelContext();
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $staleTenant->workspace_id);
|
||||
|
||||
Livewire::actingAs($user)
|
||||
->test(ReviewRegister::class)
|
||||
->assertCanSeeTableRecords([$staleReview, $partialReview])
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the evidence basis before publishing this review')
|
||||
->assertSee('Complete the evidence basis before publishing this review')
|
||||
->assertDontSee('Publishable');
|
||||
});
|
||||
|
||||
@ -12,3 +12,25 @@
|
||||
->assertOk()
|
||||
->assertSee('/admin/provider-connections?tenant_id='.(string) $tenant->external_id, false);
|
||||
});
|
||||
|
||||
it('keeps the canonical provider connections CTA when the tenant needs a default microsoft connection', function (): void {
|
||||
$tenant = \App\Models\Tenant::factory()->active()->create();
|
||||
[$user, $tenant] = createUserWithTenant(
|
||||
tenant: $tenant,
|
||||
role: 'owner',
|
||||
ensureDefaultMicrosoftProviderConnection: false,
|
||||
);
|
||||
|
||||
\App\Models\ProviderConnection::factory()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'provider' => 'microsoft',
|
||||
'display_name' => 'Fallback Connection',
|
||||
'is_default' => false,
|
||||
]);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(TenantResource::getUrl('view', ['record' => $tenant], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('/admin/provider-connections?tenant_id='.(string) $tenant->external_id, false);
|
||||
});
|
||||
|
||||
@ -56,7 +56,7 @@
|
||||
assertNoOutboundHttp(function () use ($run, $fingerprint): void {
|
||||
Livewire::test(TenantlessOperationRunViewer::class, ['run' => $run])
|
||||
->assertSee('Verification report')
|
||||
->assertSee('Open previous verification')
|
||||
->assertSee('Open previous operation')
|
||||
->assertSee($fingerprint)
|
||||
->assertSee('Token acquisition works')
|
||||
->assertDontSee('access_token')
|
||||
|
||||
203
tests/Pest.php
203
tests/Pest.php
@ -1,5 +1,8 @@
|
||||
<?php
|
||||
|
||||
use App\Models\BaselineProfile;
|
||||
use App\Models\BaselineSnapshot;
|
||||
use App\Models\BaselineTenantAssignment;
|
||||
use App\Models\EvidenceSnapshot;
|
||||
use App\Models\Finding;
|
||||
use App\Models\OperationRun;
|
||||
@ -16,7 +19,11 @@
|
||||
use App\Services\Graph\GraphClientInterface;
|
||||
use App\Services\TenantReviews\TenantReviewService;
|
||||
use App\Services\Tenants\TenantActionPolicySurface;
|
||||
use App\Support\Evidence\EvidenceCompletenessState;
|
||||
use App\Support\Evidence\EvidenceSnapshotStatus;
|
||||
use App\Support\OperationRunOutcome;
|
||||
use App\Support\OperationRunStatus;
|
||||
use App\Support\OperationRunType;
|
||||
use App\Support\Providers\ProviderConnectionType;
|
||||
use App\Support\Providers\ProviderConsentStatus;
|
||||
use App\Support\Providers\ProviderCredentialKind;
|
||||
@ -345,6 +352,81 @@ function createUserWithTenant(
|
||||
return [$user, $tenant];
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array{0: BaselineProfile, 1: BaselineSnapshot}
|
||||
*/
|
||||
function seedActiveBaselineForTenant(Tenant $tenant): array
|
||||
{
|
||||
$profile = BaselineProfile::factory()->active()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
]);
|
||||
|
||||
$snapshot = BaselineSnapshot::factory()->complete()->create([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'baseline_profile_id' => (int) $profile->getKey(),
|
||||
]);
|
||||
|
||||
$profile->forceFill([
|
||||
'active_snapshot_id' => (int) $snapshot->getKey(),
|
||||
])->save();
|
||||
|
||||
BaselineTenantAssignment::query()->updateOrCreate([
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
], [
|
||||
'baseline_profile_id' => (int) $profile->getKey(),
|
||||
'override_scope_jsonb' => null,
|
||||
]);
|
||||
|
||||
return [$profile, $snapshot];
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $compareContext
|
||||
*/
|
||||
function seedBaselineCompareRun(
|
||||
Tenant $tenant,
|
||||
BaselineProfile $profile,
|
||||
BaselineSnapshot $snapshot,
|
||||
array $compareContext = [],
|
||||
string $status = OperationRunStatus::Completed->value,
|
||||
string $outcome = OperationRunOutcome::Succeeded->value,
|
||||
?\Carbon\CarbonInterface $completedAt = null,
|
||||
): OperationRun {
|
||||
$completedAt ??= now();
|
||||
|
||||
return OperationRun::factory()->create([
|
||||
'tenant_id' => (int) $tenant->getKey(),
|
||||
'workspace_id' => (int) $tenant->workspace_id,
|
||||
'type' => OperationRunType::BaselineCompare->value,
|
||||
'status' => $status,
|
||||
'outcome' => $outcome,
|
||||
'created_at' => $completedAt,
|
||||
'completed_at' => $status === OperationRunStatus::Completed->value ? $completedAt : null,
|
||||
'context' => [
|
||||
'baseline_profile_id' => (int) $profile->getKey(),
|
||||
'baseline_snapshot_id' => (int) $snapshot->getKey(),
|
||||
'baseline_compare' => $compareContext,
|
||||
],
|
||||
]);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array<string, mixed>
|
||||
*/
|
||||
function workspaceOverviewCompareCoverage(): array
|
||||
{
|
||||
return [
|
||||
'reason_code' => \App\Support\Baselines\BaselineCompareReasonCode::NoDriftDetected->value,
|
||||
'coverage' => [
|
||||
'effective_types' => ['deviceConfiguration'],
|
||||
'covered_types' => ['deviceConfiguration'],
|
||||
'uncovered_types' => [],
|
||||
'proof' => true,
|
||||
],
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array{tenant: string}
|
||||
*/
|
||||
@ -569,6 +651,70 @@ function seedTenantReviewEvidence(
|
||||
return $snapshot->load('items');
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $permissionPayload
|
||||
* @param array<string, mixed> $rolePayload
|
||||
*/
|
||||
function seedStaleTenantReviewEvidence(
|
||||
Tenant $tenant,
|
||||
array $permissionPayload = [],
|
||||
array $rolePayload = [],
|
||||
int $findingCount = 3,
|
||||
int $driftCount = 1,
|
||||
int $operationRunCount = 1,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = seedTenantReviewEvidence(
|
||||
tenant: $tenant,
|
||||
permissionPayload: $permissionPayload,
|
||||
rolePayload: $rolePayload,
|
||||
findingCount: $findingCount,
|
||||
driftCount: $driftCount,
|
||||
operationRunCount: $operationRunCount,
|
||||
);
|
||||
|
||||
return restateTenantReviewEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Stale,
|
||||
array_replace([
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 2,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $permissionPayload
|
||||
* @param array<string, mixed> $rolePayload
|
||||
*/
|
||||
function seedPartialTenantReviewEvidence(
|
||||
Tenant $tenant,
|
||||
array $permissionPayload = [],
|
||||
array $rolePayload = [],
|
||||
int $findingCount = 3,
|
||||
int $driftCount = 1,
|
||||
int $operationRunCount = 1,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = seedTenantReviewEvidence(
|
||||
tenant: $tenant,
|
||||
permissionPayload: $permissionPayload,
|
||||
rolePayload: $rolePayload,
|
||||
findingCount: $findingCount,
|
||||
driftCount: $driftCount,
|
||||
operationRunCount: $operationRunCount,
|
||||
);
|
||||
|
||||
return restateTenantReviewEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Partial,
|
||||
array_replace([
|
||||
'missing_dimensions' => 1,
|
||||
'stale_dimensions' => 0,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
function composeTenantReviewForTest(Tenant $tenant, User $user, ?EvidenceSnapshot $snapshot = null): TenantReview
|
||||
{
|
||||
$snapshot ??= seedTenantReviewEvidence($tenant);
|
||||
@ -586,6 +732,63 @@ function composeTenantReviewForTest(Tenant $tenant, User $user, ?EvidenceSnapsho
|
||||
return $review->refresh();
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $summaryOverrides
|
||||
*/
|
||||
function restateTenantReviewEvidenceSnapshot(
|
||||
EvidenceSnapshot $snapshot,
|
||||
EvidenceCompletenessState $completenessState,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
||||
|
||||
$summary = array_replace($summary, match ($completenessState) {
|
||||
EvidenceCompletenessState::Stale => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => max(1, (int) ($summary['stale_dimensions'] ?? 1)),
|
||||
],
|
||||
EvidenceCompletenessState::Partial => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Missing => [
|
||||
'dimension_count' => (int) ($summary['dimension_count'] ?? 0),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Complete => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
});
|
||||
|
||||
$summary = array_replace_recursive($summary, $summaryOverrides);
|
||||
|
||||
$snapshot->forceFill([
|
||||
'completeness_state' => $completenessState->value,
|
||||
'summary' => $summary,
|
||||
])->save();
|
||||
|
||||
$primaryItem = $snapshot->items()->where('required', true)->orderBy('sort_order')->first();
|
||||
|
||||
if ($primaryItem !== null) {
|
||||
$primaryItem->forceFill([
|
||||
'state' => $completenessState->value,
|
||||
'measured_at' => $completenessState === EvidenceCompletenessState::Stale
|
||||
? now()->subDays(45)
|
||||
: ($primaryItem->measured_at ?? now()),
|
||||
'freshness_at' => $completenessState === EvidenceCompletenessState::Stale
|
||||
? now()->subDays(45)
|
||||
: ($primaryItem->freshness_at ?? now()),
|
||||
])->save();
|
||||
}
|
||||
|
||||
return $snapshot->fresh('items');
|
||||
}
|
||||
|
||||
function setTenantPanelContext(Tenant $tenant): void
|
||||
{
|
||||
$tenant->makeCurrent();
|
||||
|
||||
@ -5,7 +5,43 @@
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeDomain;
|
||||
|
||||
it('maps provider connection status safely', function (): void {
|
||||
it('maps provider consent status safely', function (): void {
|
||||
$unknown = BadgeCatalog::spec(BadgeDomain::ProviderConsentStatus, 'unknown');
|
||||
expect($unknown->color)->toBe('gray');
|
||||
expect($unknown->label)->toBe('Unknown');
|
||||
|
||||
$required = BadgeCatalog::spec(BadgeDomain::ProviderConsentStatus, 'required');
|
||||
expect($required->color)->toBe('warning');
|
||||
expect($required->label)->toBe('Required');
|
||||
|
||||
$granted = BadgeCatalog::spec(BadgeDomain::ProviderConsentStatus, 'granted');
|
||||
expect($granted->color)->toBe('success');
|
||||
expect($granted->label)->toBe('Granted');
|
||||
|
||||
$failed = BadgeCatalog::spec(BadgeDomain::ProviderConsentStatus, 'failed');
|
||||
expect($failed->color)->toBe('danger');
|
||||
expect($failed->label)->toBe('Failed');
|
||||
});
|
||||
|
||||
it('maps provider verification status safely', function (): void {
|
||||
$unknown = BadgeCatalog::spec(BadgeDomain::ProviderVerificationStatus, 'unknown');
|
||||
expect($unknown->color)->toBe('gray');
|
||||
expect($unknown->label)->toBe('Unknown');
|
||||
|
||||
$pending = BadgeCatalog::spec(BadgeDomain::ProviderVerificationStatus, 'pending');
|
||||
expect($pending->color)->toBe('info');
|
||||
expect($pending->label)->toBe('Pending');
|
||||
|
||||
$healthy = BadgeCatalog::spec(BadgeDomain::ProviderVerificationStatus, 'healthy');
|
||||
expect($healthy->color)->toBe('success');
|
||||
expect($healthy->label)->toBe('Healthy');
|
||||
|
||||
$blocked = BadgeCatalog::spec(BadgeDomain::ProviderVerificationStatus, 'blocked');
|
||||
expect($blocked->color)->toBe('danger');
|
||||
expect($blocked->label)->toBe('Blocked');
|
||||
});
|
||||
|
||||
it('maps provider connection legacy status safely', function (): void {
|
||||
$connected = BadgeCatalog::spec(BadgeDomain::ProviderConnectionStatus, 'connected');
|
||||
expect($connected->color)->toBe('success');
|
||||
expect($connected->label)->toBe('Connected');
|
||||
@ -23,7 +59,7 @@
|
||||
expect($disabled->label)->toBe('Disabled');
|
||||
});
|
||||
|
||||
it('maps provider connection health safely', function (): void {
|
||||
it('maps provider connection legacy health safely', function (): void {
|
||||
$ok = BadgeCatalog::spec(BadgeDomain::ProviderConnectionHealth, 'ok');
|
||||
expect($ok->color)->toBe('success');
|
||||
expect($ok->label)->toBe('OK');
|
||||
|
||||
@ -23,7 +23,7 @@
|
||||
expect($error->color)->toBe('danger');
|
||||
});
|
||||
|
||||
it('maps tenant app status values to canonical badge semantics', function (): void {
|
||||
it('maps tenant app status values to legacy diagnostic badge semantics', function (): void {
|
||||
$ok = BadgeCatalog::spec(BadgeDomain::TenantAppStatus, 'ok');
|
||||
expect($ok->label)->toBe('OK');
|
||||
expect($ok->color)->toBe('success');
|
||||
|
||||
@ -9,7 +9,7 @@
|
||||
|
||||
expect($catalog->entryLabel('baseline_snapshot'))->toBe('Snapshot')
|
||||
->and($catalog->actionLabel('baseline_snapshot'))->toBe('View snapshot')
|
||||
->and($catalog->entryLabel('source_run'))->toBe('Run')
|
||||
->and($catalog->entryLabel('source_run'))->toBe('Operation')
|
||||
->and($catalog->actionLabel('operations'))->toBe('Open operations');
|
||||
});
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user