ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
platform-dev
TenantAtlas/specs/359-operationrun-reconciliation-adapter-framework-review-compose-adapter/checklists/requirements.md
ahmido 3a750726fd feat: implement review compose reconciliation adapter (spec 359) (#430) 
Spec 359: add a narrow review-compose reconciliation path, deterministic duplicate/superseded recovery, shared review truth resolution, and bounded unit/feature/browser coverage. PGSQL validation remains locally blocked because the pgsql host/Docker runtime was unavailable.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #430
2026-06-06 14:58:16 +00:00

4.2 KiB
Raw Permalink Blame History

Requirements Checklist: Spec 359 - OperationRun Reconciliation Adapter Framework & Review Compose Adapter

Purpose: Preparation analysis for Spec 359 readiness
Created: 2026-06-06
Feature: specs/359-operationrun-reconciliation-adapter-framework-review-compose-adapter/spec.md

Candidate Selection And Guardrails

  • CHK001 The candidate source is explicit: direct user-provided draft plus repo-verified current code truth.
  • CHK002 No specs/359-* package existed before this prep.
  • CHK003 Related existing specs were checked for completed/prepared/runtime signals and are treated as context only: 357, 358, and 311.
  • CHK004 The active candidate queue's no safe automatic next-best-prep target note is respected; this package is an intentional manual promotion rather than an auto-selected queue item.
  • CHK005 Repo-truth deviations from the user draft are recorded in spec.md, especially the existing restore adapter precedent and current reconciliation metadata seam.

Required Prep Artifacts

  • CHK006 spec.md exists and contains no template placeholders.
  • CHK007 plan.md exists and is repo-aware.
  • CHK008 tasks.md exists and is ordered, small, and verifiable.
  • CHK009 This checklist exists.

Spec Quality

  • CHK010 Spec Candidate Check is completed and scored above the approval threshold.
  • CHK011 The spec keeps OperationRun persistence unchanged and explicitly forbids a new status/reconciled column.
  • CHK012 The spec explains why a narrow adapter contract is justified now despite the constitution's anti-abstraction bias.
  • CHK013 The spec keeps scope bounded to review-compose truth, duplicate recovery, and existing monitoring/review-start surfaces.
  • CHK014 The proportionality review rejects a universal reconciliation engine, schema expansion, and cross-domain adapter sprawl.

Plan / Task Alignment

  • CHK015 The plan identifies the actual repo surfaces likely to change, including the current restore adapter precedent and current review-compose seams.
  • CHK016 The plan keeps Filament v5 / Livewire v4 posture and provider-registration location visible.
  • CHK017 The plan explicitly requires a PGSQL lane for duplicate-index and lock behavior.
  • CHK018 The tasks start with repo truth and failing tests before runtime edits.
  • CHK019 The tasks include explicit anti-creep guardrails against new persistence, universal adapters, and destructive cleanup.

UI / Monitoring / Review Coverage

  • CHK020 UI Surface Impact is completed and does not claim a new page family.
  • CHK021 The changed surfaces are correctly classified as existing monitoring/detail and review-start feedback follow-through, not a new strategic customer surface.
  • CHK022 No new page-report identity or route-inventory expansion is required unless implementation proves a materially new visible hierarchy.
  • CHK023 Audience-aware disclosure and no-raw-SQL wording boundaries are explicit.

Test Governance

  • CHK024 The declared test families are the narrowest honest proof: Unit + Feature + one bounded Browser smoke, with PGSQL lane coverage for duplicate-index truth.
  • CHK025 No heavy-governance family is introduced.
  • CHK026 Planned validation commands are explicit and include Spec 358 plus review/report regressions.

Readiness Gate Outcome

  • CHK027 Candidate Selection Gate passes.
  • CHK028 Spec Readiness Gate passes.
  • CHK029 Runtime implementation has not started in this preparation step.
  • CHK030 Recommended next step is implementation, not more prep.

Review Outcome

  • Outcome class: acceptable-special-case
  • Workflow outcome: keep
  • Final note location: active feature PR close-out entry Guardrail / Smoke Coverage
  • Preparation analyze result: pass via repo-based artifact review checklist; no standalone local speckit.analyze command was available in this repo surface
  • Tooling note: Spec Kit branch/spec creation succeeded via create-new-feature.sh, setup-plan.sh generated the plan file, and tasks.md plus this checklist were authored manually because this repo surface does not expose standalone local tasks/analyze generators