Automated PR created by Codex via Gitea API. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #459
4.8 KiB
4.8 KiB
Specification Quality Checklist: Spec 388 - Resolution Proof & Currentness Contract v1
Purpose: Validate specification completeness and preparation readiness before implementation
Created: 2026-06-19
Feature: specs/388-resolution-proof-currentness-contract-v1/spec.md
Candidate Selection and Guardrails
- CHK001 The candidate source is the direct user-provided Spec 388 draft attachment.
- CHK002 The active auto-prep queue in
docs/product/spec-candidates.mdis acknowledged as empty/no-safe-automatic-target, and this spec is treated as manual user-provided promotion. - CHK003 No existing
specs/388-*package or*388*branch existed before Spec Kit scaffold. - CHK004 Completed or implemented related specs 385, 386, and 387 are treated as dependency context only and are not rewritten.
- CHK005 Close alternatives are deferred instead of hidden inside the primary scope.
- CHK006 Candidate Selection Gate passes with scope narrowed to Review Publication Resolution proof/currentness V1.
Scope and Constitution Fit
- CHK007 The spec includes the mandatory Spec Candidate Check with approval class, score, red flags, and decision.
- CHK008 The spec includes proportionality review for new DTO/value objects and proof state families.
- CHK009 The plan keeps source truth in existing OperationRun, StoredReport, EvidenceSnapshot, EnvironmentReview, ReviewPack, and ReviewPublicationResolution records.
- CHK010 No new proof persistence, migration, global registry, workflow engine, broad adapter package, Resource, route family, panel provider, or global search surface is approved by default.
- CHK011 Restore, Provider Onboarding, Governance Inbox, Report Delivery, Cross-Tenant Promotion, and AI proof adapters are explicit follow-up candidates only.
- CHK012 Existing workspace/managed-environment isolation and deny-as-not-found expectations are carried into proof evaluation.
Requirements Quality
- CHK013 Problem statement, business value, users, user stories, functional requirements, non-functional requirements, edge cases, out-of-scope boundaries, success criteria, assumptions, and open questions are present.
- CHK014 Requirements define behavior for current, stale, superseded, missing, running, failed, inaccessible, unknown, usable, not usable, and inspection-only proof.
- CHK015 Requirements state that successful OperationRun alone cannot complete artifact-backed steps without current artifact proof.
- CHK016 Requirements state that newer current artifact proof supersedes older failed/running proof where appropriate.
- CHK017 Requirements state that safe summaries exclude raw provider payloads, Graph responses, tokens, secrets, full report/evidence content, and raw exception messages.
- CHK018 No
[NEEDS CLARIFICATION]markers remain.
UI, Filament, and Disclosure
- CHK019 UI Surface Impact is explicit and limited to existing proof/state presentation plus customer no-leakage regression.
- CHK020 UI/Productization Coverage reuses UI-101, UI-040, and UI-006 context without inventing a new route taxonomy.
- CHK021 Technical proof remains collapsed/secondary by default.
- CHK022 Customer-facing surfaces are explicitly forbidden from showing internal proof mechanics.
- CHK023 Filament v5 / Livewire v4 compliance is stated.
- CHK024 Laravel 12 panel provider location is stated as
apps/platform/bootstrap/providers.php, with no provider change planned. - CHK025 No globally searchable Resource is added.
- CHK026 No new destructive action is approved; existing high-impact actions remain confirmation-, authorization-, audit-, and test-gated.
- CHK027 Asset strategy is stated as no new registered Filament assets expected.
Plan and Task Readiness
- CHK028
spec.md,plan.md,tasks.md, and this checklist exist. - CHK029 The plan identifies likely affected repo surfaces and avoids contradicting existing architecture.
- CHK030 Tasks are ordered, small, verifiable, and include tests before implementation.
- CHK031 Tasks include unit, feature, RBAC/scope, customer no-leakage, and optional browser/screenshot coverage.
- CHK032 Validation commands use Sail-first paths and include focused Spec 388, Spec 386/387 regression, optional browser, Pint, and
git diff --check. - CHK033 No full-suite success is implied by the preparation artifacts.
Spec Readiness Gate
- CHK034 Preparation artifacts are consistent on scope: Review Publication Resolution proof/currentness only.
- CHK035 No task expands beyond
spec.mdorplan.md. - CHK036 Open questions are non-blocking.
- CHK037 Spec Readiness Gate passes for a later implementation loop.
Notes
- This checklist validates preparation artifacts only. It does not claim implementation, tests, browser smoke, or runtime behavior has been completed.